Cover Detail
Show a cover letter.
GET /api/covers/9/?format=api
{ "id": 9, "url": "http://patchwork.dpdk.org/api/covers/9/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/cover/1690954318-3126-1-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1690954318-3126-1-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1690954318-3126-1-git-send-email-roretzla@linux.microsoft.com", "date": "2023-08-02T05:31:54", "name": "[v4,0/4] eal: update public API to use stdatomic atomics", "submitter": { "id": 2077, "url": "http://patchwork.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/cover/1690954318-3126-1-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 29086, "url": "http://patchwork.dpdk.org/api/series/29086/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29086", "date": "2023-08-02T05:31:55", "name": "eal: update public API to use stdatomic atomics", "version": 4, "mbox": "http://patchwork.dpdk.org/series/29086/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/covers/9/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0E6F442FB4;\n\tWed, 2 Aug 2023 07:32:12 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3697643258;\n\tWed, 2 Aug 2023 07:32:03 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 0AB94410DC\n for <dev@dpdk.org>; Wed, 2 Aug 2023 07:32:00 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 13940238AF62; Tue, 1 Aug 2023 22:31:59 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 13940238AF62", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1690954319;\n bh=MyjSoqFEHPfYdVMgjIaMX2HOicUiEBJpV2r7Jl4Pf1g=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=R/q6F7FInXz/VENhKeaYvdU47vshKykszq9k3W3rmVAuW4TJqCrRCBf3enKa76AL+\n eG8hDRFmWoLN+phYZnsF4eYDV0FC2dgtPIKF+/IDLMHXBt3Yrj2wuWpTblGSpzvtX0\n WyDEhgg39qH8+VmiuBPyR9uKfersCCay3o8p8EgM=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Gaetan Rivet <grive@u256.net>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Nicolas Chautru <nicolas.chautru@intel.com>,\n Yipeng Wang <yipeng1.wang@intel.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Anatoly Burakov <anatoly.burakov@intel.com>,\n Olivier Matz <olivier.matz@6wind.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Joyce Kong <joyce.kong@arm.com>,\n Erik Gabriel Carrillo <erik.g.carrillo@intel.com>,\n Liang Ma <liangma@liangbit.com>, Peter Mccarthy <peter.mccarthy@intel.com>,\n Jerin Jacob <jerinj@marvell.com>, Maciej Czekaj <mczekaj@marvell.com>,\n David Hunt <david.hunt@intel.com>, Ruifeng Wang <ruifeng.wang@arm.com>,\n Min Zhou <zhoumin@loongson.cn>, David Christensen <drc@linux.vnet.ibm.com>,\n Stanislaw Kardach <kda@semihalf.com>, david.marchand@redhat.com,\n stephen@networkplumber.org, mb@smartsharesystems.com,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v4 0/4] eal: update public API to use stdatomic atomics", "Date": "Tue, 1 Aug 2023 22:31:54 -0700", "Message-Id": "<1690954318-3126-1-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1690837661-27573-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1690837661-27573-1-git-send-email-roretzla@linux.microsoft.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Update EAL public API to use standard C11 atomics. In accordance with\ntechnical board discussion February 2023.\nhttp://mails.dpdk.org/archives/dev/2023-February/263516.html\n\nThis initial series makes no attempt to adapt every use of builtin atomics\nfrom GCC it intends only to adapt the public API of the EAL presented as\na compatibility surface to applications.\n\nFurther series will be submitted to adapt the rest of DPDK to use standard\natomics that are 'internal' and not do not straddle the EAL API.\n\nThe choice has been made to break these two changes apart to allow more\nprecise analysis of any potential performance impact this change or\nsubsequent changes may introduce.\n\nAdditionally, it is not possible to break the commits up per driver/lib as\nboth the provider and consumer of the APIs need to be changed in the same\ncommit to maintain non-broken build and function.\n\nFinally, the first patch in this series is a duplication of Bruce Richardson\nseries https://patchwork.dpdk.org/project/dpdk/list/?series=29048 and is\nonly being provided to enable the CI run on this series. It is expected that\nBruce's series when committed will allow the build: require minimum c11 compiler\nhere to be dropped from this series.\n\nv4:\n * fix previous cut & paste mistake including rte_pause.h when rte_atomic.h\n was intended in loongarch, ppc, riscv rte_pause.h (sorry was tired)\n\nv3:\n * restore incorrectly dropped architecture specific #include \"rte_pause.h\"\n for loongarch, ppc, riscv\n * convert parameters to stdatomic in RTE_WAIT_UNTIL_MASKED macro usage\n (missed previously)\n * lib/ring missed some conversion to stdatomic on struct rte_ring _Atomic\n fields (picked up by clang which is more strict than gcc)\n * drivers/mlx5 use stdatomic operations on struct rte_ring _Atomic fields\n (picked up by clang which is more strict than gcc)\n\nv2:\n * remove volatile qualification from variables, structure fields and\n parameters that have been qualified _Atomic\n * restore removal of #include <rte_atomic.h> in rte_ring_core.h the ring\n library still uses other rte_atomic APIs and types that are not replaced\n by the standard or compiler intrinsics\n * add missing adaption to stdatomic in ring/rte_ring_c11_pvt.h\n\nTyler Retzlaff (4):\n build: require minimum c11 compiler\n devtools: forbid use of GCC atomic builtins\n eal: adapt rte pause APIs to use C11 atomics\n eal: adapt rte spinlock and rwlock APIs to use C11 atomics\n\n app/test-bbdev/test_bbdev_perf.c | 123 ++++++++++++++++++++-----------\n app/test/test_func_reentrancy.c | 8 +-\n app/test/test_mcslock.c | 12 +--\n app/test/test_mempool_perf.c | 8 +-\n app/test/test_pflock.c | 12 +--\n app/test/test_pmd_perf.c | 10 +--\n app/test/test_ring_perf.c | 8 +-\n app/test/test_rwlock.c | 8 +-\n app/test/test_spinlock.c | 8 +-\n app/test/test_stack_perf.c | 12 +--\n app/test/test_ticketlock.c | 8 +-\n app/test/test_timer.c | 16 ++--\n devtools/checkpatches.sh | 8 ++\n drivers/event/opdl/opdl_ring.c | 47 ++++++------\n drivers/net/failsafe/meson.build | 1 -\n drivers/net/mlx5/mlx5_hws_cnt.h | 4 +-\n drivers/net/thunderx/nicvf_rxtx.c | 5 +-\n drivers/net/thunderx/nicvf_struct.h | 2 +-\n lib/bpf/bpf_pkt.c | 6 +-\n lib/distributor/distributor_private.h | 2 +-\n lib/distributor/rte_distributor_single.c | 44 +++++------\n lib/eal/arm/include/rte_pause_64.h | 28 +++----\n lib/eal/common/eal_common_errno.c | 1 +\n lib/eal/common/eal_memcfg.h | 2 +-\n lib/eal/include/generic/rte_pause.h | 51 ++++++-------\n lib/eal/include/generic/rte_rwlock.h | 46 ++++++------\n lib/eal/include/generic/rte_spinlock.h | 21 +++---\n lib/eal/include/rte_mcslock.h | 14 ++--\n lib/eal/include/rte_pflock.h | 22 +++---\n lib/eal/include/rte_ticketlock.h | 8 +-\n lib/eal/x86/include/rte_spinlock.h | 2 +-\n lib/ring/rte_ring_c11_pvt.h | 42 ++++++-----\n lib/ring/rte_ring_core.h | 4 +-\n lib/ring/rte_ring_generic_pvt.h | 19 +++--\n lib/ring/rte_ring_peek_elem_pvt.h | 2 +-\n meson.build | 1 +\n 36 files changed, 337 insertions(+), 278 deletions(-)" }