Cover Detail
Show a cover letter.
GET /api/covers/91049/?format=api
{ "id": 91049, "url": "http://patchwork.dpdk.org/api/covers/91049/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/cover/20210410224732.20234-1-dmitry.kozliuk@gmail.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210410224732.20234-1-dmitry.kozliuk@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210410224732.20234-1-dmitry.kozliuk@gmail.com", "date": "2021-04-10T22:47:28", "name": "[v9,0/4] eal/windows: do not expose POSIX symbols", "submitter": { "id": 1581, "url": "http://patchwork.dpdk.org/api/people/1581/?format=api", "name": "Dmitry Kozlyuk", "email": "dmitry.kozliuk@gmail.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/cover/20210410224732.20234-1-dmitry.kozliuk@gmail.com/mbox/", "series": [ { "id": 16271, "url": "http://patchwork.dpdk.org/api/series/16271/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=16271", "date": "2021-04-10T22:47:28", "name": "eal/windows: do not expose POSIX symbols", "version": 9, "mbox": "http://patchwork.dpdk.org/series/16271/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/covers/91049/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 23299A0547;\n\tSun, 11 Apr 2021 00:47:42 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9D94A4014E;\n\tSun, 11 Apr 2021 00:47:41 +0200 (CEST)", "from mail-lf1-f52.google.com (mail-lf1-f52.google.com\n [209.85.167.52]) by mails.dpdk.org (Postfix) with ESMTP id 1C6F04003D\n for <dev@dpdk.org>; Sun, 11 Apr 2021 00:47:41 +0200 (CEST)", "by mail-lf1-f52.google.com with SMTP id n8so15411983lfh.1\n for <dev@dpdk.org>; Sat, 10 Apr 2021 15:47:41 -0700 (PDT)", "from localhost.localdomain (broadband-37-110-65-23.ip.moscow.rt.ru.\n [37.110.65.23])\n by smtp.gmail.com with ESMTPSA id o15sm370270lfu.155.2021.04.10.15.47.39\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 10 Apr 2021 15:47:39 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=bQjrlMQOlSIkeMuFJtJgVIgaCJy67rpBgWJ9OLam0QI=;\n b=HIq61FiJJdYWYvqLwNOvrgnbUxpiucwieceGkAr73Fnne87r3maCNZFXXppqQnEon8\n gKJQxzCgCrJdxxBVtkIv4rR0nqOWPktTI8F8GDGlqZaySIu5kH8ADC/jtVvFcuGKZjis\n Cw5b1Tc5GrXee0L+aJVFdKP2Qsb77dl02KCok63rUkt8z5e3gea+qfqCn5K66WZ3RrBy\n LLRcooBPFaFtqV7kaBvndhhIXqT6G4h06EE4sgfSmsNddQjhwFVAQDZPmQy1SKQiFaEE\n FAM5trC9QQIXQ752HgugS5mRKo2Z/0EfxRuznxmcZ88DCO6MAhRu3PiiPv2TQfIq0SlD\n SOxQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=bQjrlMQOlSIkeMuFJtJgVIgaCJy67rpBgWJ9OLam0QI=;\n b=BH/xqes2y8vawCnpZnvarL41GJ//emrK1vcL2qShj+sEOM93yYqxbUHpqoajrgVCtC\n ZQvAf3P/YRcv+3dCjnS0tEmWvj3eLzIjQ2AdddqF25dBCvk6JptUUj7LZP9bwV5pLumF\n A8VrVxztjosWhthn8Fyjt8cijnVXavrBo1v24msro7riSyXiXxkz7Ph0P7MZqKQyYBTf\n WglqkNQ5yEdAOXaUr8/p+/rQ2yWDnZ0SeyEdN2/ictdBzr1JGH0Ra+GkDhvcz0cDeF9D\n 44LUDMZuc34am3c2CBD0DIbXlhuW9sU4bOBNpTDYj6U9+ErzORBU35WIflBkgBjls1VD\n l6Ug==", "X-Gm-Message-State": "AOAM532WF79KdDyIGcm4Bbn+Agfy0PAj9lq3xSTHGFYP5df8bakFQ3wv\n 6gkRB6er+iHUvrw6RbkK6kMh+ipjEcuxFA==", "X-Google-Smtp-Source": "\n ABdhPJzJTHTSXKWB2goMzRtpbUrfwuvs6Ouw7fKgT/J9rb/O0Q1pmioLmJOZwkk8wg/tAZoNOTJu5g==", "X-Received": "by 2002:a05:6512:c02:: with SMTP id\n z2mr14607535lfu.595.1618094860277;\n Sat, 10 Apr 2021 15:47:40 -0700 (PDT)", "From": "Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>", "To": "dev@dpdk.org", "Cc": "Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>", "Date": "Sun, 11 Apr 2021 01:47:28 +0300", "Message-Id": "<20210410224732.20234-1-dmitry.kozliuk@gmail.com>", "X-Mailer": "git-send-email 2.29.3", "In-Reply-To": "<20210407222249.6729-1-dmitry.kozliuk@gmail.com>", "References": "<20210407222249.6729-1-dmitry.kozliuk@gmail.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v9 0/4] eal/windows: do not expose POSIX symbols", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "On Windows, EAL contains two sets of functions and macros for POSIX\ncompatibility: <rte_os.h> and a networking shim (socket headers).\nThe latter conflicts with system headers and should not exist.\nExposing the former from EAL can break consumer own POSIX compatibility\nlayer and is against standards in general. Hide these symbols from\nexternal consumers, while keeping them available for DPDK code.\n\nv9:\n * Fix missing <rte_os_shim.h> include in rte_common_log.c.\n (This will happen again. Going to add a checkpatch test\n after this series is merged.)\nv8:\n * Drop rte_thread_sleep API, use rte_delay_us_sleep (Morten Brørup).\n\nDmitry Kozlyuk (4):\n eal/windows: hide asprintf() shim\n eal: make OS shims internal\n net: work around s_addr macro on Windows\n net: provide IP-related API on any OS\n\n drivers/bus/pci/private.h | 4 +-\n drivers/bus/vdev/vdev_private.h | 2 +\n drivers/common/mlx5/mlx5_common.h | 1 +\n drivers/net/i40e/i40e_ethdev.c | 1 +\n drivers/net/i40e/i40e_fdir.c | 1 +\n drivers/net/mlx5/mlx5.h | 1 -\n drivers/net/mlx5/mlx5_flow.c | 4 +-\n drivers/net/mlx5/mlx5_flow.h | 3 +-\n drivers/net/mlx5/mlx5_mac.c | 1 -\n examples/cmdline/commands.c | 5 --\n examples/cmdline/parse_obj_list.c | 2 -\n lib/librte_cmdline/cmdline.c | 5 --\n lib/librte_cmdline/cmdline_os_windows.c | 2 -\n lib/librte_cmdline/cmdline_parse.c | 2 -\n lib/librte_cmdline/cmdline_parse_etheraddr.c | 6 --\n lib/librte_cmdline/cmdline_parse_ipaddr.c | 6 --\n lib/librte_cmdline/cmdline_parse_ipaddr.h | 2 +-\n lib/librte_cmdline/cmdline_private.h | 1 +\n lib/librte_cmdline/cmdline_socket.c | 4 -\n lib/librte_eal/common/eal_common_config.c | 1 -\n lib/librte_eal/common/eal_common_errno.c | 4 +\n lib/librte_eal/common/eal_common_log.c | 1 +\n lib/librte_eal/common/eal_common_options.c | 2 +-\n lib/librte_eal/common/eal_common_timer.c | 4 +-\n lib/librte_eal/common/eal_internal_cfg.h | 1 +\n lib/librte_eal/common/eal_private.h | 11 +++\n lib/librte_eal/freebsd/include/rte_os_shim.h | 14 +++\n lib/librte_eal/linux/include/rte_os_shim.h | 14 +++\n lib/librte_eal/windows/eal.c | 30 +++++++\n lib/librte_eal/windows/eal_hugepages.c | 1 -\n lib/librte_eal/windows/eal_lcore.c | 1 -\n lib/librte_eal/windows/eal_memalloc.c | 1 -\n lib/librte_eal/windows/include/arpa/inet.h | 30 -------\n lib/librte_eal/windows/include/netinet/in.h | 38 --------\n lib/librte_eal/windows/include/netinet/ip.h | 10 ---\n lib/librte_eal/windows/include/rte_os.h | 92 +-------------------\n lib/librte_eal/windows/include/rte_os_shim.h | 36 ++++++++\n lib/librte_eal/windows/include/sys/socket.h | 24 -----\n lib/librte_ethdev/ethdev_private.h | 2 +\n lib/librte_ethdev/rte_ethdev.c | 12 +--\n lib/librte_ethdev/rte_ethdev_core.h | 1 -\n lib/librte_kvargs/rte_kvargs.c | 1 +\n lib/librte_net/rte_ether.h | 26 ++++--\n lib/librte_net/rte_ip.h | 7 ++\n lib/librte_net/rte_net.c | 1 +\n 45 files changed, 165 insertions(+), 253 deletions(-)\n create mode 100644 lib/librte_eal/freebsd/include/rte_os_shim.h\n create mode 100644 lib/librte_eal/linux/include/rte_os_shim.h\n delete mode 100644 lib/librte_eal/windows/include/arpa/inet.h\n delete mode 100644 lib/librte_eal/windows/include/netinet/in.h\n delete mode 100644 lib/librte_eal/windows/include/netinet/ip.h\n create mode 100644 lib/librte_eal/windows/include/rte_os_shim.h\n delete mode 100644 lib/librte_eal/windows/include/sys/socket.h" }