Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/100207/?format=api
{ "id": 100207, "url": "http://patchwork.dpdk.org/api/patches/100207/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20211001090723.1414911-4-andrew.rybchenko@oktetlabs.ru/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211001090723.1414911-4-andrew.rybchenko@oktetlabs.ru>", "list_archive_url": "https://inbox.dpdk.org/dev/20211001090723.1414911-4-andrew.rybchenko@oktetlabs.ru", "date": "2021-10-01T09:07:22", "name": "[v9,4/5] ethdev: improve xstats names by IDs get prototype", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "1467f084ae23602c48dbce6e22e9bd35dbf27668", "submitter": { "id": 2013, "url": "http://patchwork.dpdk.org/api/people/2013/?format=api", "name": "Andrew Rybchenko", "email": "Andrew.Rybchenko@oktetlabs.ru" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20211001090723.1414911-4-andrew.rybchenko@oktetlabs.ru/mbox/", "series": [ { "id": 19319, "url": "http://patchwork.dpdk.org/api/series/19319/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=19319", "date": "2021-10-01T09:07:19", "name": "[v9,1/5] ethdev: fix docs of functions getting xstats by IDs", "version": 9, "mbox": "http://patchwork.dpdk.org/series/19319/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/100207/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/100207/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 25D43A0032;\n\tFri, 1 Oct 2021 11:07:51 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8EA0241136;\n\tFri, 1 Oct 2021 11:07:44 +0200 (CEST)", "from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])\n by mails.dpdk.org (Postfix) with ESMTP id E977541135\n for <dev@dpdk.org>; Fri, 1 Oct 2021 11:07:43 +0200 (CEST)", "by shelob.oktetlabs.ru (Postfix, from userid 122)\n id BE3E67F6D8; Fri, 1 Oct 2021 12:07:43 +0300 (MSK)", "from aros.oktetlabs.ru (aros.oktetlabs.ru [192.168.38.17])\n by shelob.oktetlabs.ru (Postfix) with ESMTP id 60FD77F6C1;\n Fri, 1 Oct 2021 12:07:28 +0300 (MSK)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on shelob.oktetlabs.ru", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.8 required=5.0 tests=ALL_TRUSTED,\n DKIM_ADSP_DISCARD,\n URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2", "DKIM-Filter": "OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 60FD77F6C1", "Authentication-Results": "shelob.oktetlabs.ru/60FD77F6C1; dkim=none;\n dkim-atps=neutral", "From": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "To": "Somalapuram Amaranath <asomalap@amd.com>,\n Nithin Dabilpuram <ndabilpuram@marvell.com>,\n Kiran Kumar K <kirankumark@marvell.com>,\n Sunil Kumar Kori <skori@marvell.com>, Satha Rao <skoteshwar@marvell.com>,\n Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,\n Hemant Agrawal <hemant.agrawal@nxp.com>,\n Sachin Saxena <sachin.saxena@oss.nxp.com>,\n Haiyue Wang <haiyue.wang@intel.com>,\n \"Min Hu (Connor)\" <humin29@huawei.com>,\n Yisen Zhuang <yisen.zhuang@huawei.com>, Lijun Ou <oulijun@huawei.com>,\n Andrew Boyer <aboyer@pensando.io>, Jerin Jacob <jerinj@marvell.com>,\n Jiawen Wu <jiawenwu@trustnetic.com>, Jian Wang <jianwang@trustnetic.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Ferruh Yigit <ferruh.yigit@intel.com>", "Cc": "dev@dpdk.org", "Date": "Fri, 1 Oct 2021 12:07:22 +0300", "Message-Id": "<20211001090723.1414911-4-andrew.rybchenko@oktetlabs.ru>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20211001090723.1414911-1-andrew.rybchenko@oktetlabs.ru>", "References": "<20210604144225.287678-1-andrew.rybchenko@oktetlabs.ru>\n <20211001090723.1414911-1-andrew.rybchenko@oktetlabs.ru>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v9 4/5] ethdev: improve xstats names by IDs get\n prototype", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Adjust parameters order to eth_xstats_get_by_id_t prototype.\nMake ids the second parameter similar to eth_xstats_get_by_id_t.\n\nSigned-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>\n---\n drivers/net/axgbe/axgbe_ethdev.c | 4 ++--\n drivers/net/cnxk/cnxk_ethdev.h | 3 ++-\n drivers/net/cnxk/cnxk_stats.c | 3 ++-\n drivers/net/cxgbe/cxgbe_ethdev.c | 3 ++-\n drivers/net/dpaa/dpaa_ethdev.c | 2 +-\n drivers/net/dpaa2/dpaa2_ethdev.c | 2 +-\n drivers/net/e1000/igb_ethdev.c | 6 +++---\n drivers/net/hns3/hns3_stats.c | 7 ++++---\n drivers/net/hns3/hns3_stats.h | 2 +-\n drivers/net/igc/igc_ethdev.c | 4 ++--\n drivers/net/ionic/ionic_ethdev.c | 6 +++---\n drivers/net/ixgbe/ixgbe_ethdev.c | 6 +++---\n drivers/net/octeontx2/otx2_ethdev.h | 3 ++-\n drivers/net/octeontx2/otx2_stats.c | 3 ++-\n drivers/net/sfc/sfc_ethdev.c | 3 ++-\n drivers/net/txgbe/txgbe_ethdev.c | 2 +-\n lib/ethdev/ethdev_driver.h | 6 +++---\n lib/ethdev/rte_ethdev.c | 2 +-\n 18 files changed, 37 insertions(+), 30 deletions(-)", "diff": "diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c\nindex 9cb4818af1..ebd5411fdd 100644\n--- a/drivers/net/axgbe/axgbe_ethdev.c\n+++ b/drivers/net/axgbe/axgbe_ethdev.c\n@@ -57,8 +57,8 @@ axgbe_dev_xstats_get_by_id(struct rte_eth_dev *dev,\n \t\t\t unsigned int n);\n static int\n axgbe_dev_xstats_get_names_by_id(struct rte_eth_dev *dev,\n-\t\t\t\t struct rte_eth_xstat_name *xstats_names,\n \t\t\t\t const uint64_t *ids,\n+\t\t\t\t struct rte_eth_xstat_name *xstats_names,\n \t\t\t\t unsigned int size);\n static int axgbe_dev_xstats_reset(struct rte_eth_dev *dev);\n static int axgbe_dev_rss_reta_update(struct rte_eth_dev *dev,\n@@ -1076,8 +1076,8 @@ axgbe_dev_xstats_get_by_id(struct rte_eth_dev *dev, const uint64_t *ids,\n \n static int\n axgbe_dev_xstats_get_names_by_id(struct rte_eth_dev *dev,\n-\t\t\t\t struct rte_eth_xstat_name *xstats_names,\n \t\t\t\t const uint64_t *ids,\n+\t\t\t\t struct rte_eth_xstat_name *xstats_names,\n \t\t\t\t unsigned int size)\n {\n \tstruct rte_eth_xstat_name xstats_names_copy[AXGBE_XSTATS_COUNT];\ndiff --git a/drivers/net/cnxk/cnxk_ethdev.h b/drivers/net/cnxk/cnxk_ethdev.h\nindex 10e05e6b5e..946629f72e 100644\n--- a/drivers/net/cnxk/cnxk_ethdev.h\n+++ b/drivers/net/cnxk/cnxk_ethdev.h\n@@ -365,8 +365,9 @@ int cnxk_nix_xstats_get_names(struct rte_eth_dev *eth_dev,\n \t\t\t struct rte_eth_xstat_name *xstats_names,\n \t\t\t unsigned int limit);\n int cnxk_nix_xstats_get_names_by_id(struct rte_eth_dev *eth_dev,\n+\t\t\t\t const uint64_t *ids,\n \t\t\t\t struct rte_eth_xstat_name *xstats_names,\n-\t\t\t\t const uint64_t *ids, unsigned int limit);\n+\t\t\t\t unsigned int limit);\n int cnxk_nix_xstats_get_by_id(struct rte_eth_dev *eth_dev, const uint64_t *ids,\n \t\t\t uint64_t *values, unsigned int n);\n int cnxk_nix_xstats_reset(struct rte_eth_dev *eth_dev);\ndiff --git a/drivers/net/cnxk/cnxk_stats.c b/drivers/net/cnxk/cnxk_stats.c\nindex 19bab2170c..4b0deac05e 100644\n--- a/drivers/net/cnxk/cnxk_stats.c\n+++ b/drivers/net/cnxk/cnxk_stats.c\n@@ -227,8 +227,9 @@ cnxk_nix_xstats_get_names(struct rte_eth_dev *eth_dev,\n \n int\n cnxk_nix_xstats_get_names_by_id(struct rte_eth_dev *eth_dev,\n+\t\t\t\tconst uint64_t *ids,\n \t\t\t\tstruct rte_eth_xstat_name *xstats_names,\n-\t\t\t\tconst uint64_t *ids, unsigned int limit)\n+\t\t\t\tunsigned int limit)\n {\n \tstruct cnxk_eth_dev *dev = cnxk_eth_pmd_priv(eth_dev);\n \tuint32_t nix_cnt = roc_nix_num_xstats_get(&dev->nix);\ndiff --git a/drivers/net/cxgbe/cxgbe_ethdev.c b/drivers/net/cxgbe/cxgbe_ethdev.c\nindex 177eca3976..4929766d9a 100644\n--- a/drivers/net/cxgbe/cxgbe_ethdev.c\n+++ b/drivers/net/cxgbe/cxgbe_ethdev.c\n@@ -1006,8 +1006,9 @@ static int cxgbe_dev_xstats_get_by_id(struct rte_eth_dev *dev,\n \n /* Get names of port extended statistics by ID. */\n static int cxgbe_dev_xstats_get_names_by_id(struct rte_eth_dev *dev,\n+\t\t\t\t\t const uint64_t *ids,\n \t\t\t\t\t struct rte_eth_xstat_name *xnames,\n-\t\t\t\t\t const uint64_t *ids, unsigned int n)\n+\t\t\t\t\t unsigned int n)\n {\n \tstruct port_info *pi = dev->data->dev_private;\n \tstruct rte_eth_xstat_name *xnames_copy;\ndiff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c\nindex 36d8f9249d..1f80e8d744 100644\n--- a/drivers/net/dpaa/dpaa_ethdev.c\n+++ b/drivers/net/dpaa/dpaa_ethdev.c\n@@ -815,8 +815,8 @@ dpaa_xstats_get_by_id(struct rte_eth_dev *dev, const uint64_t *ids,\n static int\n dpaa_xstats_get_names_by_id(\n \tstruct rte_eth_dev *dev,\n-\tstruct rte_eth_xstat_name *xstats_names,\n \tconst uint64_t *ids,\n+\tstruct rte_eth_xstat_name *xstats_names,\n \tunsigned int limit)\n {\n \tunsigned int i, stat_cnt = RTE_DIM(dpaa_xstats_strings);\ndiff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c\nindex c12169578e..ea191564fc 100644\n--- a/drivers/net/dpaa2/dpaa2_ethdev.c\n+++ b/drivers/net/dpaa2/dpaa2_ethdev.c\n@@ -1795,8 +1795,8 @@ dpaa2_xstats_get_by_id(struct rte_eth_dev *dev, const uint64_t *ids,\n static int\n dpaa2_xstats_get_names_by_id(\n \tstruct rte_eth_dev *dev,\n-\tstruct rte_eth_xstat_name *xstats_names,\n \tconst uint64_t *ids,\n+\tstruct rte_eth_xstat_name *xstats_names,\n \tunsigned int limit)\n {\n \tunsigned int i, stat_cnt = RTE_DIM(dpaa2_xstats_strings);\ndiff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c\nindex d80fad01e3..6510cd7ceb 100644\n--- a/drivers/net/e1000/igb_ethdev.c\n+++ b/drivers/net/e1000/igb_ethdev.c\n@@ -96,7 +96,7 @@ static int eth_igb_xstats_get_names(struct rte_eth_dev *dev,\n \t\t\t\t struct rte_eth_xstat_name *xstats_names,\n \t\t\t\t unsigned int size);\n static int eth_igb_xstats_get_names_by_id(struct rte_eth_dev *dev,\n-\t\tstruct rte_eth_xstat_name *xstats_names, const uint64_t *ids,\n+\t\tconst uint64_t *ids, struct rte_eth_xstat_name *xstats_names,\n \t\tunsigned int limit);\n static int eth_igb_stats_reset(struct rte_eth_dev *dev);\n static int eth_igb_xstats_reset(struct rte_eth_dev *dev);\n@@ -1883,7 +1883,7 @@ static int eth_igb_xstats_get_names(__rte_unused struct rte_eth_dev *dev,\n }\n \n static int eth_igb_xstats_get_names_by_id(struct rte_eth_dev *dev,\n-\t\tstruct rte_eth_xstat_name *xstats_names, const uint64_t *ids,\n+\t\tconst uint64_t *ids, struct rte_eth_xstat_name *xstats_names,\n \t\tunsigned int limit)\n {\n \tunsigned int i;\n@@ -1902,7 +1902,7 @@ static int eth_igb_xstats_get_names_by_id(struct rte_eth_dev *dev,\n \t} else {\n \t\tstruct rte_eth_xstat_name xstats_names_copy[IGB_NB_XSTATS];\n \n-\t\teth_igb_xstats_get_names_by_id(dev, xstats_names_copy, NULL,\n+\t\teth_igb_xstats_get_names_by_id(dev, NULL, xstats_names_copy,\n \t\t\t\tIGB_NB_XSTATS);\n \n \t\tfor (i = 0; i < limit; i++) {\ndiff --git a/drivers/net/hns3/hns3_stats.c b/drivers/net/hns3/hns3_stats.c\nindex e09dc0da80..0fe853d626 100644\n--- a/drivers/net/hns3/hns3_stats.c\n+++ b/drivers/net/hns3/hns3_stats.c\n@@ -1365,12 +1365,12 @@ hns3_dev_xstats_get_by_id(struct rte_eth_dev *dev, const uint64_t *ids,\n *\n * @param dev\n * Pointer to Ethernet device.\n+ * @param ids\n+ * IDs array given by app to retrieve specific statistics\n * @param xstats_names\n * An rte_eth_xstat_name array of at least *size* elements to\n * be filled. If set to NULL, the function returns the required number\n * of elements.\n- * @param ids\n- * IDs array given by app to retrieve specific statistics\n * @param size\n * The size of the xstats_names array (number of elements).\n * @return\n@@ -1383,8 +1383,9 @@ hns3_dev_xstats_get_by_id(struct rte_eth_dev *dev, const uint64_t *ids,\n */\n int\n hns3_dev_xstats_get_names_by_id(struct rte_eth_dev *dev,\n+\t\t\t\tconst uint64_t *ids,\n \t\t\t\tstruct rte_eth_xstat_name *xstats_names,\n-\t\t\t\tconst uint64_t *ids, uint32_t size)\n+\t\t\t\tuint32_t size)\n {\n \tconst uint32_t cnt_stats = hns3_xstats_calc_num(dev);\n \tstruct hns3_adapter *hns = dev->data->dev_private;\ndiff --git a/drivers/net/hns3/hns3_stats.h b/drivers/net/hns3/hns3_stats.h\nindex de5c40d6b5..d1230f94cb 100644\n--- a/drivers/net/hns3/hns3_stats.h\n+++ b/drivers/net/hns3/hns3_stats.h\n@@ -161,8 +161,8 @@ int hns3_dev_xstats_get_by_id(struct rte_eth_dev *dev,\n \t\t\t uint64_t *values,\n \t\t\t uint32_t size);\n int hns3_dev_xstats_get_names_by_id(struct rte_eth_dev *dev,\n-\t\t\t\t struct rte_eth_xstat_name *xstats_names,\n \t\t\t\t const uint64_t *ids,\n+\t\t\t\t struct rte_eth_xstat_name *xstats_names,\n \t\t\t\t uint32_t size);\n int hns3_stats_reset(struct rte_eth_dev *dev);\n int hns3_tqp_stats_init(struct hns3_hw *hw);\ndiff --git a/drivers/net/igc/igc_ethdev.c b/drivers/net/igc/igc_ethdev.c\nindex 224a095483..be2c066111 100644\n--- a/drivers/net/igc/igc_ethdev.c\n+++ b/drivers/net/igc/igc_ethdev.c\n@@ -216,7 +216,7 @@ static int eth_igc_xstats_get_names(struct rte_eth_dev *dev,\n \t\t\t\tstruct rte_eth_xstat_name *xstats_names,\n \t\t\t\tunsigned int size);\n static int eth_igc_xstats_get_names_by_id(struct rte_eth_dev *dev,\n-\t\tstruct rte_eth_xstat_name *xstats_names, const uint64_t *ids,\n+\t\tconst uint64_t *ids, struct rte_eth_xstat_name *xstats_names,\n \t\tunsigned int limit);\n static int eth_igc_xstats_reset(struct rte_eth_dev *dev);\n static int\n@@ -2013,7 +2013,7 @@ eth_igc_xstats_get_names(__rte_unused struct rte_eth_dev *dev,\n \n static int\n eth_igc_xstats_get_names_by_id(struct rte_eth_dev *dev,\n-\t\tstruct rte_eth_xstat_name *xstats_names, const uint64_t *ids,\n+\t\tconst uint64_t *ids, struct rte_eth_xstat_name *xstats_names,\n \t\tunsigned int limit)\n {\n \tunsigned int i;\ndiff --git a/drivers/net/ionic/ionic_ethdev.c b/drivers/net/ionic/ionic_ethdev.c\nindex e620793966..344c076f30 100644\n--- a/drivers/net/ionic/ionic_ethdev.c\n+++ b/drivers/net/ionic/ionic_ethdev.c\n@@ -52,7 +52,7 @@ static int ionic_dev_xstats_reset(struct rte_eth_dev *dev);\n static int ionic_dev_xstats_get_names(struct rte_eth_dev *dev,\n \tstruct rte_eth_xstat_name *xstats_names, unsigned int size);\n static int ionic_dev_xstats_get_names_by_id(struct rte_eth_dev *dev,\n-\tstruct rte_eth_xstat_name *xstats_names, const uint64_t *ids,\n+\tconst uint64_t *ids, struct rte_eth_xstat_name *xstats_names,\n \tunsigned int limit);\n static int ionic_dev_fw_version_get(struct rte_eth_dev *eth_dev,\n \tchar *fw_version, size_t fw_size);\n@@ -733,7 +733,7 @@ ionic_dev_xstats_get_names(__rte_unused struct rte_eth_dev *eth_dev,\n \n static int\n ionic_dev_xstats_get_names_by_id(struct rte_eth_dev *eth_dev,\n-\t\tstruct rte_eth_xstat_name *xstats_names, const uint64_t *ids,\n+\t\tconst uint64_t *ids, struct rte_eth_xstat_name *xstats_names,\n \t\tunsigned int limit)\n {\n \tstruct rte_eth_xstat_name xstats_names_copy[IONIC_NB_HW_STATS];\n@@ -751,7 +751,7 @@ ionic_dev_xstats_get_names_by_id(struct rte_eth_dev *eth_dev,\n \t\treturn IONIC_NB_HW_STATS;\n \t}\n \n-\tionic_dev_xstats_get_names_by_id(eth_dev, xstats_names_copy, NULL,\n+\tionic_dev_xstats_get_names_by_id(eth_dev, NULL, xstats_names_copy,\n \t\tIONIC_NB_HW_STATS);\n \n \tfor (i = 0; i < limit; i++) {\ndiff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex 47693c0c47..aae8b55d83 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -173,8 +173,8 @@ static int ixgbevf_dev_xstats_get_names(struct rte_eth_dev *dev,\n \tstruct rte_eth_xstat_name *xstats_names, unsigned limit);\n static int ixgbe_dev_xstats_get_names_by_id(\n \tstruct rte_eth_dev *dev,\n-\tstruct rte_eth_xstat_name *xstats_names,\n \tconst uint64_t *ids,\n+\tstruct rte_eth_xstat_name *xstats_names,\n \tunsigned int limit);\n static int ixgbe_dev_queue_stats_mapping_set(struct rte_eth_dev *eth_dev,\n \t\t\t\t\t uint16_t queue_id,\n@@ -3437,8 +3437,8 @@ static int ixgbe_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,\n \n static int ixgbe_dev_xstats_get_names_by_id(\n \tstruct rte_eth_dev *dev,\n-\tstruct rte_eth_xstat_name *xstats_names,\n \tconst uint64_t *ids,\n+\tstruct rte_eth_xstat_name *xstats_names,\n \tunsigned int limit)\n {\n \tif (!ids) {\n@@ -3497,7 +3497,7 @@ static int ixgbe_dev_xstats_get_names_by_id(\n \tuint16_t size = ixgbe_xstats_calc_num();\n \tstruct rte_eth_xstat_name xstats_names_copy[size];\n \n-\tixgbe_dev_xstats_get_names_by_id(dev, xstats_names_copy, NULL,\n+\tixgbe_dev_xstats_get_names_by_id(dev, NULL, xstats_names_copy,\n \t\t\tsize);\n \n \tfor (i = 0; i < limit; i++) {\ndiff --git a/drivers/net/octeontx2/otx2_ethdev.h b/drivers/net/octeontx2/otx2_ethdev.h\nindex 7871e3d30b..b1575f59a2 100644\n--- a/drivers/net/octeontx2/otx2_ethdev.h\n+++ b/drivers/net/octeontx2/otx2_ethdev.h\n@@ -514,8 +514,9 @@ int otx2_nix_xstats_get_by_id(struct rte_eth_dev *eth_dev,\n \t\t\t const uint64_t *ids,\n \t\t\t uint64_t *values, unsigned int n);\n int otx2_nix_xstats_get_names_by_id(struct rte_eth_dev *eth_dev,\n+\t\t\t\t const uint64_t *ids,\n \t\t\t\t struct rte_eth_xstat_name *xstats_names,\n-\t\t\t\t const uint64_t *ids, unsigned int limit);\n+\t\t\t\t unsigned int limit);\n \n /* RSS */\n void otx2_nix_rss_set_key(struct otx2_eth_dev *dev,\ndiff --git a/drivers/net/octeontx2/otx2_stats.c b/drivers/net/octeontx2/otx2_stats.c\nindex 8aaf270a7c..3adf21608c 100644\n--- a/drivers/net/octeontx2/otx2_stats.c\n+++ b/drivers/net/octeontx2/otx2_stats.c\n@@ -240,8 +240,9 @@ otx2_nix_xstats_get_names(struct rte_eth_dev *eth_dev,\n \n int\n otx2_nix_xstats_get_names_by_id(struct rte_eth_dev *eth_dev,\n+\t\t\t\tconst uint64_t *ids,\n \t\t\t\tstruct rte_eth_xstat_name *xstats_names,\n-\t\t\t\tconst uint64_t *ids, unsigned int limit)\n+\t\t\t\tunsigned int limit)\n {\n \tstruct rte_eth_xstat_name xstats_names_copy[OTX2_NIX_NUM_XSTATS_REG];\n \tuint16_t i;\ndiff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c\nindex 2db0d000c3..f212ca8ad6 100644\n--- a/drivers/net/sfc/sfc_ethdev.c\n+++ b/drivers/net/sfc/sfc_ethdev.c\n@@ -838,8 +838,9 @@ sfc_xstats_get_by_id(struct rte_eth_dev *dev, const uint64_t *ids,\n \n static int\n sfc_xstats_get_names_by_id(struct rte_eth_dev *dev,\n+\t\t\t const uint64_t *ids,\n \t\t\t struct rte_eth_xstat_name *xstats_names,\n-\t\t\t const uint64_t *ids, unsigned int size)\n+\t\t\t unsigned int size)\n {\n \tstruct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);\n \tstruct sfc_port *port = &sa->port;\ndiff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c\nindex 0063994688..b267da462b 100644\n--- a/drivers/net/txgbe/txgbe_ethdev.c\n+++ b/drivers/net/txgbe/txgbe_ethdev.c\n@@ -2451,8 +2451,8 @@ static int txgbe_dev_xstats_get_names(struct rte_eth_dev *dev,\n }\n \n static int txgbe_dev_xstats_get_names_by_id(struct rte_eth_dev *dev,\n-\tstruct rte_eth_xstat_name *xstats_names,\n \tconst uint64_t *ids,\n+\tstruct rte_eth_xstat_name *xstats_names,\n \tunsigned int limit)\n {\n \tunsigned int i;\ndiff --git a/lib/ethdev/ethdev_driver.h b/lib/ethdev/ethdev_driver.h\nindex 81dee87586..96dd0ecaf3 100644\n--- a/lib/ethdev/ethdev_driver.h\n+++ b/lib/ethdev/ethdev_driver.h\n@@ -237,11 +237,11 @@ typedef int (*eth_xstats_get_names_t)(struct rte_eth_dev *dev,\n *\n * @param dev\n * ethdev handle of port.\n+ * @param ids\n+ * IDs array to retrieve specific statistics. Must not be NULL.\n * @param xstats_names\n * An rte_eth_xstat_name array of at least @p size elements to be filled.\n * Must not be NULL.\n- * @param ids\n- * IDs array to retrieve specific statistics. Must not be NULL.\n * @param size\n * Element count in @p ids and @p xstats_names.\n *\n@@ -250,7 +250,7 @@ typedef int (*eth_xstats_get_names_t)(struct rte_eth_dev *dev,\n * - A negative value on error.\n */\n typedef int (*eth_xstats_get_names_by_id_t)(struct rte_eth_dev *dev,\n-\tstruct rte_eth_xstat_name *xstats_names, const uint64_t *ids,\n+\tconst uint64_t *ids, struct rte_eth_xstat_name *xstats_names,\n \tunsigned int size);\n \n typedef int (*eth_queue_stats_mapping_set_t)(struct rte_eth_dev *dev,\ndiff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c\nindex e5ddc1b81f..655d7be3b5 100644\n--- a/lib/ethdev/rte_ethdev.c\n+++ b/lib/ethdev/rte_ethdev.c\n@@ -3023,7 +3023,7 @@ rte_eth_xstats_get_names_by_id(uint16_t port_id,\n \n \t\tif (no_basic_stat_requested)\n \t\t\treturn (*dev->dev_ops->xstats_get_names_by_id)(dev,\n-\t\t\t\t\txstats_names, ids_copy, size);\n+\t\t\t\t\tids_copy, xstats_names, size);\n \t}\n \n \t/* Retrieve all stats */\n", "prefixes": [ "v9", "4/5" ] }