Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/103164/?format=api
{ "id": 103164, "url": "http://patchwork.dpdk.org/api/patches/103164/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/9802c552ddd70f0d9b751ea567804bcaf0b7f0bd.1635428963.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<9802c552ddd70f0d9b751ea567804bcaf0b7f0bd.1635428963.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/9802c552ddd70f0d9b751ea567804bcaf0b7f0bd.1635428963.git.anatoly.burakov@intel.com", "date": "2021-10-28T13:49:29", "name": "[v2,3/4] vfio: fix documentation to match intended behavior", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "11b2b4401958c7fd13db0a9b5803d05377ce6283", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/9802c552ddd70f0d9b751ea567804bcaf0b7f0bd.1635428963.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 20100, "url": "http://patchwork.dpdk.org/api/series/20100/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=20100", "date": "2021-10-28T13:49:27", "name": "[v2,1/4] vfio: drop fallback Linux implementation", "version": 2, "mbox": "http://patchwork.dpdk.org/series/20100/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/103164/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/103164/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D7FB5A0547;\n\tThu, 28 Oct 2021 15:49:46 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C61B1426D3;\n\tThu, 28 Oct 2021 15:49:37 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by mails.dpdk.org (Postfix) with ESMTP id DEF9C411FE;\n Thu, 28 Oct 2021 15:49:34 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Oct 2021 06:49:34 -0700", "from silpixa00401191.ir.intel.com ([10.55.128.95])\n by orsmga007.jf.intel.com with ESMTP; 28 Oct 2021 06:49:33 -0700" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10150\"; a=\"230261430\"", "E=Sophos;i=\"5.87,190,1631602800\"; d=\"scan'208\";a=\"230261430\"", "E=Sophos;i=\"5.87,190,1631602800\"; d=\"scan'208\";a=\"487136678\"" ], "X-ExtLoop1": "1", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "stable@dpdk.org", "Date": "Thu, 28 Oct 2021 13:49:29 +0000", "Message-Id": "\n <9802c552ddd70f0d9b751ea567804bcaf0b7f0bd.1635428963.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "\n <b2382197250fe4a359a7eb2e7e4c1d12cd959500.1635428963.git.anatoly.burakov@intel.com>", "References": "\n <25dd76eca01ec57d64be9c0a78ac2752f602984f.1631788595.git.anatoly.burakov@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 3/4] vfio: fix documentation to match intended\n behavior", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "On FreeBSD, `rte_vfio_is_enabled()` and `rte_vfio_noiommu_is_enabled()`\nAPI calls will not return error, and will instead return 0. This is\nintentional, because the caller of this API does not care whether VFIO\nis supported at all, and will instead be interested in whether VFIO is\nenabled or not. However, the doxygen comments for these functions state\nthat they will return an error on FreeBSD, which is incorrect.\n\nFix the doxygen comment to call out the fact that these\nfunctions are only relevant on Linux, but remove the reference to\nreturning errors.\n\nCc: stable@dpdk.org\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n\nNotes:\n Current minimum support Linux kernel is 4.4, and Meson build file sets the\n RTE_EAL_VFIO config option to `true` simply because we are compiling for Linux.\n So, it looks like VFIO support is pretty much assumed on Linux, so i think we\n can safely drop the fallback dummy implementation from Linux altogether?\n\n lib/eal/include/rte_vfio.h | 6 ++----\n 1 file changed, 2 insertions(+), 4 deletions(-)", "diff": "diff --git a/lib/eal/include/rte_vfio.h b/lib/eal/include/rte_vfio.h\nindex 2d90b36480..7bdb8932b2 100644\n--- a/lib/eal/include/rte_vfio.h\n+++ b/lib/eal/include/rte_vfio.h\n@@ -150,8 +150,7 @@ int rte_vfio_enable(const char *modname);\n /**\n * Check whether a VFIO-related kmod is enabled.\n *\n- * This function is only relevant to linux and will return\n- * an error on BSD.\n+ * This function is only relevant to Linux.\n *\n * @param modname\n * kernel module name.\n@@ -165,8 +164,7 @@ int rte_vfio_is_enabled(const char *modname);\n /**\n * Whether VFIO NOIOMMU mode is enabled.\n *\n- * This function is only relevant to linux and will return\n- * an error on BSD.\n+ * This function is only relevant to Linux.\n *\n * @return\n * 1 if true.\n", "prefixes": [ "v2", "3/4" ] }