Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/104783/?format=api
{ "id": 104783, "url": "http://patchwork.dpdk.org/api/patches/104783/?format=api", "web_url": "http://patchwork.dpdk.org/project/dts/patch/20211201141258.144488-1-leweix.yang@intel.com/", "project": { "id": 3, "url": "http://patchwork.dpdk.org/api/projects/3/?format=api", "name": "DTS", "link_name": "dts", "list_id": "dts.dpdk.org", "list_email": "dts@dpdk.org", "web_url": "", "scm_url": "git://dpdk.org/tools/dts", "webscm_url": "http://git.dpdk.org/tools/dts/", "list_archive_url": "https://inbox.dpdk.org/dts", "list_archive_url_format": "https://inbox.dpdk.org/dts/{}", "commit_url_format": "" }, "msgid": "<20211201141258.144488-1-leweix.yang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dts/20211201141258.144488-1-leweix.yang@intel.com", "date": "2021-12-01T14:12:58", "name": "[V1] test/smoke:remove specific parameters in common cases", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e0f7736fe25f0ec300ff059975f22c8e21929ff5", "submitter": { "id": 2225, "url": "http://patchwork.dpdk.org/api/people/2225/?format=api", "name": "Lewei Yang", "email": "leweix.yang@intel.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dts/patch/20211201141258.144488-1-leweix.yang@intel.com/mbox/", "series": [ { "id": 20820, "url": "http://patchwork.dpdk.org/api/series/20820/?format=api", "web_url": "http://patchwork.dpdk.org/project/dts/list/?series=20820", "date": "2021-12-01T14:12:58", "name": "[V1] test/smoke:remove specific parameters in common cases", "version": 1, "mbox": "http://patchwork.dpdk.org/series/20820/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/104783/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/104783/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dts-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6CC3CA0C4C;\n\tWed, 1 Dec 2021 07:12:57 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 333514068C;\n\tWed, 1 Dec 2021 07:12:57 +0100 (CET)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by mails.dpdk.org (Postfix) with ESMTP id 451284067B\n for <dts@dpdk.org>; Wed, 1 Dec 2021 07:12:55 +0100 (CET)", "from orsmga002.jf.intel.com ([10.7.209.21])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 30 Nov 2021 22:12:54 -0800", "from unknown (HELO dpdk.lan) ([10.240.183.77])\n by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 30 Nov 2021 22:12:52 -0800" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10184\"; a=\"236621951\"", "E=Sophos;i=\"5.87,278,1631602800\"; d=\"scan'208\";a=\"236621951\"", "E=Sophos;i=\"5.87,278,1631602800\"; d=\"scan'208\";a=\"477424879\"" ], "From": "Lewei Yang <leweix.yang@intel.com>", "To": "dts@dpdk.org", "Cc": "Lewei Yang <leweix.yang@intel.com>", "Subject": "[dts][PATCH V1] test/smoke:remove specific parameters in common cases", "Date": "Wed, 1 Dec 2021 14:12:58 +0000", "Message-Id": "<20211201141258.144488-1-leweix.yang@intel.com>", "X-Mailer": "git-send-email 2.33.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dts@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "test suite reviews and discussions <dts.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dts/>", "List-Post": "<mailto:dts@dpdk.org>", "List-Help": "<mailto:dts-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>", "Errors-To": "dts-bounces@dpdk.org" }, "content": "remove specific parameters in common cases.\n\nSigned-off-by: Lewei Yang <leweix.yang@intel.com>\n---\n test_plans/pf_smoke_test_plan.rst | 14 ++++++++------\n test_plans/vf_smoke_test_plan.rst | 13 +++++++------\n tests/TestSuite_pf_smoke.py | 17 ++++++++++-------\n tests/TestSuite_vf_smoke.py | 19 ++++++++++++-------\n 4 files changed, 37 insertions(+), 26 deletions(-)", "diff": "diff --git a/test_plans/pf_smoke_test_plan.rst b/test_plans/pf_smoke_test_plan.rst\nindex 2b6c6128..ffcd2105 100644\n--- a/test_plans/pf_smoke_test_plan.rst\n+++ b/test_plans/pf_smoke_test_plan.rst\n@@ -71,7 +71,7 @@ Prerequisites\n \n 8. Launch dpdk on PF::\n \n- ./x86_64-native-linuxapp-gcc/app/dpdk-testpmd -c 0xf -n 4 -a 0000:86:00.0 --file-prefix=pf -- -i --max-pkt-len=9600 --tx-offloads=0x00008000 --rxq=4 --txq=4\n+ ./x86_64-native-linuxapp-gcc/app/dpdk-testpmd -c 0xf -n 4 -a 0000:86:00.0 --file-prefix=pf -- -i --rxq=4 --txq=4\n testpmd> set fwd mac\n testpmd> set verbose 3\n testpmd> start\n@@ -79,13 +79,15 @@ Prerequisites\n \n Test Case 1: test enable and disable jumbo frame\n ====================================================\n-1. set fwd mode is mac::\n+1. when launch dpdk on PF, add parameter '--max-pkt-len=9600 --tx-offloads=0x00008000'\n+\n+2. set fwd mode is mac::\n \n testpmd> set fwd mac\n testpmd> set verbose 3\n testpmd> start\n \n-2. Send a packet with size 9601 bytes ::\n+3. Send a packet with size 9601 bytes ::\n \n testpmd> show port stats 0\n \n@@ -96,7 +98,7 @@ Test Case 1: test enable and disable jumbo frame\n \n Verify that TX-bytes on port 0 and RX-bytes on port 0 are 0.\n \n-3. Send a packet with size 9600 bytes ::\n+4. Send a packet with size 9600 bytes ::\n \n testpmd> show port stats 0\n \n@@ -107,11 +109,11 @@ Verify that TX-bytes on port 0 and RX-bytes on port 0 are 0.\n \n Verify that TX-bytes on port 0 and RX-bytes on port 0 are 9600.\n \n-4. Set mtu is 1500 ::\n+5. Set mtu is 1500 ::\n \n testpmd> port config mtu 1500\n \n-5. Send a packet with size 1518 bytes ::\n+6. Send a packet with size 1518 bytes ::\n \n testpmd> show port stats 0\n \ndiff --git a/test_plans/vf_smoke_test_plan.rst b/test_plans/vf_smoke_test_plan.rst\nindex 650f759c..43330c10 100644\n--- a/test_plans/vf_smoke_test_plan.rst\n+++ b/test_plans/vf_smoke_test_plan.rst\n@@ -82,7 +82,7 @@ Prerequisites\n \n 8. Launch dpdk on VF::\n \n- ./x86_64-native-linuxapp-gcc/app/dpdk-testpmd -c 0xf -n 4 -a 0000:86:01.0 --file-prefix=pf -- -i --max-pkt-len=9600 --tx-offloads=0x00008000 --rxq=4 --txq=4\n+ ./x86_64-native-linuxapp-gcc/app/dpdk-testpmd -c 0xf -n 4 -a 0000:86:01.0 --file-prefix=pf -- -i --rxq=4 --txq=4\n testpmd> set fwd mac\n testpmd> set verbose 3\n testpmd> start\n@@ -91,14 +91,15 @@ Prerequisites\n \n Test Case 1: test enable and disable jumbo frame\n ====================================================\n+1. when launch dpdk on VF, add parameter '--max-pkt-len=9600 --tx-offloads=0x00008000'\n \n-1. set fwd mode is mac::\n+2. set fwd mode is mac::\n \n testpmd> set fwd mac\n testpmd> set verbose 3\n testpmd> start\n \n-2. Send a packet with size 9601 bytes ::\n+3. Send a packet with size 9601 bytes ::\n \n testpmd> show port stats 0\n \n@@ -109,7 +110,7 @@ Test Case 1: test enable and disable jumbo frame\n \n Verify that TX-bytes on port 0 and RX-bytes on port 0 are 0.\n \n-3. Send a packet with size 9600 bytes ::\n+4. Send a packet with size 9600 bytes ::\n \n testpmd> show port stats 0\n \n@@ -120,11 +121,11 @@ Verify that TX-bytes on port 0 and RX-bytes on port 0 are 0.\n \n Verify that TX-bytes on port 0 and RX-bytes on port 0 are 9600.\n \n-4. Set mtu is 1500 ::\n+5. Set mtu is 1500 ::\n \n testpmd> port config mtu 1500\n \n-5. Send a packet with size 1518 bytes ::\n+6. Send a packet with size 1518 bytes ::\n \n testpmd> show port stats 0\n \ndiff --git a/tests/TestSuite_pf_smoke.py b/tests/TestSuite_pf_smoke.py\nindex 7477f498..a8e4adde 100644\n--- a/tests/TestSuite_pf_smoke.py\n+++ b/tests/TestSuite_pf_smoke.py\n@@ -72,9 +72,6 @@ class TestPfSmoke(TestCase):\n # set default app parameter\n self.pmd_out = PmdOutput(self.dut)\n self.ports = [self.dut.ports_info[self.smoke_dut_ports[0]]['pci']]\n- self.param = '--max-pkt-len={} --tx-offloads=0x8000 --rxq={} --txq={}'.format(JUMBO_FRAME_LENGTH,\n- LAUNCH_QUEUE,\n- LAUNCH_QUEUE)\n self.test_func = SmokeTest(self)\n self.check_session = self.dut.new_session(suite=\"pf_smoke_test\")\n \n@@ -82,15 +79,19 @@ class TestPfSmoke(TestCase):\n \"\"\"\n Run before each test case.\n \"\"\"\n+ # set tester mtu and testpmd parameter\n+ if self._suite_result.test_case == \"test_pf_jumbo_frames\":\n+ self.tester.send_expect(\"ifconfig {} mtu {}\".format(self.smoke_tester_nic, JUMBO_FRAME_MTU), '# ')\n+ self.param = '--max-pkt-len={} --tx-offloads=0x8000 --rxq={} --txq={}'.format(JUMBO_FRAME_LENGTH,\n+ LAUNCH_QUEUE,\n+ LAUNCH_QUEUE)\n+ else:\n+ self.param = '--rxq={} --txq={}'.format(LAUNCH_QUEUE, LAUNCH_QUEUE)\n # verify app launch state.\n out = self.check_session.send_expect(\"ls -l /var/run/dpdk |awk '/^d/ {print $NF}'\", '# ', 1)\n if out == '' or 'No such file or directory' in out:\n self.pf_launch_dpdk_app()\n \n- # set tester mtu\n- if self._suite_result.test_case == \"test_pf_jumbo_frames\":\n- self.tester.send_expect(\"ifconfig {} mtu {}\".format(self.smoke_tester_nic, JUMBO_FRAME_MTU), '# ')\n-\n def pf_launch_dpdk_app(self):\n self.pmd_out.start_testpmd(cores=self.cores, ports=self.ports, param=self.param)\n \n@@ -146,6 +147,8 @@ class TestPfSmoke(TestCase):\n self.dut.send_expect(\"port config all rxq {}\".format(LAUNCH_QUEUE), \"testpmd> \")\n self.dut.send_expect(\"port config all txq {}\".format(LAUNCH_QUEUE), \"testpmd> \")\n self.dut.send_expect(\"port start all\", \"testpmd> \")\n+ self.dut.send_expect(\"quit\", \"# \")\n+ self.dut.kill_all()\n \n def tear_down_all(self):\n if self.check_session:\ndiff --git a/tests/TestSuite_vf_smoke.py b/tests/TestSuite_vf_smoke.py\nindex ab939acc..d63db2be 100644\n--- a/tests/TestSuite_vf_smoke.py\n+++ b/tests/TestSuite_vf_smoke.py\n@@ -92,9 +92,6 @@ class TestVfSmoke(TestCase):\n self.ports = [self.vf0_prop['opt_host']]\n \n self.pmd_out = PmdOutput(self.dut)\n- self.param = '--max-pkt-len={} --tx-offloads=0x8000 --rxq={} --txq={}'.format(JUMBO_FRAME_LENGTH,\n- LAUNCH_QUEUE,\n- LAUNCH_QUEUE)\n self.test_func = SmokeTest(self)\n self.check_session = self.dut.new_session(suite=\"vf_smoke_test\")\n \n@@ -102,14 +99,20 @@ class TestVfSmoke(TestCase):\n \"\"\"\n Run before each test case.\n \"\"\"\n+ # set tester mtu and testpmd parameter\n+ if self._suite_result.test_case == \"test_vf_jumbo_frames\":\n+ self.tester.send_expect(\"ifconfig {} mtu {}\".format(self.smoke_tester_nic, JUMBO_FRAME_MTU), '# ')\n+ self.param = '--max-pkt-len={} --tx-offloads=0x8000 --rxq={} --txq={}'.format(JUMBO_FRAME_LENGTH,\n+ LAUNCH_QUEUE,\n+ LAUNCH_QUEUE)\n+ else:\n+ self.param = '--rxq={} --txq={}'.format(LAUNCH_QUEUE, LAUNCH_QUEUE)\n+\n # verify app launch state.\n out = self.check_session.send_expect(\"ls -l /var/run/dpdk |awk '/^d/ {print $NF}'\", '# ', 1)\n if out == '' or 'No such file or directory' in out:\n self.vf_launch_dpdk_app()\n \n- if self._suite_result.test_case == \"test_vf_jumbo_frames\":\n- self.tester.send_expect(\"ifconfig {} mtu {}\".format(self.smoke_tester_nic, JUMBO_FRAME_MTU), '# ')\n-\n def vf_launch_dpdk_app(self):\n self.pmd_out.start_testpmd(cores=self.cores, ports=self.ports, param=self.param)\n \n@@ -155,7 +158,7 @@ class TestVfSmoke(TestCase):\n # set tester mtu to default value\n self.pmd_out.execute_cmd(\"stop\")\n if self._suite_result.test_case == \"test_vf_jumbo_frames\":\n- self.tester.send_expect(\"ifconfig {} mtu {}\".format(self.smoke_tester_nic, DEFAULT_PKG_LEN), '# ')\n+ self.tester.send_expect(\"ifconfig {} mtu {}\".format(self.smoke_tester_nic, DEFAULT_MTU_VALUE), '# ')\n \n # set dpdk queues to launch value\n if self._suite_result.test_case == \"test_vf_tx_rx_queue\":\n@@ -163,6 +166,8 @@ class TestVfSmoke(TestCase):\n self.dut.send_expect(\"port config all rxq {}\".format(LAUNCH_QUEUE), \"testpmd> \")\n self.dut.send_expect(\"port config all txq {}\".format(LAUNCH_QUEUE), \"testpmd> \")\n self.dut.send_expect(\"port start all\", \"testpmd> \")\n+ self.dut.send_expect(\"quit\", \"# \")\n+ self.dut.kill_all()\n \n def tear_down_all(self):\n if self.check_session:\n", "prefixes": [ "V1" ] }