Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/10686/?format=api
{ "id": 10686, "url": "http://patchwork.dpdk.org/api/patches/10686/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1455880025-6912-4-git-send-email-xiao.w.wang@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1455880025-6912-4-git-send-email-xiao.w.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1455880025-6912-4-git-send-email-xiao.w.wang@intel.com", "date": "2016-02-19T11:06:50", "name": "[dpdk-dev,v3,03/18] fm10k/base: cleanup namespace pollution", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "725c4a6eacbfd13eaaac150b84b2307a774bf522", "submitter": { "id": 281, "url": "http://patchwork.dpdk.org/api/people/281/?format=api", "name": "Xiao Wang", "email": "xiao.w.wang@intel.com" }, "delegate": { "id": 10, "url": "http://patchwork.dpdk.org/api/users/10/?format=api", "username": "bruce", "first_name": "Bruce", "last_name": "Richardson", "email": "bruce.richardson@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1455880025-6912-4-git-send-email-xiao.w.wang@intel.com/mbox/", "series": [], "comments": "http://patchwork.dpdk.org/api/patches/10686/comments/", "check": "pending", "checks": "http://patchwork.dpdk.org/api/patches/10686/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 2FBE0C53A;\n\tFri, 19 Feb 2016 12:07:23 +0100 (CET)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id F194CC52A\n\tfor <dev@dpdk.org>; Fri, 19 Feb 2016 12:07:19 +0100 (CET)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga103.jf.intel.com with ESMTP; 19 Feb 2016 03:07:21 -0800", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby FMSMGA003.fm.intel.com with ESMTP; 19 Feb 2016 03:07:19 -0800", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id u1JB7GKd026619;\n\tFri, 19 Feb 2016 19:07:16 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid u1JB7ETu006967; Fri, 19 Feb 2016 19:07:16 +0800", "(from xiaowan1@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id u1JB7Epf006963; \n\tFri, 19 Feb 2016 19:07:14 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.22,470,1449561600\"; d=\"scan'208\";a=\"655582253\"", "From": "Wang Xiao W <xiao.w.wang@intel.com>", "To": "jing.d.chen@intel.com", "Date": "Fri, 19 Feb 2016 19:06:50 +0800", "Message-Id": "<1455880025-6912-4-git-send-email-xiao.w.wang@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1455880025-6912-1-git-send-email-xiao.w.wang@intel.com>", "References": "<1453866647-16215-2-git-send-email-xiao.w.wang@intel.com>\n\t<1455880025-6912-1-git-send-email-xiao.w.wang@intel.com>", "Cc": "dev@dpdk.org", "Subject": "[dpdk-dev] [PATCH v3 03/18] fm10k/base: cleanup namespace pollution", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Make functions that are only referenced locally static.\n\nWrap fm10k_msg_data fm10k_iov_msg_data_pf[] in the new ifndef\nNO_DEFAULT_SRIOV_MSG_HANDLERS so that drivers with custom SR-IOV\nmessage handlers can strip it.\n\nSigned-off-by: Wang Xiao W <xiao.w.wang@intel.com>\n---\n drivers/net/fm10k/base/fm10k_pf.c | 6 ++++--\n drivers/net/fm10k/base/fm10k_pf.h | 4 ++--\n drivers/net/fm10k/base/fm10k_tlv.c | 14 +++++++-------\n drivers/net/fm10k/base/fm10k_tlv.h | 5 -----\n drivers/net/fm10k/base/fm10k_vf.c | 2 --\n 5 files changed, 13 insertions(+), 18 deletions(-)", "diff": "diff --git a/drivers/net/fm10k/base/fm10k_pf.c b/drivers/net/fm10k/base/fm10k_pf.c\nindex 4a028f3..5b8c039 100644\n--- a/drivers/net/fm10k/base/fm10k_pf.c\n+++ b/drivers/net/fm10k/base/fm10k_pf.c\n@@ -1457,6 +1457,7 @@ s32 fm10k_iov_msg_lport_state_pf(struct fm10k_hw *hw, u32 **results,\n \treturn err;\n }\n \n+#ifndef NO_DEFAULT_SRIOV_MSG_HANDLERS\n const struct fm10k_msg_data fm10k_iov_msg_data_pf[] = {\n \tFM10K_TLV_MSG_TEST_HANDLER(fm10k_tlv_msg_test),\n \tFM10K_VF_MSG_MSIX_HANDLER(fm10k_iov_msg_msix_pf),\n@@ -1465,6 +1466,7 @@ const struct fm10k_msg_data fm10k_iov_msg_data_pf[] = {\n \tFM10K_TLV_MSG_ERROR_HANDLER(fm10k_tlv_msg_error),\n };\n \n+#endif\n /**\n * fm10k_update_stats_hw_pf - Updates hardware related statistics of PF\n * @hw: pointer to hardware structure\n@@ -1754,8 +1756,8 @@ const struct fm10k_tlv_attr fm10k_update_pvid_msg_attr[] = {\n *\n * This handler configures the default VLAN for the PF\n **/\n-s32 fm10k_msg_update_pvid_pf(struct fm10k_hw *hw, u32 **results,\n-\t\t\t struct fm10k_mbx_info *mbx)\n+static s32 fm10k_msg_update_pvid_pf(struct fm10k_hw *hw, u32 **results,\n+\t\t\t\t struct fm10k_mbx_info *mbx)\n {\n \tu16 glort, pvid;\n \tu32 pvid_update;\ndiff --git a/drivers/net/fm10k/base/fm10k_pf.h b/drivers/net/fm10k/base/fm10k_pf.h\nindex 44bd193..92e2962 100644\n--- a/drivers/net/fm10k/base/fm10k_pf.h\n+++ b/drivers/net/fm10k/base/fm10k_pf.h\n@@ -149,8 +149,6 @@ extern const struct fm10k_tlv_attr fm10k_lport_map_msg_attr[];\n #define FM10K_PF_MSG_LPORT_MAP_HANDLER(func) \\\n \tFM10K_MSG_HANDLER(FM10K_PF_MSG_ID_LPORT_MAP, \\\n \t\t\t fm10k_lport_map_msg_attr, func)\n-s32 fm10k_msg_update_pvid_pf(struct fm10k_hw *, u32 **,\n-\t\t\t struct fm10k_mbx_info *);\n extern const struct fm10k_tlv_attr fm10k_update_pvid_msg_attr[];\n #define FM10K_PF_MSG_UPDATE_PVID_HANDLER(func) \\\n \tFM10K_MSG_HANDLER(FM10K_PF_MSG_ID_UPDATE_PVID, \\\n@@ -183,7 +181,9 @@ s32 fm10k_iov_msg_mac_vlan_pf(struct fm10k_hw *, u32 **,\n \t\t\t struct fm10k_mbx_info *);\n s32 fm10k_iov_msg_lport_state_pf(struct fm10k_hw *, u32 **,\n \t\t\t\t struct fm10k_mbx_info *);\n+#ifndef NO_DEFAULT_SRIOV_MSG_HANDLERS\n extern const struct fm10k_msg_data fm10k_iov_msg_data_pf[];\n+#endif\n \n s32 fm10k_init_ops_pf(struct fm10k_hw *hw);\n #endif /* _FM10K_PF_H */\ndiff --git a/drivers/net/fm10k/base/fm10k_tlv.c b/drivers/net/fm10k/base/fm10k_tlv.c\nindex 1d9d7d8..4b5f684 100644\n--- a/drivers/net/fm10k/base/fm10k_tlv.c\n+++ b/drivers/net/fm10k/base/fm10k_tlv.c\n@@ -63,8 +63,8 @@ s32 fm10k_tlv_msg_init(u32 *msg, u16 msg_id)\n * the attribute buffer. It will return success if provided with a valid\n * pointers.\n **/\n-s32 fm10k_tlv_attr_put_null_string(u32 *msg, u16 attr_id,\n-\t\t\t\t const unsigned char *string)\n+static s32 fm10k_tlv_attr_put_null_string(u32 *msg, u16 attr_id,\n+\t\t\t\t\t const unsigned char *string)\n {\n \tu32 attr_data = 0, len = 0;\n \tu32 *attr;\n@@ -115,7 +115,7 @@ s32 fm10k_tlv_attr_put_null_string(u32 *msg, u16 attr_id,\n * it in the array pointed by by string. It will return success if provided\n * with a valid pointers.\n **/\n-s32 fm10k_tlv_attr_get_null_string(u32 *attr, unsigned char *string)\n+static s32 fm10k_tlv_attr_get_null_string(u32 *attr, unsigned char *string)\n {\n \tu32 len;\n \n@@ -386,7 +386,7 @@ s32 fm10k_tlv_attr_get_le_struct(u32 *attr, void *le_struct, u32 len)\n * function will return NULL on failure, and a pointer to the start\n * of the nested attributes on success.\n **/\n-u32 *fm10k_tlv_attr_nest_start(u32 *msg, u16 attr_id)\n+static u32 *fm10k_tlv_attr_nest_start(u32 *msg, u16 attr_id)\n {\n \tu32 *attr;\n \n@@ -413,7 +413,7 @@ u32 *fm10k_tlv_attr_nest_start(u32 *msg, u16 attr_id)\n * the case of a nest within the nest this would be the outer nest pointer.\n * This function will return success provided all pointers are valid.\n **/\n-s32 fm10k_tlv_attr_nest_stop(u32 *msg)\n+static s32 fm10k_tlv_attr_nest_stop(u32 *msg)\n {\n \tu32 *attr;\n \tu32 len;\n@@ -522,8 +522,8 @@ STATIC s32 fm10k_tlv_attr_validate(u32 *attr,\n * FM10K_NOT_IMPLEMENTED for any attribute that is outside of the array\n * and 0 on success.\n **/\n-s32 fm10k_tlv_attr_parse(u32 *attr, u32 **results,\n-\t\t\t const struct fm10k_tlv_attr *tlv_attr)\n+static s32 fm10k_tlv_attr_parse(u32 *attr, u32 **results,\n+\t\t\t\tconst struct fm10k_tlv_attr *tlv_attr)\n {\n \tu32 i, attr_id, offset = 0;\n \ts32 err = 0;\ndiff --git a/drivers/net/fm10k/base/fm10k_tlv.h b/drivers/net/fm10k/base/fm10k_tlv.h\nindex ad97236..a297bb8 100644\n--- a/drivers/net/fm10k/base/fm10k_tlv.h\n+++ b/drivers/net/fm10k/base/fm10k_tlv.h\n@@ -119,8 +119,6 @@ struct fm10k_msg_data {\n #define FM10K_MSG_HANDLER(id, attr, func) { id, attr, func }\n \n s32 fm10k_tlv_msg_init(u32 *, u16);\n-s32 fm10k_tlv_attr_put_null_string(u32 *, u16, const unsigned char *);\n-s32 fm10k_tlv_attr_get_null_string(u32 *, unsigned char *);\n s32 fm10k_tlv_attr_put_mac_vlan(u32 *, u16, const u8 *, u16);\n s32 fm10k_tlv_attr_get_mac_vlan(u32 *, u8 *, u16 *);\n s32 fm10k_tlv_attr_put_bool(u32 *, u16);\n@@ -160,9 +158,6 @@ s32 fm10k_tlv_attr_get_value(u32 *, void *, u32);\n \t\tfm10k_tlv_attr_get_value(attr, ptr, sizeof(s64))\n s32 fm10k_tlv_attr_put_le_struct(u32 *, u16, const void *, u32);\n s32 fm10k_tlv_attr_get_le_struct(u32 *, void *, u32);\n-u32 *fm10k_tlv_attr_nest_start(u32 *, u16);\n-s32 fm10k_tlv_attr_nest_stop(u32 *);\n-s32 fm10k_tlv_attr_parse(u32 *, u32 **, const struct fm10k_tlv_attr *);\n s32 fm10k_tlv_msg_parse(struct fm10k_hw *, u32 *, struct fm10k_mbx_info *,\n \t\t\tconst struct fm10k_msg_data *);\n s32 fm10k_tlv_msg_error(struct fm10k_hw *hw, u32 **results,\ndiff --git a/drivers/net/fm10k/base/fm10k_vf.c b/drivers/net/fm10k/base/fm10k_vf.c\nindex a46b488..7822ab6 100644\n--- a/drivers/net/fm10k/base/fm10k_vf.c\n+++ b/drivers/net/fm10k/base/fm10k_vf.c\n@@ -414,8 +414,6 @@ const struct fm10k_tlv_attr fm10k_lport_state_msg_attr[] = {\n \tFM10K_TLV_ATTR_LAST\n };\n \n-extern const struct fm10k_tlv_attr fm10k_1588_msg_attr[];\n-\n /**\n * fm10k_msg_lport_state_vf - Message handler for lport_state message from PF\n * @hw: Pointer to hardware structure\n", "prefixes": [ "dpdk-dev", "v3", "03/18" ] }