Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/108568/?format=api
{ "id": 108568, "url": "http://patchwork.dpdk.org/api/patches/108568/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20220307102556.1011130-1-haiyue.wang@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220307102556.1011130-1-haiyue.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220307102556.1011130-1-haiyue.wang@intel.com", "date": "2022-03-07T10:25:56", "name": "[v3] graph: remove the useless duplicate name check", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d44a5ea999aaff978c274ea29d0e714f600bd58e", "submitter": { "id": 1044, "url": "http://patchwork.dpdk.org/api/people/1044/?format=api", "name": "Wang, Haiyue", "email": "haiyue.wang@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20220307102556.1011130-1-haiyue.wang@intel.com/mbox/", "series": [ { "id": 22045, "url": "http://patchwork.dpdk.org/api/series/22045/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=22045", "date": "2022-03-07T10:25:56", "name": "[v3] graph: remove the useless duplicate name check", "version": 3, "mbox": "http://patchwork.dpdk.org/series/22045/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/108568/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/108568/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DA0CCA0093;\n\tMon, 7 Mar 2022 12:00:21 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BE49140688;\n\tMon, 7 Mar 2022 12:00:21 +0100 (CET)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by mails.dpdk.org (Postfix) with ESMTP id 7A8064014E\n for <dev@dpdk.org>; Mon, 7 Mar 2022 12:00:19 +0100 (CET)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 07 Mar 2022 03:00:18 -0800", "from npg-dpdk-haiyue-2.sh.intel.com ([10.67.118.240])\n by orsmga006.jf.intel.com with ESMTP; 07 Mar 2022 03:00:16 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1646650819; x=1678186819;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=kVxHU87D+y10urVuzSR9pPN9vWgAbIu6ZQbtU9hMWbA=;\n b=durc2xX8QSuVQnmsoiaFttqT8+4TIxpG3UmPskQiAC4h4uBswk61s3ej\n J+pbMAn3sxZUmcAETO7FClaOAeaHjdgu83YpdK8Km1Zq0tJXX2vpd12GD\n aWN9IvprNty9aC/9JGR9TWruj8sJHJcArKMurUoFKlha8hubHaEMSXg/L\n EFfYALQrupOyMISbN5XfSHEcjg24rhc59h/2Bc80Es4ZqzgnV1xMjKg+E\n Y802LpIN4/mnOsoBSDjhireSBuXYgViez99Cf66ood0t49cwYN/aV3da6\n lV1yecu039DVOHyMjRr3eYN15VuBhEnI2/RzlGL6yB6OhU7vlZdiC2LP6 w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10278\"; a=\"254555254\"", "E=Sophos;i=\"5.90,162,1643702400\"; d=\"scan'208\";a=\"254555254\"", "E=Sophos;i=\"5.90,161,1643702400\"; d=\"scan'208\";a=\"512641480\"" ], "X-ExtLoop1": "1", "From": "Haiyue Wang <haiyue.wang@intel.com>", "To": "dev@dpdk.org", "Cc": "Haiyue Wang <haiyue.wang@intel.com>, Jerin Jacob <jerinj@marvell.com>,\n Kiran Kumar K <kirankumark@marvell.com>,\n Nithin Dabilpuram <ndabilpuram@marvell.com>", "Subject": "[PATCH v3] graph: remove the useless duplicate name check", "Date": "Mon, 7 Mar 2022 18:25:56 +0800", "Message-Id": "<20220307102556.1011130-1-haiyue.wang@intel.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<0220307064318.1002855-1-haiyue.wang@intel.com>", "References": "<0220307064318.1002855-1-haiyue.wang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The node clone API parameter 'name' is the new node's postfix name, not\nthe final node name, so it makes no sense to check it. And the new name\nwill be checked duplicate when calling API '__rte_node_register'.\n\nAnd update the test case to call clone API twice to check the real name\nduplicate.\n\nSigned-off-by: Haiyue Wang <haiyue.wang@intel.com>\n---\nv3: No need to define another node id var.\nv2: update the test case.\n---\n app/test/test_graph.c | 6 ++++++\n lib/graph/node.c | 4 ----\n 2 files changed, 6 insertions(+), 4 deletions(-)", "diff": "diff --git a/app/test/test_graph.c b/app/test/test_graph.c\nindex 35e1a95b89..1a2d1e6fab 100644\n--- a/app/test/test_graph.c\n+++ b/app/test/test_graph.c\n@@ -550,6 +550,12 @@ test_node_clone(void)\n \tnode_id = rte_node_from_name(\"test_node00\");\n \ttm->test_node[0].idx = node_id;\n \n+\tdummy_id = rte_node_clone(node_id, \"test_node00\");\n+\tif (rte_node_is_invalid(dummy_id)) {\n+\t\tprintf(\"Got invalid id when clone, Expecting fail\\n\");\n+\t\treturn -1;\n+\t}\n+\n \t/* Clone with same name, should fail */\n \tdummy_id = rte_node_clone(node_id, \"test_node00\");\n \tif (!rte_node_is_invalid(dummy_id)) {\ndiff --git a/lib/graph/node.c b/lib/graph/node.c\nindex 79230035a2..ae6eadb260 100644\n--- a/lib/graph/node.c\n+++ b/lib/graph/node.c\n@@ -150,10 +150,6 @@ node_clone(struct node *node, const char *name)\n \t\tgoto fail;\n \t}\n \n-\t/* Check for duplicate name */\n-\tif (node_has_duplicate_entry(name))\n-\t\tgoto fail;\n-\n \treg = calloc(1, sizeof(*reg) + (sizeof(char *) * node->nb_edges));\n \tif (reg == NULL) {\n \t\trte_errno = ENOMEM;\n", "prefixes": [ "v3" ] }