Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/108703/?format=api
{ "id": 108703, "url": "http://patchwork.dpdk.org/api/patches/108703/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20220314014414.251869-1-yajunw@nvidia.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220314014414.251869-1-yajunw@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220314014414.251869-1-yajunw@nvidia.com", "date": "2022-03-14T01:44:12", "name": "vdpa/mlx5: workaround var offset within page", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c59402eea11316e9a558e69a9e7183e5aea01a3b", "submitter": { "id": 2517, "url": "http://patchwork.dpdk.org/api/people/2517/?format=api", "name": "Yajun Wu", "email": "yajunw@nvidia.com" }, "delegate": { "id": 2642, "url": "http://patchwork.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20220314014414.251869-1-yajunw@nvidia.com/mbox/", "series": [ { "id": 22132, "url": "http://patchwork.dpdk.org/api/series/22132/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=22132", "date": "2022-03-14T01:44:12", "name": "vdpa/mlx5: workaround var offset within page", "version": 1, "mbox": "http://patchwork.dpdk.org/series/22132/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/108703/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/108703/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1F114A00BE;\n\tMon, 14 Mar 2022 02:46:41 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A826840698;\n\tMon, 14 Mar 2022 02:46:40 +0100 (CET)", "from NAM11-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam11on2071.outbound.protection.outlook.com [40.107.236.71])\n by mails.dpdk.org (Postfix) with ESMTP id 278CA40141;\n Mon, 14 Mar 2022 02:46:39 +0100 (CET)", "from BN9PR03CA0589.namprd03.prod.outlook.com (2603:10b6:408:10d::24)\n by BL1PR12MB5078.namprd12.prod.outlook.com (2603:10b6:208:313::11)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.24; Mon, 14 Mar\n 2022 01:46:27 +0000", "from BN8NAM11FT056.eop-nam11.prod.protection.outlook.com\n (2603:10b6:408:10d:cafe::26) by BN9PR03CA0589.outlook.office365.com\n (2603:10b6:408:10d::24) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.26 via Frontend\n Transport; Mon, 14 Mar 2022 01:46:27 +0000", "from mail.nvidia.com (12.22.5.235) by\n BN8NAM11FT056.mail.protection.outlook.com (10.13.177.26) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.5061.22 via Frontend Transport; Mon, 14 Mar 2022 01:46:26 +0000", "from rnnvmail201.nvidia.com (10.129.68.8) by DRHQMAIL107.nvidia.com\n (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1497.32;\n Mon, 14 Mar 2022 01:46:16 +0000", "from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com\n (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Sun, 13 Mar\n 2022 18:46:13 -0700" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=RgBPsYyyyvKiOPngtE0GdBRlLbf58AXeDgNqlczRG78G8teL6hqaLweK4T+IiWScRAnOyAanwX0+nYxgu4EwRh3xzD7tlDPXfl730h4vWpMyM0q1Hl4cC62XVGCD9Q5m14twMYVYuR85mqsHaG1J2Be5bwLTQNbPuJWIblQk251EEwNQloruxYrkBloJC/POgBEgsEI4U7JbpYnJAmMb03NS84mlyO/rgCJCY2u5sO6Qy0imzdo7XXUtBjSruFE+2Z6JDtoz8pvAelQh/dGiAiimrf9T8BczDYPAs7lDKHqUrYxVJREHwU69MRAMKLF9Z19AE6RDKL8ZKOe5pyMULA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=Ay9CqBR9H5nblGQgMBHhdIo8zuCDey40eCVXZzu1gQ4=;\n b=GkERg6DtE7v/UEsCglx2hXfO60GTqcLLjuArCHiR3QQnzhZO3+kXmcL3sb/he8adZDBUePfHcbit9XyQ09WNMNE2gMsX7iVKDYE6fvKW0PE+ckAd2HIlG3tpWKmg+vzUqgYmFFE5NjFEHWvRpbzgz5ruegGYVI/HPGNulFVlUZVQlPPkiJJU84hi6otSs3nsFfahDw/UlyQuXX3+X0bC5Zer4xjBNXgJp3BxmfY62owL4pfn9SQVcQvOeazvi354qiDcgFhTkEDgPv688Hc/2wkrcz6ZJ4Xy96BstD3NgxxGs7Rre6xKVlcAnCf07PddwhU+mawFOc3j+S2WY4VOqg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 12.22.5.235) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=Ay9CqBR9H5nblGQgMBHhdIo8zuCDey40eCVXZzu1gQ4=;\n b=sVG5R8YDO2LvzTSg9LtPXEut6x2w2HAixmoThkCCdBhqJOTUqtPgT5v1ALEkeQ5Ox79eIzJ+wlrnc7358qdnqYpQpyR70OD54opu7JsmVY+pTxQlBLR6eQwj/yZcX7W48a+2uPlWjjz5BufH3xaRHJ2ytd5KU3fpAt57UgSmENPWwa06B0CbTYdiwFGC7llCG555JxfuYa8mDuervrRdiSQ5f++gCLD0R+6i0Fka6xsa1zseYe3m537gzN6Yluw7VJPqoBdjugTzGtLtRZUu0t9hN+ly7aIfV760KYnzL+/kcgm3VCcZUi95MMrRHTRXKJEhYpP9aCBgNHclkYt6+A==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 12.22.5.235)\n smtp.mailfrom=nvidia.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 12.22.5.235 as permitted sender) receiver=protection.outlook.com;\n client-ip=12.22.5.235; helo=mail.nvidia.com;", "From": "Yajun Wu <yajunw@nvidia.com>", "To": "<orika@nvidia.com>, <viacheslavo@nvidia.com>, <matan@nvidia.com>,\n <shahafs@nvidia.com>, Maxime Coquelin <maxime.coquelin@redhat.com>", "CC": "<dev@dpdk.org>, <thomas@monjalon.net>, <rasland@nvidia.com>,\n <roniba@nvidia.com>, <stable@dpdk.org>", "Subject": "[PATCH] vdpa/mlx5: workaround var offset within page", "Date": "Mon, 14 Mar 2022 03:44:12 +0200", "Message-ID": "<20220314014414.251869-1-yajunw@nvidia.com>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.126.230.35]", "X-ClientProxiedBy": "rnnvmail201.nvidia.com (10.129.68.8) To\n rnnvmail201.nvidia.com (10.129.68.8)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "70b6b3f1-c453-4f42-c0a4-08da055c7436", "X-MS-TrafficTypeDiagnostic": "BL1PR12MB5078:EE_", "X-LD-Processed": "43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr", "X-Microsoft-Antispam-PRVS": "\n <BL1PR12MB50788E23906451627A161D13B60F9@BL1PR12MB5078.namprd12.prod.outlook.com>", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n IzAA/MymrQe4nUMTqlQ+WrSiMGtiQ6zH/vR8EoekWTGtm2Ia61AhRUNSTF7V9mvWsQfT8h4OSPYVBD57G5eRin8bmbWFGGC+8RqBwHixygdszaAYYbtRos+tjBEerGC5mjZz9QKrSVrA82XsrYGCcxiQVaY/qcJqHjhpa+1ifb0twKniVy6elDlS/58MRvby5Vf4n+b5wn+3k8/C7A1p4zQyOJnItUbwJPBI5yjFXDO3JUV3SEMHNeDtynHb+f73T8foxHWZqAZ4t3mMOZodgvWISWXkMQ7ZVh0of322MiFJXK53uWBNbD6677qjl89w0jIu08AOZOoeerGqxSSQhkTYuqlAnxo4cRD673wpR0oRvFYewoZrN9fcJfS7U6ZDeBG/PYfpeeR4ef08GwAMxGF/zNhQI20b3o7AIAUyD+UKZrhZTf0KkwCYBRDWSieIqYPEXPypz9FOZpzInlRreZYcUibeZWoe59Xr7KW/EMmm9WYWu1tasQLsAP2IDiZ400VyNNC6vzGYBYHHiJ+JFU0awHHl2O5UXt0lOnoKENuAK8BUiTg6HfDaA6anYWFcAYWbnr6i503tZhO+tzkNlhJA5HnM4QP7LWGcibVHJQRedS3lu7xa/jJ7r6E+fw5swkfxRVIxYmKOqPmcge+RAq/3VixxZPyoQS3PJCkPdvoKI+lERwlDU/uF5VpT/Liq2tzXY+5jR7wlwHhY3o2TxQ==", "X-Forefront-Antispam-Report": "CIP:12.22.5.235; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:mail.nvidia.com; PTR:InfoNoRecords; CAT:NONE;\n SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(83380400001)(316002)(82310400004)(2906002)(86362001)(55016003)(36860700001)(40460700003)(47076005)(4326008)(8676002)(70206006)(70586007)(1076003)(7696005)(508600001)(8936002)(2616005)(356005)(110136005)(54906003)(36756003)(6286002)(336012)(426003)(5660300002)(16526019)(26005)(186003)(81166007)(36900700001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "14 Mar 2022 01:46:26.9503 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 70b6b3f1-c453-4f42-c0a4-08da055c7436", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[12.22.5.235];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n BN8NAM11FT056.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BL1PR12MB5078", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "vDPA driver first uses kernel driver to allocate doorbell(VAR) area for\neach device. Then uses var->mmap_off and var->length to mmap uverbs device\nfile as doorbell userspace virtual address.\n\nCurrent kernel driver provides var->mmap_off equal to page start of VAR.\nIt's fine with x86 4K page server, because VAR physical address is only 4K\naligned thus locate in 4K page start.\n\nBut with aarch64 64K page server, the actual VAR physical address has\noffset within page(not locate in 64K page start). So vDPA driver need add\nthis within page offset(caps.doorbell_bar_offset) to get right VAR virtual\naddress.\n\nFixes: 62c813706e4 (\"vdpa/mlx5: map doorbell\")\nCc: stable@dpdk.org\n\nSigned-off-by: Yajun Wu <yajunw@nvidia.com>\nAcked-by: Matan Azrad <matan@nvidia.com>\n---\n drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 10 +++++++++-\n 1 file changed, 9 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c b/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c\nindex 3416797d28..0748710a76 100644\n--- a/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c\n+++ b/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c\n@@ -9,6 +9,7 @@\n #include <rte_malloc.h>\n #include <rte_errno.h>\n #include <rte_io.h>\n+#include <rte_eal_paging.h>\n \n #include <mlx5_common.h>\n \n@@ -123,7 +124,10 @@ mlx5_vdpa_virtqs_release(struct mlx5_vdpa_priv *priv)\n \t\tpriv->td = NULL;\n \t}\n \tif (priv->virtq_db_addr) {\n-\t\tclaim_zero(munmap(priv->virtq_db_addr, priv->var->length));\n+\t\t/* Mask out the within page offset for ummap. */\n+\t\tclaim_zero(munmap((void *)((uint64_t)priv->virtq_db_addr &\n+\t\t\t~(rte_mem_page_size() - 1ULL)),\n+\t\t\tpriv->var->length));\n \t\tpriv->virtq_db_addr = NULL;\n \t}\n \tpriv->features = 0;\n@@ -486,6 +490,10 @@ mlx5_vdpa_virtqs_prepare(struct mlx5_vdpa_priv *priv)\n \t\tpriv->virtq_db_addr = NULL;\n \t\tgoto error;\n \t} else {\n+\t\t/* Add within page offset for 64K page system. */\n+\t\tpriv->virtq_db_addr = (char *)priv->virtq_db_addr +\n+\t\t\t((rte_mem_page_size() - 1) &\n+\t\t\tpriv->caps.doorbell_bar_offset);\n \t\tDRV_LOG(DEBUG, \"VAR address of doorbell mapping is %p.\",\n \t\t\tpriv->virtq_db_addr);\n \t}\n", "prefixes": [] }