Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/109812/?format=api
{ "id": 109812, "url": "http://patchwork.dpdk.org/api/patches/109812/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20220419055921.10566-7-ndabilpuram@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220419055921.10566-7-ndabilpuram@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220419055921.10566-7-ndabilpuram@marvell.com", "date": "2022-04-19T05:59:04", "name": "[07/24] common/cnxk: fix issues in soft expiry disable path", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "94835e39612bfe2e11a3f172b837f4a013be769e", "submitter": { "id": 1202, "url": "http://patchwork.dpdk.org/api/people/1202/?format=api", "name": "Nithin Dabilpuram", "email": "ndabilpuram@marvell.com" }, "delegate": { "id": 310, "url": "http://patchwork.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20220419055921.10566-7-ndabilpuram@marvell.com/mbox/", "series": [ { "id": 22546, "url": "http://patchwork.dpdk.org/api/series/22546/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=22546", "date": "2022-04-19T05:58:58", "name": "[01/24] common/cnxk: add multi channel support for SDP send queues", "version": 1, "mbox": "http://patchwork.dpdk.org/series/22546/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/109812/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/109812/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8368FA00C3;\n\tTue, 19 Apr 2022 08:00:42 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E9D1E427F9;\n\tTue, 19 Apr 2022 08:00:21 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 7537941156\n for <dev@dpdk.org>; Tue, 19 Apr 2022 08:00:20 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id\n 23INEdMU010013\n for <dev@dpdk.org>; Mon, 18 Apr 2022 23:00:19 -0700", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3ffwap25vx-6\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Mon, 18 Apr 2022 23:00:19 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Mon, 18 Apr 2022 23:00:13 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Mon, 18 Apr 2022 23:00:13 -0700", "from hyd1588t430.marvell.com (unknown [10.29.52.204])\n by maili.marvell.com (Postfix) with ESMTP id 93D445B6947;\n Mon, 18 Apr 2022 23:00:11 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-type; s=pfpt0220; bh=f+W9lDyIhR9jYvUKNeM5/uDSId4g/gC8FR/lcUagDsA=;\n b=f2c5O8jcLYUaojIsdXgG9jTLUnD9q91MAi3l9dK6lrGCSYD7Ioc3STfuoa1J4sojiJYv\n 5mWbjIOysQIGZ7FsB+lY5yNKCbCwaMFXPs6knPvNLoFiB2A47z2+ep+Qe6TlwY8/bIyk\n PLObxx41e3uHtChs1xFNyP0+E2GDVSP7VN2NC2+V57Zh+rIQ9Po7tAjPGrHYzX9We1bk\n eq4cl7gxnOgbAh9/qPF2knPNfFiXAmH5yubw/yk4WlFU6b24kWgTIXLd617MMEHAGqAR\n BYJ8JU4041GPrdWX1Y9afvo4UJzIH5Q3+vsYCnBbx/oc0yWPqNsOseNKINSr4Hh0//Yj RA==", "From": "Nithin Dabilpuram <ndabilpuram@marvell.com>", "To": "<jerinj@marvell.com>, Nithin Dabilpuram <ndabilpuram@marvell.com>, \"Kiran\n Kumar K\" <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>,\n Satha Rao <skoteshwar@marvell.com>", "CC": "<dev@dpdk.org>", "Subject": "[PATCH 07/24] common/cnxk: fix issues in soft expiry disable path", "Date": "Tue, 19 Apr 2022 11:29:04 +0530", "Message-ID": "<20220419055921.10566-7-ndabilpuram@marvell.com>", "X-Mailer": "git-send-email 2.8.4", "In-Reply-To": "<20220419055921.10566-1-ndabilpuram@marvell.com>", "References": "<20220419055921.10566-1-ndabilpuram@marvell.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Proofpoint-GUID": "O1dVBQuTGTPbURpRFdVHemS9fJblEmbG", "X-Proofpoint-ORIG-GUID": "O1dVBQuTGTPbURpRFdVHemS9fJblEmbG", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514\n definitions=2022-04-19_02,2022-04-15_01,2022-02-23_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Fix issues in mode where soft expiry is disabled in RoC.\nWhen soft expiry support is not enabled in inline device,\nmemory is not allocated for the ring base array and should\nnot be accessed.\n\nFixes: bea5d990a93b (\"net/cnxk: support outbound soft expiry notification\")\nSigned-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>\n---\n drivers/common/cnxk/roc_nix_inl.c | 9 +++++----\n drivers/common/cnxk/roc_nix_inl_dev.c | 5 +++--\n drivers/common/cnxk/roc_nix_inl_priv.h | 1 +\n 3 files changed, 9 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/common/cnxk/roc_nix_inl.c b/drivers/common/cnxk/roc_nix_inl.c\nindex bfb33b1..6c72248 100644\n--- a/drivers/common/cnxk/roc_nix_inl.c\n+++ b/drivers/common/cnxk/roc_nix_inl.c\n@@ -208,7 +208,7 @@ roc_nix_inl_inb_sa_sz(struct roc_nix *roc_nix, bool inl_dev_sa)\n uintptr_t\n roc_nix_inl_inb_sa_get(struct roc_nix *roc_nix, bool inb_inl_dev, uint32_t spi)\n {\n-\tuint32_t max_spi, min_spi, mask;\n+\tuint32_t max_spi = 0, min_spi = 0, mask;\n \tuintptr_t sa_base;\n \tuint64_t sz;\n \n@@ -461,7 +461,7 @@ roc_nix_inl_outb_init(struct roc_nix *roc_nix)\n \tnix->outb_se_ring_base =\n \t\troc_nix->port_id * ROC_NIX_SOFT_EXP_PER_PORT_MAX_RINGS;\n \n-\tif (inl_dev == NULL) {\n+\tif (inl_dev == NULL || !inl_dev->set_soft_exp_poll) {\n \t\tnix->outb_se_ring_cnt = 0;\n \t\treturn 0;\n \t}\n@@ -537,11 +537,12 @@ roc_nix_inl_outb_fini(struct roc_nix *roc_nix)\n \tplt_free(nix->outb_sa_base);\n \tnix->outb_sa_base = NULL;\n \n-\tif (idev && idev->nix_inl_dev) {\n+\tif (idev && idev->nix_inl_dev && nix->outb_se_ring_cnt) {\n \t\tinl_dev = idev->nix_inl_dev;\n \t\tring_base = inl_dev->sa_soft_exp_ring;\n+\t\tring_base += nix->outb_se_ring_base;\n \n-\t\tfor (i = 0; i < ROC_NIX_INL_MAX_SOFT_EXP_RNGS; i++) {\n+\t\tfor (i = 0; i < nix->outb_se_ring_cnt; i++) {\n \t\t\tif (ring_base[i])\n \t\t\t\tplt_free(PLT_PTR_CAST(ring_base[i]));\n \t\t}\ndiff --git a/drivers/common/cnxk/roc_nix_inl_dev.c b/drivers/common/cnxk/roc_nix_inl_dev.c\nindex 51f1f68..5e61a42 100644\n--- a/drivers/common/cnxk/roc_nix_inl_dev.c\n+++ b/drivers/common/cnxk/roc_nix_inl_dev.c\n@@ -814,6 +814,7 @@ roc_nix_inl_dev_init(struct roc_nix_inl_dev *roc_inl_dev)\n \tinl_dev->wqe_skip = roc_inl_dev->wqe_skip;\n \tinl_dev->spb_drop_pc = NIX_AURA_DROP_PC_DFLT;\n \tinl_dev->lpb_drop_pc = NIX_AURA_DROP_PC_DFLT;\n+\tinl_dev->set_soft_exp_poll = roc_inl_dev->set_soft_exp_poll;\n \n \tif (roc_inl_dev->spb_drop_pc)\n \t\tinl_dev->spb_drop_pc = roc_inl_dev->spb_drop_pc;\n@@ -849,7 +850,7 @@ roc_nix_inl_dev_init(struct roc_nix_inl_dev *roc_inl_dev)\n \tif (rc)\n \t\tgoto sso_release;\n \n-\tif (roc_inl_dev->set_soft_exp_poll) {\n+\tif (inl_dev->set_soft_exp_poll) {\n \t\trc = nix_inl_outb_poll_thread_setup(inl_dev);\n \t\tif (rc)\n \t\t\tgoto cpt_release;\n@@ -898,7 +899,7 @@ roc_nix_inl_dev_fini(struct roc_nix_inl_dev *roc_inl_dev)\n \tinl_dev = idev->nix_inl_dev;\n \tpci_dev = inl_dev->pci_dev;\n \n-\tif (roc_inl_dev->set_soft_exp_poll) {\n+\tif (inl_dev->set_soft_exp_poll) {\n \t\tsoft_exp_poll_thread_exit = true;\n \t\tpthread_join(inl_dev->soft_exp_poll_thread, NULL);\n \t\tplt_bitmap_free(inl_dev->soft_exp_ring_bmap);\ndiff --git a/drivers/common/cnxk/roc_nix_inl_priv.h b/drivers/common/cnxk/roc_nix_inl_priv.h\nindex f9646a3..1ab8470 100644\n--- a/drivers/common/cnxk/roc_nix_inl_priv.h\n+++ b/drivers/common/cnxk/roc_nix_inl_priv.h\n@@ -59,6 +59,7 @@ struct nix_inl_dev {\n \tpthread_t soft_exp_poll_thread;\n \tuint32_t soft_exp_poll_freq;\n \tuint64_t *sa_soft_exp_ring;\n+\tbool set_soft_exp_poll;\n \n \t/* Soft expiry ring bitmap */\n \tstruct plt_bitmap *soft_exp_ring_bmap;\n", "prefixes": [ "07/24" ] }