Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/120846/?format=api
{ "id": 120846, "url": "http://patchwork.dpdk.org/api/patches/120846/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20221213182730.97065-4-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221213182730.97065-4-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221213182730.97065-4-bruce.richardson@intel.com", "date": "2022-12-13T18:27:26", "name": "[RFC,3/7] telemetry: remove RTE prefix from internal enum values", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "617061664d38ad48368406d0589384b327022bae", "submitter": { "id": 20, "url": "http://patchwork.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20221213182730.97065-4-bruce.richardson@intel.com/mbox/", "series": [ { "id": 26112, "url": "http://patchwork.dpdk.org/api/series/26112/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=26112", "date": "2022-12-13T18:27:23", "name": "Standardize telemetry int types", "version": 1, "mbox": "http://patchwork.dpdk.org/series/26112/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/120846/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/120846/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0EE97A0540;\n\tTue, 13 Dec 2022 19:28:10 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0216242D1F;\n\tTue, 13 Dec 2022 19:27:57 +0100 (CET)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by mails.dpdk.org (Postfix) with ESMTP id 3F3DD42C29\n for <dev@dpdk.org>; Tue, 13 Dec 2022 19:27:53 +0100 (CET)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Dec 2022 10:27:51 -0800", "from silpixa00401459.ir.intel.com (HELO\n silpixa00401459.ger.corp.intel.com) ([10.237.223.55])\n by orsmga006.jf.intel.com with ESMTP; 13 Dec 2022 10:27:50 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1670956073; x=1702492073;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=3aUSgccpUEqr1kd/O3/T4U+4fImPSyAuW9KTcQcA574=;\n b=Egf1yzgdG32K/AHg3DU+0aBesgnpdlRiB697i1kbpF92lINRt4MFxL3p\n hNA7KPmNiZu/ZTvnr6fExdKoGwreCAAnHt8oGqLeP0CmauXWepm7B+hTJ\n ql4uDC7KgVLUM5IiXTI1wRtTm1gZDaZpcxN3pf/UQvgo4tsBfeEMvwjYw\n /sTU8CogrzLmakL8RyRjwlObVBFXkIS7WsCClTltxj/PJf2yeRwfnzDOk\n NOQatowU5qbAlbRavLgbRABoRn+KepCvcSMRxwCFEKsoYdhEcJo1RFwQA\n Ly6Uk+DmIQnOzNk27dqGncDZI7ssZ/4vGcQ9snaHiAjvhVcl1pIApqgV4 Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10560\"; a=\"382506976\"", "E=Sophos;i=\"5.96,242,1665471600\"; d=\"scan'208\";a=\"382506976\"", "E=McAfee;i=\"6500,9779,10560\"; a=\"626445201\"", "E=Sophos;i=\"5.96,242,1665471600\"; d=\"scan'208\";a=\"626445201\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>", "Subject": "[RFC PATCH 3/7] telemetry: remove RTE prefix from internal enum\n values", "Date": "Tue, 13 Dec 2022 18:27:26 +0000", "Message-Id": "<20221213182730.97065-4-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20221213182730.97065-1-bruce.richardson@intel.com>", "References": "<20221213182730.97065-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "To better distinguish which values are public and which are internal\nremove the \"RTE_\" prefix off the internal enum defining the container\ntypes.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n lib/ethdev/sff_telemetry.c | 2 +-\n lib/telemetry/telemetry.c | 36 +++++++++++++++---------------\n lib/telemetry/telemetry_data.c | 40 +++++++++++++++++-----------------\n lib/telemetry/telemetry_data.h | 14 ++++++------\n 4 files changed, 46 insertions(+), 46 deletions(-)", "diff": "diff --git a/lib/ethdev/sff_telemetry.c b/lib/ethdev/sff_telemetry.c\nindex ca6d196560..5923350424 100644\n--- a/lib/ethdev/sff_telemetry.c\n+++ b/lib/ethdev/sff_telemetry.c\n@@ -96,7 +96,7 @@ ssf_add_dict_string(struct rte_tel_data *d, const char *name_str, const char *va\n {\n \tstruct tel_dict_entry *e = &d->data.dict[d->data_len];\n \n-\tif (d->type != RTE_TEL_DICT)\n+\tif (d->type != TEL_DICT)\n \t\treturn;\n \tif (d->data_len >= RTE_TEL_MAX_DICT_ENTRIES) {\n \t\tRTE_ETHDEV_LOG(ERR, \"data_len has exceeded the maximum number of inserts\\n\");\ndiff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telemetry.c\nindex fd8186383f..89bdde8422 100644\n--- a/lib/telemetry/telemetry.c\n+++ b/lib/telemetry/telemetry.c\n@@ -167,27 +167,27 @@ container_to_json(const struct rte_tel_data *d, char *out_buf, size_t buf_len)\n \tsize_t used = 0;\n \tunsigned int i;\n \n-\tif (d->type != RTE_TEL_DICT && d->type != RTE_TEL_ARRAY_UINT &&\n-\t\td->type != RTE_TEL_ARRAY_INT && d->type != RTE_TEL_ARRAY_STRING)\n+\tif (d->type != TEL_DICT && d->type != TEL_ARRAY_UINT &&\n+\t\td->type != TEL_ARRAY_INT && d->type != TEL_ARRAY_STRING)\n \t\treturn snprintf(out_buf, buf_len, \"null\");\n \n \tused = rte_tel_json_empty_array(out_buf, buf_len, 0);\n-\tif (d->type == RTE_TEL_ARRAY_UINT)\n+\tif (d->type == TEL_ARRAY_UINT)\n \t\tfor (i = 0; i < d->data_len; i++)\n \t\t\tused = rte_tel_json_add_array_u64(out_buf,\n \t\t\t\tbuf_len, used,\n \t\t\t\td->data.array[i].uval);\n-\tif (d->type == RTE_TEL_ARRAY_INT)\n+\tif (d->type == TEL_ARRAY_INT)\n \t\tfor (i = 0; i < d->data_len; i++)\n \t\t\tused = rte_tel_json_add_array_int(out_buf,\n \t\t\t\tbuf_len, used,\n \t\t\t\td->data.array[i].ival);\n-\tif (d->type == RTE_TEL_ARRAY_STRING)\n+\tif (d->type == TEL_ARRAY_STRING)\n \t\tfor (i = 0; i < d->data_len; i++)\n \t\t\tused = rte_tel_json_add_array_string(out_buf,\n \t\t\t\tbuf_len, used,\n \t\t\t\td->data.array[i].sval);\n-\tif (d->type == RTE_TEL_DICT)\n+\tif (d->type == TEL_DICT)\n \t\tfor (i = 0; i < d->data_len; i++) {\n \t\t\tconst struct tel_dict_entry *v = &d->data.dict[i];\n \t\t\tswitch (v->type) {\n@@ -245,15 +245,15 @@ output_json(const char *cmd, const struct rte_tel_data *d, int s)\n \tbuf_len = sizeof(out_buf) - prefix_used - 1; /* space for '}' */\n \n \tswitch (d->type) {\n-\tcase RTE_TEL_NULL:\n+\tcase TEL_NULL:\n \t\tused = strlcpy(cb_data_buf, \"null\", buf_len);\n \t\tbreak;\n \n-\tcase RTE_TEL_STRING:\n+\tcase TEL_STRING:\n \t\tused = rte_tel_json_str(cb_data_buf, buf_len, 0, d->data.str);\n \t\tbreak;\n \n-\tcase RTE_TEL_DICT:\n+\tcase TEL_DICT:\n \t\tused = rte_tel_json_empty_obj(cb_data_buf, buf_len, 0);\n \t\tfor (i = 0; i < d->data_len; i++) {\n \t\t\tconst struct tel_dict_entry *v = &d->data.dict[i];\n@@ -291,26 +291,26 @@ output_json(const char *cmd, const struct rte_tel_data *d, int s)\n \t\t}\n \t\tbreak;\n \n-\tcase RTE_TEL_ARRAY_STRING:\n-\tcase RTE_TEL_ARRAY_INT:\n-\tcase RTE_TEL_ARRAY_UINT:\n-\tcase RTE_TEL_ARRAY_CONTAINER:\n+\tcase TEL_ARRAY_STRING:\n+\tcase TEL_ARRAY_INT:\n+\tcase TEL_ARRAY_UINT:\n+\tcase TEL_ARRAY_CONTAINER:\n \t\tused = rte_tel_json_empty_array(cb_data_buf, buf_len, 0);\n \t\tfor (i = 0; i < d->data_len; i++)\n-\t\t\tif (d->type == RTE_TEL_ARRAY_STRING)\n+\t\t\tif (d->type == TEL_ARRAY_STRING)\n \t\t\t\tused = rte_tel_json_add_array_string(\n \t\t\t\t\t\tcb_data_buf,\n \t\t\t\t\t\tbuf_len, used,\n \t\t\t\t\t\td->data.array[i].sval);\n-\t\t\telse if (d->type == RTE_TEL_ARRAY_INT)\n+\t\t\telse if (d->type == TEL_ARRAY_INT)\n \t\t\t\tused = rte_tel_json_add_array_int(cb_data_buf,\n \t\t\t\t\t\tbuf_len, used,\n \t\t\t\t\t\td->data.array[i].ival);\n-\t\t\telse if (d->type == RTE_TEL_ARRAY_UINT)\n+\t\t\telse if (d->type == TEL_ARRAY_UINT)\n \t\t\t\tused = rte_tel_json_add_array_u64(cb_data_buf,\n \t\t\t\t\t\tbuf_len, used,\n \t\t\t\t\t\td->data.array[i].uval);\n-\t\t\telse if (d->type == RTE_TEL_ARRAY_CONTAINER) {\n+\t\t\telse if (d->type == TEL_ARRAY_CONTAINER) {\n \t\t\t\tchar temp[buf_len];\n \t\t\t\tconst struct container *rec_data =\n \t\t\t\t\t\t&d->data.array[i].container;\n@@ -351,7 +351,7 @@ static int\n unknown_command(const char *cmd __rte_unused, const char *params __rte_unused,\n \t\tstruct rte_tel_data *d)\n {\n-\treturn d->type = RTE_TEL_NULL;\n+\treturn d->type = TEL_NULL;\n }\n \n static void *\ndiff --git a/lib/telemetry/telemetry_data.c b/lib/telemetry/telemetry_data.c\nindex 077b0c4a6f..d51724e1f5 100644\n--- a/lib/telemetry/telemetry_data.c\n+++ b/lib/telemetry/telemetry_data.c\n@@ -16,10 +16,10 @@ int\n rte_tel_data_start_array(struct rte_tel_data *d, enum rte_tel_value_type type)\n {\n \tenum tel_container_types array_types[] = {\n-\t\t\tRTE_TEL_ARRAY_STRING, /* RTE_TEL_STRING_VAL = 0 */\n-\t\t\tRTE_TEL_ARRAY_INT, /* RTE_TEL_INT_VAL = 1 */\n-\t\t\tRTE_TEL_ARRAY_UINT, /* RTE_TEL_UINT_VAL = 2 */\n-\t\t\tRTE_TEL_ARRAY_CONTAINER, /* RTE_TEL_CONTAINER = 3 */\n+\t\t\tTEL_ARRAY_STRING, /* RTE_TEL_STRING_VAL = 0 */\n+\t\t\tTEL_ARRAY_INT, /* RTE_TEL_INT_VAL = 1 */\n+\t\t\tTEL_ARRAY_UINT, /* RTE_TEL_UINT_VAL = 2 */\n+\t\t\tTEL_ARRAY_CONTAINER, /* RTE_TEL_CONTAINER = 3 */\n \t};\n \td->type = array_types[type];\n \td->data_len = 0;\n@@ -29,7 +29,7 @@ rte_tel_data_start_array(struct rte_tel_data *d, enum rte_tel_value_type type)\n int\n rte_tel_data_start_dict(struct rte_tel_data *d)\n {\n-\td->type = RTE_TEL_DICT;\n+\td->type = TEL_DICT;\n \td->data_len = 0;\n \treturn 0;\n }\n@@ -37,7 +37,7 @@ rte_tel_data_start_dict(struct rte_tel_data *d)\n int\n rte_tel_data_string(struct rte_tel_data *d, const char *str)\n {\n-\td->type = RTE_TEL_STRING;\n+\td->type = TEL_STRING;\n \td->data_len = strlcpy(d->data.str, str, sizeof(d->data.str));\n \tif (d->data_len >= RTE_TEL_MAX_SINGLE_STRING_LEN) {\n \t\td->data_len = RTE_TEL_MAX_SINGLE_STRING_LEN - 1;\n@@ -49,7 +49,7 @@ rte_tel_data_string(struct rte_tel_data *d, const char *str)\n int\n rte_tel_data_add_array_string(struct rte_tel_data *d, const char *str)\n {\n-\tif (d->type != RTE_TEL_ARRAY_STRING)\n+\tif (d->type != TEL_ARRAY_STRING)\n \t\treturn -EINVAL;\n \tif (d->data_len >= RTE_TEL_MAX_ARRAY_ENTRIES)\n \t\treturn -ENOSPC;\n@@ -61,7 +61,7 @@ rte_tel_data_add_array_string(struct rte_tel_data *d, const char *str)\n int\n rte_tel_data_add_array_int(struct rte_tel_data *d, int x)\n {\n-\tif (d->type != RTE_TEL_ARRAY_INT)\n+\tif (d->type != TEL_ARRAY_INT)\n \t\treturn -EINVAL;\n \tif (d->data_len >= RTE_TEL_MAX_ARRAY_ENTRIES)\n \t\treturn -ENOSPC;\n@@ -72,7 +72,7 @@ rte_tel_data_add_array_int(struct rte_tel_data *d, int x)\n int\n rte_tel_data_add_array_uint(struct rte_tel_data *d, uint64_t x)\n {\n-\tif (d->type != RTE_TEL_ARRAY_UINT)\n+\tif (d->type != TEL_ARRAY_UINT)\n \t\treturn -EINVAL;\n \tif (d->data_len >= RTE_TEL_MAX_ARRAY_ENTRIES)\n \t\treturn -ENOSPC;\n@@ -90,10 +90,10 @@ int\n rte_tel_data_add_array_container(struct rte_tel_data *d,\n \t\tstruct rte_tel_data *val, int keep)\n {\n-\tif (d->type != RTE_TEL_ARRAY_CONTAINER ||\n-\t\t\t(val->type != RTE_TEL_ARRAY_UINT\n-\t\t\t&& val->type != RTE_TEL_ARRAY_INT\n-\t\t\t&& val->type != RTE_TEL_ARRAY_STRING))\n+\tif (d->type != TEL_ARRAY_CONTAINER ||\n+\t\t\t(val->type != TEL_ARRAY_UINT\n+\t\t\t&& val->type != TEL_ARRAY_INT\n+\t\t\t&& val->type != TEL_ARRAY_STRING))\n \t\treturn -EINVAL;\n \tif (d->data_len >= RTE_TEL_MAX_ARRAY_ENTRIES)\n \t\treturn -ENOSPC;\n@@ -128,7 +128,7 @@ rte_tel_data_add_dict_string(struct rte_tel_data *d, const char *name,\n \tstruct tel_dict_entry *e = &d->data.dict[d->data_len];\n \tsize_t nbytes, vbytes;\n \n-\tif (d->type != RTE_TEL_DICT)\n+\tif (d->type != TEL_DICT)\n \t\treturn -EINVAL;\n \tif (d->data_len >= RTE_TEL_MAX_DICT_ENTRIES)\n \t\treturn -ENOSPC;\n@@ -150,7 +150,7 @@ int\n rte_tel_data_add_dict_int(struct rte_tel_data *d, const char *name, int val)\n {\n \tstruct tel_dict_entry *e = &d->data.dict[d->data_len];\n-\tif (d->type != RTE_TEL_DICT)\n+\tif (d->type != TEL_DICT)\n \t\treturn -EINVAL;\n \tif (d->data_len >= RTE_TEL_MAX_DICT_ENTRIES)\n \t\treturn -ENOSPC;\n@@ -170,7 +170,7 @@ rte_tel_data_add_dict_uint(struct rte_tel_data *d,\n \t\tconst char *name, uint64_t val)\n {\n \tstruct tel_dict_entry *e = &d->data.dict[d->data_len];\n-\tif (d->type != RTE_TEL_DICT)\n+\tif (d->type != TEL_DICT)\n \t\treturn -EINVAL;\n \tif (d->data_len >= RTE_TEL_MAX_DICT_ENTRIES)\n \t\treturn -ENOSPC;\n@@ -197,10 +197,10 @@ rte_tel_data_add_dict_container(struct rte_tel_data *d, const char *name,\n {\n \tstruct tel_dict_entry *e = &d->data.dict[d->data_len];\n \n-\tif (d->type != RTE_TEL_DICT || (val->type != RTE_TEL_ARRAY_UINT\n-\t\t\t&& val->type != RTE_TEL_ARRAY_INT\n-\t\t\t&& val->type != RTE_TEL_ARRAY_STRING\n-\t\t\t&& val->type != RTE_TEL_DICT))\n+\tif (d->type != TEL_DICT || (val->type != TEL_ARRAY_UINT\n+\t\t\t&& val->type != TEL_ARRAY_INT\n+\t\t\t&& val->type != TEL_ARRAY_STRING\n+\t\t\t&& val->type != TEL_DICT))\n \t\treturn -EINVAL;\n \tif (d->data_len >= RTE_TEL_MAX_DICT_ENTRIES)\n \t\treturn -ENOSPC;\ndiff --git a/lib/telemetry/telemetry_data.h b/lib/telemetry/telemetry_data.h\nindex 939deaa618..8db6875a81 100644\n--- a/lib/telemetry/telemetry_data.h\n+++ b/lib/telemetry/telemetry_data.h\n@@ -8,13 +8,13 @@\n #include \"rte_telemetry.h\"\n \n enum tel_container_types {\n-\tRTE_TEL_NULL,\t /** null, used as error value */\n-\tRTE_TEL_STRING,\t /** basic string type, no included data */\n-\tRTE_TEL_DICT,\t /** name-value pairs, of individual value type */\n-\tRTE_TEL_ARRAY_STRING, /** array of string values only */\n-\tRTE_TEL_ARRAY_INT, /** array of signed, 32-bit int values */\n-\tRTE_TEL_ARRAY_UINT, /** array of unsigned 64-bit int values */\n-\tRTE_TEL_ARRAY_CONTAINER, /** array of container structs */\n+\tTEL_NULL, /** null, used as error value */\n+\tTEL_STRING, /** basic string type, no included data */\n+\tTEL_DICT, /** name-value pairs, of individual value type */\n+\tTEL_ARRAY_STRING, /** array of string values only */\n+\tTEL_ARRAY_INT, /** array of signed, 32-bit int values */\n+\tTEL_ARRAY_UINT, /** array of unsigned 64-bit int values */\n+\tTEL_ARRAY_CONTAINER, /** array of container structs */\n };\n \n struct container {\n", "prefixes": [ "RFC", "3/7" ] }