Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/122500/?format=api
{ "id": 122500, "url": "http://patchwork.dpdk.org/api/patches/122500/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1674583351-15292-2-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1674583351-15292-2-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1674583351-15292-2-git-send-email-roretzla@linux.microsoft.com", "date": "2023-01-24T18:02:28", "name": "[v9,1/4] eal: add thread set name API operating on rte thread", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f1b1607488d8cde3ef1f594c78b321ce1b6a6c5b", "submitter": { "id": 2077, "url": "http://patchwork.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1674583351-15292-2-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 26644, "url": "http://patchwork.dpdk.org/api/series/26644/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=26644", "date": "2023-01-24T18:02:27", "name": "add rte_thread_set_name API for rte_thread_t", "version": 9, "mbox": "http://patchwork.dpdk.org/series/26644/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/122500/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/122500/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 880A34247A;\n\tTue, 24 Jan 2023 19:03:05 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D752F42D46;\n\tTue, 24 Jan 2023 19:02:43 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id A596E40684\n for <dev@dpdk.org>; Tue, 24 Jan 2023 19:02:38 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id E10FD20E2D3F; Tue, 24 Jan 2023 10:02:37 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com E10FD20E2D3F", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1674583357;\n bh=BLREEzvyDGPaAdEULmaoXB4DKJSPtjt9VDCzebhLk2g=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=KBOeSPm6/rPYIYCeREWa15YBzcSjNqxjJF2c4wVFQmXJ/UpZZwVRPpHO0Yg67feJZ\n qobMrzEqfc3of2iRsJdXV/9P9QZX443MvKNRCNHOuUerBj+0V0JvVoaCg3NawbPZ8w\n rYE4cfdzeA8TLjk+/AT4S7eQPzmdVSeAWNPHelNI=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, david.marchand@redhat.com, jerinjacobk@gmail.com,\n mb@smartsharesystems.com, Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v9 1/4] eal: add thread set name API operating on rte thread", "Date": "Tue, 24 Jan 2023 10:02:28 -0800", "Message-Id": "<1674583351-15292-2-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1674583351-15292-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1670439617-9054-1-git-send-email-roretzla@linux.microsoft.com>\n <1674583351-15292-1-git-send-email-roretzla@linux.microsoft.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add a rte_thread_set_name that sets the name of an rte_thread_t thread.\nThis is a replacement for the rte_thread_setname(pthread_t, ...) which\nexposes platform-specific details.\n\nIntroduces Windows implementation for rte_thread_set_name not previously\navailable on Windows.\n\nAdapt drivers/mlx5 to use the new internal rte_thread_set_name API\ninstead of the soon to be deprecated rte_thread_setname API.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\n---\n drivers/net/mlx5/mlx5_hws_cnt.c | 3 ++-\n drivers/vdpa/mlx5/mlx5_vdpa_event.c | 3 +--\n lib/eal/common/eal_common_thread.c | 8 ++-----\n lib/eal/freebsd/eal.c | 3 +--\n lib/eal/freebsd/eal_thread.c | 11 ++++++++++\n lib/eal/include/rte_thread.h | 20 +++++++++++++++++\n lib/eal/linux/eal.c | 6 +-----\n lib/eal/linux/eal_thread.c | 22 +++++++++++++++++++\n lib/eal/version.map | 3 +++\n lib/eal/windows/rte_thread.c | 43 +++++++++++++++++++++++++++++++++++++\n 10 files changed, 106 insertions(+), 16 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_hws_cnt.c b/drivers/net/mlx5/mlx5_hws_cnt.c\nindex 51704ef..05cc954 100644\n--- a/drivers/net/mlx5/mlx5_hws_cnt.c\n+++ b/drivers/net/mlx5/mlx5_hws_cnt.c\n@@ -465,7 +465,8 @@ struct mlx5_hws_cnt_pool *\n \t}\n \tsnprintf(name, CNT_THREAD_NAME_MAX - 1, \"%s/svc@%d\",\n \t\t sh->ibdev_name, service_core);\n-\trte_thread_setname(sh->cnt_svc->service_thread, name);\n+\trte_thread_set_name((rte_thread_t){(uintptr_t)sh->cnt_svc->service_thread},\n+\t\tname);\n \tCPU_SET(service_core, &cpuset);\n \tpthread_setaffinity_np(sh->cnt_svc->service_thread, sizeof(cpuset),\n \t\t\t\t&cpuset);\ndiff --git a/drivers/vdpa/mlx5/mlx5_vdpa_event.c b/drivers/vdpa/mlx5/mlx5_vdpa_event.c\nindex 4d81976..f3d392c 100644\n--- a/drivers/vdpa/mlx5/mlx5_vdpa_event.c\n+++ b/drivers/vdpa/mlx5/mlx5_vdpa_event.c\n@@ -547,8 +547,7 @@\n \t\tgoto out;\n \t}\n \tsnprintf(name, sizeof(name), \"vDPA-mlx5-%d\", priv->vid);\n-\tif (rte_thread_setname(priv->timer_tid, name) != 0)\n-\t\tDRV_LOG(DEBUG, \"Cannot set timer thread name.\");\n+\trte_thread_set_name((rte_thread_t){(uintptr_t)priv->timer_tid}, name);\n out:\n \tif (attrp != NULL)\n \t\tpthread_attr_destroy(attrp);\ndiff --git a/lib/eal/common/eal_common_thread.c b/lib/eal/common/eal_common_thread.c\nindex 38d83a6..3181515 100644\n--- a/lib/eal/common/eal_common_thread.c\n+++ b/lib/eal/common/eal_common_thread.c\n@@ -288,12 +288,8 @@ static void *ctrl_thread_init(void *arg)\n \t\treturn -ret;\n \t}\n \n-\tif (name != NULL) {\n-\t\tret = rte_thread_setname(*thread, name);\n-\t\tif (ret < 0)\n-\t\t\tRTE_LOG(DEBUG, EAL,\n-\t\t\t\t\"Cannot set name for ctrl thread\\n\");\n-\t}\n+\tif (name != NULL)\n+\t\trte_thread_set_name((rte_thread_t){(uintptr_t)*thread}, name);\n \n \t/* Wait for the control thread to initialize successfully */\n \twhile ((ctrl_thread_status =\ndiff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c\nindex 8db5007..9303401 100644\n--- a/lib/eal/freebsd/eal.c\n+++ b/lib/eal/freebsd/eal.c\n@@ -817,8 +817,7 @@ static void rte_eal_init_alert(const char *msg)\n \t\t/* Set thread_name for aid in debugging. */\n \t\tsnprintf(thread_name, sizeof(thread_name),\n \t\t\t\t\"rte-worker-%d\", i);\n-\t\trte_thread_setname((pthread_t)lcore_config[i].thread_id.opaque_id,\n-\t\t\tthread_name);\n+\t\trte_thread_set_name(lcore_config[i].thread_id, thread_name);\n \n \t\tret = rte_thread_set_affinity_by_id(lcore_config[i].thread_id,\n \t\t\t&lcore_config[i].cpuset);\ndiff --git a/lib/eal/freebsd/eal_thread.c b/lib/eal/freebsd/eal_thread.c\nindex ab81b52..b69f5d3 100644\n--- a/lib/eal/freebsd/eal_thread.c\n+++ b/lib/eal/freebsd/eal_thread.c\n@@ -32,6 +32,17 @@ int rte_sys_gettid(void)\n \treturn (int)lwpid;\n }\n \n+void rte_thread_set_name(rte_thread_t thread_id, const char *thread_name)\n+{\n+\tchar truncated[RTE_MAX_THREAD_NAME_LEN];\n+\tconst size_t truncatedsz = sizeof(truncated);\n+\n+\tif (strlcpy(truncated, thread_name, truncatedsz) >= truncatedsz)\n+\t\tRTE_LOG(DEBUG, EAL, \"Truncated thread name\\n\");\n+\n+\tpthread_set_name_np((pthread_t)thread_id.opaque_id, truncated);\n+}\n+\n int rte_thread_setname(pthread_t id, const char *name)\n {\n \t/* this BSD function returns no error */\ndiff --git a/lib/eal/include/rte_thread.h b/lib/eal/include/rte_thread.h\nindex b9edf70..d247930 100644\n--- a/lib/eal/include/rte_thread.h\n+++ b/lib/eal/include/rte_thread.h\n@@ -146,6 +146,26 @@ int rte_thread_create(rte_thread_t *thread_id,\n * @warning\n * @b EXPERIMENTAL: this API may change without prior notice.\n *\n+ * Set the name of the thread.\n+ * This API is a noop if the underlying platform does not\n+ * support setting the thread name or the platform-specific\n+ * API used to set the thread name fails.\n+ *\n+ * @param thread_id\n+ * The id of the thread to set name.\n+ *\n+ * @param thread_name\n+ * The name to set. Truncated to RTE_MAX_THREAD_NAME_LEN,\n+ * including terminating NUL if necessary.\n+ */\n+__rte_experimental\n+void\n+rte_thread_set_name(rte_thread_t thread_id, const char *thread_name);\n+\n+/**\n+ * @warning\n+ * @b EXPERIMENTAL: this API may change without prior notice.\n+ *\n * Check if 2 thread ids are equal.\n *\n * @param t1\ndiff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c\nindex 60298c0..d4c3507 100644\n--- a/lib/eal/linux/eal.c\n+++ b/lib/eal/linux/eal.c\n@@ -1261,11 +1261,7 @@ static void rte_eal_init_alert(const char *msg)\n \t\t/* Set thread_name for aid in debugging. */\n \t\tsnprintf(thread_name, sizeof(thread_name),\n \t\t\t\"rte-worker-%d\", i);\n-\t\tret = rte_thread_setname((pthread_t)lcore_config[i].thread_id.opaque_id,\n-\t\t\tthread_name);\n-\t\tif (ret != 0)\n-\t\t\tRTE_LOG(DEBUG, EAL,\n-\t\t\t\t\"Cannot set name for lcore thread\\n\");\n+\t\trte_thread_set_name(lcore_config[i].thread_id, thread_name);\n \n \t\tret = rte_thread_set_affinity_by_id(lcore_config[i].thread_id,\n \t\t\t&lcore_config[i].cpuset);\ndiff --git a/lib/eal/linux/eal_thread.c b/lib/eal/linux/eal_thread.c\nindex 625bde6..d5fddab 100644\n--- a/lib/eal/linux/eal_thread.c\n+++ b/lib/eal/linux/eal_thread.c\n@@ -10,6 +10,7 @@\n \n #include <rte_eal.h>\n #include <rte_lcore.h>\n+#include <rte_log.h>\n #include <rte_string_fns.h>\n \n /* require calling thread tid by gettid() */\n@@ -18,6 +19,27 @@ int rte_sys_gettid(void)\n \treturn (int)syscall(SYS_gettid);\n }\n \n+void rte_thread_set_name(rte_thread_t thread_id, const char *thread_name)\n+{\n+\tint ret = ENOSYS;\n+#if defined(__GLIBC__) && defined(__GLIBC_PREREQ)\n+#if __GLIBC_PREREQ(2, 12)\n+\tchar truncated[RTE_MAX_THREAD_NAME_LEN];\n+\tconst size_t truncatedsz = sizeof(truncated);\n+\n+\tif (strlcpy(truncated, thread_name, truncatedsz) >= truncatedsz)\n+\t\tRTE_LOG(DEBUG, EAL, \"Truncated thread name\\n\");\n+\n+\tret = pthread_setname_np((pthread_t)thread_id.opaque_id, truncated);\n+#endif\n+#endif\n+\tRTE_SET_USED(thread_id);\n+\tRTE_SET_USED(thread_name);\n+\n+\tif (ret != 0)\n+\t\tRTE_LOG(DEBUG, EAL, \"Failed to set thread name\\n\");\n+}\n+\n int rte_thread_setname(pthread_t id, const char *name)\n {\n \tint ret = ENOSYS;\ndiff --git a/lib/eal/version.map b/lib/eal/version.map\nindex 7ad12a7..c98ba71 100644\n--- a/lib/eal/version.map\n+++ b/lib/eal/version.map\n@@ -440,6 +440,9 @@ EXPERIMENTAL {\n \trte_thread_detach;\n \trte_thread_equal;\n \trte_thread_join;\n+\n+\t# added in 23.03\n+\trte_thread_set_name;\n };\n \n INTERNAL {\ndiff --git a/lib/eal/windows/rte_thread.c b/lib/eal/windows/rte_thread.c\nindex 1c1e9d0..8556a84 100644\n--- a/lib/eal/windows/rte_thread.c\n+++ b/lib/eal/windows/rte_thread.c\n@@ -4,7 +4,9 @@\n */\n \n #include <errno.h>\n+#include <wchar.h>\n \n+#include <rte_eal.h>\n #include <rte_common.h>\n #include <rte_errno.h>\n #include <rte_thread.h>\n@@ -305,6 +307,47 @@ struct thread_routine_ctx {\n \treturn thread_id;\n }\n \n+void\n+rte_thread_set_name(rte_thread_t thread_id, const char *thread_name)\n+{\n+\tint ret = 0;\n+\twchar_t wname[RTE_MAX_THREAD_NAME_LEN];\n+\tmbstate_t state = {0};\n+\tsize_t rv;\n+\tHANDLE thread_handle;\n+\n+\tthread_handle = OpenThread(THREAD_ALL_ACCESS, FALSE,\n+\t\tthread_id.opaque_id);\n+\tif (thread_handle == NULL) {\n+\t\tret = thread_log_last_error(\"OpenThread()\");\n+\t\tgoto cleanup;\n+\t}\n+\n+\tmemset(wname, 0, sizeof(wname));\n+\trv = mbsrtowcs(wname, &thread_name, RTE_DIM(wname) - 1, &state);\n+\tif (rv == (size_t)-1) {\n+\t\tret = EILSEQ;\n+\t\tgoto cleanup;\n+\t}\n+\n+#ifndef RTE_TOOLCHAIN_GCC\n+\tif (FAILED(SetThreadDescription(thread_handle, wname))) {\n+\t\tret = EINVAL;\n+\t\tgoto cleanup;\n+\t}\n+#else\n+\tret = ENOTSUP;\n+\tgoto cleanup;\n+#endif\n+\n+cleanup:\n+\tif (thread_handle != NULL)\n+\t\tCloseHandle(thread_handle);\n+\n+\tif (ret != 0)\n+\t\tRTE_LOG(DEBUG, EAL, \"Failed to set thread name\\n\");\n+}\n+\n int\n rte_thread_get_priority(rte_thread_t thread_id,\n \tenum rte_thread_priority *priority)\n", "prefixes": [ "v9", "1/4" ] }