Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/125960/?format=api
{ "id": 125960, "url": "http://patchwork.dpdk.org/api/patches/125960/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230412095239.1709477-1-zhoumin@loongson.cn/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230412095239.1709477-1-zhoumin@loongson.cn>", "list_archive_url": "https://inbox.dpdk.org/dev/20230412095239.1709477-1-zhoumin@loongson.cn", "date": "2023-04-12T09:52:39", "name": "[RFC] app/testpmd: use RSS conf from software when configuring DCB", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "efc6470b263f3d5afc5a5e3346911c1a6dd62af8", "submitter": { "id": 2394, "url": "http://patchwork.dpdk.org/api/people/2394/?format=api", "name": "zhoumin", "email": "zhoumin@loongson.cn" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230412095239.1709477-1-zhoumin@loongson.cn/mbox/", "series": [ { "id": 27672, "url": "http://patchwork.dpdk.org/api/series/27672/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=27672", "date": "2023-04-12T09:52:39", "name": "[RFC] app/testpmd: use RSS conf from software when configuring DCB", "version": 1, "mbox": "http://patchwork.dpdk.org/series/27672/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/125960/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/125960/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id ECA3342925;\n\tWed, 12 Apr 2023 11:52:49 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C7CD440FAE;\n\tWed, 12 Apr 2023 11:52:49 +0200 (CEST)", "from loongson.cn (mail.loongson.cn [114.242.206.163])\n by mails.dpdk.org (Postfix) with ESMTP id B9E024067B\n for <dev@dpdk.org>; Wed, 12 Apr 2023 11:52:47 +0200 (CEST)", "from loongson.cn (unknown [10.2.5.185])\n by gateway (Coremail) with SMTP id _____8BxedltfzZkOCsbAA--.42107S3;\n Wed, 12 Apr 2023 17:52:46 +0800 (CST)", "from localhost.localdomain (unknown [10.2.5.185])\n by localhost.localdomain (Coremail) with SMTP id\n AQAAf8DxSL1nfzZkUdggAA--.34284S2;\n Wed, 12 Apr 2023 17:52:44 +0800 (CST)" ], "From": "Min Zhou <zhoumin@loongson.cn>", "To": "aman.deep.singh@intel.com,\n\tyuying.zhang@intel.com,\n\tzhoumin@loongson.cn", "Cc": "dev@dpdk.org,\n\tmaobibo@loongson.cn", "Subject": "[RFC] app/testpmd: use RSS conf from software when configuring DCB", "Date": "Wed, 12 Apr 2023 17:52:39 +0800", "Message-Id": "<20230412095239.1709477-1-zhoumin@loongson.cn>", "X-Mailer": "git-send-email 2.31.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-CM-TRANSID": "AQAAf8DxSL1nfzZkUdggAA--.34284S2", "X-CM-SenderInfo": "52kr3ztlq6z05rqj20fqof0/", "X-Coremail-Antispam": "1Uk129KBjvJXoW7WryxWF1DGF45CFy7XFWUJwb_yoW8uF47pF\n srC3ZYyF48JFsxXa1kCaykuFs7Ar1xJFWUAFZ3A34rC3Z0yr1S9r1jqr18ZFW8WrWkJr1r\n Za93tasrXF1DCaUanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUj1kv1TuYvTs0mT0YCTnIWj\n qI5I8CrVACY4xI64kE6c02F40Ex7xfYxn0WfASr-VFAUDa7-sFnT9fnUUIcSsGvfJTRUUU\n b0kFc2x0x2IEx4CE42xK8VAvwI8IcIk0rVWrJVCq3wA2ocxC64kIII0Yj41l84x0c7CEw4\n AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26r4j6ryUM28EF7xvwVC0I7IYx2IY6xkF\n 7I0E14v26r4j6F4UM28EF7xvwVC2z280aVAFwI0_Cr1j6rxdM28EF7xvwVC2z280aVCY1x\n 0267AKxVWxJr0_GcWle2I262IYc4CY6c8Ij28IcVAaY2xG8wAqjxCEc2xF0cIa020Ex4CE\n 44I27wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E74AGY7Cv6cx26rWlOx8S6xCaFVCjc4\n AY6r1j6r4UM4x0Y48IcxkI7VAKI48JMxAIw28IcxkI7VAKI48JMxAIw28IcVCjz48v1sIE\n Y20_WwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E74\n 80Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcVC0\n I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04\n k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7Cj\n xVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7xRE6wZ7UUUUU==", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "In the testpmd command, we have to stop the port firstly before configuring\nthe DCB. However, some PMDs may execute a hardware reset during the port\nstop, such as ixgbe. Some kind of reset operations of PMD could clear the\nconfigurations of RSS in the hardware register. This would cause the loss\nof RSS configurations that were set during the testpmd initialization. As\na result, I find that I cannot enable RSS and DCB at the same time in the\ntestpmd command when using Intel 82599 NIC.\n\nAlthough this patch can solve the problem I encountered, is there any risk\nof using rss conf from software instead of reading from the hardware\nregister when configuring DCB?\n\nSigned-off-by: Min Zhou <zhoumin@loongson.cn>\n---\n app/test-pmd/testpmd.c | 11 +----------\n 1 file changed, 1 insertion(+), 10 deletions(-)", "diff": "diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex 5cb6f92523..3c382267b8 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -4247,14 +4247,12 @@ const uint16_t vlan_tags[] = {\n };\n \n static int\n-get_eth_dcb_conf(portid_t pid, struct rte_eth_conf *eth_conf,\n+get_eth_dcb_conf(portid_t pid __rte_unused, struct rte_eth_conf *eth_conf,\n \t\t enum dcb_mode_enable dcb_mode,\n \t\t enum rte_eth_nb_tcs num_tcs,\n \t\t uint8_t pfc_en)\n {\n \tuint8_t i;\n-\tint32_t rc;\n-\tstruct rte_eth_rss_conf rss_conf;\n \n \t/*\n \t * Builds up the correct configuration for dcb+vt based on the vlan tags array\n@@ -4296,12 +4294,6 @@ get_eth_dcb_conf(portid_t pid, struct rte_eth_conf *eth_conf,\n \t\tstruct rte_eth_dcb_tx_conf *tx_conf =\n \t\t\t\tð_conf->tx_adv_conf.dcb_tx_conf;\n \n-\t\tmemset(&rss_conf, 0, sizeof(struct rte_eth_rss_conf));\n-\n-\t\trc = rte_eth_dev_rss_hash_conf_get(pid, &rss_conf);\n-\t\tif (rc != 0)\n-\t\t\treturn rc;\n-\n \t\trx_conf->nb_tcs = num_tcs;\n \t\ttx_conf->nb_tcs = num_tcs;\n \n@@ -4313,7 +4305,6 @@ get_eth_dcb_conf(portid_t pid, struct rte_eth_conf *eth_conf,\n \t\teth_conf->rxmode.mq_mode =\n \t\t\t\t(enum rte_eth_rx_mq_mode)\n \t\t\t\t\t(rx_mq_mode & RTE_ETH_MQ_RX_DCB_RSS);\n-\t\teth_conf->rx_adv_conf.rss_conf = rss_conf;\n \t\teth_conf->txmode.mq_mode = RTE_ETH_MQ_TX_DCB;\n \t}\n \n", "prefixes": [ "RFC" ] }