Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/127607/?format=api
{ "id": 127607, "url": "http://patchwork.dpdk.org/api/patches/127607/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230527085910.972-11-anoobj@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230527085910.972-11-anoobj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230527085910.972-11-anoobj@marvell.com", "date": "2023-05-27T08:58:59", "name": "[v5,10/21] test/pdcp: pdcp HFN tests in combined mode", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "8f395e36d19c7946af973d0dc854d0605d722906", "submitter": { "id": 1205, "url": "http://patchwork.dpdk.org/api/people/1205/?format=api", "name": "Anoob Joseph", "email": "anoobj@marvell.com" }, "delegate": { "id": 6690, "url": "http://patchwork.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230527085910.972-11-anoobj@marvell.com/mbox/", "series": [ { "id": 28216, "url": "http://patchwork.dpdk.org/api/series/28216/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28216", "date": "2023-05-27T08:58:50", "name": "lib: add pdcp protocol", "version": 5, "mbox": "http://patchwork.dpdk.org/series/28216/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/127607/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/127607/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 24C2442BB3;\n\tSat, 27 May 2023 11:53:59 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1272442D32;\n\tSat, 27 May 2023 11:53:59 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 7358541141\n for <dev@dpdk.org>; Sat, 27 May 2023 11:53:57 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 34R9jcXW017715; Sat, 27 May 2023 02:53:56 -0700", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3quaj6rkm1-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Sat, 27 May 2023 02:53:56 -0700", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Sat, 27 May 2023 02:53:54 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Sat, 27 May 2023 02:53:54 -0700", "from BG-LT92004.corp.innovium.com (unknown [10.193.65.175])\n by maili.marvell.com (Postfix) with ESMTP id 4074B5E72DD;\n Sat, 27 May 2023 01:59:58 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=Y2R/3w1whBgnnivM4BkIGMKyEXpW6DFgl8L9b7VjOyA=;\n b=KrTv1yT4uky2pQAUvdfyMcmVdMvL1lSZTy+HtcgL/G+YYLH1kMrYBwbI/d3GYiPHA347\n S9tFfOIB5LxUN4i8p0kSWrMxmNLGIR8XPchPithWutHBss/CyreGLu6RbnJWPCNgIt1W\n UOzqWsiUonO4npJiUvg2Orc5xVuMtqxjt3m5aRLCfUzP4Sh6zgWJWTgImuvPa4yuvBu8\n 64ouAvcTernwmv7tPuuf/PVSeXCLPgqcTvmyP7lOOzW1uEob/6rO/a+2DkXWZDs4n8ML\n l6r1Dc4aY5rd046GxPjMopbgf0m4hUTqZd4qGip2cLXN3/yZ8ehOB15FEXYHXpKWGbLH Jg==", "From": "Anoob Joseph <anoobj@marvell.com>", "To": "Thomas Monjalon <thomas@monjalon.net>, Akhil Goyal <gakhil@marvell.com>,\n Jerin Jacob <jerinj@marvell.com>, Konstantin Ananyev\n <konstantin.v.ananyev@yandex.ru>", "CC": "Volodymyr Fialko <vfialko@marvell.com>,\n Hemant Agrawal <hemant.agrawal@nxp.com>,\n =?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>,\n Kiran Kumar K <kirankumark@marvell.com>, <dev@dpdk.org>,\n Olivier Matz <olivier.matz@6wind.com>,\n Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[PATCH v5 10/21] test/pdcp: pdcp HFN tests in combined mode", "Date": "Sat, 27 May 2023 14:28:59 +0530", "Message-ID": "<20230527085910.972-11-anoobj@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230527085910.972-1-anoobj@marvell.com>", "References": "<20230526210214.617-1-anoobj@marvell.com>\n <20230527085910.972-1-anoobj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-GUID": "69iFD6UwjI-4f8cO7LFTkgXLxOuCsyVq", "X-Proofpoint-ORIG-GUID": "69iFD6UwjI-4f8cO7LFTkgXLxOuCsyVq", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26\n definitions=2023-05-27_06,2023-05-25_03,2023-05-22_02", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Volodymyr Fialko <vfialko@marvell.com>\n\nAdd tests to verify HFN/SN behaviour.\n\nSigned-off-by: Anoob Joseph <anoobj@marvell.com>\nSigned-off-by: Volodymyr Fialko <vfialko@marvell.com>\n---\n app/test/test_pdcp.c | 302 ++++++++++++++++++++++++++++++++++++++++++-\n 1 file changed, 299 insertions(+), 3 deletions(-)", "diff": "diff --git a/app/test/test_pdcp.c b/app/test/test_pdcp.c\nindex 34b759eaef..cfe2ec6aa9 100644\n--- a/app/test/test_pdcp.c\n+++ b/app/test/test_pdcp.c\n@@ -16,6 +16,9 @@\n #define NB_TESTS RTE_DIM(pdcp_test_params)\n #define PDCP_IV_LEN 16\n \n+/* According to formula(7.2.a Window_Size) */\n+#define PDCP_WINDOW_SIZE(sn_size) (1 << (sn_size - 1))\n+\n struct pdcp_testsuite_params {\n \tstruct rte_mempool *mbuf_pool;\n \tstruct rte_mempool *cop_pool;\n@@ -36,12 +39,69 @@ struct pdcp_test_conf {\n \tuint32_t output_len;\n };\n \n+static int create_test_conf_from_index(const int index, struct pdcp_test_conf *conf);\n+\n+typedef int (*test_with_conf_t)(struct pdcp_test_conf *conf);\n+\n+static int\n+run_test_foreach_known_vec(test_with_conf_t test, bool stop_on_first_pass)\n+{\n+\tstruct pdcp_test_conf test_conf;\n+\tbool all_tests_skipped = true;\n+\tuint32_t i;\n+\tint ret;\n+\n+\tfor (i = 0; i < NB_TESTS; i++) {\n+\t\tcreate_test_conf_from_index(i, &test_conf);\n+\t\tret = test(&test_conf);\n+\n+\t\tif (ret == TEST_FAILED) {\n+\t\t\tprintf(\"[%03i] - %s - failed\\n\", i, pdcp_test_params[i].name);\n+\t\t\treturn TEST_FAILED;\n+\t\t}\n+\n+\t\tif ((ret == TEST_SKIPPED) || (ret == -ENOTSUP))\n+\t\t\tcontinue;\n+\n+\t\tif (stop_on_first_pass)\n+\t\t\treturn TEST_SUCCESS;\n+\n+\t\tall_tests_skipped = false;\n+\t}\n+\n+\tif (all_tests_skipped)\n+\t\treturn TEST_SKIPPED;\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+static int\n+run_test_with_all_known_vec(const void *args)\n+{\n+\ttest_with_conf_t test = args;\n+\n+\treturn run_test_foreach_known_vec(test, false);\n+}\n+\n static inline int\n pdcp_hdr_size_get(enum rte_security_pdcp_sn_size sn_size)\n {\n \treturn RTE_ALIGN_MUL_CEIL(sn_size, 8) / 8;\n }\n \n+static int\n+pktmbuf_read_into(const struct rte_mbuf *m, void *buf, size_t buf_len)\n+{\n+\tif (m->pkt_len > buf_len)\n+\t\treturn -ENOMEM;\n+\n+\tconst void *read = rte_pktmbuf_read(m, 0, m->pkt_len, buf);\n+\tif (read != NULL && read != buf)\n+\t\tmemcpy(buf, read, m->pkt_len);\n+\n+\treturn 0;\n+}\n+\n static int\n cryptodev_init(int dev_id)\n {\n@@ -326,6 +386,21 @@ pdcp_sn_from_raw_get(const void *data, enum rte_security_pdcp_sn_size size)\n \treturn sn;\n }\n \n+static void\n+pdcp_sn_to_raw_set(void *data, uint32_t sn, int size)\n+{\n+\tif (size == RTE_SECURITY_PDCP_SN_SIZE_12) {\n+\t\tstruct rte_pdcp_up_data_pdu_sn_12_hdr *pdu_hdr = data;\n+\t\tpdu_hdr->sn_11_8 = ((sn & 0xf00) >> 8);\n+\t\tpdu_hdr->sn_7_0 = (sn & 0xff);\n+\t} else if (size == RTE_SECURITY_PDCP_SN_SIZE_18) {\n+\t\tstruct rte_pdcp_up_data_pdu_sn_18_hdr *pdu_hdr = data;\n+\t\tpdu_hdr->sn_17_16 = ((sn & 0x30000) >> 16);\n+\t\tpdu_hdr->sn_15_8 = ((sn & 0xff00) >> 8);\n+\t\tpdu_hdr->sn_7_0 = (sn & 0xff);\n+\t}\n+}\n+\n static int\n create_test_conf_from_index(const int index, struct pdcp_test_conf *conf)\n {\n@@ -648,9 +723,17 @@ test_attempt_single(struct pdcp_test_conf *t_conf)\n \t\tgoto mbuf_free;\n \t}\n \n-\tret = pdcp_known_vec_verify(mbuf, t_conf->output, t_conf->output_len);\n-\tif (ret)\n-\t\tgoto mbuf_free;\n+\t/* If expected output provided - verify, else - store for future use */\n+\tif (t_conf->output_len) {\n+\t\tret = pdcp_known_vec_verify(mbuf, t_conf->output, t_conf->output_len);\n+\t\tif (ret)\n+\t\t\tgoto mbuf_free;\n+\t} else {\n+\t\tret = pktmbuf_read_into(mbuf, t_conf->output, RTE_PDCP_CTRL_PDU_SIZE_MAX);\n+\t\tif (ret)\n+\t\t\tgoto mbuf_free;\n+\t\tt_conf->output_len = mbuf->pkt_len;\n+\t}\n \n \tret = rte_pdcp_entity_suspend(pdcp_entity, out_mb);\n \tif (ret) {\n@@ -667,6 +750,193 @@ test_attempt_single(struct pdcp_test_conf *t_conf)\n \treturn ret;\n }\n \n+static void\n+uplink_to_downlink_convert(const struct pdcp_test_conf *ul_cfg,\n+\t\t\t struct pdcp_test_conf *dl_cfg)\n+{\n+\tassert(ul_cfg->entity.pdcp_xfrm.pkt_dir == RTE_SECURITY_PDCP_UPLINK);\n+\n+\tmemcpy(dl_cfg, ul_cfg, sizeof(*dl_cfg));\n+\tdl_cfg->entity.pdcp_xfrm.pkt_dir = RTE_SECURITY_PDCP_DOWNLINK;\n+\tdl_cfg->entity.reverse_iv_direction = false;\n+\n+\tif (dl_cfg->is_integrity_protected) {\n+\t\tdl_cfg->entity.crypto_xfrm = &dl_cfg->c_xfrm;\n+\n+\t\tdl_cfg->c_xfrm.cipher.op = RTE_CRYPTO_CIPHER_OP_DECRYPT;\n+\t\tdl_cfg->c_xfrm.next = &dl_cfg->a_xfrm;\n+\n+\t\tdl_cfg->a_xfrm.auth.op = RTE_CRYPTO_AUTH_OP_VERIFY;\n+\t\tdl_cfg->a_xfrm.next = NULL;\n+\t} else {\n+\t\tdl_cfg->entity.crypto_xfrm = &dl_cfg->c_xfrm;\n+\t\tdl_cfg->c_xfrm.next = NULL;\n+\t\tdl_cfg->c_xfrm.cipher.op = RTE_CRYPTO_CIPHER_OP_DECRYPT;\n+\t}\n+\n+\tdl_cfg->entity.dev_id = (uint8_t)cryptodev_id_get(dl_cfg->is_integrity_protected,\n+\t\t\t&dl_cfg->c_xfrm, &dl_cfg->a_xfrm);\n+\n+\tmemcpy(dl_cfg->input, ul_cfg->output, ul_cfg->output_len);\n+\tdl_cfg->input_len = ul_cfg->output_len;\n+\n+\tmemcpy(dl_cfg->output, ul_cfg->input, ul_cfg->input_len);\n+\tdl_cfg->output_len = ul_cfg->input_len;\n+}\n+\n+/*\n+ * According to ETSI TS 138 323 V17.1.0, Section 5.2.2.1,\n+ * SN could be divided into following ranges,\n+ * relatively to current value of RX_DELIV state:\n+ * +-------------+-------------+-------------+-------------+\n+ * | -Outside | -Window | +Window | +Outside |\n+ * | (valid) | (Invalid) | (Valid) | (Invalid) |\n+ * +-------------+-------------^-------------+-------------+\n+ * |\n+ * v\n+ * SN(RX_DELIV)\n+ */\n+enum sn_range_type {\n+\tSN_RANGE_MINUS_OUTSIDE,\n+\tSN_RANGE_MINUS_WINDOW,\n+\tSN_RANGE_PLUS_WINDOW,\n+\tSN_RANGE_PLUS_OUTSIDE,\n+};\n+\n+#define PDCP_SET_COUNT(hfn, sn, size) ((hfn << size) | (sn & ((1 << size) - 1)))\n+\n+/*\n+ * Take uplink test case as base, modify RX_DELIV in state and SN in input\n+ */\n+static int\n+test_sn_range_type(enum sn_range_type type, struct pdcp_test_conf *conf)\n+{\n+\tuint32_t rx_deliv_hfn, rx_deliv_sn, new_hfn, new_sn;\n+\tconst int domain = conf->entity.pdcp_xfrm.domain;\n+\tstruct pdcp_test_conf dl_conf;\n+\tint ret, expected_ret;\n+\n+\tif (conf->entity.pdcp_xfrm.pkt_dir == RTE_SECURITY_PDCP_DOWNLINK)\n+\t\treturn TEST_SKIPPED;\n+\n+\tif (domain != RTE_SECURITY_PDCP_MODE_CONTROL && domain != RTE_SECURITY_PDCP_MODE_DATA)\n+\t\treturn TEST_SKIPPED;\n+\n+\tconst uint32_t sn_size = conf->entity.pdcp_xfrm.sn_size;\n+\tconst uint32_t window_size = PDCP_WINDOW_SIZE(sn_size);\n+\t/* Max value of SN that could fit in `sn_size` bits */\n+\tconst uint32_t max_sn = (1 << sn_size) - 1;\n+\tconst uint32_t shift = (max_sn - window_size) / 2;\n+\t/* Could be any number up to `shift` value */\n+\tconst uint32_t default_sn = RTE_MIN(2u, shift);\n+\n+\t/* Initialize HFN as non zero value, to be able check values before */\n+\trx_deliv_hfn = 0xa;\n+\n+\tswitch (type) {\n+\tcase SN_RANGE_PLUS_WINDOW:\n+\t\t/* Within window size, HFN stay same */\n+\t\tnew_hfn = rx_deliv_hfn;\n+\t\trx_deliv_sn = default_sn;\n+\t\tnew_sn = rx_deliv_sn + 1;\n+\t\texpected_ret = TEST_SUCCESS;\n+\t\tbreak;\n+\tcase SN_RANGE_MINUS_WINDOW:\n+\t\t/* Within window size, HFN stay same */\n+\t\tnew_hfn = rx_deliv_hfn;\n+\t\trx_deliv_sn = default_sn;\n+\t\tnew_sn = rx_deliv_sn - 1;\n+\t\texpected_ret = TEST_FAILED;\n+\t\tbreak;\n+\tcase SN_RANGE_PLUS_OUTSIDE:\n+\t\t/* RCVD_SN >= SN(RX_DELIV) + Window_Size */\n+\t\tnew_hfn = rx_deliv_hfn - 1;\n+\t\trx_deliv_sn = default_sn;\n+\t\tnew_sn = rx_deliv_sn + window_size;\n+\t\texpected_ret = TEST_FAILED;\n+\t\tbreak;\n+\tcase SN_RANGE_MINUS_OUTSIDE:\n+\t\t/* RCVD_SN < SN(RX_DELIV) - Window_Size */\n+\t\tnew_hfn = rx_deliv_hfn + 1;\n+\t\trx_deliv_sn = window_size + default_sn;\n+\t\tnew_sn = rx_deliv_sn - window_size - 1;\n+\t\texpected_ret = TEST_SUCCESS;\n+\t\tbreak;\n+\tdefault:\n+\t\treturn TEST_FAILED;\n+\t}\n+\n+\t/* Configure Uplink to generate expected, encrypted packet */\n+\tpdcp_sn_to_raw_set(conf->input, new_sn, conf->entity.pdcp_xfrm.sn_size);\n+\tconf->entity.reverse_iv_direction = true;\n+\tconf->entity.pdcp_xfrm.hfn = new_hfn;\n+\tconf->entity.sn = new_sn;\n+\tconf->output_len = 0;\n+\tret = test_attempt_single(conf);\n+\tif (ret != TEST_SUCCESS)\n+\t\treturn ret;\n+\n+\t/* Flip configuration to downlink */\n+\tuplink_to_downlink_convert(conf, &dl_conf);\n+\n+\t/* Modify the rx_deliv to verify the expected behaviour */\n+\tdl_conf.entity.pdcp_xfrm.hfn = rx_deliv_hfn;\n+\tdl_conf.entity.sn = rx_deliv_sn;\n+\tret = test_attempt_single(&dl_conf);\n+\tif ((ret == TEST_SKIPPED) || (ret == -ENOTSUP))\n+\t\treturn ret;\n+\n+\tTEST_ASSERT_EQUAL(ret, expected_ret, \"Unexpected result\");\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+static int\n+test_sn_plus_window(struct pdcp_test_conf *t_conf)\n+{\n+\treturn test_sn_range_type(SN_RANGE_PLUS_WINDOW, t_conf);\n+}\n+\n+static int\n+test_sn_minus_window(struct pdcp_test_conf *t_conf)\n+{\n+\treturn test_sn_range_type(SN_RANGE_MINUS_WINDOW, t_conf);\n+}\n+\n+static int\n+test_sn_plus_outside(struct pdcp_test_conf *t_conf)\n+{\n+\treturn test_sn_range_type(SN_RANGE_PLUS_OUTSIDE, t_conf);\n+}\n+\n+static int\n+test_sn_minus_outside(struct pdcp_test_conf *t_conf)\n+{\n+\treturn test_sn_range_type(SN_RANGE_MINUS_OUTSIDE, t_conf);\n+}\n+\n+static int\n+test_combined(struct pdcp_test_conf *ul_conf)\n+{\n+\tstruct pdcp_test_conf dl_conf;\n+\tint ret;\n+\n+\tif (ul_conf->entity.pdcp_xfrm.pkt_dir == RTE_SECURITY_PDCP_DOWNLINK)\n+\t\treturn TEST_SKIPPED;\n+\n+\tul_conf->entity.reverse_iv_direction = true;\n+\tul_conf->output_len = 0;\n+\n+\tret = test_attempt_single(ul_conf);\n+\tif (ret != TEST_SUCCESS)\n+\t\treturn ret;\n+\n+\tuplink_to_downlink_convert(ul_conf, &dl_conf);\n+\tret = test_attempt_single(&dl_conf);\n+\n+\treturn ret;\n+}\n+\n static int\n run_test_for_one_known_vec(const void *arg)\n {\n@@ -677,8 +947,34 @@ run_test_for_one_known_vec(const void *arg)\n \treturn test_attempt_single(&test_conf);\n }\n \n+static struct unit_test_suite combined_mode_cases = {\n+\t.suite_name = \"PDCP combined mode\",\n+\t.unit_test_cases = {\n+\t\tTEST_CASE_NAMED_WITH_DATA(\"combined mode\", ut_setup_pdcp, ut_teardown_pdcp,\n+\t\t\trun_test_with_all_known_vec, test_combined),\n+\t\tTEST_CASES_END() /**< NULL terminate unit test array */\n+\t}\n+};\n+\n+static struct unit_test_suite hfn_sn_test_cases = {\n+\t.suite_name = \"PDCP HFN/SN\",\n+\t.unit_test_cases = {\n+\t\tTEST_CASE_NAMED_WITH_DATA(\"SN plus window\", ut_setup_pdcp, ut_teardown_pdcp,\n+\t\t\trun_test_with_all_known_vec, test_sn_plus_window),\n+\t\tTEST_CASE_NAMED_WITH_DATA(\"SN minus window\", ut_setup_pdcp, ut_teardown_pdcp,\n+\t\t\trun_test_with_all_known_vec, test_sn_minus_window),\n+\t\tTEST_CASE_NAMED_WITH_DATA(\"SN plus outside\", ut_setup_pdcp, ut_teardown_pdcp,\n+\t\t\trun_test_with_all_known_vec, test_sn_plus_outside),\n+\t\tTEST_CASE_NAMED_WITH_DATA(\"SN minus outside\", ut_setup_pdcp, ut_teardown_pdcp,\n+\t\t\trun_test_with_all_known_vec, test_sn_minus_outside),\n+\t\tTEST_CASES_END() /**< NULL terminate unit test array */\n+\t}\n+};\n+\n struct unit_test_suite *test_suites[] = {\n \tNULL, /* Place holder for known_vector_cases */\n+\t&combined_mode_cases,\n+\t&hfn_sn_test_cases,\n \tNULL /* End of suites list */\n };\n \n", "prefixes": [ "v5", "10/21" ] }