Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/128853/?format=api
{ "id": 128853, "url": "http://patchwork.dpdk.org/api/patches/128853/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230620140704.171667-5-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230620140704.171667-5-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230620140704.171667-5-david.marchand@redhat.com", "date": "2023-06-20T14:07:04", "name": "[v3,4/4] ci: build examples externally", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "9f749c6c60c8d8d8cf823253c1863a8cb2ea9a44", "submitter": { "id": 1173, "url": "http://patchwork.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230620140704.171667-5-david.marchand@redhat.com/mbox/", "series": [ { "id": 28585, "url": "http://patchwork.dpdk.org/api/series/28585/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28585", "date": "2023-06-20T14:07:04", "name": "Test examples compilation externally", "version": 3, "mbox": "http://patchwork.dpdk.org/series/28585/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/128853/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/128853/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B43CE42D09;\n\tTue, 20 Jun 2023 16:08:43 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7E08A40DDA;\n\tTue, 20 Jun 2023 16:08:43 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by mails.dpdk.org (Postfix) with ESMTP id 8F9BD400D6\n for <dev@dpdk.org>; Tue, 20 Jun 2023 16:08:41 +0200 (CEST)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-126-R5_TRFiDPXSDtKWHHH96Ug-1; Tue, 20 Jun 2023 10:08:34 -0400", "from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com\n [10.11.54.10])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6506989E764;\n Tue, 20 Jun 2023 14:07:46 +0000 (UTC)", "from dmarchan.redhat.com (unknown [10.45.224.210])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 5BDA5425357;\n Tue, 20 Jun 2023 14:07:45 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1687270121;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=Co0zeLwHidaWkG+loEHzJ3C8FIkEVdWTy1gsr4jWHJY=;\n b=C3rZadR3rYLxlEkppYCW7jVSa4IHf/UE5Pty/uzkG97rwK4jqGFo7Rw6a0IhJ2HjUVTjWH\n tUwGx5xWkPYkJ1uOgvWsUW1a374UYYr6r8286Kvwat/I1EvlhNHOXib0IGjt6dOGjcMhac\n cVWOYhXriLudRIRZeXePGHZkVzY00j0=", "X-MC-Unique": "R5_TRFiDPXSDtKWHHH96Ug-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, bruce.richardson@intel.com,\n Aaron Conole <aconole@redhat.com>,\n Michael Santana <maicolgabriel@hotmail.com>", "Subject": "[PATCH v3 4/4] ci: build examples externally", "Date": "Tue, 20 Jun 2023 16:07:04 +0200", "Message-Id": "<20230620140704.171667-5-david.marchand@redhat.com>", "In-Reply-To": "<20230620140704.171667-1-david.marchand@redhat.com>", "References": "<20230613081741.4083273-1-david.marchand@redhat.com>\n <20230620140704.171667-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.10", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Enhance our CI coverage by building examples against an installed DPDK.\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\nAcked-by: Aaron Conole <aconole@redhat.com>\n---\nChanges since v2:\n- dropped unneeded -e in sed cmdline,\n\nChanges since v1:\n- reworked built examples discovery,\n- added comment for people who are not sed fluent,\n\n---\n .ci/linux-build.sh | 27 ++++++++++++++++++++++++++-\n .github/workflows/build.yml | 6 +++---\n 2 files changed, 29 insertions(+), 4 deletions(-)", "diff": "diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh\nindex 9631e342b5..d0d9f89bae 100755\n--- a/.ci/linux-build.sh\n+++ b/.ci/linux-build.sh\n@@ -1,7 +1,7 @@\n #!/bin/sh -xe\n \n if [ -z \"${DEF_LIB:-}\" ]; then\n- DEF_LIB=static ABI_CHECKS= BUILD_DOCS= RUN_TESTS= $0\n+ DEF_LIB=static ABI_CHECKS= BUILD_DOCS= BUILD_EXAMPLES= RUN_TESTS= $0\n DEF_LIB=shared $0\n exit\n fi\n@@ -99,6 +99,7 @@ if [ \"$MINI\" = \"true\" ]; then\n else\n OPTS=\"$OPTS -Ddisable_libs=\"\n fi\n+OPTS=\"$OPTS -Dlibdir=lib\"\n \n if [ \"$ASAN\" = \"true\" ]; then\n OPTS=\"$OPTS -Db_sanitize=address\"\n@@ -168,3 +169,27 @@ if [ \"$RUN_TESTS\" = \"true\" ]; then\n catch_coredump\n [ \"$failed\" != \"true\" ]\n fi\n+\n+# Test examples compilation with an installed dpdk\n+if [ \"$BUILD_EXAMPLES\" = \"true\" ]; then\n+ [ -d install ] || DESTDIR=$(pwd)/install ninja -C build install\n+ export LD_LIBRARY_PATH=$(dirname $(find $(pwd)/install -name librte_eal.so)):$LD_LIBRARY_PATH\n+ export PKG_CONFIG_PATH=$(dirname $(find $(pwd)/install -name libdpdk.pc)):$PKG_CONFIG_PATH\n+ export PKGCONF=\"pkg-config --define-prefix\"\n+ find build/examples -maxdepth 1 -type f -name \"dpdk-*\" |\n+ while read target; do\n+ target=${target%%:*}\n+ target=${target#build/examples/dpdk-}\n+ if [ -e examples/$target/Makefile ]; then\n+ echo $target\n+ continue\n+ fi\n+ # Some examples binaries are built from an example sub\n+ # directory, discover the \"top level\" example name.\n+ find examples -name Makefile |\n+ sed -n \"s,examples/\\([^/]*\\)\\(/.*\\|\\)/$target/Makefile,\\1,p\"\n+ done | sort -u |\n+ while read example; do\n+ make -C install/usr/local/share/dpdk/examples/$example clean shared\n+ done\n+fi\ndiff --git a/.github/workflows/build.yml b/.github/workflows/build.yml\nindex 3b629fcdbd..414dd089e0 100644\n--- a/.github/workflows/build.yml\n+++ b/.github/workflows/build.yml\n@@ -20,6 +20,7 @@ jobs:\n BUILD_32BIT: ${{ matrix.config.cross == 'i386' }}\n BUILD_DEBUG: ${{ contains(matrix.config.checks, 'debug') }}\n BUILD_DOCS: ${{ contains(matrix.config.checks, 'doc') }}\n+ BUILD_EXAMPLES: ${{ contains(matrix.config.checks, 'examples') }}\n CC: ccache ${{ matrix.config.compiler }}\n DEF_LIB: ${{ matrix.config.library }}\n LIBABIGAIL_VERSION: libabigail-2.1\n@@ -39,7 +40,7 @@ jobs:\n mini: mini\n - os: ubuntu-20.04\n compiler: gcc\n- checks: abi+debug+doc+tests\n+ checks: abi+debug+doc+examples+tests\n - os: ubuntu-20.04\n compiler: clang\n checks: asan+doc+tests\n@@ -96,12 +97,11 @@ jobs:\n - name: Install packages\n run: sudo apt install -y ccache libarchive-dev libbsd-dev libfdt-dev\n libibverbs-dev libjansson-dev libnuma-dev libpcap-dev libssl-dev\n- ninja-build python3-pip python3-pyelftools python3-setuptools\n+ ninja-build pkg-config python3-pip python3-pyelftools python3-setuptools\n python3-wheel zlib1g-dev\n - name: Install libabigail build dependencies if no cache is available\n if: env.ABI_CHECKS == 'true' && steps.libabigail-cache.outputs.cache-hit != 'true'\n run: sudo apt install -y autoconf automake libdw-dev libtool libxml2-dev\n- pkg-config\n - name: Install i386 cross compiling packages\n if: env.BUILD_32BIT == 'true'\n run: sudo apt install -y gcc-multilib g++-multilib\n", "prefixes": [ "v3", "4/4" ] }