Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/128902/?format=api
{ "id": 128902, "url": "http://patchwork.dpdk.org/api/patches/128902/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230622034738.51288-5-denis.pryazhennikov@arknetworks.am/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230622034738.51288-5-denis.pryazhennikov@arknetworks.am>", "list_archive_url": "https://inbox.dpdk.org/dev/20230622034738.51288-5-denis.pryazhennikov@arknetworks.am", "date": "2023-06-22T03:47:38", "name": "[v2,4/4] net/sfc: add configurable Rx CRC stripping", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "39f4ee13e42d986009a3402a9ab8ea1a0b915a9a", "submitter": { "id": 3057, "url": "http://patchwork.dpdk.org/api/people/3057/?format=api", "name": "Denis Pryazhennikov", "email": "denis.pryazhennikov@arknetworks.am" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230622034738.51288-5-denis.pryazhennikov@arknetworks.am/mbox/", "series": [ { "id": 28609, "url": "http://patchwork.dpdk.org/api/series/28609/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28609", "date": "2023-06-22T03:47:34", "name": "net/sfc: support KEEP_CRC offload", "version": 2, "mbox": "http://patchwork.dpdk.org/series/28609/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/128902/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/128902/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C35E242D1D;\n\tThu, 22 Jun 2023 05:48:06 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2728842D20;\n\tThu, 22 Jun 2023 05:47:53 +0200 (CEST)", "from agw.arknetworks.am (agw.arknetworks.am [79.141.165.80])\n by mails.dpdk.org (Postfix) with ESMTP id 1D7D541104\n for <dev@dpdk.org>; Thu, 22 Jun 2023 05:47:43 +0200 (CEST)", "from localhost.localdomain (unknown [37.252.90.118])\n (using TLSv1.3 with cipher TLS_CHACHA20_POLY1305_SHA256 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA512)\n (No client certificate requested)\n by agw.arknetworks.am (Postfix) with ESMTPSA id 8F085E1198;\n Thu, 22 Jun 2023 07:47:42 +0400 (+04)" ], "From": "Denis Pryazhennikov <denis.pryazhennikov@arknetworks.am>", "To": "dev@dpdk.org", "Cc": "Ferruh Yigit <ferruh.yigit@amd.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Roman Zhukov <roman.zhukov@arknetworks.am>,\n Andy Moreton <amoreton@xilinx.com>", "Subject": "[PATCH v2 4/4] net/sfc: add configurable Rx CRC stripping", "Date": "Thu, 22 Jun 2023 07:47:38 +0400", "Message-Id": "<20230622034738.51288-5-denis.pryazhennikov@arknetworks.am>", "X-Mailer": "git-send-email 2.39.2 (Apple Git-143)", "In-Reply-To": "<20230622034738.51288-1-denis.pryazhennikov@arknetworks.am>", "References": "<20230601114220.17796-1-denis.pryazhennikov@arknetworks.am>\n <20230622034738.51288-1-denis.pryazhennikov@arknetworks.am>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Configurable Rx CRC stripping is allowed only if\nrunning firmware variant supports it and if NIC is\nconfigured with single PF per port and without VFs.\nWhen KEEP_CRC is supported, CRC will be part of\nthe packet payload. The packet length will also\ncontain CRC length. At the same time, CRC length\nshould be removed from stats.\n\nSigned-off-by: Denis Pryazhennikov <denis.pryazhennikov@arknetworks.am>\nSigned-off-by: Roman Zhukov <roman.zhukov@arknetworks.am>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n doc/guides/nics/features/sfc.ini | 1 +\n doc/guides/nics/sfc_efx.rst | 6 ++++--\n doc/guides/rel_notes/release_23_07.rst | 2 ++\n drivers/net/sfc/sfc.h | 1 +\n drivers/net/sfc/sfc_ef100_rx.c | 2 +-\n drivers/net/sfc/sfc_ef10_rx.c | 3 ++-\n drivers/net/sfc/sfc_ethdev.c | 7 ++++++-\n drivers/net/sfc/sfc_port.c | 12 ++++++++++++\n drivers/net/sfc/sfc_rx.c | 6 +++++-\n 9 files changed, 34 insertions(+), 6 deletions(-)", "diff": "diff --git a/doc/guides/nics/features/sfc.ini b/doc/guides/nics/features/sfc.ini\nindex a4b53c619c12..8a9198adcb5b 100644\n--- a/doc/guides/nics/features/sfc.ini\n+++ b/doc/guides/nics/features/sfc.ini\n@@ -23,6 +23,7 @@ RSS key update = Y\n RSS reta update = Y\n SR-IOV = Y\n Flow control = Y\n+CRC offload = Y\n VLAN offload = P\n FEC = Y\n L3 checksum offload = Y\ndiff --git a/doc/guides/nics/sfc_efx.rst b/doc/guides/nics/sfc_efx.rst\nindex ba82b020932b..24459da33ea8 100644\n--- a/doc/guides/nics/sfc_efx.rst\n+++ b/doc/guides/nics/sfc_efx.rst\n@@ -114,6 +114,10 @@ SFC EFX PMD has support for:\n \n - Loopback\n \n+- Configurable Rx CRC stripping (if running firmware variant supports it and\n+ if NIC is configured with single PF per port and without VFs, otherwise\n+ always stripped)\n+\n - SR-IOV PF\n \n - Port representors (see :ref: switch_representation)\n@@ -126,8 +130,6 @@ The features not yet supported include:\n \n - Priority-based flow control\n \n-- Configurable RX CRC stripping (always stripped)\n-\n - Header split on receive\n \n - VLAN filtering\ndiff --git a/doc/guides/rel_notes/release_23_07.rst b/doc/guides/rel_notes/release_23_07.rst\nindex 3db443d16018..738d35d9f7c6 100644\n--- a/doc/guides/rel_notes/release_23_07.rst\n+++ b/doc/guides/rel_notes/release_23_07.rst\n@@ -145,6 +145,8 @@ New Features\n * Added support for transfer flow action INDIRECT with subtype COUNT,\n for aggregated statistics.\n \n+ * Added support for keeping CRC.\n+\n * **Added vmxnet3 version 7 support.**\n \n Added support for vmxnet3 version 7 which includes support\ndiff --git a/drivers/net/sfc/sfc.h b/drivers/net/sfc/sfc.h\nindex 89e2c46fa974..25cdeaa5cd25 100644\n--- a/drivers/net/sfc/sfc.h\n+++ b/drivers/net/sfc/sfc.h\n@@ -74,6 +74,7 @@ struct sfc_port {\n \n \tunsigned int\t\t\tflow_ctrl;\n \tboolean_t\t\t\tflow_ctrl_autoneg;\n+\tboolean_t\t\t\tinclude_fcs;\n \tsize_t\t\t\t\tpdu;\n \n \t/*\ndiff --git a/drivers/net/sfc/sfc_ef100_rx.c b/drivers/net/sfc/sfc_ef100_rx.c\nindex 37b754fa3305..5563bd9a0bd1 100644\n--- a/drivers/net/sfc/sfc_ef100_rx.c\n+++ b/drivers/net/sfc/sfc_ef100_rx.c\n@@ -1004,7 +1004,7 @@ struct sfc_dp_rx sfc_ef100_rx = {\n \t\t\t\t SFC_DP_RX_FEAT_FLOW_MARK |\n \t\t\t\t SFC_DP_RX_FEAT_INTR |\n \t\t\t\t SFC_DP_RX_FEAT_STATS,\n-\t.dev_offload_capa\t= 0,\n+\t.dev_offload_capa\t= RTE_ETH_RX_OFFLOAD_KEEP_CRC,\n \t.queue_offload_capa\t= RTE_ETH_RX_OFFLOAD_CHECKSUM |\n \t\t\t\t RTE_ETH_RX_OFFLOAD_OUTER_IPV4_CKSUM |\n \t\t\t\t RTE_ETH_RX_OFFLOAD_OUTER_UDP_CKSUM |\ndiff --git a/drivers/net/sfc/sfc_ef10_rx.c b/drivers/net/sfc/sfc_ef10_rx.c\nindex 7be224c9c412..30a320d0791c 100644\n--- a/drivers/net/sfc/sfc_ef10_rx.c\n+++ b/drivers/net/sfc/sfc_ef10_rx.c\n@@ -825,7 +825,8 @@ struct sfc_dp_rx sfc_ef10_rx = {\n \t\t\t\t SFC_DP_RX_FEAT_INTR,\n \t.dev_offload_capa\t= RTE_ETH_RX_OFFLOAD_CHECKSUM |\n \t\t\t\t RTE_ETH_RX_OFFLOAD_OUTER_IPV4_CKSUM |\n-\t\t\t\t RTE_ETH_RX_OFFLOAD_RSS_HASH,\n+\t\t\t\t RTE_ETH_RX_OFFLOAD_RSS_HASH |\n+\t\t\t\t RTE_ETH_RX_OFFLOAD_KEEP_CRC,\n \t.queue_offload_capa\t= RTE_ETH_RX_OFFLOAD_SCATTER,\n \t.get_dev_info\t\t= sfc_ef10_rx_get_dev_info,\n \t.qsize_up_rings\t\t= sfc_ef10_rx_qsize_up_rings,\ndiff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c\nindex f120ddc5a8d8..1efe64a36a7f 100644\n--- a/drivers/net/sfc/sfc_ethdev.c\n+++ b/drivers/net/sfc/sfc_ethdev.c\n@@ -689,8 +689,13 @@ sfc_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n \n \tsfc_adapter_lock(sa);\n \n-\tif (have_dp_rx_stats)\n+\tif (have_dp_rx_stats) {\n \t\tsfc_stats_get_dp_rx(sa, &stats->ipackets, &stats->ibytes);\n+\t\tif (dev->data->dev_conf.rxmode.offloads &\n+\t\t RTE_ETH_RX_OFFLOAD_KEEP_CRC) {\n+\t\t\tstats->ibytes -= stats->ipackets * RTE_ETHER_CRC_LEN;\n+\t\t}\n+\t}\n \tif (have_dp_tx_stats)\n \t\tsfc_stats_get_dp_tx(sa, &stats->opackets, &stats->obytes);\n \ndiff --git a/drivers/net/sfc/sfc_port.c b/drivers/net/sfc/sfc_port.c\nindex 0c887ddedb09..3897facfbc5b 100644\n--- a/drivers/net/sfc/sfc_port.c\n+++ b/drivers/net/sfc/sfc_port.c\n@@ -241,6 +241,11 @@ sfc_port_start(struct sfc_adapter *sa)\n \tif (rc != 0)\n \t\tgoto fail_mac_pdu_set;\n \n+\tsfc_log_init(sa, \"set include FCS=%u\", port->include_fcs);\n+\trc = efx_mac_include_fcs_set(sa->nic, port->include_fcs);\n+\tif (rc != 0)\n+\t\tgoto fail_include_fcs_set;\n+\n \tif (!sfc_sa2shared(sa)->isolated) {\n \t\tstruct rte_ether_addr *addr = &port->default_mac_addr;\n \n@@ -328,6 +333,7 @@ sfc_port_start(struct sfc_adapter *sa)\n \t(void)efx_mac_drain(sa->nic, B_TRUE);\n \n fail_mac_drain:\n+fail_include_fcs_set:\n fail_mac_stats_upload:\n \t(void)efx_mac_stats_periodic(sa->nic, &port->mac_stats_dma_mem,\n \t\t\t\t 0, B_FALSE);\n@@ -375,11 +381,17 @@ sfc_port_configure(struct sfc_adapter *sa)\n {\n \tconst struct rte_eth_dev_data *dev_data = sa->eth_dev->data;\n \tstruct sfc_port *port = &sa->port;\n+\tconst struct rte_eth_rxmode *rxmode = &dev_data->dev_conf.rxmode;\n \n \tsfc_log_init(sa, \"entry\");\n \n \tport->pdu = EFX_MAC_PDU(dev_data->mtu);\n \n+\tif (rxmode->offloads & RTE_ETH_RX_OFFLOAD_KEEP_CRC)\n+\t\tport->include_fcs = true;\n+\telse\n+\t\tport->include_fcs = false;\n+\n \treturn 0;\n }\n \ndiff --git a/drivers/net/sfc/sfc_rx.c b/drivers/net/sfc/sfc_rx.c\nindex edd0f0c03842..ac94d973de04 100644\n--- a/drivers/net/sfc/sfc_rx.c\n+++ b/drivers/net/sfc/sfc_rx.c\n@@ -654,7 +654,8 @@ struct sfc_dp_rx sfc_efx_rx = {\n \t},\n \t.features\t\t= SFC_DP_RX_FEAT_INTR,\n \t.dev_offload_capa\t= RTE_ETH_RX_OFFLOAD_CHECKSUM |\n-\t\t\t\t RTE_ETH_RX_OFFLOAD_RSS_HASH,\n+\t\t\t\t RTE_ETH_RX_OFFLOAD_RSS_HASH |\n+\t\t\t\t RTE_ETH_RX_OFFLOAD_KEEP_CRC,\n \t.queue_offload_capa\t= RTE_ETH_RX_OFFLOAD_SCATTER,\n \t.qsize_up_rings\t\t= sfc_efx_rx_qsize_up_rings,\n \t.qcreate\t\t= sfc_efx_rx_qcreate,\n@@ -938,6 +939,9 @@ sfc_rx_get_offload_mask(struct sfc_adapter *sa)\n \tif (encp->enc_tunnel_encapsulations_supported == 0)\n \t\tno_caps |= RTE_ETH_RX_OFFLOAD_OUTER_IPV4_CKSUM;\n \n+\tif (encp->enc_rx_include_fcs_supported == 0)\n+\t\tno_caps |= RTE_ETH_RX_OFFLOAD_KEEP_CRC;\n+\n \treturn ~no_caps;\n }\n \n", "prefixes": [ "v2", "4/4" ] }