Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/128921/?format=api
{ "id": 128921, "url": "http://patchwork.dpdk.org/api/patches/128921/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230622123136.264482-1-artemii.morozov@arknetworks.am/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230622123136.264482-1-artemii.morozov@arknetworks.am>", "list_archive_url": "https://inbox.dpdk.org/dev/20230622123136.264482-1-artemii.morozov@arknetworks.am", "date": "2023-06-22T12:31:36", "name": "[v5] common/sfc_efx/base: fix Rx queue creation without RSS hash prefix", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "552c88e79bcea9a15e1571dfbedae43977a99190", "submitter": { "id": 3083, "url": "http://patchwork.dpdk.org/api/people/3083/?format=api", "name": "Artemii Morozov", "email": "Artemii.Morozov@arknetworks.am" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230622123136.264482-1-artemii.morozov@arknetworks.am/mbox/", "series": [ { "id": 28616, "url": "http://patchwork.dpdk.org/api/series/28616/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28616", "date": "2023-06-22T12:31:36", "name": "[v5] common/sfc_efx/base: fix Rx queue creation without RSS hash prefix", "version": 5, "mbox": "http://patchwork.dpdk.org/series/28616/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/128921/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/128921/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 55DCB42D23;\n\tThu, 22 Jun 2023 14:32:53 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D0799406B8;\n\tThu, 22 Jun 2023 14:32:52 +0200 (CEST)", "from agw.arknetworks.am (agw.arknetworks.am [79.141.165.80])\n by mails.dpdk.org (Postfix) with ESMTP id 1C197406A2;\n Thu, 22 Jun 2023 14:32:51 +0200 (CEST)", "from angrod.. (unknown [141.136.90.242])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by agw.arknetworks.am (Postfix) with ESMTPSA id 26E89E123E;\n Thu, 22 Jun 2023 16:32:51 +0400 (+04)" ], "From": "Artemii Morozov <artemii.morozov@arknetworks.am>", "To": "dev@dpdk.org", "Cc": "Ferruh Yigit <ferruh.yigit@amd.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, stable@dpdk.org,\n Andy Moreton <amoreton@xilinx.com>", "Subject": "[PATCH v5] common/sfc_efx/base: fix Rx queue creation without RSS\n hash prefix", "Date": "Thu, 22 Jun 2023 16:31:36 +0400", "Message-Id": "<20230622123136.264482-1-artemii.morozov@arknetworks.am>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230531070810.93131-1-artemii.morozov@arknetworks.am>", "References": "<20230531070810.93131-1-artemii.morozov@arknetworks.am>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "If the prefix for the RSS hash was not chosen the ENOTSUP error should\nbe returned.\n\nBefore this patch success was returned for this case causing Rx queue\ncreation to fail.\n\nFixing return value to indicate failure.\n\nFixes: f784cdc5cbb1 (\"common/sfc_efx/base: provide control to deliver RSS hash\")\nCc: stable@dpdk.org\n\nSigned-off-by: Artemii Morozov <artemii.morozov@arknetworks.am>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\nAcked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>\n---\nv5: update commit message\n\nv4: add Cc: stable@dpdk.org and transform rss to RSS\n \nv3: update commit log as fix commit\n\nv2: don't use capital letters in email\n\n drivers/common/sfc_efx/base/efx_rx.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/common/sfc_efx/base/efx_rx.c b/drivers/common/sfc_efx/base/efx_rx.c\nindex 68f42f5cac..61726a9f0b 100644\n--- a/drivers/common/sfc_efx/base/efx_rx.c\n+++ b/drivers/common/sfc_efx/base/efx_rx.c\n@@ -937,8 +937,10 @@ efx_rx_qcreate_internal(\n \n \t\trss_hash_field =\n \t\t &erplp->erpl_fields[EFX_RX_PREFIX_FIELD_RSS_HASH];\n-\t\tif (rss_hash_field->erpfi_width_bits == 0)\n+\t\tif (rss_hash_field->erpfi_width_bits == 0) {\n+\t\t\trc = ENOTSUP;\n \t\t\tgoto fail5;\n+\t\t}\n \t}\n \n \tenp->en_rx_qcount++;\n", "prefixes": [ "v5" ] }