Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 129495,
    "url": "http://patchwork.dpdk.org/api/patches/129495/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230712083153.3250798-2-qiming.yang@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20230712083153.3250798-2-qiming.yang@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20230712083153.3250798-2-qiming.yang@intel.com",
    "date": "2023-07-12T08:31:51",
    "name": "[v2,1/3] net/ixgbevf: fix Rx and Tx queue status get",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "bbc229b8c2eb09cd9102224d3ae6f112b364ae36",
    "submitter": {
        "id": 522,
        "url": "http://patchwork.dpdk.org/api/people/522/?format=api",
        "name": "Qiming Yang",
        "email": "qiming.yang@intel.com"
    },
    "delegate": {
        "id": 1540,
        "url": "http://patchwork.dpdk.org/api/users/1540/?format=api",
        "username": "qzhan15",
        "first_name": "Qi",
        "last_name": "Zhang",
        "email": "qi.z.zhang@intel.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230712083153.3250798-2-qiming.yang@intel.com/mbox/",
    "series": [
        {
            "id": 28919,
            "url": "http://patchwork.dpdk.org/api/series/28919/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28919",
            "date": "2023-07-12T08:31:50",
            "name": "fix Rx and Tx queue status get",
            "version": 2,
            "mbox": "http://patchwork.dpdk.org/series/28919/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/129495/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/129495/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6ACFF42E52;\n\tWed, 12 Jul 2023 10:49:58 +0200 (CEST)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 598A741156;\n\tWed, 12 Jul 2023 10:49:58 +0200 (CEST)",
            "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by mails.dpdk.org (Postfix) with ESMTP id F2A5A406BA;\n Wed, 12 Jul 2023 10:49:56 +0200 (CEST)",
            "from fmsmga001.fm.intel.com ([10.253.24.23])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 12 Jul 2023 01:49:32 -0700",
            "from dpdk-qiming3.sh.intel.com ([10.67.111.4])\n by fmsmga001.fm.intel.com with ESMTP; 12 Jul 2023 01:49:30 -0700"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1689151797; x=1720687797;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=DB1cVTM+VXy+6OhhH/4JlYcsJ2Srjsjr08JpRAO6f6Q=;\n b=nd9lymL7P6RbBsmQw6SeEx0S29d5niyvkqqyblwF+fWsVmnfzpLrS0xp\n yyn/jmWBaAwsG+o2A9p3jTc+wdsDYxBqDBkAf/v2DICW6peX3wIkqKko8\n eogt/9Fc/FQEsRucYEWFeVZzLcJl0/X2S42sM2ilo0cP6YCHmcjq7ZbfW\n 95jDT04ys5+mWrvxNS2Yubmk593PTOISiQVl+RKGwf/0WgNG68Wb8NRa1\n mQ+s5ZUhndrV/NGzWA9q4F0R7Nlm9yGh6dAGGhqVK7XcWClvGGEv1+RZ5\n Qk9Cq6629fuSxoQGnb3wvCyCYUx6JyfNWdWqPErLuPbPO2hH8oWf26z4T w==;",
        "X-IronPort-AV": [
            "E=McAfee;i=\"6600,9927,10768\"; a=\"345152449\"",
            "E=Sophos;i=\"6.01,199,1684825200\"; d=\"scan'208\";a=\"345152449\"",
            "E=McAfee;i=\"6600,9927,10768\"; a=\"866036707\"",
            "E=Sophos;i=\"6.01,199,1684825200\"; d=\"scan'208\";a=\"866036707\""
        ],
        "X-ExtLoop1": "1",
        "From": "Qiming Yang <qiming.yang@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "beilei.xing@intel.com, qi.z.zhang@intel.com,\n Qiming Yang <qiming.yang@intel.com>, stable@dpdk.org,\n Jie Hai <haijie1@huawei.com>",
        "Subject": "[PATCH v2 1/3] net/ixgbevf: fix Rx and Tx queue status get",
        "Date": "Wed, 12 Jul 2023 08:31:51 +0000",
        "Message-Id": "<20230712083153.3250798-2-qiming.yang@intel.com>",
        "X-Mailer": "git-send-email 2.25.1",
        "In-Reply-To": "<20230712083153.3250798-1-qiming.yang@intel.com>",
        "References": "<20230712083153.3250798-1-qiming.yang@intel.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "Ixgbevf driver don't enable queue start/stop functions, queue status is not\nupdated when the HW queue enabled or disabled. It caused application can't\nget correct queue status.\nThis patch fixes the issue by updating the queue states when the queue is\ndisabled or enabled.\n\nFixes: 429c6d86b371 (\"ixgbe: prepare for vector pmd\")\nFixes: f0c50e5f56fa (\"ixgbe: move PMD specific fields out of base driver\")\nCc: stable@dpdk.org\n\nSigned-off-by: Qiming Yang <qiming.yang@intel.com>\nSigned-off-by: Jie Hai <haijie1@huawei.com>\n---\n drivers/net/ixgbe/ixgbe_rxtx.c | 6 ++++++\n 1 file changed, 6 insertions(+)",
    "diff": "diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c\nindex 61f17cd90b..954ef241a0 100644\n--- a/drivers/net/ixgbe/ixgbe_rxtx.c\n+++ b/drivers/net/ixgbe/ixgbe_rxtx.c\n@@ -3378,6 +3378,7 @@ ixgbe_dev_clear_queues(struct rte_eth_dev *dev)\n \t\tif (txq != NULL) {\n \t\t\ttxq->ops->release_mbufs(txq);\n \t\t\ttxq->ops->reset(txq);\n+\t\t\tdev->data->tx_queue_state[i] = RTE_ETH_QUEUE_STATE_STOPPED;\n \t\t}\n \t}\n \n@@ -3387,6 +3388,7 @@ ixgbe_dev_clear_queues(struct rte_eth_dev *dev)\n \t\tif (rxq != NULL) {\n \t\t\tixgbe_rx_queue_release_mbufs(rxq);\n \t\t\tixgbe_reset_rx_queue(adapter, rxq);\n+\t\t\tdev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STOPPED;\n \t\t}\n \t}\n \t/* If loopback mode was enabled, reconfigure the link accordingly */\n@@ -5896,6 +5898,8 @@ ixgbevf_dev_rxtx_start(struct rte_eth_dev *dev)\n \t\t} while (--poll_ms && !(txdctl & IXGBE_TXDCTL_ENABLE));\n \t\tif (!poll_ms)\n \t\t\tPMD_INIT_LOG(ERR, \"Could not enable Tx Queue %d\", i);\n+\t\telse\n+\t\t\tdev->data->tx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED;\n \t}\n \tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n \n@@ -5913,6 +5917,8 @@ ixgbevf_dev_rxtx_start(struct rte_eth_dev *dev)\n \t\t} while (--poll_ms && !(rxdctl & IXGBE_RXDCTL_ENABLE));\n \t\tif (!poll_ms)\n \t\t\tPMD_INIT_LOG(ERR, \"Could not enable Rx Queue %d\", i);\n+\t\telse\n+\t\t\tdev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED;\n \t\trte_wmb();\n \t\tIXGBE_WRITE_REG(hw, IXGBE_VFRDT(i), rxq->nb_rx_desc - 1);\n \n",
    "prefixes": [
        "v2",
        "1/3"
    ]
}