Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/130476/?format=api
{ "id": 130476, "url": "http://patchwork.dpdk.org/api/patches/130476/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230817212417.3637080-2-Harjot.Singh@arm.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230817212417.3637080-2-Harjot.Singh@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230817212417.3637080-2-Harjot.Singh@arm.com", "date": "2023-08-17T21:24:17", "name": "[1/1] hash: add SVE support for bulk key lookup", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "97cdc024a4d757db4abf5c2fb24ad54737bb1935", "submitter": { "id": 3154, "url": "http://patchwork.dpdk.org/api/people/3154/?format=api", "name": "Harjot Singh", "email": "Harjot.Singh@arm.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230817212417.3637080-2-Harjot.Singh@arm.com/mbox/", "series": [ { "id": 29267, "url": "http://patchwork.dpdk.org/api/series/29267/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29267", "date": "2023-08-17T21:24:16", "name": "hash: add SVE support for bulk key lookup", "version": 1, "mbox": "http://patchwork.dpdk.org/series/29267/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/130476/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/130476/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6A55243094;\n\tThu, 17 Aug 2023 23:24:43 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6082E410FD;\n\tThu, 17 Aug 2023 23:24:38 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by mails.dpdk.org (Postfix) with ESMTP id 9DC44406A2\n for <dev@dpdk.org>; Thu, 17 Aug 2023 23:24:35 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DB8C11063;\n Thu, 17 Aug 2023 14:25:15 -0700 (PDT)", "from 2u-thunderx2.usa.Arm.com (unknown [10.118.12.78])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D4AF63F6C4;\n Thu, 17 Aug 2023 14:24:34 -0700 (PDT)" ], "From": "Harjot Singh <Harjot.Singh@arm.com>", "To": "Thomas Monjalon <thomas@monjalon.net>,\n Yipeng Wang <yipeng1.wang@intel.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>", "Cc": "dev@dpdk.org, nd@arm.com, Harjot Singh <harjot.singh@arm.com>,\n Nathan Brown <nathan.brown@arm.com>, Feifei Wang <feifei.wang2@arm.com>,\n Jieqiang Wang <jieqiang.wang@arm.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>", "Subject": "[PATCH 1/1] hash: add SVE support for bulk key lookup", "Date": "Thu, 17 Aug 2023 21:24:17 +0000", "Message-Id": "<20230817212417.3637080-2-Harjot.Singh@arm.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230817212417.3637080-1-Harjot.Singh@arm.com>", "References": "<20230817212417.3637080-1-Harjot.Singh@arm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Harjot Singh <harjot.singh@arm.com>\n\n- Implemented Vector Length Agnostic SVE code for comparing signatures\nin bulk lookup.\n- Added Defines in code for SVE code support.\n- New Optimised SVE code is 1-2 CPU cycle slower than NEON for N2\nprocessor.\n\nPerformance Numbers from hash_perf_autotest :\n\nElements in Primary or Secondary Location\n\nResults (in CPU cycles/operation)\n-----------------------------------\n Operations without data\n\nWithout pre-computed hash values\n\nKeysize Add/Lookup/Lookup_bulk\n Neon SVE\n4 93/71/26 93/71/27\n8 93/70/26 93/70/27\n9 94/74/27 94/74/28\n13 100/80/31 100/79/32\n16 100/78/30 100/78/31\n32 109/110/38 108/110/39\n\nWith pre-computed hash values\n\nKeysize Add/Lookup/Lookup_bulk\n Neon SVE\n4 83/58/27 83/58/29\n8 83/57/27 83/57/28\n9 83/60/28 83/60/29\n13 84/60/28 83/60/29\n16 83/58/27 83/58/29\n32 84/68/31 84/68/32\n\nSigned-off-by: Harjot Singh <harjot.singh@arm.com>\nReviewed-by: Nathan Brown <nathan.brown@arm.com>\nReviewed-by: Feifei Wang <feifei.wang2@arm.com>\nReviewed-by: Jieqiang Wang <jieqiang.wang@arm.com>\nReviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\n\n---\n .mailmap | 1 +\n lib/hash/rte_cuckoo_hash.c | 37 ++++++++++++++++++++++++++++++++++++-\n lib/hash/rte_cuckoo_hash.h | 1 +\n 3 files changed, 38 insertions(+), 1 deletion(-)", "diff": "diff --git a/.mailmap b/.mailmap\nindex 864d33ee46..2cce48c900 100644\n--- a/.mailmap\n+++ b/.mailmap\n@@ -481,6 +481,7 @@ Hari Kumar Vemula <hari.kumarx.vemula@intel.com>\n Harini Ramakrishnan <harini.ramakrishnan@microsoft.com>\n Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>\n Harish Patil <harish.patil@cavium.com> <harish.patil@qlogic.com>\n+Harjot Singh <harjot.singh@arm.com>\n Harman Kalra <hkalra@marvell.com>\n Harneet Singh <harneet.singh@intel.com>\n Harold Huang <baymaxhuang@gmail.com>\ndiff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c\nindex d92a903bb3..fdb06eb33e 100644\n--- a/lib/hash/rte_cuckoo_hash.c\n+++ b/lib/hash/rte_cuckoo_hash.c\n@@ -435,8 +435,11 @@ rte_hash_create(const struct rte_hash_parameters *params)\n \t\th->sig_cmp_fn = RTE_HASH_COMPARE_SSE;\n \telse\n #elif defined(RTE_ARCH_ARM64)\n-\tif (rte_cpu_get_flag_enabled(RTE_CPUFLAG_NEON))\n+\tif (rte_cpu_get_flag_enabled(RTE_CPUFLAG_NEON)) {\n \t\th->sig_cmp_fn = RTE_HASH_COMPARE_NEON;\n+\t\tif (rte_cpu_get_flag_enabled(RTE_CPUFLAG_SVE))\n+\t\t\th->sig_cmp_fn = RTE_HASH_COMPARE_SVE;\n+\t}\n \telse\n #endif\n \t\th->sig_cmp_fn = RTE_HASH_COMPARE_SCALAR;\n@@ -1892,6 +1895,38 @@ compare_signatures(uint32_t *prim_hash_matches, uint32_t *sec_hash_matches,\n \t\t*sec_hash_matches = (uint32_t)(vaddvq_u16(x));\n \t\t}\n \t\tbreak;\n+#if defined(RTE_HAS_SVE_ACLE)\n+\tcase RTE_HASH_COMPARE_SVE: {\n+\t\tsvuint16_t vsign, shift, sv_prim_matches, sv_sec_matches;\n+\t\tsvbool_t pred, p_match, s_match;\n+\t\tint i = 0;\n+\t\tuint64_t vl = svcnth();\n+\n+\t\tvsign = svdup_u16(sig);\n+\t\tshift = svindex_u16(0, 2);\n+\t\tdo {\n+\t\t\tpred = svwhilelt_b16(i, RTE_HASH_BUCKET_ENTRIES);\n+\t\t\t/* Compare all signatures in the primary bucket */\n+\t\t\tp_match = svcmpeq_u16(pred, vsign, svld1_u16(pred,\n+\t\t\t\t\t\t&prim_bkt->sig_current[i]));\n+\t\t\tif (svptest_any(svptrue_b16(), p_match)) {\n+\t\t\t\tsv_prim_matches = svdup_u16_z(p_match, 1);\n+\t\t\t\tsv_prim_matches = svlsl_u16_z(pred, sv_prim_matches, shift);\n+\t\t\t\t*prim_hash_matches |= svorv_u16(pred, sv_prim_matches);\n+\t\t\t}\n+\t\t\t/* Compare all signatures in the secondary bucket */\n+\t\t\ts_match = svcmpeq_u16(pred, vsign, svld1_u16(pred,\n+\t\t\t\t\t\t&sec_bkt->sig_current[i]));\n+\t\t\tif (svptest_any(svptrue_b16(), s_match)) {\n+\t\t\t\tsv_sec_matches = svdup_u16_z(s_match, 1);\n+\t\t\t\tsv_sec_matches = svlsl_u16_z(pred, sv_sec_matches, shift);\n+\t\t\t\t*sec_hash_matches |= svorv_u16(pred, sv_sec_matches);\n+\t\t\t}\n+\t\t\ti += vl;\n+\t\t} while (i < RTE_HASH_BUCKET_ENTRIES);\n+\t}\n+\tbreak;\n+#endif\n #endif\n \tdefault:\n \t\tfor (i = 0; i < RTE_HASH_BUCKET_ENTRIES; i++) {\ndiff --git a/lib/hash/rte_cuckoo_hash.h b/lib/hash/rte_cuckoo_hash.h\nindex eb2644f74b..356ec2a69e 100644\n--- a/lib/hash/rte_cuckoo_hash.h\n+++ b/lib/hash/rte_cuckoo_hash.h\n@@ -148,6 +148,7 @@ enum rte_hash_sig_compare_function {\n \tRTE_HASH_COMPARE_SCALAR = 0,\n \tRTE_HASH_COMPARE_SSE,\n \tRTE_HASH_COMPARE_NEON,\n+\tRTE_HASH_COMPARE_SVE,\n \tRTE_HASH_COMPARE_NUM\n };\n \n", "prefixes": [ "1/1" ] }