Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/130873/?format=api
{ "id": 130873, "url": "http://patchwork.dpdk.org/api/patches/130873/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230830103303.2428995-1-artemyko@nvidia.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230830103303.2428995-1-artemyko@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230830103303.2428995-1-artemyko@nvidia.com", "date": "2023-08-30T10:33:03", "name": "eal: fix memory initialization deadlock", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ddd15c5ba6e6e07588223a84923c4a7b5a70e50d", "submitter": { "id": 3172, "url": "http://patchwork.dpdk.org/api/people/3172/?format=api", "name": "Artemy Kovalyov", "email": "artemyko@nvidia.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230830103303.2428995-1-artemyko@nvidia.com/mbox/", "series": [ { "id": 29370, "url": "http://patchwork.dpdk.org/api/series/29370/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29370", "date": "2023-08-30T10:33:03", "name": "eal: fix memory initialization deadlock", "version": 1, "mbox": "http://patchwork.dpdk.org/series/29370/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/130873/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/130873/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B564E41FCC;\n\tWed, 30 Aug 2023 12:34:39 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4BE164027E;\n\tWed, 30 Aug 2023 12:34:39 +0200 (CEST)", "from NAM04-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam04on2056.outbound.protection.outlook.com [40.107.100.56])\n by mails.dpdk.org (Postfix) with ESMTP id 950C140277;\n Wed, 30 Aug 2023 12:34:37 +0200 (CEST)", "from CY5PR19CA0049.namprd19.prod.outlook.com (2603:10b6:930:1a::7)\n by SA1PR12MB6996.namprd12.prod.outlook.com (2603:10b6:806:24f::18) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.18; Wed, 30 Aug\n 2023 10:34:35 +0000", "from CY4PEPF0000E9D1.namprd03.prod.outlook.com\n (2603:10b6:930:1a:cafe::91) by CY5PR19CA0049.outlook.office365.com\n (2603:10b6:930:1a::7) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.20 via Frontend\n Transport; Wed, 30 Aug 2023 10:34:35 +0000", "from mail.nvidia.com (216.228.117.161) by\n CY4PEPF0000E9D1.mail.protection.outlook.com (10.167.241.144) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.6745.16 via Frontend Transport; Wed, 30 Aug 2023 10:34:35 +0000", "from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com\n (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Wed, 30 Aug 2023\n 03:34:22 -0700", "from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail205.nvidia.com\n (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Wed, 30 Aug\n 2023 03:34:21 -0700", "from nvidia.com (10.127.8.9) by mail.nvidia.com (10.129.68.8) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37 via Frontend\n Transport; Wed, 30 Aug 2023 03:34:19 -0700" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=mfBprrdgrL31O8w2flbS+7HtLiL9ra3fgBE0FbEdpp7n9uJiJ0rzQs4Bk5hxG1KW4+8iH8kGO1kKRBEXJVopuN0745U51TSOmAM2kWGiWljXf3BhS0L5zcN6voZA9uKAcdetgLZ76TzMN2+cw7CXA4WRAzCuPYelt+k9/xe0UPfpw0LGxe9xIXbTLp07AXHG6/ABgdfOGofmnxguW1U5Wu3l6LIk/ykyzM3cdAteTKZhPOvVM6XXmtsVxDvianWXb0tPPjy2wxsdIVck7wD7rdpciszDkH0Uqupx3/D6YqxtlfylQekL6y+cM2qJ9NK9hZqoI9IZL0/6tl+UHi7LXg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=XIIrphqzA7XEf46xUiGzNh9E8mto4ugX1uB97qKuDQ4=;\n b=VgpHw/u6D1e+roy7EShm5dT1PEHNDNcmLfcO/4l7gMC4uo2uP4N6jC+v3F/sNLQMvxI6mki3Eyggiaow54TUt/Q7RE1NkrmnR2Ha8zehDo2yAm1jDJLl8DbwJNs/Sfh6/oBAj9uYeKGtbBU0JYmCr84p4dm4wGN8jT1Wr9/VcFUqN5/fK7ExiY1/LHTwRClqdRoD+QXPlI9L14KHXEkWhEjMof6ZSpcNstH2psHS01GQst3y5ltTKueaAcdsXQAK4bue0jkAeoX6QjZqvPMxPEunyFXOSHWv1mZhpUg3SX3fAgzykSEUdZ7fmfOhemvjjDJQ6CfH1SFQqlDPF0Dm+Q==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=XIIrphqzA7XEf46xUiGzNh9E8mto4ugX1uB97qKuDQ4=;\n b=nku3NadNnGVHQczypVW5ar3PTnPe6GGGE666OxrcDDz108LT6PBdlu9ryT2jOvDEqc/I07jW/h9F6Uc4ylL7MzO+LUQu8YFwOvd13KGqU8HcPSGIu1gbruHgkzM2SKJ+99t7wAStSipIPLdPXLAdz2ux9GD59nCeGRjkoPCmnUnTzwN/6dyDWXATQZr9TD2S4diVkPmtfaP7ZiGhuSxc2ZEswp68S/i9uJVdaZ+DNdo/GL1qh1vl/6l2cYAHFkUsrOMFHGUZ3Osa1ka30ePsuGwSEp3rSORkefCd2dsixnnQJiHc7SMRcsx5mZ3AhEFKJ9u/ZbRjOAEDFigTlnLSXw==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.161)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.161 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C", "From": "Artemy Kovalyov <artemyko@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "Thomas Monjalon <thomas@monjalon.net>, Ophir Munk <ophirmu@nvidia.com>,\n <stable@dpdk.org>, Anatoly Burakov <anatoly.burakov@intel.com>,\n \"Stephen Hemminger\" <stephen@networkplumber.org>, =?utf-8?q?Morten_Br=C3=B8?=\n\t=?utf-8?q?rup?= <mb@smartsharesystems.com>", "Subject": "[PATCH] eal: fix memory initialization deadlock", "Date": "Wed, 30 Aug 2023 13:33:03 +0300", "Message-ID": "<20230830103303.2428995-1-artemyko@nvidia.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-NV-OnPremToCloud": "ExternallySecured", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "CY4PEPF0000E9D1:EE_|SA1PR12MB6996:EE_", "X-MS-Office365-Filtering-Correlation-Id": "352c7254-2104-4bd9-32fc-08dba944b474", "X-LD-Processed": "43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n gfKJ6GOGQ7qIyK+Wy2D0sWi8M9By5c+2CB0uoNOJ/HyDOjypkLryFQBP7WlEhx6TAmSQ1A6DXmZjgvrBdOd18MoTsa5FpXmI6UhFjw/PPRuUyanj3y3JpcTDzaYPusvG/im1IrnTqgfCLyvlncaI2FPsItx6i6TiEsoFlNznfF5hMHbvVYPhDMq8nv3OfwtgVU8Lk8v0+oNRQ4IX8TJxvaFmtxqzNWUOJdF+6153Dj8NFu/YD492W/5tyinNipEtcBvm/ZHGrH70xKSQqanIWENRsrF2TgWZV/cKrIh9O6tXhFUhXKZ/7otnO2yqAoyx6KKZRgwN+dI+JzqjOpdfrwKEO0VIuVLOdBGggTFmPJ/QATDot8m0elsyq4fdm3SA0FKjaC3MJr8Z6fAgyfoJKjsh+0fNHMvVtspnt3lwJIobaGBUkE8p0zT5ymaB2IqUaFkYMpvfz5bipI+CxRtFo4bKPm3x3EbGbfpwu1X8tGNh1ntIU5ZjUufIcbVvEaDyxfWi5ZisfaWc1fjPx4L6gTohzLgaPmHprFOtGAsrU2LC/RX+xSMPXHlQBKa5VO2xi4nltur1Zy12N1OarrpI6+wzdS166Qx04GVEP1wBcvq63G6QKihpvNtCNUCvYv7GTqjef9PrMtrAX/JtzM9M1aO9Xh8KcnqgLDa/MVvtwujZ70icjT+xQFOS3vHOWv5Z93kP9KsCKHXFLd18WZM4IPhy1oZNVwG9GjdRJsxuNxc+rvK2Ap+ieMdsAC8KzhQJ", "X-Forefront-Antispam-Report": "CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE;\n SFS:(13230031)(4636009)(39860400002)(396003)(376002)(136003)(346002)(451199024)(82310400011)(1800799009)(186009)(40470700004)(36840700001)(46966006)(40460700003)(316002)(41300700001)(6916009)(4326008)(336012)(426003)(6286002)(2906002)(47076005)(86362001)(2616005)(55016003)(8676002)(5660300002)(26005)(83380400001)(36756003)(1076003)(40480700001)(36860700001)(8936002)(6666004)(7636003)(356005)(82740400003)(7696005)(54906003)(70206006)(70586007)(478600001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "30 Aug 2023 10:34:35.2191 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 352c7254-2104-4bd9-32fc-08dba944b474", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CY4PEPF0000E9D1.namprd03.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "SA1PR12MB6996", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The issue arose due to the change in the DPDK read-write lock\nimplementation. That change added a new flag, RTE_RWLOCK_WAIT, designed\nto prevent new read locks while a write lock is in the queue. However,\nthis change has led to a scenario where a recursive read lock, where a\nlock is acquired twice by the same execution thread, can initiate a\nsequence of events resulting in a deadlock:\n\nProcess 1 takes the first read lock.\nProcess 2 attempts to take a write lock, triggering RTE_RWLOCK_WAIT due\nto the presence of a read lock. This makes process 2 enter a wait loop\nuntil the read lock is released.\nProcess 1 tries to take a second read lock. However, since a write lock\nis waiting (due to RTE_RWLOCK_WAIT), it also enters a wait loop until\nthe write lock is acquired and then released.\n\nBoth processes end up in a blocked state, unable to proceed, resulting\nin a deadlock scenario.\n\nFollowing these changes, the RW-lock no longer supports\nrecursion, implying that a single thread shouldn't obtain a read lock if\nit already possesses one. The problem arises during initialization: the\nrte_eal_init() function acquires the memory_hotplug_lock, and later on,\nthe sequence of calls rte_eal_memory_init() -> eal_memalloc_init() ->\nrte_memseg_list_walk() acquires it again without releasing it. This\nscenario introduces the risk of a potential deadlock when concurrent\nwrite locks are applied to the same memory_hotplug_lock. To address this\nwe resolved the issue by replacing rte_memseg_list_walk() with\nrte_memseg_list_walk_thread_unsafe().\n\nBugzilla ID: 1277\nFixes: 832cecc03d77 (\"rwlock: prevent readers from starving writers\")\nCc: stable@dpdk.org\n\nSigned-off-by: Artemy Kovalyov <artemyko@nvidia.com>\n---\n lib/eal/include/generic/rte_rwlock.h | 4 ++++\n lib/eal/linux/eal_memalloc.c | 7 +++++--\n 2 files changed, 9 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/eal/include/generic/rte_rwlock.h b/lib/eal/include/generic/rte_rwlock.h\nindex 9e083bbc61..c98fc7d083 100644\n--- a/lib/eal/include/generic/rte_rwlock.h\n+++ b/lib/eal/include/generic/rte_rwlock.h\n@@ -80,6 +80,10 @@ rte_rwlock_init(rte_rwlock_t *rwl)\n /**\n * Take a read lock. Loop until the lock is held.\n *\n+ * @note The RW lock isn't recursive, so calling this function on the same\n+ * lock twice without releasing it could potentially result in a deadlock\n+ * scenario when a write lock is involved.\n+ *\n * @param rwl\n * A pointer to a rwlock structure.\n */\ndiff --git a/lib/eal/linux/eal_memalloc.c b/lib/eal/linux/eal_memalloc.c\nindex f8b1588cae..3705b41f5f 100644\n--- a/lib/eal/linux/eal_memalloc.c\n+++ b/lib/eal/linux/eal_memalloc.c\n@@ -1740,7 +1740,10 @@ eal_memalloc_init(void)\n \t\teal_get_internal_configuration();\n \n \tif (rte_eal_process_type() == RTE_PROC_SECONDARY)\n-\t\tif (rte_memseg_list_walk(secondary_msl_create_walk, NULL) < 0)\n+\t\t/* memory_hotplug_lock is taken in rte_eal_init(), so it's\n+\t\t * safe to call thread-unsafe version.\n+\t\t */\n+\t\tif (rte_memseg_list_walk_thread_unsafe(secondary_msl_create_walk, NULL) < 0)\n \t\t\treturn -1;\n \tif (rte_eal_process_type() == RTE_PROC_PRIMARY &&\n \t\t\tinternal_conf->in_memory) {\n@@ -1778,7 +1781,7 @@ eal_memalloc_init(void)\n \t}\n \n \t/* initialize all of the fd lists */\n-\tif (rte_memseg_list_walk(fd_list_create_walk, NULL))\n+\tif (rte_memseg_list_walk_thread_unsafe(fd_list_create_walk, NULL))\n \t\treturn -1;\n \treturn 0;\n }\n", "prefixes": [] }