Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/132330/?format=api
{ "id": 132330, "url": "http://patchwork.dpdk.org/api/patches/132330/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231005062513.29467-1-hkalra@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231005062513.29467-1-hkalra@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231005062513.29467-1-hkalra@marvell.com", "date": "2023-10-05T06:25:12", "name": "[1/2] common/cnxk: fix handling up and down interrupts", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "7d91bf419ea2d9916a8b23c9857f8d31b232fece", "submitter": { "id": 1182, "url": "http://patchwork.dpdk.org/api/people/1182/?format=api", "name": "Harman Kalra", "email": "hkalra@marvell.com" }, "delegate": { "id": 310, "url": "http://patchwork.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231005062513.29467-1-hkalra@marvell.com/mbox/", "series": [ { "id": 29742, "url": "http://patchwork.dpdk.org/api/series/29742/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29742", "date": "2023-10-05T06:25:12", "name": "[1/2] common/cnxk: fix handling up and down interrupts", "version": 1, "mbox": "http://patchwork.dpdk.org/series/29742/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/132330/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/132330/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 15EDC426BE;\n\tThu, 5 Oct 2023 08:25:35 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 16458402B3;\n\tThu, 5 Oct 2023 08:25:33 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id C5305402A9\n for <dev@dpdk.org>; Thu, 5 Oct 2023 08:25:31 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 39543DH5016272 for <dev@dpdk.org>; Wed, 4 Oct 2023 23:25:31 -0700", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3th2b6mw9t-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Wed, 04 Oct 2023 23:25:30 -0700", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Wed, 4 Oct 2023 23:25:29 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Wed, 4 Oct 2023 23:25:28 -0700", "from localhost.localdomain (unknown [10.29.52.211])\n by maili.marvell.com (Postfix) with ESMTP id 247DD3F7043;\n Wed, 4 Oct 2023 23:25:21 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : mime-version : content-type; s=pfpt0220;\n bh=/ThXy0kb8HxiBnLa7ORl/fuRQSNm/LinJ+1uvEKHlU8=;\n b=FhZn4+rakxKJ02CA0q2LBlCCyjUH0A29+hu7eIpVYd2oLnVNfha0zCwklCXigzBbLXUx\n Z6DMBTWItPWTU/EFASDNhY2ZdiflhbiLlfazWlGeprTv/1NCyichr8g8srlWWWVK176i\n hNiMBNVrP3r1M2YXlEeXpCEhk2vadFVZkFewLV/JywwQwIZh3PSFdGo5Ypa9OkQR5J2t\n qJsC6OVaioF55PJXp9cbgueEF8Yza8uY50cQVHrlwfbXtBI37ZYPOl/eZJmkxBV3+5ZO\n gGBpooZK5MiQg7P0+4i/sIbD8IEnJW183NpdEt9IkUjeyjl3Km7wd5B88pFvkd8wDxGC zQ==", "From": "Harman Kalra <hkalra@marvell.com>", "To": "<jerinj@marvell.com>, Nithin Dabilpuram <ndabilpuram@marvell.com>, \"Kiran\n Kumar K\" <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>,\n Satha Rao <skoteshwar@marvell.com>", "CC": "<dev@dpdk.org>, Harman Kalra <hkalra@marvell.com>", "Subject": "[PATCH 1/2] common/cnxk: fix handling up and down interrupts", "Date": "Thu, 5 Oct 2023 11:55:12 +0530", "Message-ID": "<20231005062513.29467-1-hkalra@marvell.com>", "X-Mailer": "git-send-email 2.18.0", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "T01sBXN4k8wdFZpYPNMJb5qPpwPDAJio", "X-Proofpoint-GUID": "T01sBXN4k8wdFZpYPNMJb5qPpwPDAJio", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26\n definitions=2023-10-05_03,2023-10-02_01,2023-05-22_02", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Down messages should be processed only when down interrupt is received\nwhile UP messages should be processed when up interrupt is received.\nA scenario has been observed where processing down message on UP\nmessage interrupt causes processing of old message response while\nresponse of latest message is not received.\n\nFixes: fa4ee2d43188 (\"common/cnxk: sync between mbox up and down messages\")\n\nSigned-off-by: Harman Kalra <hkalra@marvell.com>\n---\n drivers/common/cnxk/roc_dev.c | 40 ++++++++++++++++++++++++-----------\n 1 file changed, 28 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/common/cnxk/roc_dev.c b/drivers/common/cnxk/roc_dev.c\nindex e41235ea8a..c948caba63 100644\n--- a/drivers/common/cnxk/roc_dev.c\n+++ b/drivers/common/cnxk/roc_dev.c\n@@ -770,14 +770,22 @@ roc_pf_vf_mbox_irq(void *param)\n \t * by 1ms until this region is zeroed mbox_wait_for_zero()\n \t */\n \tmbox_data = plt_read64(dev->bar2 + RVU_VF_VFPF_MBOX0);\n-\tif (mbox_data)\n-\t\tplt_write64(!mbox_data, dev->bar2 + RVU_VF_VFPF_MBOX0);\n+\t/* If interrupt occurred for down message */\n+\tif (mbox_data & MBOX_DOWN_MSG) {\n+\t\tmbox_data &= ~MBOX_DOWN_MSG;\n+\t\tplt_write64(mbox_data, dev->bar2 + RVU_VF_VFPF_MBOX0);\n \n-\t/* First process all configuration messages */\n-\tprocess_msgs(dev, dev->mbox);\n+\t\t/* First process all configuration messages */\n+\t\tprocess_msgs(dev, dev->mbox);\n+\t}\n+\t/* If interrupt occurred for UP message */\n+\tif (mbox_data & MBOX_UP_MSG) {\n+\t\tmbox_data &= ~MBOX_UP_MSG;\n+\t\tplt_write64(mbox_data, dev->bar2 + RVU_VF_VFPF_MBOX0);\n \n-\t/* Process Uplink messages */\n-\tprocess_msgs_up(dev, &dev->mbox_up);\n+\t\t/* Process Uplink messages */\n+\t\tprocess_msgs_up(dev, &dev->mbox_up);\n+\t}\n }\n \n /* IRQ to PF from AF - PF context (interrupt thread) */\n@@ -799,14 +807,22 @@ roc_af_pf_mbox_irq(void *param)\n \t * by 1ms until this region is zeroed mbox_wait_for_zero()\n \t */\n \tmbox_data = plt_read64(dev->bar2 + RVU_PF_PFAF_MBOX0);\n-\tif (mbox_data)\n-\t\tplt_write64(!mbox_data, dev->bar2 + RVU_PF_PFAF_MBOX0);\n+\t/* If interrupt occurred for down message */\n+\tif (mbox_data & MBOX_DOWN_MSG) {\n+\t\tmbox_data &= ~MBOX_DOWN_MSG;\n+\t\tplt_write64(mbox_data, dev->bar2 + RVU_PF_PFAF_MBOX0);\n \n-\t/* First process all configuration messages */\n-\tprocess_msgs(dev, dev->mbox);\n+\t\t/* First process all configuration messages */\n+\t\tprocess_msgs(dev, dev->mbox);\n+\t}\n+\t/* If interrupt occurred for up message */\n+\tif (mbox_data & MBOX_UP_MSG) {\n+\t\tmbox_data &= ~MBOX_UP_MSG;\n+\t\tplt_write64(mbox_data, dev->bar2 + RVU_PF_PFAF_MBOX0);\n \n-\t/* Process Uplink messages */\n-\tprocess_msgs_up(dev, &dev->mbox_up);\n+\t\t/* Process Uplink messages */\n+\t\tprocess_msgs_up(dev, &dev->mbox_up);\n+\t}\n }\n \n static int\n", "prefixes": [ "1/2" ] }