Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/132382/?format=api
{ "id": 132382, "url": "http://patchwork.dpdk.org/api/patches/132382/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231007071559.3453852-1-jieqiang.wang@arm.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231007071559.3453852-1-jieqiang.wang@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231007071559.3453852-1-jieqiang.wang@arm.com", "date": "2023-10-07T07:15:59", "name": "[v2] hash: fix SSE comparison", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "541959b81246ca0211413b7824379c36bace31d5", "submitter": { "id": 3129, "url": "http://patchwork.dpdk.org/api/people/3129/?format=api", "name": "Jieqiang Wang", "email": "jieqiang.wang@arm.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231007071559.3453852-1-jieqiang.wang@arm.com/mbox/", "series": [ { "id": 29759, "url": "http://patchwork.dpdk.org/api/series/29759/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29759", "date": "2023-10-07T07:15:59", "name": "[v2] hash: fix SSE comparison", "version": 2, "mbox": "http://patchwork.dpdk.org/series/29759/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/132382/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/132382/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A76EE426DC;\n\tSat, 7 Oct 2023 09:16:43 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 332CF4029C;\n\tSat, 7 Oct 2023 09:16:43 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by mails.dpdk.org (Postfix) with ESMTP id 6908840293;\n Sat, 7 Oct 2023 09:16:42 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5E506C15;\n Sat, 7 Oct 2023 00:17:21 -0700 (PDT)", "from net-x86-dell-8268.shanghai.arm.com\n (net-x86-dell-8268.shanghai.arm.com [10.169.210.116])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id DC03D3F762;\n Sat, 7 Oct 2023 00:16:37 -0700 (PDT)" ], "From": "Jieqiang Wang <jieqiang.wang@arm.com>", "To": "Yipeng Wang <yipeng1.wang@intel.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Dharmik Thakkar <dharmik.thakkar@arm.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>", "Cc": "dev@dpdk.org, nd@arm.com, Jieqiang Wang <jieqiang.wang@arm.com>,\n stable@dpdk.org, Feifei Wang <feifei.wang2@arm.com>,\n Ruifeng Wang <ruifeng.wang@arm.com>", "Subject": "[PATCH v2] hash: fix SSE comparison", "Date": "Sat, 7 Oct 2023 15:15:59 +0800", "Message-Id": "<20231007071559.3453852-1-jieqiang.wang@arm.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230906023100.3618303-1-jieqiang.wang@arm.com>", "References": "<20230906023100.3618303-1-jieqiang.wang@arm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "__mm_cmpeq_epi16 returns 0xFFFF if the corresponding 16-bit elements are\nequal. In original SSE2 implementation for function compare_signatures,\nit utilizes _mm_movemask_epi8 to create mask from the MSB of each 8-bit\nelement, while we should only care about the MSB of lower 8-bit in each\n16-bit element.\nFor example, if the comparison result is all equal, SSE2 path returns\n0xFFFF while NEON and default scalar path return 0x5555.\nAlthough this bug is not causing any negative effects since the caller\nfunction solely examines the trailing zeros of each match mask, we\nrecommend this fix to ensure consistency with NEON and default scalar\ncode behaviors.\n\nFixes: c7d93df552c2 (\"hash: use partial-key hashing\")\nCc: stable@dpdk.org\n\nSigned-off-by: Feifei Wang <feifei.wang2@arm.com>\nSigned-off-by: Jieqiang Wang <jieqiang.wang@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n lib/hash/rte_cuckoo_hash.c | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c\nindex d92a903bb3..d348d45246 100644\n--- a/lib/hash/rte_cuckoo_hash.c\n+++ b/lib/hash/rte_cuckoo_hash.c\n@@ -1868,11 +1868,15 @@ compare_signatures(uint32_t *prim_hash_matches, uint32_t *sec_hash_matches,\n \t\t\t\t_mm_load_si128(\n \t\t\t\t\t(__m128i const *)prim_bkt->sig_current),\n \t\t\t\t_mm_set1_epi16(sig)));\n+ /* Extract the even-index bits only */\n+ *prim_hash_matches &= 0x5555;\n \t\t/* Compare all signatures in the bucket */\n \t\t*sec_hash_matches = _mm_movemask_epi8(_mm_cmpeq_epi16(\n \t\t\t\t_mm_load_si128(\n \t\t\t\t\t(__m128i const *)sec_bkt->sig_current),\n \t\t\t\t_mm_set1_epi16(sig)));\n+ /* Extract the even-index bits only */\n+ *sec_hash_matches &= 0x5555;\n \t\tbreak;\n #elif defined(__ARM_NEON)\n \tcase RTE_HASH_COMPARE_NEON: {\n", "prefixes": [ "v2" ] }