Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/132428/?format=api
{ "id": 132428, "url": "http://patchwork.dpdk.org/api/patches/132428/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/d789735781888601bec1aa6d1fd7f5a5d27b06e2.1696859505.git.gmuthukrishn@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<d789735781888601bec1aa6d1fd7f5a5d27b06e2.1696859505.git.gmuthukrishn@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/d789735781888601bec1aa6d1fd7f5a5d27b06e2.1696859505.git.gmuthukrishn@marvell.com", "date": "2023-10-09T13:54:50", "name": "[v4,3/7] cryptodev: use generic EC xform params for SM2", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b4077d7f94ea8a3dc8815ca31b361f70561d562f", "submitter": { "id": 2301, "url": "http://patchwork.dpdk.org/api/people/2301/?format=api", "name": "Gowrishankar Muthukrishnan", "email": "gmuthukrishn@marvell.com" }, "delegate": { "id": 6690, "url": "http://patchwork.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/d789735781888601bec1aa6d1fd7f5a5d27b06e2.1696859505.git.gmuthukrishn@marvell.com/mbox/", "series": [ { "id": 29773, "url": "http://patchwork.dpdk.org/api/series/29773/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29773", "date": "2023-10-09T13:54:47", "name": "cryptodev: support digest message in SM2", "version": 4, "mbox": "http://patchwork.dpdk.org/series/29773/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/132428/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/132428/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6D58C4233C;\n\tMon, 9 Oct 2023 15:55:26 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 08B2D406BC;\n\tMon, 9 Oct 2023 15:55:15 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 406B840A6F\n for <dev@dpdk.org>; Mon, 9 Oct 2023 15:55:13 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 399CpdlN008257; Mon, 9 Oct 2023 06:55:12 -0700", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3tkh7ccd83-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Mon, 09 Oct 2023 06:55:12 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Mon, 9 Oct 2023 06:55:10 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Mon, 9 Oct 2023 06:55:10 -0700", "from BG-LT91401.marvell.com (BG-LT91401.marvell.com [10.28.168.34])\n by maili.marvell.com (Postfix) with ESMTP id A44B03F70A4;\n Mon, 9 Oct 2023 06:55:07 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=RWI3ku3OzPmqnYwvaTdp4Z0xqZs9YhHk0iUhuMuY1hc=;\n b=Uew5oPtgFqaNnqog4gARf/tLb75k8mqwQjEHrfoVU23GHAzM7snr4HjiKDFKrVX8bQLm\n ocoRbCq2PsnR7g5t7AXbwrknzUywXvi2FgIyl3a7xHAaJlCIQrcngHglUnSI5T7S4B47\n irMaW52/MpwOzxrYtxcsjOiU3O4Km2FrfA6ODi7+jKt2B5RwccZYQVgzOIC812iQA3SG\n zHdtZa/MheqFzb792kSqxhHhl9LmME/+ACUOoNLGueUKk2Dndx+Acwc8Oc9KraM4+IH0\n BmdUiDxBEk0TFa5e+Sf2jVL5kzwjrzxhsWwF9waa3BrQ/sV8hznGhqK0vR7+7/l25xyQ PQ==", "From": "Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>", "To": "<dev@dpdk.org>", "CC": "<anoobj@marvell.com>, Akhil Goyal <gakhil@marvell.com>, Fan Zhang\n <fanzhang.oss@gmail.com>, Kai Ji <kai.ji@intel.com>, Arkadiusz Kusztal\n <arkadiuszx.kusztal@intel.com>, Ciara Power <ciara.power@intel.com>,\n Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>", "Subject": "[PATCH v4 3/7] cryptodev: use generic EC xform params for SM2", "Date": "Mon, 9 Oct 2023 19:24:50 +0530", "Message-ID": "\n <d789735781888601bec1aa6d1fd7f5a5d27b06e2.1696859505.git.gmuthukrishn@marvell.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<cover.1696859505.git.gmuthukrishn@marvell.com>", "References": "<cover.1696859505.git.gmuthukrishn@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-GUID": "uDILLAjgF9dTDaJ4Cz9d9udRleTDvHSx", "X-Proofpoint-ORIG-GUID": "uDILLAjgF9dTDaJ4Cz9d9udRleTDvHSx", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26\n definitions=2023-10-09_11,2023-10-09_01,2023-05-22_02", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "SM2 curve could use generic EC xform as it is yet another EC.\nThis would also require SM2 curve ID enumerated\nalong with other curves, as listed in:\nhttps://www.iana.org/assignments/tls-parameters/tls-parameters.xhtml\n\nSigned-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>\nAcked-by: Arkadiusz Kusztal <arkadiuszx.kusztal@intel.com>\n---\n app/test/test_cryptodev_asym.c | 40 ++++++++++++--------\n app/test/test_cryptodev_sm2_test_vectors.h | 4 +-\n doc/guides/rel_notes/release_23_11.rst | 2 +\n drivers/crypto/openssl/rte_openssl_pmd_ops.c | 3 --\n lib/cryptodev/rte_crypto_asym.h | 19 +++-------\n 5 files changed, 34 insertions(+), 34 deletions(-)", "diff": "diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c\nindex af323e02d9..514ea96b8b 100644\n--- a/app/test/test_cryptodev_asym.c\n+++ b/app/test/test_cryptodev_asym.c\n@@ -1846,10 +1846,7 @@ _test_sm2_sign(bool rnd_secret)\n \t/* Setup asym xform */\n \txform.next = NULL;\n \txform.xform_type = RTE_CRYPTO_ASYM_XFORM_SM2;\n-\tif (rte_cryptodev_asym_xform_capability_check_hash(capa, RTE_CRYPTO_AUTH_SM3))\n-\t\txform.sm2.hash = RTE_CRYPTO_AUTH_SM3;\n-\telse\n-\t\txform.sm2.hash = RTE_CRYPTO_AUTH_NULL;\n+\txform.ec.curve_id = input_params.curve;\n \n \tret = rte_cryptodev_asym_session_create(dev_id, &xform, sess_mpool, &sess);\n \tif (ret < 0) {\n@@ -1867,6 +1864,11 @@ _test_sm2_sign(bool rnd_secret)\n \n \t/* Populate op with operational details */\n \tasym_op->sm2.op_type = RTE_CRYPTO_ASYM_OP_SIGN;\n+\tif (rte_cryptodev_asym_xform_capability_check_hash(capa, RTE_CRYPTO_AUTH_SM3))\n+\t\tasym_op->sm2.hash = RTE_CRYPTO_AUTH_SM3;\n+\telse\n+\t\tasym_op->sm2.hash = RTE_CRYPTO_AUTH_NULL;\n+\n \tasym_op->sm2.message.data = input_params.message.data;\n \tasym_op->sm2.message.length = input_params.message.length;\n \tasym_op->sm2.pkey.data = input_params.pkey.data;\n@@ -2038,10 +2040,7 @@ test_sm2_verify(void)\n \t/* Setup asym xform */\n \txform.next = NULL;\n \txform.xform_type = RTE_CRYPTO_ASYM_XFORM_SM2;\n-\tif (rte_cryptodev_asym_xform_capability_check_hash(capa, RTE_CRYPTO_AUTH_SM3))\n-\t\txform.sm2.hash = RTE_CRYPTO_AUTH_SM3;\n-\telse\n-\t\txform.sm2.hash = RTE_CRYPTO_AUTH_NULL;\n+\txform.ec.curve_id = input_params.curve;\n \n \tret = rte_cryptodev_asym_session_create(dev_id, &xform, sess_mpool, &sess);\n \tif (ret < 0) {\n@@ -2059,6 +2058,11 @@ test_sm2_verify(void)\n \n \t/* Populate op with operational details */\n \tasym_op->sm2.op_type = RTE_CRYPTO_ASYM_OP_VERIFY;\n+\tif (rte_cryptodev_asym_xform_capability_check_hash(capa, RTE_CRYPTO_AUTH_SM3))\n+\t\tasym_op->sm2.hash = RTE_CRYPTO_AUTH_SM3;\n+\telse\n+\t\tasym_op->sm2.hash = RTE_CRYPTO_AUTH_NULL;\n+\n \tasym_op->sm2.message.data = input_params.message.data;\n \tasym_op->sm2.message.length = input_params.message.length;\n \tasym_op->sm2.pkey.data = input_params.pkey.data;\n@@ -2150,10 +2154,7 @@ _test_sm2_enc(bool rnd_secret)\n \t/* Setup asym xform */\n \txform.next = NULL;\n \txform.xform_type = RTE_CRYPTO_ASYM_XFORM_SM2;\n-\tif (rte_cryptodev_asym_xform_capability_check_hash(capa, RTE_CRYPTO_AUTH_SM3))\n-\t\txform.sm2.hash = RTE_CRYPTO_AUTH_SM3;\n-\telse\n-\t\txform.sm2.hash = RTE_CRYPTO_AUTH_NULL;\n+\txform.ec.curve_id = input_params.curve;\n \n \tret = rte_cryptodev_asym_session_create(dev_id, &xform, sess_mpool, &sess);\n \tif (ret < 0) {\n@@ -2171,6 +2172,11 @@ _test_sm2_enc(bool rnd_secret)\n \n \t/* Populate op with operational details */\n \tasym_op->sm2.op_type = RTE_CRYPTO_ASYM_OP_ENCRYPT;\n+\tif (rte_cryptodev_asym_xform_capability_check_hash(capa, RTE_CRYPTO_AUTH_SM3))\n+\t\tasym_op->sm2.hash = RTE_CRYPTO_AUTH_SM3;\n+\telse\n+\t\tasym_op->sm2.hash = RTE_CRYPTO_AUTH_NULL;\n+\n \tasym_op->sm2.message.data = input_params.message.data;\n \tasym_op->sm2.message.length = input_params.message.length;\n \tasym_op->sm2.pkey.data = input_params.pkey.data;\n@@ -2340,10 +2346,7 @@ test_sm2_dec(void)\n \t/* Setup asym xform */\n \txform.next = NULL;\n \txform.xform_type = RTE_CRYPTO_ASYM_XFORM_SM2;\n-\tif (rte_cryptodev_asym_xform_capability_check_hash(capa, RTE_CRYPTO_AUTH_SM3))\n-\t\txform.sm2.hash = RTE_CRYPTO_AUTH_SM3;\n-\telse\n-\t\txform.sm2.hash = RTE_CRYPTO_AUTH_NULL;\n+\txform.ec.curve_id = input_params.curve;\n \n \tret = rte_cryptodev_asym_session_create(dev_id, &xform, sess_mpool, &sess);\n \tif (ret < 0) {\n@@ -2361,6 +2364,11 @@ test_sm2_dec(void)\n \n \t/* Populate op with operational details */\n \tasym_op->sm2.op_type = RTE_CRYPTO_ASYM_OP_DECRYPT;\n+\tif (rte_cryptodev_asym_xform_capability_check_hash(capa, RTE_CRYPTO_AUTH_SM3))\n+\t\tasym_op->sm2.hash = RTE_CRYPTO_AUTH_SM3;\n+\telse\n+\t\tasym_op->sm2.hash = RTE_CRYPTO_AUTH_NULL;\n+\n \tasym_op->sm2.cipher.data = input_params.cipher.data;\n \tasym_op->sm2.cipher.length = input_params.cipher.length;\n \tasym_op->sm2.pkey.data = input_params.pkey.data;\ndiff --git a/app/test/test_cryptodev_sm2_test_vectors.h b/app/test/test_cryptodev_sm2_test_vectors.h\nindex 7a4ce70c10..3d2dba1359 100644\n--- a/app/test/test_cryptodev_sm2_test_vectors.h\n+++ b/app/test/test_cryptodev_sm2_test_vectors.h\n@@ -17,6 +17,7 @@ struct crypto_testsuite_sm2_params {\n \trte_crypto_param id;\n \trte_crypto_param cipher;\n \trte_crypto_param message;\n+\tint curve;\n };\n \n static uint8_t fp256_pkey[] = {\n@@ -123,7 +124,8 @@ struct crypto_testsuite_sm2_params sm2_param_fp256 = {\n \t.cipher = {\n \t\t.data = fp256_cipher,\n \t\t.length = sizeof(fp256_cipher),\n-\t}\n+\t},\n+\t.curve = RTE_CRYPTO_EC_GROUP_SM2\n };\n \n #endif /* __TEST_CRYPTODEV_SM2_TEST_VECTORS_H__ */\ndiff --git a/doc/guides/rel_notes/release_23_11.rst b/doc/guides/rel_notes/release_23_11.rst\nindex 250735efa9..53639543a6 100644\n--- a/doc/guides/rel_notes/release_23_11.rst\n+++ b/doc/guides/rel_notes/release_23_11.rst\n@@ -122,6 +122,8 @@ Removed Items\n * security: Removed deprecated field ``reserved_opts`` from struct\n ``rte_security_ipsec_sa_options``.\n \n+* crypto: Removed SM2 xform parameter in asymmetric xform.\n+\n \n API Changes\n -----------\ndiff --git a/drivers/crypto/openssl/rte_openssl_pmd_ops.c b/drivers/crypto/openssl/rte_openssl_pmd_ops.c\nindex d5dc365064..6252a36f94 100644\n--- a/drivers/crypto/openssl/rte_openssl_pmd_ops.c\n+++ b/drivers/crypto/openssl/rte_openssl_pmd_ops.c\n@@ -1305,9 +1305,6 @@ static int openssl_set_asym_session_parameters(\n \t\tOSSL_PARAM *params = NULL;\n \t\tint ret = -1;\n \n-\t\tif (xform->sm2.hash != RTE_CRYPTO_AUTH_SM3)\n-\t\t\treturn -1;\n-\n \t\tparam_bld = OSSL_PARAM_BLD_new();\n \t\tif (!param_bld) {\n \t\t\tOPENSSL_LOG(ERR, \"failed to allocate params\\n\");\ndiff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_asym.h\nindex 2f000ab015..e56c8c7816 100644\n--- a/lib/cryptodev/rte_crypto_asym.h\n+++ b/lib/cryptodev/rte_crypto_asym.h\n@@ -64,7 +64,8 @@ enum rte_crypto_curve_id {\n \tRTE_CRYPTO_EC_GROUP_SECP224R1 = 21,\n \tRTE_CRYPTO_EC_GROUP_SECP256R1 = 23,\n \tRTE_CRYPTO_EC_GROUP_SECP384R1 = 24,\n-\tRTE_CRYPTO_EC_GROUP_SECP521R1 = 25\n+\tRTE_CRYPTO_EC_GROUP_SECP521R1 = 25,\n+\tRTE_CRYPTO_EC_GROUP_SM2 = 41,\n };\n \n /**\n@@ -373,16 +374,6 @@ struct rte_crypto_ec_xform {\n \t/**< Pre-defined ec groups */\n };\n \n-/**\n- * Asymmetric SM2 transform data.\n- *\n- * Structure describing SM2 xform params.\n- */\n-struct rte_crypto_sm2_xform {\n-\tenum rte_crypto_auth_algorithm hash;\n-\t/**< Hash algorithm used in SM2 op. */\n-};\n-\n /**\n * Operations params for modular operations:\n * exponentiation and multiplicative inverse\n@@ -639,9 +630,6 @@ struct rte_crypto_asym_xform {\n \t\t/**< EC xform parameters, used by elliptic curve based\n \t\t * operations.\n \t\t */\n-\n-\t\tstruct rte_crypto_sm2_xform sm2;\n-\t\t/**< SM2 xform parameters */\n \t};\n };\n \n@@ -652,6 +640,9 @@ struct rte_crypto_sm2_op_param {\n \tenum rte_crypto_asym_op_type op_type;\n \t/**< Signature generation or verification. */\n \n+\tenum rte_crypto_auth_algorithm hash;\n+\t/**< Hash algorithm used in EC op. */\n+\n \trte_crypto_uint pkey;\n \t/**< Private key for encryption or sign generation. */\n \n", "prefixes": [ "v4", "3/7" ] }