Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/133593/?format=api
{ "id": 133593, "url": "http://patchwork.dpdk.org/api/patches/133593/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231029163202.216450-20-getelson@nvidia.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231029163202.216450-20-getelson@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231029163202.216450-20-getelson@nvidia.com", "date": "2023-10-29T16:31:52", "name": "[20/30] net/mlx5/hws: support insert header action", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f4589491d25bbf9438a87857fef175622d29b826", "submitter": { "id": 1882, "url": "http://patchwork.dpdk.org/api/people/1882/?format=api", "name": "Gregory Etelson", "email": "getelson@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patchwork.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231029163202.216450-20-getelson@nvidia.com/mbox/", "series": [ { "id": 30049, "url": "http://patchwork.dpdk.org/api/series/30049/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=30049", "date": "2023-10-29T16:31:33", "name": "[01/30] net/mlx5/hws: Definer, add mlx5dr context to definer_conv_data", "version": 1, "mbox": "http://patchwork.dpdk.org/series/30049/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/133593/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/133593/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 483FB43238;\n\tSun, 29 Oct 2023 17:35:26 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B00C942D9F;\n\tSun, 29 Oct 2023 17:33:39 +0100 (CET)", "from NAM02-BN1-obe.outbound.protection.outlook.com\n (mail-bn1nam02on2040.outbound.protection.outlook.com [40.107.212.40])\n by mails.dpdk.org (Postfix) with ESMTP id ABE3742D91\n for <dev@dpdk.org>; Sun, 29 Oct 2023 17:33:37 +0100 (CET)", "from BYAPR02CA0071.namprd02.prod.outlook.com (2603:10b6:a03:54::48)\n by PH7PR12MB7164.namprd12.prod.outlook.com (2603:10b6:510:203::13)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.26; Sun, 29 Oct\n 2023 16:33:33 +0000", "from CO1PEPF000044F4.namprd05.prod.outlook.com\n (2603:10b6:a03:54:cafe::4f) by BYAPR02CA0071.outlook.office365.com\n (2603:10b6:a03:54::48) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.27 via Frontend\n Transport; Sun, 29 Oct 2023 16:33:33 +0000", "from mail.nvidia.com (216.228.117.160) by\n CO1PEPF000044F4.mail.protection.outlook.com (10.167.241.74) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.6933.22 via Frontend Transport; Sun, 29 Oct 2023 16:33:33 +0000", "from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com\n (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 29 Oct\n 2023 09:33:21 -0700", "from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com\n (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 29 Oct\n 2023 09:33:18 -0700" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=SZzpDJ8hVqeahGAvwMOaaxweqZzp0huB6o63VOL7KsUvEBYy5vD4VWbVC5Ai5yOmPKez0nV2I8U0fyySRFpz8jZkb6T6tX4xGloHKMJC1o2RFIp5XZTnGkw4sBvJWJK/95z9ARUU3NJQEUEkyazaKYhzcTvYYCwOqxfzujqkD5DRdX/S8vGUP8pp0yYU2VJ4sV/4LpKcKmhE711kpeUbdIp9LAwjNuSE4OKcPbsmhwhD/LnkubjIbd7eFQ610+umMiKb2AaKwtGX9nUo7H89NLusLeG7ilyYFmqR61vmxD9DqbeRDFkmFwPmre/lhj8PP7R3P+vXq0HusyYEtrEwRg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=m96wFSonQGgcihWRW+fu+ZweFa4C8Bkh1DZhR5PFRMw=;\n b=bN8ZJBVvugJs2vdmVEkkxUqY5FXihw9+iNSvq4Ys4192WlG8Ss8R5EA2qnmaCuqB0ZC4EBgiLTdgCu6jF+4NS7iDjoSGnSaI74svsyR4eXL+ThNHgDCHWWBxRfFzFew9kfPghwFXWjGa24U1cICWipvJNKvYY/3BcfNfuPcQuwNOmq8oArEfDvey9ps5NRcrB3zPky1LHFMdyZ+x1NOGPFk1JlzAgC6PRlrv1l3EPL2PGGChjFyW/BNiaEIEE8bGEhhkGrIimFGH3m82WuSPC1QHbVZDAN5wqRoc4jI3abLO+SuDxt/4ewdbt285YilZj+/vWHHvLkaXctdMBr8w9g==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=m96wFSonQGgcihWRW+fu+ZweFa4C8Bkh1DZhR5PFRMw=;\n b=Y35dbcwKWckQmSH4J1510G4iQLejedqayZCcZuZX6jVpLX68UT11tkRQpC9PdgSz0YthXGzLOMyhuT2k9XTOyLTqoVnPXJRNhGt/ZZiG6ROX3XRkG9BYNu+WMj0uN0nuYYu47EWzWJTs3UF7dqCS2T/sQCTRuozh0/FvwLwR5LzNxbeII/VvhJUAQaz/wk/+S+CKoLYvkyNnfmyeruS17pb5dAHbwDetbo5lXgR0VUVBDF48VGTWmzYtk6OOF/ERhGIelG2JMRvLITZ+KlWEQ+uPIUcswSYgQyF/xVlm5LTeNRF5GkPxr7fbhWLUEKyshRDYZI2o9O1SeOr9cIBpCg==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.160)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.160 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C", "From": "Gregory Etelson <getelson@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "<getelson@nvidia.com>, <mkashani@nvidia.com>, <rasland@nvidia.com>,\n \"Hamdan Igbaria\" <hamdani@nvidia.com>, Alex Vesker <valex@nvidia.com>, Matan\n Azrad <matan@nvidia.com>, Viacheslav Ovsiienko <viacheslavo@nvidia.com>, Ori\n Kam <orika@nvidia.com>, Suanming Mou <suanmingm@nvidia.com>", "Subject": "[PATCH 20/30] net/mlx5/hws: support insert header action", "Date": "Sun, 29 Oct 2023 18:31:52 +0200", "Message-ID": "<20231029163202.216450-20-getelson@nvidia.com>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20231029163202.216450-1-getelson@nvidia.com>", "References": "<20231029163202.216450-1-getelson@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.126.231.35]", "X-ClientProxiedBy": "rnnvmail203.nvidia.com (10.129.68.9) To\n rnnvmail201.nvidia.com (10.129.68.8)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "CO1PEPF000044F4:EE_|PH7PR12MB7164:EE_", "X-MS-Office365-Filtering-Correlation-Id": "6528e1ae-e62e-4e7d-d2af-08dbd89ccb1a", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n N+VpKYtQJ601yFRM+Yx14sGX7Kai3lko6OLm2CuDwtdh3VCwx9vmArSc1Joq5naidlN4zzxZf3+O8oZwdC9swzUZe/VnCWRX/jFWljxsPlrtn/j6vCTOv0yohuOx/x4C1QVcLwSNm2fuXoAsHOdELV6U//HYAjhqPouaQA59vJHzBvg2Az7nYd3LvL4km/0ABDsmpdTNnrc9hiAkLg3bqUWFZF+zWKPi+lmFOWIKDVshMREV2Yz0Xdi4hke7sa89dZoPEQ7wVzlzOyrY5caiHbbWqfU0EOv5AHlxxA9gK6wtJDssEVz+Au1LQ4Wd+5E3baiaLTHksv5051iwpNLhcWnNJzxnU4OAKLUMaGcY7uUmXOMmZGjtuK7FmNp3DxXEJ3k2nNc/hbPmRRJF5R+pk5ldI/oD5Vhifubl4XsL2hBUABXdjhLF14JGR7eWPELsyTwNUFBNEaiWck1EvZzi8v5GgGGsWU+h0R1wxhHMvLDVYj85eWYEr7ldrTklUBfeWkA5UFO/8oMWRFs8Iuf1e3sjliyJ/0JIWzDp4075mq4/J+wZjJkqGuqAzAbzClqImtn/YGf4D7G8IW/2XWGY5PUSmKIwHKSXcb4pFMCKMz55u8bXAkvIc8goP/gar9Mr+WaD34g05zgsRiWcwJZ4jeenYinkbH5E5gWBC4Hyc4RkQ9NS5IbQ3zfAf5thRYiPQYfeav5gARjKI5xl1NvTV02WDyN3HNgIgY1TuuoTfla4p/ZfYI+uP99B2fyfwAIk", "X-Forefront-Antispam-Report": "CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE;\n SFS:(13230031)(4636009)(376002)(39860400002)(346002)(136003)(396003)(230922051799003)(82310400011)(64100799003)(186009)(451199024)(1800799009)(46966006)(40470700004)(36840700001)(2616005)(1076003)(16526019)(6286002)(26005)(40480700001)(55016003)(40460700003)(86362001)(36756003)(7636003)(82740400003)(356005)(426003)(336012)(83380400001)(2906002)(30864003)(478600001)(7696005)(107886003)(36860700001)(6666004)(47076005)(4326008)(8676002)(8936002)(54906003)(6916009)(316002)(41300700001)(70206006)(70586007)(5660300002);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "29 Oct 2023 16:33:33.5993 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 6528e1ae-e62e-4e7d-d2af-08dbd89ccb1a", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CO1PEPF000044F4.namprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "PH7PR12MB7164", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Hamdan Igbaria <hamdani@nvidia.com>\n\nSupport insert header action, this will allow encap at\na specific anchor and offset selected by the user.\n\nSigned-off-by: Hamdan Igbaria <hamdani@nvidia.com>\nReviewed-by: Alex Vesker <valex@nvidia.com>\nAcked-by: Matan Azrad <matan@nvidia.com>\n---\n drivers/net/mlx5/hws/mlx5dr.h | 36 ++++++++\n drivers/net/mlx5/hws/mlx5dr_action.c | 112 +++++++++++++++++++++----\n drivers/net/mlx5/hws/mlx5dr_action.h | 5 +-\n drivers/net/mlx5/hws/mlx5dr_cmd.c | 4 +-\n drivers/net/mlx5/hws/mlx5dr_debug.c | 1 +\n drivers/net/mlx5/hws/mlx5dr_internal.h | 1 +\n 6 files changed, 141 insertions(+), 18 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/hws/mlx5dr.h b/drivers/net/mlx5/hws/mlx5dr.h\nindex e7d89ad7ec..a6bbb85eed 100644\n--- a/drivers/net/mlx5/hws/mlx5dr.h\n+++ b/drivers/net/mlx5/hws/mlx5dr.h\n@@ -50,6 +50,7 @@ enum mlx5dr_action_type {\n \tMLX5DR_ACTION_TYP_ASO_FIRST_HIT,\n \tMLX5DR_ACTION_TYP_CRYPTO_ENCRYPT,\n \tMLX5DR_ACTION_TYP_CRYPTO_DECRYPT,\n+\tMLX5DR_ACTION_TYP_INSERT_HEADER,\n \tMLX5DR_ACTION_TYP_DEST_ROOT,\n \tMLX5DR_ACTION_TYP_DEST_ARRAY,\n \tMLX5DR_ACTION_TYP_MAX,\n@@ -174,6 +175,20 @@ struct mlx5dr_action_reformat_header {\n \tvoid *data;\n };\n \n+struct mlx5dr_action_insert_header {\n+\tstruct mlx5dr_action_reformat_header hdr;\n+\t/* PRM start anchor to which header will be inserted */\n+\tuint8_t anchor;\n+\t/* Header insertion offset in bytes, from the start\n+\t * anchor to the location where new header will be inserted.\n+\t */\n+\tuint8_t offset;\n+\t/* Indicates this header insertion adds encapsulation header to the packet,\n+\t * requiring device to update offloaded fields (for example IPv4 total length).\n+\t */\n+\tbool encap;\n+};\n+\n struct mlx5dr_action_mh_pattern {\n \t/* Byte size of modify actions provided by \"data\" */\n \tsize_t sz;\n@@ -813,6 +828,27 @@ mlx5dr_action_create_crypto(struct mlx5dr_context *ctx,\n \t\t\t struct mlx5dr_action_crypto_attr *attr,\n \t\t\t uint32_t flags);\n \n+/* Create insert header action.\n+ *\n+ * @param[in] ctx\n+ *\tThe context in which the new action will be created.\n+ * @param[in] num_of_hdrs\n+ *\tNumber of provided headers in \"hdrs\" array.\n+ * @param[in] hdrs\n+ *\tHeaders array containing header information.\n+ * @param[in] log_bulk_size\n+ *\tNumber of unique values used with this insert header.\n+ * @param[in] flags\n+ *\tAction creation flags. (enum mlx5dr_action_flags)\n+ * @return pointer to mlx5dr_action on success NULL otherwise.\n+ */\n+struct mlx5dr_action *\n+mlx5dr_action_create_insert_header(struct mlx5dr_context *ctx,\n+\t\t\t\t uint8_t num_of_hdrs,\n+\t\t\t\t struct mlx5dr_action_insert_header *hdrs,\n+\t\t\t\t uint32_t log_bulk_size,\n+\t\t\t\t uint32_t flags);\n+\n /* Destroy direct rule action.\n *\n * @param[in] action\ndiff --git a/drivers/net/mlx5/hws/mlx5dr_action.c b/drivers/net/mlx5/hws/mlx5dr_action.c\nindex fe9c39b207..9885555a8f 100644\n--- a/drivers/net/mlx5/hws/mlx5dr_action.c\n+++ b/drivers/net/mlx5/hws/mlx5dr_action.c\n@@ -34,6 +34,7 @@ static const uint32_t action_order_arr[MLX5DR_TABLE_TYPE_MAX][MLX5DR_ACTION_TYP_\n \t\tBIT(MLX5DR_ACTION_TYP_PUSH_VLAN),\n \t\tBIT(MLX5DR_ACTION_TYP_PUSH_VLAN),\n \t\tBIT(MLX5DR_ACTION_TYP_MODIFY_HDR),\n+\t\tBIT(MLX5DR_ACTION_TYP_INSERT_HEADER) |\n \t\tBIT(MLX5DR_ACTION_TYP_REFORMAT_L2_TO_TNL_L2) |\n \t\tBIT(MLX5DR_ACTION_TYP_REFORMAT_L2_TO_TNL_L3),\n \t\tBIT(MLX5DR_ACTION_TYP_TBL) |\n@@ -55,6 +56,7 @@ static const uint32_t action_order_arr[MLX5DR_TABLE_TYPE_MAX][MLX5DR_ACTION_TYP_\n \t\tBIT(MLX5DR_ACTION_TYP_PUSH_VLAN),\n \t\tBIT(MLX5DR_ACTION_TYP_PUSH_VLAN),\n \t\tBIT(MLX5DR_ACTION_TYP_MODIFY_HDR),\n+\t\tBIT(MLX5DR_ACTION_TYP_INSERT_HEADER) |\n \t\tBIT(MLX5DR_ACTION_TYP_REFORMAT_L2_TO_TNL_L2) |\n \t\tBIT(MLX5DR_ACTION_TYP_REFORMAT_L2_TO_TNL_L3),\n \t\tBIT(MLX5DR_ACTION_TYP_REFORMAT_TRAILER),\n@@ -80,6 +82,7 @@ static const uint32_t action_order_arr[MLX5DR_TABLE_TYPE_MAX][MLX5DR_ACTION_TYP_\n \t\tBIT(MLX5DR_ACTION_TYP_PUSH_VLAN),\n \t\tBIT(MLX5DR_ACTION_TYP_PUSH_VLAN),\n \t\tBIT(MLX5DR_ACTION_TYP_MODIFY_HDR),\n+\t\tBIT(MLX5DR_ACTION_TYP_INSERT_HEADER) |\n \t\tBIT(MLX5DR_ACTION_TYP_REFORMAT_L2_TO_TNL_L2) |\n \t\tBIT(MLX5DR_ACTION_TYP_REFORMAT_L2_TO_TNL_L3),\n \t\tBIT(MLX5DR_ACTION_TYP_REFORMAT_TRAILER),\n@@ -640,20 +643,15 @@ static void mlx5dr_action_fill_stc_attr(struct mlx5dr_action *action,\n \t\tattr->remove_header.end_anchor = MLX5_HEADER_ANCHOR_INNER_MAC;\n \t\tbreak;\n \tcase MLX5DR_ACTION_TYP_REFORMAT_L2_TO_TNL_L2:\n-\t\tattr->action_type = MLX5_IFC_STC_ACTION_TYPE_HEADER_INSERT;\n-\t\tattr->action_offset = MLX5DR_ACTION_OFFSET_DW6;\n-\t\tattr->insert_header.encap = 1;\n-\t\tattr->insert_header.insert_anchor = MLX5_HEADER_ANCHOR_PACKET_START;\n-\t\tattr->insert_header.arg_id = action->reformat.arg_obj->id;\n-\t\tattr->insert_header.header_size = action->reformat.header_size;\n-\t\tbreak;\n \tcase MLX5DR_ACTION_TYP_REFORMAT_L2_TO_TNL_L3:\n+\tcase MLX5DR_ACTION_TYP_INSERT_HEADER:\n \t\tattr->action_type = MLX5_IFC_STC_ACTION_TYPE_HEADER_INSERT;\n \t\tattr->action_offset = MLX5DR_ACTION_OFFSET_DW6;\n-\t\tattr->insert_header.encap = 1;\n-\t\tattr->insert_header.insert_anchor = MLX5_HEADER_ANCHOR_PACKET_START;\n+\t\tattr->insert_header.encap = action->reformat.encap;\n+\t\tattr->insert_header.insert_anchor = action->reformat.anchor;\n \t\tattr->insert_header.arg_id = action->reformat.arg_obj->id;\n \t\tattr->insert_header.header_size = action->reformat.header_size;\n+\t\tattr->insert_header.insert_offset = action->reformat.offset;\n \t\tbreak;\n \tcase MLX5DR_ACTION_TYP_ASO_METER:\n \t\tattr->action_offset = MLX5DR_ACTION_OFFSET_DW6;\n@@ -1382,7 +1380,7 @@ mlx5dr_action_create_reformat_root(struct mlx5dr_action *action,\n }\n \n static int\n-mlx5dr_action_handle_l2_to_tunnel_l2(struct mlx5dr_action *action,\n+mlx5dr_action_handle_insert_with_ptr(struct mlx5dr_action *action,\n \t\t\t\t uint8_t num_of_hdrs,\n \t\t\t\t struct mlx5dr_action_reformat_header *hdrs,\n \t\t\t\t uint32_t log_bulk_sz)\n@@ -1392,8 +1390,8 @@ mlx5dr_action_handle_l2_to_tunnel_l2(struct mlx5dr_action *action,\n \tint ret, i;\n \n \tfor (i = 0; i < num_of_hdrs; i++) {\n-\t\tif (hdrs[i].sz % 2 != 0) {\n-\t\t\tDR_LOG(ERR, \"Header data size should be multiply of 2\");\n+\t\tif (hdrs[i].sz % W_SIZE != 0) {\n+\t\t\tDR_LOG(ERR, \"Header data size should be in WORD granularity\");\n \t\t\trte_errno = EINVAL;\n \t\t\treturn rte_errno;\n \t\t}\n@@ -1415,6 +1413,13 @@ mlx5dr_action_handle_l2_to_tunnel_l2(struct mlx5dr_action *action,\n \t\taction[i].reformat.num_of_hdrs = num_of_hdrs;\n \t\taction[i].reformat.max_hdr_sz = max_sz;\n \n+\t\tif (action[i].type == MLX5DR_ACTION_TYP_REFORMAT_L2_TO_TNL_L2 ||\n+\t\t action[i].type == MLX5DR_ACTION_TYP_REFORMAT_L2_TO_TNL_L3) {\n+\t\t\taction[i].reformat.anchor = MLX5_HEADER_ANCHOR_PACKET_START;\n+\t\t\taction[i].reformat.offset = 0;\n+\t\t\taction[i].reformat.encap = 1;\n+\t\t}\n+\n \t\tret = mlx5dr_action_create_stcs(&action[i], NULL);\n \t\tif (ret) {\n \t\t\tDR_LOG(ERR, \"Failed to create stc for reformat\");\n@@ -1448,7 +1453,7 @@ mlx5dr_action_handle_l2_to_tunnel_l3(struct mlx5dr_action *action,\n \t}\n \n \t/* Reuse the insert with pointer for the L2L3 header */\n-\tret = mlx5dr_action_handle_l2_to_tunnel_l2(action,\n+\tret = mlx5dr_action_handle_insert_with_ptr(action,\n \t\t\t\t\t\t num_of_hdrs,\n \t\t\t\t\t\t hdrs,\n \t\t\t\t\t\t log_bulk_sz);\n@@ -1592,7 +1597,7 @@ mlx5dr_action_create_reformat_hws(struct mlx5dr_action *action,\n \t\tret = mlx5dr_action_create_stcs(action, NULL);\n \t\tbreak;\n \tcase MLX5DR_ACTION_TYP_REFORMAT_L2_TO_TNL_L2:\n-\t\tret = mlx5dr_action_handle_l2_to_tunnel_l2(action, num_of_hdrs, hdrs, bulk_size);\n+\t\tret = mlx5dr_action_handle_insert_with_ptr(action, num_of_hdrs, hdrs, bulk_size);\n \t\tbreak;\n \tcase MLX5DR_ACTION_TYP_REFORMAT_L2_TO_TNL_L3:\n \t\tret = mlx5dr_action_handle_l2_to_tunnel_l3(action, num_of_hdrs, hdrs, bulk_size);\n@@ -1622,6 +1627,7 @@ mlx5dr_action_create_reformat(struct mlx5dr_context *ctx,\n \n \tif (!num_of_hdrs) {\n \t\tDR_LOG(ERR, \"Reformat num_of_hdrs cannot be zero\");\n+\t\trte_errno = EINVAL;\n \t\treturn NULL;\n \t}\n \n@@ -1657,7 +1663,6 @@ mlx5dr_action_create_reformat(struct mlx5dr_context *ctx,\n \tret = mlx5dr_action_create_reformat_hws(action, num_of_hdrs, hdrs, log_bulk_size);\n \tif (ret) {\n \t\tDR_LOG(ERR, \"Failed to create HWS reformat action\");\n-\t\trte_errno = EINVAL;\n \t\tgoto free_action;\n \t}\n \n@@ -2186,6 +2191,81 @@ mlx5dr_action_create_reformat_trailer(struct mlx5dr_context *ctx,\n \treturn action;\n }\n \n+struct mlx5dr_action *\n+mlx5dr_action_create_insert_header(struct mlx5dr_context *ctx,\n+\t\t\t\t uint8_t num_of_hdrs,\n+\t\t\t\t struct mlx5dr_action_insert_header *hdrs,\n+\t\t\t\t uint32_t log_bulk_size,\n+\t\t\t\t uint32_t flags)\n+{\n+\tstruct mlx5dr_action_reformat_header *reformat_hdrs;\n+\tstruct mlx5dr_action *action;\n+\tint i, ret;\n+\n+\tif (!num_of_hdrs) {\n+\t\tDR_LOG(ERR, \"Reformat num_of_hdrs cannot be zero\");\n+\t\treturn NULL;\n+\t}\n+\n+\tif (mlx5dr_action_is_root_flags(flags)) {\n+\t\tDR_LOG(ERR, \"Dynamic reformat action not supported over root\");\n+\t\trte_errno = ENOTSUP;\n+\t\treturn NULL;\n+\t}\n+\n+\tif (!mlx5dr_action_is_hws_flags(flags) ||\n+\t ((flags & MLX5DR_ACTION_FLAG_SHARED) && (log_bulk_size || num_of_hdrs > 1))) {\n+\t\tDR_LOG(ERR, \"Reformat flags don't fit HWS (flags: 0x%x)\", flags);\n+\t\trte_errno = EINVAL;\n+\t\treturn NULL;\n+\t}\n+\n+\taction = mlx5dr_action_create_generic_bulk(ctx, flags,\n+\t\t\t\t\t\t MLX5DR_ACTION_TYP_INSERT_HEADER,\n+\t\t\t\t\t\t num_of_hdrs);\n+\tif (!action)\n+\t\treturn NULL;\n+\n+\treformat_hdrs = simple_calloc(num_of_hdrs, sizeof(*reformat_hdrs));\n+\tif (!reformat_hdrs) {\n+\t\tDR_LOG(ERR, \"Failed to allocate memory for reformat_hdrs\");\n+\t\trte_errno = ENOMEM;\n+\t\tgoto free_action;\n+\t}\n+\n+\tfor (i = 0; i < num_of_hdrs; i++) {\n+\t\tif (hdrs[i].offset % W_SIZE != 0) {\n+\t\t\tDR_LOG(ERR, \"Header offset should be in WORD granularity\");\n+\t\t\trte_errno = EINVAL;\n+\t\t\tgoto free_reformat_hdrs;\n+\t\t}\n+\n+\t\taction[i].reformat.anchor = hdrs[i].anchor;\n+\t\taction[i].reformat.encap = hdrs[i].encap;\n+\t\taction[i].reformat.offset = hdrs[i].offset;\n+\t\treformat_hdrs[i].sz = hdrs[i].hdr.sz;\n+\t\treformat_hdrs[i].data = hdrs[i].hdr.data;\n+\t}\n+\n+\tret = mlx5dr_action_handle_insert_with_ptr(action, num_of_hdrs,\n+\t\t\t\t\t\t reformat_hdrs, log_bulk_size);\n+\tif (ret) {\n+\t\tDR_LOG(ERR, \"Failed to create HWS reformat action\");\n+\t\trte_errno = EINVAL;\n+\t\tgoto free_reformat_hdrs;\n+\t}\n+\n+\tsimple_free(reformat_hdrs);\n+\n+\treturn action;\n+\n+free_reformat_hdrs:\n+\tsimple_free(reformat_hdrs);\n+free_action:\n+\tsimple_free(action);\n+\treturn NULL;\n+}\n+\n static void mlx5dr_action_destroy_hws(struct mlx5dr_action *action)\n {\n \tstruct mlx5dr_devx_obj *obj = NULL;\n@@ -2252,6 +2332,7 @@ static void mlx5dr_action_destroy_hws(struct mlx5dr_action *action)\n \t\t\tmlx5dr_action_destroy_stcs(&action[i]);\n \t\tmlx5dr_cmd_destroy_obj(action->reformat.arg_obj);\n \t\tbreak;\n+\tcase MLX5DR_ACTION_TYP_INSERT_HEADER:\n \tcase MLX5DR_ACTION_TYP_REFORMAT_L2_TO_TNL_L2:\n \t\tfor (i = 0; i < action->reformat.num_of_hdrs; i++)\n \t\t\tmlx5dr_action_destroy_stcs(&action[i]);\n@@ -2850,6 +2931,7 @@ int mlx5dr_action_template_process(struct mlx5dr_action_template *at)\n \t\t\tsetter->idx_single = i;\n \t\t\tbreak;\n \n+\t\tcase MLX5DR_ACTION_TYP_INSERT_HEADER:\n \t\tcase MLX5DR_ACTION_TYP_REFORMAT_L2_TO_TNL_L2:\n \t\t\t/* Double insert header with pointer */\n \t\t\tsetter = mlx5dr_action_setter_find_first(last_setter, ASF_DOUBLE);\ndiff --git a/drivers/net/mlx5/hws/mlx5dr_action.h b/drivers/net/mlx5/hws/mlx5dr_action.h\nindex b64d6cc9a8..02358da4cb 100644\n--- a/drivers/net/mlx5/hws/mlx5dr_action.h\n+++ b/drivers/net/mlx5/hws/mlx5dr_action.h\n@@ -136,8 +136,11 @@ struct mlx5dr_action {\n \t\t\t\tstruct {\n \t\t\t\t\tstruct mlx5dr_devx_obj *arg_obj;\n \t\t\t\t\tuint32_t header_size;\n-\t\t\t\t\tuint8_t num_of_hdrs;\n \t\t\t\t\tuint16_t max_hdr_sz;\n+\t\t\t\t\tuint8_t num_of_hdrs;\n+\t\t\t\t\tuint8_t anchor;\n+\t\t\t\t\tuint8_t offset;\n+\t\t\t\t\tbool encap;\n \t\t\t\t} reformat;\n \t\t\t\tstruct {\n \t\t\t\t\tstruct mlx5dr_devx_obj *devx_obj;\ndiff --git a/drivers/net/mlx5/hws/mlx5dr_cmd.c b/drivers/net/mlx5/hws/mlx5dr_cmd.c\nindex 02547e7178..0ba4774f08 100644\n--- a/drivers/net/mlx5/hws/mlx5dr_cmd.c\n+++ b/drivers/net/mlx5/hws/mlx5dr_cmd.c\n@@ -492,9 +492,9 @@ mlx5dr_cmd_stc_modify_set_stc_param(struct mlx5dr_cmd_stc_modify_attr *stc_attr,\n \t\t\t stc_attr->insert_header.insert_anchor);\n \t\t/* HW gets the next 2 sizes in words */\n \t\tMLX5_SET(stc_ste_param_insert, stc_parm, insert_size,\n-\t\t\t stc_attr->insert_header.header_size / 2);\n+\t\t\t stc_attr->insert_header.header_size / W_SIZE);\n \t\tMLX5_SET(stc_ste_param_insert, stc_parm, insert_offset,\n-\t\t\t stc_attr->insert_header.insert_offset / 2);\n+\t\t\t stc_attr->insert_header.insert_offset / W_SIZE);\n \t\tMLX5_SET(stc_ste_param_insert, stc_parm, insert_argument,\n \t\t\t stc_attr->insert_header.arg_id);\n \t\tbreak;\ndiff --git a/drivers/net/mlx5/hws/mlx5dr_debug.c b/drivers/net/mlx5/hws/mlx5dr_debug.c\nindex 552dba5e63..29e207765b 100644\n--- a/drivers/net/mlx5/hws/mlx5dr_debug.c\n+++ b/drivers/net/mlx5/hws/mlx5dr_debug.c\n@@ -29,6 +29,7 @@ const char *mlx5dr_debug_action_type_str[] = {\n \t[MLX5DR_ACTION_TYP_DEST_ARRAY] = \"DEST_ARRAY\",\n \t[MLX5DR_ACTION_TYP_CRYPTO_ENCRYPT] = \"CRYPTO_ENCRYPT\",\n \t[MLX5DR_ACTION_TYP_CRYPTO_DECRYPT] = \"CRYPTO_DECRYPT\",\n+\t[MLX5DR_ACTION_TYP_INSERT_HEADER] = \"INSERT_HEADER\",\n };\n \n static_assert(ARRAY_SIZE(mlx5dr_debug_action_type_str) == MLX5DR_ACTION_TYP_MAX,\ndiff --git a/drivers/net/mlx5/hws/mlx5dr_internal.h b/drivers/net/mlx5/hws/mlx5dr_internal.h\nindex 021d599a56..b9efdc4a9a 100644\n--- a/drivers/net/mlx5/hws/mlx5dr_internal.h\n+++ b/drivers/net/mlx5/hws/mlx5dr_internal.h\n@@ -40,6 +40,7 @@\n #include \"mlx5dr_pat_arg.h\"\n #include \"mlx5dr_crc32.h\"\n \n+#define W_SIZE\t\t2\n #define DW_SIZE\t\t4\n #define BITS_IN_BYTE\t8\n #define BITS_IN_DW\t(BITS_IN_BYTE * DW_SIZE)\n", "prefixes": [ "20/30" ] }