Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/135324/?format=api
{ "id": 135324, "url": "http://patchwork.dpdk.org/api/patches/135324/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231219021650.549227-1-rushilg@google.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231219021650.549227-1-rushilg@google.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231219021650.549227-1-rushilg@google.com", "date": "2023-12-19T02:16:50", "name": "net/gve: Enable stats reporting for GQ format", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "92594f029e1ec8a471a171010838e10d4adb7755", "submitter": { "id": 2890, "url": "http://patchwork.dpdk.org/api/people/2890/?format=api", "name": "Rushil Gupta", "email": "rushilg@google.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231219021650.549227-1-rushilg@google.com/mbox/", "series": [ { "id": 30609, "url": "http://patchwork.dpdk.org/api/series/30609/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=30609", "date": "2023-12-19T02:16:50", "name": "net/gve: Enable stats reporting for GQ format", "version": 1, "mbox": "http://patchwork.dpdk.org/series/30609/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/135324/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/135324/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6F06C4373B;\n\tTue, 19 Dec 2023 03:16:55 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EB29A402D0;\n\tTue, 19 Dec 2023 03:16:54 +0100 (CET)", "from mail-yb1-f202.google.com (mail-yb1-f202.google.com\n [209.85.219.202])\n by mails.dpdk.org (Postfix) with ESMTP id AFD27402B1\n for <dev@dpdk.org>; Tue, 19 Dec 2023 03:16:53 +0100 (CET)", "by mail-yb1-f202.google.com with SMTP id\n 3f1490d57ef6-dbce2a8d700so3992362276.1\n for <dev@dpdk.org>; Mon, 18 Dec 2023 18:16:53 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=google.com; s=20230601; t=1702952213; x=1703557013; darn=dpdk.org;\n h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject\n :date:message-id:reply-to;\n bh=v9rNevC9kLezMQxeFyjJI9baLyNVDrKuXYx+VVNiRCE=;\n b=RKCee/7FnJuoQq0PZuwaci3747Jo/GM+VSp4x5PgTjYOApR1G4y+qmqWeOeCswlH86\n 3QGN44CooeDP8UtkdIWoj236+Rinu5LSaHm4+tcwKTjztSt0+/lUEigKQkVXQqCHCjit\n dV0gBb3G9bEI2LuIzuOEO6zt1nKdsqh/aVXZe+AFPCnwBs2TmTLPTeNbvQ+jhNX+RLvo\n hzQUdd0humZxlXfS0518sFI1L/rUD6/K7c6REI5tKLaYxHc0pWDfO3pCKbeSz43nR1jG\n raYMYCDo9xmemwyVwpyxs0GzulcRDk4+PTqyiwh4s0zjm7k3UeargoyFt1Ehf8zQZoJG\n VmqA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1702952213; x=1703557013;\n h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state\n :from:to:cc:subject:date:message-id:reply-to;\n bh=v9rNevC9kLezMQxeFyjJI9baLyNVDrKuXYx+VVNiRCE=;\n b=lQD/G8+NxXs9U4T1v8Yg2dQi7EBJbzKdt/0vMXbXNYnuhbP4xjclF2qvrqayH2S54H\n zqN+cwhxkzUs+e8hQGzUW9JZ79NNAt019lLpdAkMIbM1t+MyNaCFDbTgOivamPv4AQ1A\n nox2hV8exJHsAuju1MoQuPdnl9sQ/ZP3PmCjIfipq0ZbWnT1SGnDaXRJgJpj6vCc6JFT\n 4b+bFz3efZmsCGHYE8GagjiW2LOwx87A4NaqWLCnRefCkHhHRdfR02aTwkFCsydMDJwb\n sf5Mpzepwtm8JKr5+jO5YA6ZZNSzVfja5QtCBSw2NeLnBtNLcdveFQgz1vxMhCfFtmud\n ieHg==", "X-Gm-Message-State": "AOJu0YyzQFJI2Xk8Q4MbEZNpO3yVyMkr+fcfM4leK8LxjQ3OVi9ZxiQy\n yUPoujCI+SbA6lkTO2ShMT9BSlAm5Uhd", "X-Google-Smtp-Source": "\n AGHT+IEIezXjD49VnSsmrYMYriKJvRd3yol2k5C0TkzP8tq1/Gwnacms2OH6XNDSG0tggGdN4O3whGNQ1/A2", "X-Received": "from wrushilg.c.googlers.com\n ([fda3:e722:ac3:cc00:20:ed76:c0a8:2168])\n (user=rushilg job=sendgmr) by 2002:a25:dbce:0:b0:dbc:ca49:8177 with SMTP id\n g197-20020a25dbce000000b00dbcca498177mr261191ybf.3.1702952213022; Mon, 18 Dec\n 2023 18:16:53 -0800 (PST)", "Date": "Tue, 19 Dec 2023 02:16:50 +0000", "Mime-Version": "1.0", "X-Mailer": "git-send-email 2.43.0.472.g3155946c3a-goog", "Message-ID": "<20231219021650.549227-1-rushilg@google.com>", "Subject": "[PATCH] net/gve: Enable stats reporting for GQ format", "From": "Rushil Gupta <rushilg@google.com>", "To": "junfeng.guo@intel.com, jeroendb@google.com, joshwash@google.com,\n ferruh.yigit@amd.com", "Cc": "dev@dpdk.org, Rushil Gupta <rushilg@google.com>", "Content-Type": "text/plain; charset=\"UTF-8\"", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Read from shared region to retrieve imissed statistics for GQ.\nTested using `show port xstats <port-id>` in interactive mode.\nThis metric can be triggered by using queues > cores.\n\nSigned-off-by: Rushil Gupta <rushilg@google.com>\nReviewed-by: Joshua Washington <joshwash@google.com>\n---\n drivers/net/gve/base/gve_adminq.h | 11 ++++\n drivers/net/gve/gve_ethdev.c | 83 +++++++++++++++++++++++++++++++\n drivers/net/gve/gve_ethdev.h | 6 +++\n 3 files changed, 100 insertions(+)", "diff": "diff --git a/drivers/net/gve/base/gve_adminq.h b/drivers/net/gve/base/gve_adminq.h\nindex e30b184913..f05362f85f 100644\n--- a/drivers/net/gve/base/gve_adminq.h\n+++ b/drivers/net/gve/base/gve_adminq.h\n@@ -314,6 +314,17 @@ struct gve_stats_report {\n \n GVE_CHECK_STRUCT_LEN(8, gve_stats_report);\n \n+/* Numbers of gve tx/rx stats in stats report. */\n+#define GVE_TX_STATS_REPORT_NUM 6\n+#define GVE_RX_STATS_REPORT_NUM 2\n+\n+/* Interval to schedule a stats report update, 20000ms. */\n+#define GVE_STATS_REPORT_TIMER_PERIOD 20000\n+\n+/* Numbers of NIC tx/rx stats in stats report. */\n+#define NIC_TX_STATS_REPORT_NUM 0\n+#define NIC_RX_STATS_REPORT_NUM 4\n+\n enum gve_stat_names {\n \t/* stats from gve */\n \tTX_WAKE_CNT\t\t\t= 1,\ndiff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c\nindex ecd37ff37f..0db612f25c 100644\n--- a/drivers/net/gve/gve_ethdev.c\n+++ b/drivers/net/gve/gve_ethdev.c\n@@ -125,6 +125,70 @@ gve_link_update(struct rte_eth_dev *dev, __rte_unused int wait_to_complete)\n \treturn rte_eth_linkstatus_set(dev, &link);\n }\n \n+static int gve_alloc_stats_report(struct gve_priv *priv,\n+\t\tuint16_t nb_tx_queues, uint16_t nb_rx_queues)\n+{\n+\tint tx_stats_cnt;\n+\tint rx_stats_cnt;\n+\n+\ttx_stats_cnt = (GVE_TX_STATS_REPORT_NUM + NIC_TX_STATS_REPORT_NUM) *\n+\t\tnb_tx_queues;\n+\trx_stats_cnt = (GVE_RX_STATS_REPORT_NUM + NIC_RX_STATS_REPORT_NUM) *\n+\t\tnb_rx_queues;\n+\tpriv->stats_report_len = sizeof(struct gve_stats_report) +\n+\t\tsizeof(struct stats) * (tx_stats_cnt + rx_stats_cnt);\n+\tpriv->stats_report_mem = rte_memzone_reserve_aligned(\"report_stats\",\n+\t\t\tpriv->stats_report_len,\n+\t\t\trte_socket_id(),\n+\t\t\tRTE_MEMZONE_IOVA_CONTIG, PAGE_SIZE);\n+\n+\tif (!priv->stats_report_mem)\n+\t\treturn -ENOMEM;\n+\n+\t/* offset by skipping stats written by gve. */\n+\tpriv->stats_start_idx = (GVE_TX_STATS_REPORT_NUM * nb_tx_queues) +\n+\t\t(GVE_RX_STATS_REPORT_NUM * nb_rx_queues);\n+\tpriv->stats_end_idx = priv->stats_start_idx +\n+\t\t(NIC_TX_STATS_REPORT_NUM * nb_tx_queues) +\n+\t\t(NIC_RX_STATS_REPORT_NUM * nb_rx_queues) - 1;\n+\n+\treturn 0;\n+}\n+\n+static void gve_free_stats_report(struct rte_eth_dev *dev)\n+{\n+\tstruct gve_priv *priv = dev->data->dev_private;\n+\trte_memzone_free(priv->stats_report_mem);\n+}\n+\n+/* Read Rx NIC stats from shared region */\n+static void gve_get_imissed_from_nic(struct rte_eth_dev *dev)\n+{\n+\tstruct gve_stats_report *stats_report;\n+\tstruct gve_rx_queue *rxq;\n+\tstruct gve_priv *priv;\n+\tstruct stats stat;\n+\tint queue_id;\n+\tint stat_id;\n+\tint i;\n+\n+\tpriv = dev->data->dev_private;\n+\tstats_report = (struct gve_stats_report *)\n+\t\tpriv->stats_report_mem->addr;\n+\n+\tfor (i = priv->stats_start_idx; i <= priv->stats_end_idx; i++) {\n+\t\tstat = stats_report->stats[i];\n+\t\tqueue_id = cpu_to_be32(stat.queue_id);\n+\t\trxq = dev->data->rx_queues[queue_id];\n+\t\tif (rxq == NULL)\n+\t\t\tcontinue;\n+\t\tstat_id = cpu_to_be32(stat.stat_name);\n+\t\t/* Update imissed. */\n+\t\tif (stat_id == RX_NO_BUFFERS_POSTED)\n+\t\t\trxq->stats.imissed = cpu_to_be64(stat.value);\n+\t}\n+}\n+\n static int\n gve_start_queues(struct rte_eth_dev *dev)\n {\n@@ -176,6 +240,7 @@ gve_start_queues(struct rte_eth_dev *dev)\n static int\n gve_dev_start(struct rte_eth_dev *dev)\n {\n+\tstruct gve_priv *priv;\n \tint ret;\n \n \tret = gve_start_queues(dev);\n@@ -187,6 +252,17 @@ gve_dev_start(struct rte_eth_dev *dev)\n \tdev->data->dev_started = 1;\n \tgve_link_update(dev, 0);\n \n+\tpriv = dev->data->dev_private;\n+\t/* No stats available yet for Dqo. */\n+\tif (gve_is_gqi(priv)) {\n+\t\tgve_alloc_stats_report(priv,\n+\t\t\tdev->data->nb_tx_queues,\n+\t\t\tdev->data->nb_rx_queues);\n+\t\tret = gve_adminq_report_stats(priv, priv->stats_report_len,\n+\t\t\t\tpriv->stats_report_mem->iova,\n+\t\t\t\tGVE_STATS_REPORT_TIMER_PERIOD);\n+\t}\n+\n \treturn 0;\n }\n \n@@ -200,6 +276,9 @@ gve_dev_stop(struct rte_eth_dev *dev)\n \n \tdev->data->dev_started = 0;\n \n+\tif (gve_is_gqi(dev->data->dev_private))\n+\t\tgve_free_stats_report(dev);\n+\n \treturn 0;\n }\n \n@@ -352,6 +431,8 @@ static int\n gve_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n {\n \tuint16_t i;\n+\tif (gve_is_gqi(dev->data->dev_private))\n+\t\tgve_get_imissed_from_nic(dev);\n \n \tfor (i = 0; i < dev->data->nb_tx_queues; i++) {\n \t\tstruct gve_tx_queue *txq = dev->data->tx_queues[i];\n@@ -372,6 +453,7 @@ gve_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n \t\tstats->ibytes += rxq->stats.bytes;\n \t\tstats->ierrors += rxq->stats.errors;\n \t\tstats->rx_nombuf += rxq->stats.no_mbufs;\n+\t\tstats->imissed += rxq->stats.imissed;\n \t}\n \n \treturn 0;\n@@ -443,6 +525,7 @@ static const struct gve_xstats_name_offset rx_xstats_name_offset[] = {\n \t{ \"errors\", RX_QUEUE_STATS_OFFSET(errors) },\n \t{ \"mbuf_alloc_errors\", RX_QUEUE_STATS_OFFSET(no_mbufs) },\n \t{ \"mbuf_alloc_errors_bulk\", RX_QUEUE_STATS_OFFSET(no_mbufs_bulk) },\n+\t{ \"imissed\", RX_QUEUE_STATS_OFFSET(imissed) },\n };\n \n static int\ndiff --git a/drivers/net/gve/gve_ethdev.h b/drivers/net/gve/gve_ethdev.h\nindex 58d8943e71..9893fcfee6 100644\n--- a/drivers/net/gve/gve_ethdev.h\n+++ b/drivers/net/gve/gve_ethdev.h\n@@ -85,6 +85,7 @@ struct gve_rx_stats {\n \tuint64_t errors;\n \tuint64_t no_mbufs;\n \tuint64_t no_mbufs_bulk;\n+\tuint64_t imissed;\n };\n \n struct gve_xstats_name_offset {\n@@ -272,6 +273,11 @@ struct gve_priv {\n \n \tstruct gve_tx_queue **txqs;\n \tstruct gve_rx_queue **rxqs;\n+\n+\tuint32_t stats_report_len;\n+\tconst struct rte_memzone *stats_report_mem;\n+\tuint16_t stats_start_idx; /* start index of array of stats written by NIC */\n+\tuint16_t stats_end_idx; /* end index of array of stats written by NIC */\n };\n \n static inline bool\n", "prefixes": [] }