Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/135978/?format=api
{ "id": 135978, "url": "http://patchwork.dpdk.org/api/patches/135978/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240118172602.898004-1-jonathan.erb@threater.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240118172602.898004-1-jonathan.erb@threater.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240118172602.898004-1-jonathan.erb@threater.com", "date": "2024-01-18T17:26:02", "name": "telemetry: correct json empty dictionaries", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "78975bf786ed394c3bb3d8e0ea2484e862493d6b", "submitter": { "id": 3252, "url": "http://patchwork.dpdk.org/api/people/3252/?format=api", "name": "Jonathan Erb", "email": "jonathan.erb@threater.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240118172602.898004-1-jonathan.erb@threater.com/mbox/", "series": [ { "id": 30845, "url": "http://patchwork.dpdk.org/api/series/30845/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=30845", "date": "2024-01-18T17:26:02", "name": "telemetry: correct json empty dictionaries", "version": 1, "mbox": "http://patchwork.dpdk.org/series/30845/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/135978/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/135978/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A85CC438FC;\n\tFri, 19 Jan 2024 08:48:48 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0D5924111C;\n\tFri, 19 Jan 2024 08:48:43 +0100 (CET)", "from mail-qt1-f182.google.com (mail-qt1-f182.google.com\n [209.85.160.182])\n by mails.dpdk.org (Postfix) with ESMTP id BAC1B40295\n for <dev@dpdk.org>; Thu, 18 Jan 2024 18:26:07 +0100 (CET)", "by mail-qt1-f182.google.com with SMTP id\n d75a77b69052e-42a0fa5d202so11063941cf.2\n for <dev@dpdk.org>; Thu, 18 Jan 2024 09:26:07 -0800 (PST)", "from localhost.localdomain (dyn-170-246-97.myactv.net.\n [24.170.246.97]) by smtp.gmail.com with ESMTPSA id\n bb21-20020a05622a1b1500b0042a04add8a4sm2618914qtb.60.2024.01.18.09.26.06\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 18 Jan 2024 09:26:06 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=threater-com.20230601.gappssmtp.com; s=20230601; t=1705598767;\n x=1706203567;\n darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=TQ1UumE0WwaJ+jUwR/6ya6+Rg7byKLEVwWV0UleFmyA=;\n b=ezoMdEyIHkIy1LaqFj43SfPndKucwM32AmCATYmOHZUYDzsZDxPu2o3ogToIOvVx7c\n 8zTgMJZP/5hgb7TBYEk81/XD/O8ppbnKSCwEtnStKNd8hLeZuWzEHD+kb5MgU6SIaSd7\n VbtLTYweBGWDB5Eejg+/eKOqvW43HWNflafkT6Nxhh/g9LMYeygyQausLTr5cuBl7D8/\n IbvEP2NfKWL/CMs4fCEIgyeJZ7MK3eiai4ruSbXy2dVdjLufHVnKFQdSafb41bR00Yuc\n +GTjrkrWIXl4jdel1JbZPkxC+gzsodxAeLr7J/LXBtztXVDLFt9I6QvfZUBSGuFjvqWc\n KwfQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1705598767; x=1706203567;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=TQ1UumE0WwaJ+jUwR/6ya6+Rg7byKLEVwWV0UleFmyA=;\n b=Gbpvb/Pr9744HREiUhdcSeJhQOwTAqhb0Gn4RL5D2ApkmPBPgfQQnV+a5ozPXnvUg/\n TYmIVAELSnnjo5aYbE1McK4xdqSw8FvWkR3tO8XbiARFI/vI1xYL3lLXYNPGPTszcR81\n m/KQUkfWndSBGwOqfB3tow0MTQ3O7y05rWyoOjAfZRc0e3Svjan5zIG2Sy8d2wYvy9gY\n XW3HGPzGigpB8pPxSPWOIouSILiRb7530xOoMZXZAiWcaWy3eiaRpjOtpa+ldc133i78\n hVZC9Mm2NZTHrPvERORfZLUu7fG9Zx9ag0pSCHQ+47P2ExKUkwtFMQxEHYQMkFKplj6F\n gpJQ==", "X-Gm-Message-State": "AOJu0Yyredd5s4x+B5lZ8yhV1aqrScyY1fdZ3mzPJt23rBF2DVDytZIG\n YEW6wetB6yQRMDuLIRFdQbsD7Zzk2AA/QWSgqihWW9szDA0SpnZNFJfzpxE8iDQ=", "X-Google-Smtp-Source": "\n AGHT+IEq1a7y2g3hNlp1AqovfOejppet6jxA3a59nn5bMOlb0YzSu0mbphVF5a5DqFqtIungOgepRg==", "X-Received": "by 2002:ac8:5994:0:b0:429:e2fa:fdc0 with SMTP id\n e20-20020ac85994000000b00429e2fafdc0mr1088265qte.43.1705598767109;\n Thu, 18 Jan 2024 09:26:07 -0800 (PST)", "From": "Jonathan Erb <jonathan.erb@threater.com>", "To": "ciara.power@intel.com", "Cc": "dev@dpdk.org, bruce.richardson@intel.com,\n Jonathan Erb <jonathan.erb@threater.com>", "Subject": "[PATCH] telemetry: correct json empty dictionaries", "Date": "Thu, 18 Jan 2024 12:26:02 -0500", "Message-Id": "<20240118172602.898004-1-jonathan.erb@threater.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20231224220201.762377-1-jonathan.erb@threater.com>", "References": "<20231224220201.762377-1-jonathan.erb@threater.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Fri, 19 Jan 2024 08:48:40 +0100", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Fix to allow telemetry to handle empty dictionaries correctly.\n\nThis patch resolves an issue where empty dictionaries are reported\nby telemetry as '[]' rather than '{}'. Initializing the output\nbuffer based on the container type resolves the issue.\n\nSigned-off-by: Jonathan Erb <jonathan.erb@threater.com>\n---\n .mailmap | 2 +-\n lib/telemetry/telemetry.c | 6 +++++-\n 2 files changed, 6 insertions(+), 2 deletions(-)", "diff": "diff --git a/.mailmap b/.mailmap\nindex ab0742a382..a6b66ab3ad 100644\n--- a/.mailmap\n+++ b/.mailmap\n@@ -675,7 +675,7 @@ John Ousterhout <ouster@cs.stanford.edu>\n John Romein <romein@astron.nl>\n John W. Linville <linville@tuxdriver.com>\n Jonas Pfefferle <jpf@zurich.ibm.com> <pepperjo@japf.ch>\n-Jonathan Erb <jonathan.erb@threatblockr.com> <jonathan.erb@banduracyber.com>\n+Jonathan Erb <jonathan.erb@threater.com> <jonathan.erb@threatblockr.com> <jonathan.erb@banduracyber.com>\n Jonathan Tsai <jonathan1.tsai@intel.com>\n Jon DeVree <nuxi@vault24.org>\n Jon Loeliger <jdl@netgate.com>\ndiff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telemetry.c\nindex 92982842a8..eef4ac7bb7 100644\n--- a/lib/telemetry/telemetry.c\n+++ b/lib/telemetry/telemetry.c\n@@ -169,7 +169,11 @@ container_to_json(const struct rte_tel_data *d, char *out_buf, size_t buf_len)\n \t\td->type != TEL_ARRAY_INT && d->type != TEL_ARRAY_STRING)\n \t\treturn snprintf(out_buf, buf_len, \"null\");\n \n-\tused = rte_tel_json_empty_array(out_buf, buf_len, 0);\n+\tif (d->type == TEL_DICT)\n+\t\tused = rte_tel_json_empty_obj(out_buf, buf_len, 0);\n+\telse\n+\t\tused = rte_tel_json_empty_array(out_buf, buf_len, 0);\n+\n \tif (d->type == TEL_ARRAY_UINT)\n \t\tfor (i = 0; i < d->data_len; i++)\n \t\t\tused = rte_tel_json_add_array_uint(out_buf,\n", "prefixes": [] }