Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137203/?format=api
{ "id": 137203, "url": "http://patchwork.dpdk.org/api/patches/137203/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240226130342.4115292-4-nishikanta.nayak@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240226130342.4115292-4-nishikanta.nayak@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240226130342.4115292-4-nishikanta.nayak@intel.com", "date": "2024-02-26T13:03:41", "name": "[v2,3/4] crypto/qat: update headers for GEN LCE support", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "49435da9e1fd6c101fa6250c05126d2ef39445f4", "submitter": { "id": 3253, "url": "http://patchwork.dpdk.org/api/people/3253/?format=api", "name": "Nayak, Nishikanta", "email": "nishikanta.nayak@intel.com" }, "delegate": { "id": 6690, "url": "http://patchwork.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240226130342.4115292-4-nishikanta.nayak@intel.com/mbox/", "series": [ { "id": 31221, "url": "http://patchwork.dpdk.org/api/series/31221/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31221", "date": "2024-02-26T13:03:38", "name": "add QAT GEN LCE device", "version": 2, "mbox": "http://patchwork.dpdk.org/series/31221/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/137203/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/137203/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3A5F843BEF;\n\tMon, 26 Feb 2024 14:04:14 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2D4F242E39;\n\tMon, 26 Feb 2024 14:03:57 +0100 (CET)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.16])\n by mails.dpdk.org (Postfix) with ESMTP id E334242E34\n for <dev@dpdk.org>; Mon, 26 Feb 2024 14:03:54 +0100 (CET)", "from orviesa009.jf.intel.com ([10.64.159.149])\n by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 26 Feb 2024 05:03:54 -0800", "from silpixa00401797.ir.intel.com (HELO\n silpixa00400355.ger.corp.intel.com) ([10.237.222.113])\n by orviesa009.jf.intel.com with ESMTP; 26 Feb 2024 05:03:53 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1708952635; x=1740488635;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=KEtYvMoFckdSWv+s4rJE6Fpl46uZQRJsRB6VjrPH5fc=;\n b=dLKOYs02w+/3mhlIMHEs49MxuIQqFM8r208l8qpHX3z1pAz2WYaVSVnh\n GrpfhcuCK/01/AlwftBJY8Qu+Vt96EUPeN33cOreFyNSuNBydpRsYpvdP\n Qg6NmTfukUC4ycPJseUP4+wzhW5xiFsLDSLeMO4+vWq2qYS/P/6R/Qw6+\n fkOBpuspxkoTc/Cg4el0KnpgFMJSz35PjjlO3ExQcZJB34mBGlHCpgCGb\n CVTN5lL5KVHTLPKhXYU1jpfG32rDbKCWgTKtJElaLrtxP/MUEdV87wbTP\n KWA+Ep+Km9kNIoGjFDcB/4axF7M+A0McZbVAXYygFo+e+BjmxyTN0TfWq g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10995\"; a=\"3367282\"", "E=Sophos;i=\"6.06,185,1705392000\";\n d=\"scan'208\";a=\"3367282\"", "E=Sophos;i=\"6.06,185,1705392000\";\n d=\"scan'208\";a=\"6695448\"" ], "X-ExtLoop1": "1", "From": "Nishikant Nayak <nishikanta.nayak@intel.com>", "To": "dev@dpdk.org", "Cc": "ciara.power@intel.com, kai.ji@intel.com, arkadiuszx.kusztal@intel.com,\n rakesh.s.joshi@intel.com, Nishikant Nayak <nishikanta.nayak@intel.com>", "Subject": "[PATCH v2 3/4] crypto/qat: update headers for GEN LCE support", "Date": "Mon, 26 Feb 2024 13:03:41 +0000", "Message-Id": "<20240226130342.4115292-4-nishikanta.nayak@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20240226130342.4115292-1-nishikanta.nayak@intel.com>", "References": "<20231220132616.318983-1-nishikanta.nayak@intel.com>\n <20240226130342.4115292-1-nishikanta.nayak@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patch handles the changes required for updating the common\nheader fields specific to GEN LCE, Also added/updated of the response\nprocessing APIs based on GEN LCE requirement.\n\nSigned-off-by: Nishikant Nayak <nishikanta.nayak@intel.com>\n---\nv2:\n - Renamed device from GEN 5 to GEN LCE.\n - Removed unused code.\n - Updated macro names.\n - Added GEN LCE specific API for deque burst.\n - Fixed code formatting.\n---\n---\n drivers/crypto/qat/qat_sym.c | 16 ++++++-\n drivers/crypto/qat/qat_sym.h | 60 ++++++++++++++++++++++++++-\n drivers/crypto/qat/qat_sym_session.c | 62 +++++++++++++++++++++++++++-\n drivers/crypto/qat/qat_sym_session.h | 10 ++++-\n 4 files changed, 140 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/crypto/qat/qat_sym.c b/drivers/crypto/qat/qat_sym.c\nindex 6e03bde841..439a3fc00b 100644\n--- a/drivers/crypto/qat/qat_sym.c\n+++ b/drivers/crypto/qat/qat_sym.c\n@@ -180,7 +180,15 @@ qat_sym_dequeue_burst(void *qp, struct rte_crypto_op **ops,\n \t\tuint16_t nb_ops)\n {\n \treturn qat_dequeue_op_burst(qp, (void **)ops,\n-\t\t\t\tqat_sym_process_response, nb_ops);\n+\t\t\tqat_sym_process_response, nb_ops);\n+}\n+\n+uint16_t\n+qat_sym_dequeue_burst_gen_lce(void *qp, struct rte_crypto_op **ops,\n+\t\t\t\t\t\t\tuint16_t nb_ops)\n+{\n+\treturn qat_dequeue_op_burst(qp, (void **)ops,\n+\t\t\tqat_sym_process_response_gen_lce, nb_ops);\n }\n \n int\n@@ -200,6 +208,7 @@ qat_sym_dev_create(struct qat_pci_device *qat_pci_dev,\n \tchar capa_memz_name[RTE_CRYPTODEV_NAME_MAX_LEN];\n \tstruct rte_cryptodev *cryptodev;\n \tstruct qat_cryptodev_private *internals;\n+\tenum qat_device_gen qat_dev_gen = qat_pci_dev->qat_dev_gen;\n \tconst struct qat_crypto_gen_dev_ops *gen_dev_ops =\n \t\t&qat_sym_gen_dev_ops[qat_pci_dev->qat_dev_gen];\n \n@@ -249,7 +258,10 @@ qat_sym_dev_create(struct qat_pci_device *qat_pci_dev,\n \tcryptodev->dev_ops = gen_dev_ops->cryptodev_ops;\n \n \tcryptodev->enqueue_burst = qat_sym_enqueue_burst;\n-\tcryptodev->dequeue_burst = qat_sym_dequeue_burst;\n+\tif (qat_dev_gen == QAT_GEN_LCE)\n+\t\tcryptodev->dequeue_burst = qat_sym_dequeue_burst_gen_lce;\n+\telse\n+\t\tcryptodev->dequeue_burst = qat_sym_dequeue_burst;\n \n \tcryptodev->feature_flags = gen_dev_ops->get_feature_flags(qat_pci_dev);\n \ndiff --git a/drivers/crypto/qat/qat_sym.h b/drivers/crypto/qat/qat_sym.h\nindex f2f197d050..3461113c13 100644\n--- a/drivers/crypto/qat/qat_sym.h\n+++ b/drivers/crypto/qat/qat_sym.h\n@@ -90,7 +90,7 @@\n /*\n * Maximum number of SGL entries\n */\n-#define QAT_SYM_SGL_MAX_NUMBER\t16\n+#define QAT_SYM_SGL_MAX_NUMBER 16\n \n /* Maximum data length for single pass GMAC: 2^14-1 */\n #define QAT_AES_GMAC_SPC_MAX_SIZE 16383\n@@ -142,6 +142,10 @@ uint16_t\n qat_sym_dequeue_burst(void *qp, struct rte_crypto_op **ops,\n \t\tuint16_t nb_ops);\n \n+uint16_t\n+qat_sym_dequeue_burst_gen_lce(void *qp, struct rte_crypto_op **ops,\n+\t\tuint16_t nb_ops);\n+\n #ifdef RTE_QAT_OPENSSL\n /** Encrypt a single partial block\n * Depends on openssl libcrypto\n@@ -390,6 +394,52 @@ qat_sym_process_response(void **op, uint8_t *resp, void *op_cookie,\n \treturn 1;\n }\n \n+static __rte_always_inline int\n+qat_sym_process_response_gen_lce(void **op, uint8_t *resp,\n+\tvoid *op_cookie __rte_unused,\n+\tuint64_t *dequeue_err_count __rte_unused)\n+{\n+\tstruct icp_qat_fw_comn_resp *resp_msg =\n+\t\t(struct icp_qat_fw_comn_resp *)resp;\n+\tstruct rte_crypto_op *rx_op = (struct rte_crypto_op *)(uintptr_t)\n+\t\t(resp_msg->opaque_data);\n+\tstruct qat_sym_session *sess;\n+\n+#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG\n+\tQAT_DP_HEXDUMP_LOG(DEBUG, \"qat_response:\", (uint8_t *)resp_msg,\n+\t\tsizeof(struct icp_qat_fw_comn_resp));\n+#endif\n+\n+\tsess = CRYPTODEV_GET_SYM_SESS_PRIV(rx_op->sym->session);\n+\n+\trx_op->status = RTE_CRYPTO_OP_STATUS_SUCCESS;\n+\n+\tif (ICP_QAT_FW_COMN_STATUS_FLAG_OK !=\n+\t\tICP_QAT_FW_COMN_RESP_UNSUPPORTED_REQUEST_STAT_GET(\n+\t\t\tresp_msg->comn_hdr.comn_status))\n+\t\trx_op->status = RTE_CRYPTO_OP_STATUS_NOT_PROCESSED;\n+\n+\telse if (ICP_QAT_FW_COMN_STATUS_FLAG_OK !=\n+\t\tICP_QAT_FW_COMN_RESP_INVALID_PARAM_STAT_GET(\n+\t\t\tresp_msg->comn_hdr.comn_status))\n+\t\trx_op->status = RTE_CRYPTO_OP_STATUS_INVALID_ARGS;\n+\n+\tif (sess->qat_dir == ICP_QAT_HW_CIPHER_DECRYPT) {\n+\t\tif (ICP_QAT_FW_LA_VER_STATUS_FAIL ==\n+\t\t\tICP_QAT_FW_COMN_RESP_CRYPTO_STAT_GET(\n+\t\t\t\tresp_msg->comn_hdr.comn_status))\n+\t\t\trx_op->status =\tRTE_CRYPTO_OP_STATUS_AUTH_FAILED;\n+\t}\n+\n+\t*op = (void *)rx_op;\n+\n+\t/*\n+\t * return 1 as dequeue op only move on to the next op\n+\t * if one was ready to return to API\n+\t */\n+\treturn 1;\n+}\n+\n int\n qat_sym_configure_dp_ctx(struct rte_cryptodev *dev, uint16_t qp_id,\n \tstruct rte_crypto_raw_dp_ctx *raw_dp_ctx,\n@@ -455,7 +505,13 @@ qat_sym_preprocess_requests(void **ops __rte_unused,\n \n static inline void\n qat_sym_process_response(void **op __rte_unused, uint8_t *resp __rte_unused,\n-\tvoid *op_cookie __rte_unused)\n+\tvoid *op_cookie __rte_unused, uint64_t *dequeue_err_count __rte_unused)\n+{\n+}\n+\n+static inline void\n+qat_sym_process_response_gen_lce(void **op __rte_unused, uint8_t *resp __rte_unused,\n+\tvoid *op_cookie __rte_unused, uint64_t *dequeue_err_count __rte_unused)\n {\n }\n \ndiff --git a/drivers/crypto/qat/qat_sym_session.c b/drivers/crypto/qat/qat_sym_session.c\nindex 9f4f6c3d93..8f50b61365 100644\n--- a/drivers/crypto/qat/qat_sym_session.c\n+++ b/drivers/crypto/qat/qat_sym_session.c\n@@ -136,6 +136,9 @@ qat_sym_cd_auth_set(struct qat_sym_session *cdesc,\n static void\n qat_sym_session_init_common_hdr(struct qat_sym_session *session);\n \n+static void\n+qat_sym_session_init_gen_lce_hdr(struct qat_sym_session *session);\n+\n /* Req/cd init functions */\n \n static void\n@@ -738,6 +741,12 @@ qat_sym_session_set_parameters(struct rte_cryptodev *dev,\n \t\tsession->qat_cmd);\n \t\treturn -ENOTSUP;\n \t}\n+\n+\tif (qat_dev_gen == QAT_GEN_LCE) {\n+\t\tqat_sym_session_init_gen_lce_hdr(session);\n+\t\treturn 0;\n+\t}\n+\n \tqat_sym_session_finalize(session);\n \n \treturn qat_sym_gen_dev_ops[qat_dev_gen].set_session((void *)dev,\n@@ -1016,6 +1025,12 @@ qat_sym_session_configure_aead(struct rte_cryptodev *dev,\n \t\t\tdev->data->dev_private;\n \tenum qat_device_gen qat_dev_gen =\n \t\t\tinternals->qat_dev->qat_dev_gen;\n+\tif (qat_dev_gen == QAT_GEN_LCE) {\n+\t\tstruct icp_qat_fw_la_bulk_req *req_tmpl = &session->fw_req;\n+\t\tstruct lce_key_buff_desc *key_buff = &req_tmpl->key_buff;\n+\n+\t\tkey_buff->keybuff = session->key_paddr;\n+\t}\n \n \t/*\n \t * Store AEAD IV parameters as cipher IV,\n@@ -1079,9 +1094,15 @@ qat_sym_session_configure_aead(struct rte_cryptodev *dev,\n \t}\n \n \tif (session->is_single_pass) {\n-\t\tif (qat_sym_cd_cipher_set(session,\n+\t\tif (qat_dev_gen != QAT_GEN_LCE) {\n+\t\t\tif (qat_sym_cd_cipher_set(session,\n \t\t\t\taead_xform->key.data, aead_xform->key.length))\n-\t\t\treturn -EINVAL;\n+\t\t\t\treturn -EINVAL;\n+\t\t} else {\n+\t\t\tsession->auth_key_length = aead_xform->key.length;\n+\t\t\tmemcpy(session->key_array, aead_xform->key.data,\n+\t\t\t\t\t\t\taead_xform->key.length);\n+\t\t}\n \t} else if ((aead_xform->op == RTE_CRYPTO_AEAD_OP_ENCRYPT &&\n \t\t\taead_xform->algo == RTE_CRYPTO_AEAD_AES_GCM) ||\n \t\t\t(aead_xform->op == RTE_CRYPTO_AEAD_OP_DECRYPT &&\n@@ -1970,6 +1991,43 @@ qat_sym_session_init_common_hdr(struct qat_sym_session *session)\n \t\t\t\t\tICP_QAT_FW_LA_NO_DIGEST_IN_BUFFER);\n }\n \n+static void\n+qat_sym_session_init_gen_lce_hdr(struct qat_sym_session *session)\n+{\n+\tstruct icp_qat_fw_la_bulk_req *req_tmpl = &session->fw_req;\n+\tstruct icp_qat_fw_comn_req_hdr *header = &req_tmpl->comn_hdr;\n+\n+\t/*\n+\t * GEN_LCE specifies separate command id for AEAD operations but Cryptodev\n+\t * API processes AEAD operations as Single pass Crypto operations.\n+\t * Hence even for GEN_LCE, Session Algo Command ID is CIPHER.\n+\t * Note, however Session Algo Mode is AEAD.\n+\t */\n+\theader->service_cmd_id = ICP_QAT_FW_LA_CMD_AEAD;\n+\theader->service_type = ICP_QAT_FW_COMN_REQ_CPM_FW_LA;\n+\theader->hdr_flags =\n+\tICP_QAT_FW_COMN_HDR_FLAGS_BUILD_GEN_LCE(ICP_QAT_FW_COMN_REQ_FLAG_SET,\n+\t\t\tICP_QAT_FW_COMN_GEN_LCE_DESC_LAYOUT);\n+\theader->comn_req_flags =\n+\t\tICP_QAT_FW_COMN_FLAGS_BUILD_GEN_LCE(QAT_COMN_PTR_TYPE_SGL,\n+\t\t\tQAT_COMN_KEY_BUFFER_USED);\n+\n+\tICP_QAT_FW_SYM_AEAD_ALGO_SET(header->serv_specif_flags,\n+\t\tQAT_LA_CRYPTO_AEAD_AES_GCM_GEN_LCE);\n+\tICP_QAT_FW_SYM_IV_SIZE_SET(header->serv_specif_flags,\n+\t\tICP_QAT_FW_LA_GCM_IV_LEN_12_OCTETS);\n+\tICP_QAT_FW_SYM_IV_IN_DESC_FLAG_SET(header->serv_specif_flags,\n+\t\tICP_QAT_FW_SYM_IV_IN_DESC_VALID);\n+\n+\tif (session->qat_dir == ICP_QAT_HW_CIPHER_DECRYPT) {\n+\t\tICP_QAT_FW_SYM_DIR_FLAG_SET(header->serv_specif_flags,\n+\t\t\tICP_QAT_HW_CIPHER_DECRYPT);\n+\t} else {\n+\t\tICP_QAT_FW_SYM_DIR_FLAG_SET(header->serv_specif_flags,\n+\t\t\tICP_QAT_HW_CIPHER_ENCRYPT);\n+\t}\n+}\n+\n int qat_sym_cd_cipher_set(struct qat_sym_session *cdesc,\n \t\t\t\t\t\tconst uint8_t *cipherkey,\n \t\t\t\t\t\tuint32_t cipherkeylen)\ndiff --git a/drivers/crypto/qat/qat_sym_session.h b/drivers/crypto/qat/qat_sym_session.h\nindex 9209e2e8df..958af03405 100644\n--- a/drivers/crypto/qat/qat_sym_session.h\n+++ b/drivers/crypto/qat/qat_sym_session.h\n@@ -111,10 +111,16 @@ struct qat_sym_session {\n \tenum icp_qat_hw_auth_op auth_op;\n \tenum icp_qat_hw_auth_mode auth_mode;\n \tvoid *bpi_ctx;\n-\tstruct qat_sym_cd cd;\n+\tunion {\n+\t\tstruct qat_sym_cd cd;\n+\t\tuint8_t key_array[32];\n+\t};\n \tuint8_t prefix_state[QAT_PREFIX_TBL_SIZE] __rte_cache_aligned;\n \tuint8_t *cd_cur_ptr;\n-\tphys_addr_t cd_paddr;\n+\tunion {\n+\t\tphys_addr_t cd_paddr;\n+\t\tphys_addr_t key_paddr;\n+\t};\n \tphys_addr_t prefix_paddr;\n \tstruct icp_qat_fw_la_bulk_req fw_req;\n \tuint8_t aad_len;\n", "prefixes": [ "v2", "3/4" ] }