Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138129/?format=api
{ "id": 138129, "url": "http://patchwork.dpdk.org/api/patches/138129/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/DU0PR83MB05321DB2ADBEDAE7687773DF97272@DU0PR83MB0532.EURPRD83.prod.outlook.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<DU0PR83MB05321DB2ADBEDAE7687773DF97272@DU0PR83MB0532.EURPRD83.prod.outlook.com>", "list_archive_url": "https://inbox.dpdk.org/dev/DU0PR83MB05321DB2ADBEDAE7687773DF97272@DU0PR83MB0532.EURPRD83.prod.outlook.com", "date": "2024-03-08T18:09:53", "name": "[v2] net/netvsc: fix number Tx queues > Rx queues", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "e7b26529cdae7287b28674b16abb8b317d649e59", "submitter": { "id": 3272, "url": "http://patchwork.dpdk.org/api/people/3272/?format=api", "name": "Alan Elder", "email": "alan.elder@microsoft.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/DU0PR83MB05321DB2ADBEDAE7687773DF97272@DU0PR83MB0532.EURPRD83.prod.outlook.com/mbox/", "series": [ { "id": 31442, "url": "http://patchwork.dpdk.org/api/series/31442/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31442", "date": "2024-03-08T18:09:53", "name": "[v2] net/netvsc: fix number Tx queues > Rx queues", "version": 2, "mbox": "http://patchwork.dpdk.org/series/31442/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/138129/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/138129/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 79C3443C27;\n\tFri, 8 Mar 2024 19:09:57 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 469B840274;\n\tFri, 8 Mar 2024 19:09:57 +0100 (CET)", "from EUR02-VI1-obe.outbound.protection.outlook.com\n (mail-vi1eur02on2114.outbound.protection.outlook.com [40.107.241.114])\n by mails.dpdk.org (Postfix) with ESMTP id 23AD840151\n for <dev@dpdk.org>; Fri, 8 Mar 2024 19:09:56 +0100 (CET)", "from DU0PR83MB0532.EURPRD83.prod.outlook.com (2603:10a6:10:314::5)\n by PA6PR83MB0646.EURPRD83.prod.outlook.com (2603:10a6:102:3d7::20) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.0; Fri, 8 Mar\n 2024 18:09:53 +0000", "from DU0PR83MB0532.EURPRD83.prod.outlook.com\n ([fe80::d876:e1dc:284a:fc57]) by DU0PR83MB0532.EURPRD83.prod.outlook.com\n ([fe80::d876:e1dc:284a:fc57%6]) with mapi id 15.20.7386.011; Fri, 8 Mar 2024\n 18:09:53 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=Xu8878qB6SFiriWSC3gP1WZOAsurLeJqi/zmAqttkZajymeF8ZeRE6MjiOeIVklh4FVU7Zx08LlR/0j6/Y7hlUdMlHihMwjs5TQUc5kYtsffTikfD+2uF/aDZusxNm8Fr07jHtOeFnE1H7mwiuU3ZQz/ZixAN3wjHv0DcIEUBWhyzDOS4L/gvlEUZcgDXUPpZebKSg/frlfimniGK7WZ/XJFetFclX2gfMf209iTCwQPMtkNVyisX9gEd2g69hEnkY79UZNAg+9q39El7uXePb5R6lJ0Nd6J1Cl92ZM/L6WiTtrHOcL1vQQrk2FtkGPa7A5w+tkqjM8HkTjliyZJRQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=Vud6X+Eu/DUX1BYRVUxDaMWXpMPuQwT+BgsTIH/u+I8=;\n b=oTnzw9pmOXH26h1wdgWV+9l7vtqcsVXTE3pSVe99w42nvd5d8pEjg/IjlijtTqswqXa6wrS2JqLSlmFboo2bSQ1tbJfY2mbkHx0r6+9Nh+RGByC0Z77g2jliaP3ezdZXhb6M45UwFZQncmVITwZ+3tpjGK2K7NBfb3mxNWEq5vxoK1hT+5W/lSfL5ALr5p00UAPxCeLRo52eg7K+x+z8BbJcQqZ5vfzoHpJJGhhXxZI2HYUfQ0p/gafsVLcRnfiTIURKF43qimIEZByPzkukmWGxEBlr8xGUUnb2vovi5XFGEpYNiwRQ+GlIJd8boCTNmjkgiGQGBvHzI4rLFco3dQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=microsoft.com; dmarc=pass action=none\n header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=Vud6X+Eu/DUX1BYRVUxDaMWXpMPuQwT+BgsTIH/u+I8=;\n b=AOHCgpSJQ50jzz/rNz6qz7i4saPlOJHz7o0zsFg8Qt1SoPBpU5GcY3UQt9wQi6z+PL0PSF309PzuZsdPEsWjNSJpemhEBH6WfKUJZb4fyeh7stFXsaN1TRNUUKtSvP2M7FT8ThztTMtA143Div/DvneTwTdvcq2TWN2ZqHWeC/E=", "From": "Alan Elder <alan.elder@microsoft.com>", "To": "Alan Elder <alan.elder@microsoft.com>, Long Li <longli@microsoft.com>,\n Ferruh Yigit <ferruh.yigit@amd.com>, Andrew Rybchenko\n <andrew.rybchenko@oktetlabs.ru>", "CC": "\"dev@dpdk.org\" <dev@dpdk.org>, stephen <stephen@networkplumber.org>", "Subject": "[PATCH v2] net/netvsc: fix number Tx queues > Rx queues", "Thread-Topic": "[PATCH v2] net/netvsc: fix number Tx queues > Rx queues", "Thread-Index": "AQHacYPRvICdWr2D80SqgVYZcULqOg==", "Date": "Fri, 8 Mar 2024 18:09:53 +0000", "Message-ID": "\n <DU0PR83MB05321DB2ADBEDAE7687773DF97272@DU0PR83MB0532.EURPRD83.prod.outlook.com>", "References": "\n <PA4PR83MB0526128CDADC4DCC27FAF491975F2@PA4PR83MB0526.EURPRD83.prod.outlook.com>", "In-Reply-To": "\n <PA4PR83MB0526128CDADC4DCC27FAF491975F2@PA4PR83MB0526.EURPRD83.prod.outlook.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "msip_labels": "\n MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=979ac031-206c-4225-b627-540697dac625;\n MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;\n MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;\n MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;\n MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;\n MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2024-02-29T19:11:26Z;\n MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;", "authentication-results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=microsoft.com;", "x-ms-publictraffictype": "Email", "x-ms-traffictypediagnostic": "DU0PR83MB0532:EE_|PA6PR83MB0646:EE_", "x-ms-office365-filtering-correlation-id": "314dfb61-b63e-4139-3293-08dc3f9af405", "x-ld-processed": "72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr", "x-ms-exchange-senderadcheck": "1", "x-ms-exchange-antispam-relay": "0", "x-microsoft-antispam": "BCL:0;", "x-microsoft-antispam-message-info": "\n LGG+4r41JAtc54oIHs5UhmvPZBQW9Ax3h10R54wxJeFl5pl+YEs40aCX7NXxc5/Uxt/78sIjTmeqsCvImdpuaaQBXjQzwGzWyMWsq7Zj9zfjlHl3SPOW7F1MjsKDlkXu5nzdnk4TcJxNS9WWrlyHjhFcD5pypWdQFUeERkSR33sUEeyklZK20KDLv3A7jYjf+qtmv3alL1+AqtsJu8aKcUmPyfE5Wex+M/VyLLXKIPXCRHhb8cJ7rYsQefdRKFDMRzXiudM0ftjjw5noWKIgKUrMVUfnLd91Iv9YAvLqzrAbi54ZABVzIIjq19eI8ci95g2TpINcxVUu50dvrY7+lE2ODz/kmaW1lxIbVPL1Y9aU/EqbZ/8G+LTPDDOG39fdJ9F6l9ahCCwbU/q8LyqntlcWOihQ4qJQUW+Svtu8v57LqApeHMpSYZrD4kZmLmi6f0TVu2/Mx+Vf49kbCjUwPUYfMONuhnXLatmB+t5wGE5oRiIuRel3ZnsWnK88mLt9/5gd3RdkBnVFMCiW3gQuDeEu16gPkMyF/2Bhf9IPZR/Lekec/Cm88GRogRFfLkr2uLt/6vG5M9UwAHSL6CULSXU2zuKT/YL1iFPE2jjnd25eH1uPxqaZaVGCCQ82KlZMus0qGyi6ZbPwVjpe0hULZa9jA/95OLNZ6syYE84uWZvWC92A1W97/dGd214+bbHd20hGoaxwxyfH/A+ierNvdrCBBvorn6psEd1anQRX/Rw=", "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:DU0PR83MB0532.EURPRD83.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230031)(1800799015)(376005)(38070700009); DIR:OUT; SFP:1102;", "x-ms-exchange-antispam-messagedata-chunkcount": "1", "x-ms-exchange-antispam-messagedata-0": "\n 7pJTEq2kiec/1+taFrUrPUA+nP98EsFanGqe1h/21/XmLQcNdZAd8mCIj7HcXOUvt+D37ix2lB4ArDJlZmkU4HhwYcWB9yM2+5Bt62d3CU+1xR5YSqV6RwO8Rp3ds/M+FwlAPI/PHR2YNevTk7PXlR07y+npI1hiws39rsIu5fNvs7JewA0IbnVS/YabNeEyY4q8BQV/iJnlojQPWKKds+t5DA8vk6WO9Dn1RMKvw3htOqq0klTdS6hX5A5S6QdpbU6tc7qTgAZude0ixfO6sOGo2lIhNIUVdbTZKio1M9ZuiXK8T/i5NTPjG/Vsx9X/wgJR7zgu3m9T0I5R5pv07zhzVORqxZUPLvZMrwDooRoqskiChYJO60J0DVIEFDt3bXy8l9PBLCC+iwCTIbM4JcTtY5UbAoUlSTwYTe+00OaXXfpXmlSF35Y0M0Y7OAnTvfn24WGvqjyYWUMXrs1tc9OnQVKfkKtWVPUqnQMFgknMpOINBDWhTnOKo/mRhDIaP9giugkAdN9IR8rvcFB0BvvRgQm0M+ndNpdFGPgnBW+YeHhwBT5eMNpWhfyMek65ULTSbOB3QboK78pOmlt4E/ebE6QOckGmrHDNWTEFW3PQWHMGEdLhiTu5jh5+XwIJO4CdjtA0MlIDXTs+oyYf3ztbGKeV8/i6bmA+M97lRGccEhMoDdM2dbldgSyTwCGxgla69UUcS99iHfT8bMrGLlrj5j4B9bjJHzeUt/N+cyuNabDjt8c+V1oa5wr2vNQYcAxcZVndh8olr161APXkmYoqZ+gObYJlCRENUjUC8jnvEhnd4tV6/KXZciugCyvd012eP5XCNs/99+5vDeJZeDwU7kqLypcuuGoDYxQsFS1oaGM2TkxlQOx8CGuwpLS02NhdDL4Pz8/eJZpVnJEnRG3EiSbjZaZMgqPAGiOgfi4afAGSPhikV4ZtKhXj5OZ2lKc48dhje5/ldLs8iXQM0oFm/DgtICyueC6UY3bVdKG3cXiLRrdtpTE0iMA36LWe9wknaVJtlSqY2E4HJzCV0vSyBj/RRZc0wwLycxQr1awTv/XUeGsftwkB/S+LhLaI+aF2QWCv7GA+K1R0kH81urwZsOXEGLVVwuiIRTwk0meIOYOTruLbpfel4jPJMx6tk3xKaF/1BQF93OJar4kdshLPvQpHELfcmn5mT0J19klNZiodFE8PKVhwm0xLgT6p0oIF+9H/XNmz1DZDb1iQIJVbR7cmzoTVHK5abRw0mH6kpBj4nMq7vV9aFR+ckqdnwwVaON6jh76BJ+bpPVuKDhX79ARJhGgq9EkwxZRI8HNJNRhPbx9VsGfvgYUdEWG2KXEWZSrDvSJm7TfeMwjQrEMNuMclNT/hgF7O2rESfUkHXmik09jfxN2QCjZgK/NmCcxJqMfUae6I5frFQWPGaY5phUA69JXg9H77eSFT+8uhK+pg5Pg0LPzH+FiFkQaqSLEIVvV1ywxLfpvrXO/Ng2AJnxF+fk4EQr0lqEPxJOUDNk9c9lFFrxnxiNlNB43D", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "microsoft.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-AuthSource": "DU0PR83MB0532.EURPRD83.prod.outlook.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 314dfb61-b63e-4139-3293-08dc3f9af405", "X-MS-Exchange-CrossTenant-originalarrivaltime": "08 Mar 2024 18:09:53.0664 (UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "72f988bf-86f1-41af-91ab-2d7cd011db47", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "\n yLyonPpsLcPVp6/Pka7AxZpLz6SRIAMpY9zJ5ymSFpFMOAsFQd/BuXchgCsw4du/rYtf6E6bAuXgrL0/zJrGlQ==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "PA6PR83MB0646", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The previous code allowed the number of Tx queues to be set higher than\nthe number of Rx queues. If a packet was sent on a Tx queue with index\n>= number Rx queues there was a segfault.\n\nThis commit fixes the issue by creating an Rx queue for every Tx queue\nmeaning that an event buffer is allocated to handle receiving Tx\ncompletion messages.\n\nmbuf pool and Rx ring are not allocated for these additional Rx queues\nand RSS configuration ensures that no packets are received on them.\n\nFixes: 4e9c73e96e83 (\"net/netvsc: add Hyper-V network device\")\nCc: sthemmin@microsoft.com\nCc: stable@dpdk.org\n\nSigned-off-by: Alan Elder <alan.elder@microsoft.com>\n---\nv2:\n* Remove function declaration for static non-member function\n\n---\n drivers/net/netvsc/hn_ethdev.c | 9 +++++++\n drivers/net/netvsc/hn_rxtx.c | 46 +++++++++++++++++++++++++++++++---\n 2 files changed, 52 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c\nindex b8a32832d7..d7e3f12346 100644\n--- a/drivers/net/netvsc/hn_ethdev.c\n+++ b/drivers/net/netvsc/hn_ethdev.c\n@@ -313,6 +313,15 @@ static int hn_rss_reta_update(struct rte_eth_dev *dev,\n \n \t\tif (reta_conf[idx].mask & mask)\n \t\t\thv->rss_ind[i] = reta_conf[idx].reta[shift];\n+\n+\t\t/*\n+\t\t * Ensure we don't allow config that directs traffic to an Rx\n+\t\t * queue that we aren't going to poll\n+\t\t */\n+\t\tif (hv->rss_ind[i] >= dev->data->nb_rx_queues) {\n+\t\t\tPMD_DRV_LOG(ERR, \"RSS distributing traffic to invalid Rx queue\");\n+\t\t\treturn -EINVAL;\n+\t\t}\n \t}\n \n \terr = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);\ndiff --git a/drivers/net/netvsc/hn_rxtx.c b/drivers/net/netvsc/hn_rxtx.c\nindex 9bf1ec5509..c0aaeaa972 100644\n--- a/drivers/net/netvsc/hn_rxtx.c\n+++ b/drivers/net/netvsc/hn_rxtx.c\n@@ -243,6 +243,7 @@ hn_dev_tx_queue_setup(struct rte_eth_dev *dev,\n {\n \tstruct hn_data *hv = dev->data->dev_private;\n \tstruct hn_tx_queue *txq;\n+\tstruct hn_rx_queue *rxq;\n \tchar name[RTE_MEMPOOL_NAMESIZE];\n \tuint32_t tx_free_thresh;\n \tint err = -ENOMEM;\n@@ -301,6 +302,22 @@ hn_dev_tx_queue_setup(struct rte_eth_dev *dev,\n \t\tgoto error;\n \t}\n \n+\t/*\n+\t * If there are more Tx queues than Rx queues, allocate rx_queues\n+\t * with event buffer so that Tx completion messages can still be\n+\t * received\n+\t */\n+\tif (queue_idx >= dev->data->nb_rx_queues) {\n+\t\trxq = hn_rx_queue_alloc(hv, queue_idx, socket_id);\n+\t\t/*\n+\t\t * Don't allocate mbuf pool or rx ring. RSS is always configured\n+\t\t * to ensure packets aren't received by this Rx queue.\n+\t\t */\n+\t\trxq->mb_pool = NULL;\n+\t\trxq->rx_ring = NULL;\n+\t\tdev->data->rx_queues[queue_idx] = rxq;\n+\t}\n+\n \ttxq->agg_szmax = RTE_MIN(hv->chim_szmax, hv->rndis_agg_size);\n \ttxq->agg_pktmax = hv->rndis_agg_pkts;\n \ttxq->agg_align = hv->rndis_agg_align;\n@@ -354,6 +371,17 @@ static void hn_txd_put(struct hn_tx_queue *txq, struct hn_txdesc *txd)\n \trte_mempool_put(txq->txdesc_pool, txd);\n }\n \n+static void\n+hn_rx_queue_free_common(struct hn_rx_queue *rxq)\n+{\n+\tif (!rxq)\n+\t\treturn;\n+\n+\trte_free(rxq->rxbuf_info);\n+\trte_free(rxq->event_buf);\n+\trte_free(rxq);\n+}\n+\n void\n hn_dev_tx_queue_release(struct rte_eth_dev *dev, uint16_t qid)\n {\n@@ -364,6 +392,13 @@ hn_dev_tx_queue_release(struct rte_eth_dev *dev, uint16_t qid)\n \tif (!txq)\n \t\treturn;\n \n+\t/*\n+\t * Free any Rx queues allocated for a Tx queue without a corresponding\n+\t * Rx queue\n+\t */\n+\tif (qid >= dev->data->nb_rx_queues)\n+\t\thn_rx_queue_free_common(dev->data->rx_queues[qid]);\n+\n \trte_mempool_free(txq->txdesc_pool);\n \n \trte_memzone_free(txq->tx_rndis_mz);\n@@ -942,6 +977,13 @@ hn_dev_rx_queue_setup(struct rte_eth_dev *dev,\n \tif (queue_idx == 0) {\n \t\trxq = hv->primary;\n \t} else {\n+\t\t/*\n+\t\t * If the number of Tx queues was previously greater than\n+\t\t * the number of Rx queues, we may already have allocated\n+\t\t * an rxq. If so, free it now before allocating a new one.\n+\t\t */\n+\t\thn_rx_queue_free_common(dev->data->rx_queues[queue_idx]);\n+\n \t\trxq = hn_rx_queue_alloc(hv, queue_idx, socket_id);\n \t\tif (!rxq)\n \t\t\treturn -ENOMEM;\n@@ -998,9 +1040,7 @@ hn_rx_queue_free(struct hn_rx_queue *rxq, bool keep_primary)\n \tif (keep_primary && rxq == rxq->hv->primary)\n \t\treturn;\n \n-\trte_free(rxq->rxbuf_info);\n-\trte_free(rxq->event_buf);\n-\trte_free(rxq);\n+\thn_rx_queue_free_common(rxq);\n }\n \n void\n", "prefixes": [ "v2" ] }