Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138766/?format=api
{ "id": 138766, "url": "http://patchwork.dpdk.org/api/patches/138766/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240325105826.393231-1-bingz@nvidia.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240325105826.393231-1-bingz@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240325105826.393231-1-bingz@nvidia.com", "date": "2024-03-25T10:58:26", "name": "[v2] app/testpmd: fix releasing action handle flush memory", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ec05960c9422534ba54eaa9ab6c8179782fe341a", "submitter": { "id": 1976, "url": "http://patchwork.dpdk.org/api/people/1976/?format=api", "name": "Bing Zhao", "email": "bingz@nvidia.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240325105826.393231-1-bingz@nvidia.com/mbox/", "series": [ { "id": 31611, "url": "http://patchwork.dpdk.org/api/series/31611/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31611", "date": "2024-03-25T10:58:26", "name": "[v2] app/testpmd: fix releasing action handle flush memory", "version": 2, "mbox": "http://patchwork.dpdk.org/series/31611/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/138766/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/138766/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BE9E743D46;\n\tMon, 25 Mar 2024 11:59:05 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8E5C040271;\n\tMon, 25 Mar 2024 11:59:05 +0100 (CET)", "from NAM10-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam10on2052.outbound.protection.outlook.com [40.107.93.52])\n by mails.dpdk.org (Postfix) with ESMTP id DDAD140270;\n Mon, 25 Mar 2024 11:59:03 +0100 (CET)", "from BN7PR06CA0053.namprd06.prod.outlook.com (2603:10b6:408:34::30)\n by LV2PR12MB5920.namprd12.prod.outlook.com (2603:10b6:408:172::20)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.31; Mon, 25 Mar\n 2024 10:59:01 +0000", "from BN3PEPF0000B073.namprd04.prod.outlook.com\n (2603:10b6:408:34:cafe::46) by BN7PR06CA0053.outlook.office365.com\n (2603:10b6:408:34::30) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.13 via Frontend\n Transport; Mon, 25 Mar 2024 10:59:01 +0000", "from mail.nvidia.com (216.228.117.160) by\n BN3PEPF0000B073.mail.protection.outlook.com (10.167.243.118) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.7409.10 via Frontend Transport; Mon, 25 Mar 2024 10:59:01 +0000", "from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com\n (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 25 Mar\n 2024 03:58:45 -0700", "from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com\n (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Mon, 25 Mar\n 2024 03:58:43 -0700" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=mGGG6xPAVBp4Fq/68Ouyb+TysK9ev77QnvOM3fKlPrVc7wSI5g0byU7IYMF5k3KC0/wfjJftv+n9TwCfiguTevYfSuvSuDg9K8w76N30P5WHKGJ9fmwVVpExr0C/XK5scYMsIkZuWVxC7eNKiXd4sIn9wVYcKXl0s4rN3J+u4bz0b3M7PmtFbREm86LWMQZSOddiiM6fJJO7Sbfd+7isbjHYVFKWNhav2qcJT3sbRToalufcxpr3UoeXx4AHNLowXZsb0dHBSY7zyl8jfvh/mH+0KDQPriDgYslJDOXiXSflN9fnGun1HIF24ELETQQrnklZLn+ZLsS76lJZO/S6AA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=eks5dD+3m1fS4BnoRMLRGRFHyVJMR3hmJOQPQy3Lz7s=;\n b=SozRPVYNiS+b2cpE/HtVReo+5912vMj2C9hLQTVagyltohOcDT9cj7F9EdxPhwKKjSg0aAbBAoZsUQYNzXTfPCd6gvwivDX2CiVZ9wRCK20C9qp7h3rYM6gVdw1seiKdMM5WsNXL0dgnnD6p2UiLSJLcnrBl/iV7EKF39h+dxAdK1HY+QQcWzNvojH5I+LCxyDNNnKC2fFewhFmuZIKtf5ZZSJQoD6FFkyC8PSXwibrkYEnsNtu8UQA/T+3Qvey0e1n/bZ7dFNPJdXS7P0mJ61NYZkPMMastvO6kqiwqqHnIUYZpiGlFfxvUAIm306bSVAT1udbeelXOrGlXdLgQ9A==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.160) smtp.rcpttodomain=gmail.com smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=eks5dD+3m1fS4BnoRMLRGRFHyVJMR3hmJOQPQy3Lz7s=;\n b=ujD1m3+IBocdXrFtLA+AX0xapBjt26a9up9YfMaPwADKDiMhc1jMzTVSwK/bf6ThRIEK0QEmwY3EU7D6c7FaWUF0UyC//COKb/JwbIsx61DCqs4L/ZC2p7NIiquL5Ef4GIJFYKSRMOVQaWsdvvKEiU8i7oRqlYez69XsLYqoLdcHHpgG+BNYRRUs4M7R0pFQxlU1i+K24gQGovHkrnqJ+1EuRDE6V+Py6Fofo/dRHRPixfCBI9BSiJkS5GqRKvwMbpy/mRSiKZhUHBUOreTC69dBJoWuEAbefltsxhe1rKHFTLoyH5u4dZS1MVLL5G+rG2Ay5NHm0S7uLk0PtUAuYQ==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.160)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.160 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C", "From": "Bing Zhao <bingz@nvidia.com>", "To": "<dmitry.kozliuk@gmail.com>, <dev@dpdk.org>", "CC": "<aman.deep.singh@intel.com>, <yuying.zhang@intel.com>, <matan@nvidia.com>,\n <stable@dpdk.org>, Dariusz Sosnowski <dsosnowski@nvidia.com>", "Subject": "[PATCH v2] app/testpmd: fix releasing action handle flush memory", "Date": "Mon, 25 Mar 2024 12:58:26 +0200", "Message-ID": "<20240325105826.393231-1-bingz@nvidia.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240319093249.307606-1-bingz@nvidia.com>", "References": "<20240319093249.307606-1-bingz@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.126.231.35]", "X-ClientProxiedBy": "rnnvmail201.nvidia.com (10.129.68.8) To\n rnnvmail201.nvidia.com (10.129.68.8)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "BN3PEPF0000B073:EE_|LV2PR12MB5920:EE_", "X-MS-Office365-Filtering-Correlation-Id": "34729e0e-e677-4955-0562-08dc4cba944c", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n m4dqcb5HV9IvHp6WDp88X8sPgWCpaEl8SoEWhV8tEbXn+VKlk88XLjqlhgIsqIDR4UyLVm7EiKAk7iQ1L8mpEplduwiANB4DFQXLio00lSEn0O6XkDbPj3sYAORCcHOOfnMe7jPNuUfOodaOv0GEBezIBRXBwC6J3Nk/2kkDS+jAyEIAp53DXjufXJW6NHNBwur1pwl4ZoOrJvLvZzOy6T94gGWLf68hsVfuEBDYdrjUmdumVuObBz9GoC18Ob13BAY5/xqaFfNqKlCNa4DQtY7oUNHgC7eoQ2DXZjbxu+VU3NCSIZNZFvhmt1vBd5caGpVsumauoeRucobnpH8wPrV27+R7it31rrJQtf6DY+xY0bN4LLNMZvAIRFotKCxiYuNMbcZL9HPrzOndja7sS7dGJzjvDQoUDerx0JxVCtmAjZR2fHAc1QpxFcKaWUIREVZrVbxF/0ImrtBvrIkKRD21AfK19zf/vXQ6ECsNjb8F716MLwxYQvIJODJMMyKGHPQ+HPlqYeeKTjMuYLJjAHppfeuY+CmVxAhp4mZ3lwTFqZX1LiiKcK5e2+QzZA+Y3wUPJNdVFW/svv9+HHrKdR11cAc3O28zRRYtnIRumXajGW05au66Iq7m0oqW3PDAzpsGFJs1CT0O/J+95W4QeI32yBKsTXkqWBpGVpxpzhZ8RdxX7VnB/C54Rk3oAJT4mlh67NQULdQZqmGE+Qq1q/f7KyeEaOgiz0SPJNkYZElERkVC1Q8YMCe4DJ2ljYkH", "X-Forefront-Antispam-Report": "CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE;\n SFS:(13230031)(1800799015)(376005)(82310400014)(36860700004); DIR:OUT;\n SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "25 Mar 2024 10:59:01.3218 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 34729e0e-e677-4955-0562-08dc4cba944c", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n BN3PEPF0000B073.namprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "LV2PR12MB5920", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The memory of the indirect action handles should be freed after\nbeing destroyed in the flush. The behavior needs to be consistent\nwith the single handle destroy port_action_handle_destroy().\n\nOr else, there would be some memory leak when closing / detaching a\nport without quitting the application. In the meanwhile, since the\naction handles are already destroyed, it makes no sense to hold the\nindirect action software resources anymore.\n\nFixes: f7352c176bbf (\"app/testpmd: fix use of indirect action after port close\")\nCc: dmitry.kozliuk@gmail.com\nCc: stable@dpdk.org\n\nSigned-off-by: Bing Zhao <bingz@nvidia.com>\nReviewed-by: Dariusz Sosnowski <dsosnowski@nvidia.com>\n---\nv2: update the description\n---\n app/test-pmd/config.c | 9 +++------\n 1 file changed, 3 insertions(+), 6 deletions(-)", "diff": "diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c\nindex ba1007ace6..f62ba90c87 100644\n--- a/app/test-pmd/config.c\n+++ b/app/test-pmd/config.c\n@@ -1918,8 +1918,7 @@ port_action_handle_flush(portid_t port_id)\n \t\t/* Poisoning to make sure PMDs update it in case of error. */\n \t\tmemset(&error, 0x44, sizeof(error));\n \t\tif (pia->handle != NULL) {\n-\t\t\tret = pia->type ==\n-\t\t\t RTE_FLOW_ACTION_TYPE_INDIRECT_LIST ?\n+\t\t\tret = pia->type == RTE_FLOW_ACTION_TYPE_INDIRECT_LIST ?\n \t\t\t rte_flow_action_list_handle_destroy\n \t\t\t\t (port_id, pia->list_handle, &error) :\n \t\t\t rte_flow_action_handle_destroy\n@@ -1929,11 +1928,9 @@ port_action_handle_flush(portid_t port_id)\n \t\t\t\t pia->id);\n \t\t\t\tret = port_flow_complain(&error);\n \t\t\t}\n-\t\t\ttmp = &pia->next;\n-\t\t} else {\n-\t\t\t*tmp = pia->next;\n-\t\t\tfree(pia);\n \t\t}\n+\t\t*tmp = pia->next;\n+\t\tfree(pia);\n \t}\n \treturn ret;\n }\n", "prefixes": [ "v2" ] }