Patch Comment Detail
get:
Show a patch comment.
patch:
Update a patch comment.
put:
Update a patch comment.
GET /api/patches/139282/comments/169780/?format=api
{ "id": 169780, "web_url": "http://patchwork.dpdk.org/comment/169780/", "msgid": "<98CBD80474FA8B44BF855DF32C47DC35E9F40B@smartserver.smartshare.dk>", "list_archive_url": "https://inbox.dpdk.org/dev/98CBD80474FA8B44BF855DF32C47DC35E9F40B@smartserver.smartshare.dk", "date": "2024-05-01T07:43:06", "subject": "RE: [PATCH v4] net/netvsc: fix number Tx queues > Rx queues", "submitter": { "id": 591, "url": "http://patchwork.dpdk.org/api/people/591/?format=api", "name": "Morten Brørup", "email": "mb@smartsharesystems.com" }, "content": "> From: Alan Elder [mailto:alan.elder@microsoft.com]\n> Sent: Monday, 15 April 2024 16.41\n> \n> The previous code allowed the number of Tx queues to be set higher than the\n> number of Rx queues. If a packet was sent on a Tx queue with index\n> >= number Rx queues there was a segfault due to accessing beyond the end of\n> the dev->data->rx_queues[] array.\n> \n> #0 rte_spinlock_trylock (sl = invalid address) at /include/rte_spinlock.h L63\n> #1 hn_process_events at /drivers/net/netvsc/hn_rxtx.c L 1129\n> #2 hn_xmit_pkts at /drivers/net/netvsc/hn_rxtx.c L1553\n> \n> This commit fixes the issue by creating an Rx queue for every Tx queue meaning\n> that an event buffer is allocated to handle receiving Tx completion messages.\n> \n> mbuf pool and Rx ring are not allocated for these additional Rx queues and RSS\n> configuration ensures that no packets are received on them.\n> \n> Fixes: 4e9c73e96e83 (\"net/netvsc: add Hyper-V network device\")\n> Cc: sthemmin@microsoft.com\n> Cc: stable@dpdk.org\n> \n> Signed-off-by: Alan Elder <alan.elder@microsoft.com>\n> ---\n\nIs there any requirements to the order the application must call rte_eth_rx_queue_setup() and rte_eth_tx_queue_setup()?\n\nI.e. does it work if rte_eth_tx_queue_setup() is called before rte_eth_rx_queue_setup(), and in the opposite order?\n\n\nAlthough the ethdev documentation says:\n\n\"The functions exported by the application Ethernet API to setup a device designated by its port identifier must be invoked in the following order:\n\nrte_eth_dev_configure()\nrte_eth_tx_queue_setup()\nrte_eth_rx_queue_setup()\nrte_eth_dev_start()\",\n\nI would assume the order of calling rte_eth_tx_queue_setup() and rte_eth_rx_queue_setup() doesn't matter.\n\n\nAnd the rte_eth_dev_reset() function documentation has rx/tx queue setup in the opposite order:\n\n\"After calling rte_eth_dev_reset(), the application should use rte_eth_dev_configure(), rte_eth_rx_queue_setup(), rte_eth_tx_queue_setup(), and rte_eth_dev_start() to reconfigure the device as appropriate.\"", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B3AEB43F5A;\n\tWed, 1 May 2024 09:43:15 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C9177402A7;\n\tWed, 1 May 2024 09:43:12 +0200 (CEST)", "from dkmailrelay1.smartsharesystems.com\n (smartserver.smartsharesystems.com [77.243.40.215])\n by mails.dpdk.org (Postfix) with ESMTP id 797674021E\n for <dev@dpdk.org>; Wed, 1 May 2024 09:43:11 +0200 (CEST)", "from smartserver.smartsharesystems.com\n (smartserver.smartsharesys.local [192.168.4.10])\n by dkmailrelay1.smartsharesystems.com (Postfix) with ESMTP id 52D8E22038;\n Wed, 1 May 2024 09:43:11 +0200 (CEST)" ], "Content-class": "urn:content-classes:message", "MIME-Version": "1.0", "Content-Type": "text/plain;\n\tcharset=\"iso-8859-1\"", "Content-Transfer-Encoding": "quoted-printable", "Subject": "RE: [PATCH v4] net/netvsc: fix number Tx queues > Rx queues", "Date": "Wed, 1 May 2024 09:43:06 +0200", "X-MimeOLE": "Produced By Microsoft Exchange V6.5", "Message-ID": "<98CBD80474FA8B44BF855DF32C47DC35E9F40B@smartserver.smartshare.dk>", "In-Reply-To": "\n <PA4PR83MB05261AB024A2F6A286CBF22E97092@PA4PR83MB0526.EURPRD83.prod.outlook.com>", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "Thread-Topic": "[PATCH v4] net/netvsc: fix number Tx queues > Rx queues", "Thread-Index": "AQHaj0LlOhmlskdRP0OAUkt+bSOHnLGCE4Aw", "References": "\n <PA4PR83MB0526128CDADC4DCC27FAF491975F2@PA4PR83MB0526.EURPRD83.prod.outlook.com>\n <DU0PR83MB05321DB2ADBEDAE7687773DF97272@DU0PR83MB0532.EURPRD83.prod.outlook.com>\n <SJ1PR21MB3457C3F4261C263951DE9F4BCE2B2@SJ1PR21MB3457.namprd21.prod.outlook.com>\n <PA4PR83MB0526053A870E8358B7CB3643972C2@PA4PR83MB0526.EURPRD83.prod.outlook.com>\n <PA4PR83MB05261AB024A2F6A286CBF22E97092@PA4PR83MB0526.EURPRD83.prod.outlook.com>", "From": "=?iso-8859-1?q?Morten_Br=F8rup?= <mb@smartsharesystems.com>", "To": "\"Alan Elder\" <alan.elder@microsoft.com>, \"Long Li\" <longli@microsoft.com>,\n \"Ferruh Yigit\" <ferruh.yigit@amd.com>,\n \"Andrew Rybchenko\" <andrew.rybchenko@oktetlabs.ru>", "Cc": "<dev@dpdk.org>,\n\t\"Stephen Hemminger\" <stephen@networkplumber.org>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "addressed": null }