Patch Comment Detail
get:
Show a patch comment.
patch:
Update a patch comment.
put:
Update a patch comment.
GET /api/patches/139476/comments/169567/?format=api
{ "id": 169567, "web_url": "http://patchwork.dpdk.org/comment/169567/", "msgid": "<20240418151226.GA31175@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20240418151226.GA31175@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net", "date": "2024-04-18T15:12:26", "subject": "Re: [PATCH 16/16] build: enable vla warnings on Windows built code", "submitter": { "id": 2077, "url": "http://patchwork.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "content": "On Thu, Apr 18, 2024 at 08:48:39AM +0200, Morten Brørup wrote:\n> > MSVC does not support optional C11 VLAs. When building for Windows\n> > enable -Wvla so that mingw and clang also fail if a VLA is used.\n> \n> Minor detail, doesn't affect my Ack for the series...\n> \n> Applications built for Windows with mingw and clang might use VLAs in the application itself.\n> \n> Perhaps we should let them continue doing that for now.\n\ni guess you mean our examples or if dpdk is configured as a sub-project?\n\nfor examples i could explicitly suppress in examples with -Wno-vla but\nthat means any that use VLAs could not be built with MSVC.\n\nfor sub-module and sub-project of dpdk i feel like these\nadd_project_arguments are not imparted on the application with\nencapsulating project meson setup no?\n\nanyone know? Bruce? Stephen?\n\n> \n> > \n> > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n> > ---\n> > config/meson.build | 4 ++++\n> > 1 file changed, 4 insertions(+)\n> > \n> > diff --git a/config/meson.build b/config/meson.build\n> > index 8c8b019..9e887f2 100644\n> > --- a/config/meson.build\n> > +++ b/config/meson.build\n> > @@ -344,6 +344,10 @@ if cc.get_id() == 'intel'\n> > warning_flags += '-diag-disable=@0@'.format(i)\n> > endforeach\n> > endif\n> > +# no VLAs in code built on Windows\n> > +if is_windows\n> > + warning_flags += '-Wvla'\n> > +endif\n> > foreach arg: warning_flags\n> > if cc.has_argument(arg)\n> > add_project_arguments(arg, language: 'c')\n> > --\n> > 1.8.3.1\n>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D5BBC43EA5;\n\tThu, 18 Apr 2024 17:12:28 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C396940272;\n\tThu, 18 Apr 2024 17:12:28 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 3DD5940042\n for <dev@dpdk.org>; Thu, 18 Apr 2024 17:12:27 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 8C37920FD8AD; Thu, 18 Apr 2024 08:12:26 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 8C37920FD8AD", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1713453146;\n bh=8TLsmGuvO/mgrl90WvqxUuiMAUpKk5WT2Z+4BUrEiqo=;\n h=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n b=WPZVaLxiA7/5Dvl8w9C36S1gH46KDF8PaOYtuiBEBfw8sS+RM97YGhK4jfIGQQhdb\n MnTairfXRs0Vo5J3d0IQaVBCmzAT0EUZhl/DJxR2Q3hGAeJo1r/fSTtt9xGvQJoVNE\n nXyEypFmeT6at/AdsfA9r4hEDay9Tvgn/u9JR5D8=", "Date": "Thu, 18 Apr 2024 08:12:26 -0700", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "Morten =?iso-8859-1?q?Br=F8rup?= <mb@smartsharesystems.com>", "Cc": "dev@dpdk.org, Akhil Goyal <gakhil@marvell.com>,\n Aman Singh <aman.deep.singh@intel.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chengwen Feng <fengchengwen@huawei.com>,\n Dariusz Sosnowski <dsosnowski@nvidia.com>,\n Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,\n Fan Zhang <fanzhang.oss@gmail.com>, Ferruh Yigit <ferruh.yigit@amd.com>,\n Harry van Haaren <harry.van.haaren@intel.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Jiayu Hu <hujiayu.hu@foxmail.com>, Jingjing Wu <jingjing.wu@intel.com>,\n Kevin Laatz <kevin.laatz@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Matan Azrad <matan@nvidia.com>, Ori Kam <orika@nvidia.com>,\n Pallavi Kadam <pallavi.kadam@intel.com>,\n Reshma Pattan <reshma.pattan@intel.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>,\n Suanming Mou <suanmingm@nvidia.com>, Thomas Monjalon <thomas@monjalon.net>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Volodymyr Fialko <vfialko@marvell.com>,\n Yipeng Wang <yipeng1.wang@intel.com>, Yuying Zhang <Yuying.Zhang@intel.com>", "Subject": "Re: [PATCH 16/16] build: enable vla warnings on Windows built code", "Message-ID": "\n <20240418151226.GA31175@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>", "References": "<1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com>\n <1713397319-26135-17-git-send-email-roretzla@linux.microsoft.com>\n <98CBD80474FA8B44BF855DF32C47DC35E9F3B6@smartserver.smartshare.dk>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=iso-8859-1", "Content-Disposition": "inline", "Content-Transfer-Encoding": "8bit", "In-Reply-To": "\n <98CBD80474FA8B44BF855DF32C47DC35E9F3B6@smartserver.smartshare.dk>", "User-Agent": "Mutt/1.5.21 (2010-09-15)", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "addressed": null }