Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139620/?format=api
{ "id": 139620, "url": "http://patchwork.dpdk.org/api/patches/139620/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240422152336.147553-10-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240422152336.147553-10-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240422152336.147553-10-stephen@networkplumber.org", "date": "2024-04-22T15:21:39", "name": "[v5,9/9] test: add more latencystats tests", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "e860c6e1a13a614c4e630475f6583e10cca6f419", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240422152336.147553-10-stephen@networkplumber.org/mbox/", "series": [ { "id": 31803, "url": "http://patchwork.dpdk.org/api/series/31803/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31803", "date": "2024-04-22T15:21:30", "name": "latencystats: improve algorithms and tests", "version": 5, "mbox": "http://patchwork.dpdk.org/series/31803/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/139620/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/139620/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 279F643EDB;\n\tMon, 22 Apr 2024 17:24:44 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6934D40E0F;\n\tMon, 22 Apr 2024 17:24:08 +0200 (CEST)", "from mail-pf1-f170.google.com (mail-pf1-f170.google.com\n [209.85.210.170])\n by mails.dpdk.org (Postfix) with ESMTP id 5580F40A7A\n for <dev@dpdk.org>; Mon, 22 Apr 2024 17:23:54 +0200 (CEST)", "by mail-pf1-f170.google.com with SMTP id\n d2e1a72fcca58-6eced6fd98aso4292315b3a.0\n for <dev@dpdk.org>; Mon, 22 Apr 2024 08:23:54 -0700 (PDT)", "from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])\n by smtp.gmail.com with ESMTPSA id\n cb17-20020a056a02071100b0060063c4be3bsm1402783pgb.14.2024.04.22.08.23.53\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 22 Apr 2024 08:23:53 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1713799433;\n x=1714404233; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=vUoWg1PmW5lW5J3wRKwEZ2HiqMBKq7APhRaCn0FUAC8=;\n b=oqZrNcbCyV8Dk2tgKGSK7stPCrNLnBQJgcNwJy2/ejB3Een5Amcriuy3Scr7MeXFHt\n ocmS4gx0g8brAACv/QjR01OUdFiFKocFGHdmeasaJ4KAkROicSubVe63ROsNfYVetNyj\n uI0Q607IABFDzfKLso4Dn8bvIAXaNP2QwlydPtZ+NUmsCMlJZ+Jwk+Q9hPxtmfxbpCmp\n A8Wo6VBeAUM54EdoPGVl/Yl+ZkQkZ9wrBtkqQL/n2iDQwLHdD9oGOBZmQ5zXmWPpPTQj\n HbCM6I8s2BrXFuVLmZNKlBUnV/T6K0AEjRz21Z+DAXJxH3vGyvQwz7THL7aV/iiTUUX3\n dmyA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1713799433; x=1714404233;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=vUoWg1PmW5lW5J3wRKwEZ2HiqMBKq7APhRaCn0FUAC8=;\n b=ubyxevOvx6a5LGL6NMc/mNMlqoeC7tlnWMz1atanzCwwbNKP603sFE2cU3LiSwhXi+\n i7Q1Os37R2lq/GBLVYCGQHz5pLWBdCitf0/aDzg+Y//MmTZIcDik24mEPDN5L70mPOUh\n QV3lF2IKoCLPC/8i52zMa1AUFunnUAHn5foMXJemDq+aeRVmIzETc4w9onKXcdjAjcLJ\n 5NvEM1P/ffReuugeju2/RfOOQlNIDMWKgz2ZE5mIbnvWZx/N06/cgjWyqGpS+G3B+q77\n jO17TlMuuiFWbebE0NDWa5u/Wb5Rtkrio2Rip2nAGc2qeMfowcUTDFgkMPN1CbVxpg9U\n BaFQ==", "X-Gm-Message-State": "AOJu0Ywsubzlvk5SEVwkTnXQb3t1LZKNHsRRcDTGshXonHmXGz9Uzrcy\n Ovl0JY+fKoncGMvlCyQr873cxSBAxnMW108/j15GxdBOI2XnYb7d/E7LSsBBwSupAOXYG0Wu5Ee\n 9", "X-Google-Smtp-Source": "\n AGHT+IFlecSIlr/KWe7tHdfyocALerIlOsG4ocVGWVHcWJ7YXazTq9wSDC989H3rRNUuTS9mUyc/tw==", "X-Received": "by 2002:a05:6a20:394e:b0:1a7:5780:1f4b with SMTP id\n r14-20020a056a20394e00b001a757801f4bmr16300750pzg.24.1713799433595;\n Mon, 22 Apr 2024 08:23:53 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Reshma Pattan <reshma.pattan@intel.com>", "Subject": "[PATCH v5 9/9] test: add more latencystats tests", "Date": "Mon, 22 Apr 2024 08:21:39 -0700", "Message-ID": "<20240422152336.147553-10-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240422152336.147553-1-stephen@networkplumber.org>", "References": "<20240408195036.182545-1-stephen@networkplumber.org>\n <20240422152336.147553-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Look at the number of samples, min, max and average\nnumbers to make sure they look correct.\nForward for to make sure multiple samples are taken.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n app/test/test_latencystats.c | 62 +++++++++++++++++++++++++++++-------\n 1 file changed, 50 insertions(+), 12 deletions(-)", "diff": "diff --git a/app/test/test_latencystats.c b/app/test/test_latencystats.c\nindex 3369c8bb90..676a99d385 100644\n--- a/app/test/test_latencystats.c\n+++ b/app/test/test_latencystats.c\n@@ -14,7 +14,7 @@\n #include \"sample_packet_forward.h\"\n #include \"test.h\"\n \n-#define NUM_STATS 4\n+#define NUM_STATS 5\n #define LATENCY_NUM_PACKETS 10\n #define QUEUE_ID 0\n \n@@ -26,6 +26,7 @@ static struct rte_metric_name lat_stats_strings[NUM_STATS] = {\n \t{\"avg_latency_ns\"},\n \t{\"max_latency_ns\"},\n \t{\"jitter_ns\"},\n+\t{\"samples\"},\n };\n \n /* Test case for latency init with metrics init */\n@@ -141,10 +142,14 @@ static void test_latency_ring_free(void)\n \n static int test_latency_packet_forward(void)\n {\n+\tunsigned int i;\n \tint ret;\n \tstruct rte_mbuf *pbuf[LATENCY_NUM_PACKETS] = { };\n \tstruct rte_mempool *mp;\n \tchar poolname[] = \"mbuf_pool\";\n+\tuint64_t end_cycles;\n+\tstruct rte_metric_value values[NUM_STATS] = { };\n+\tstruct rte_metric_name names[NUM_STATS] = { };\n \n \tret = test_get_mbuf_from_pool(&mp, pbuf, poolname);\n \tif (ret < 0) {\n@@ -158,9 +163,41 @@ static int test_latency_packet_forward(void)\n \t\treturn TEST_FAILED;\n \t}\n \n-\tret = test_packet_forward(pbuf, portid, QUEUE_ID);\n-\tif (ret < 0)\n-\t\tprintf(\"send pkts Failed\\n\");\n+\tret = rte_latencystats_get_names(names, NUM_STATS);\n+\tTEST_ASSERT((ret == NUM_STATS), \"Test Failed to get metrics names\");\n+\n+\tret = rte_latencystats_get(values, NUM_STATS);\n+\tTEST_ASSERT(ret == NUM_STATS, \"Test failed to get results before forwarding\");\n+\tTEST_ASSERT(values[4].value == 0, \"Samples not zero at start of test\");\n+\n+\t/*\n+\t * Want test to run long enough to collect sufficient samples\n+\t * but not so long that scheduler decides to reschedule it (1000 hz).\n+\t */\n+\tend_cycles = rte_rdtsc() + rte_get_tsc_hz() / 2000;\n+\tdo {\n+\t\tret = test_packet_forward(pbuf, portid, QUEUE_ID);\n+\t\tif (ret < 0)\n+\t\t\tprintf(\"send pkts Failed\\n\");\n+\t} while (rte_rdtsc() < end_cycles);\n+\n+\tret = rte_latencystats_get(values, NUM_STATS);\n+\tTEST_ASSERT(ret == NUM_STATS, \"Test failed to get results after forwarding\");\n+\n+\tfor (i = 0; i < NUM_STATS; i++) {\n+\t\tuint16_t k = values[i].key;\n+\n+\t\tprintf(\"%s = %\"PRIu64\"\\n\",\n+\t\t names[k].name, values[i].value);\n+\t}\n+\n+\tTEST_ASSERT(values[4].value > 0, \"No samples taken\");\n+\tTEST_ASSERT(values[0].value > 0, \"Min latency should not be zero\");\n+\tTEST_ASSERT(values[1].value > 0, \"Avg latency should not be zero\");\n+\tTEST_ASSERT(values[2].value > 0, \"Max latency should not be zero\");\n+\tTEST_ASSERT(values[0].value < values[1].value, \"Min latency > Avg latency\");\n+\tTEST_ASSERT(values[0].value < values[2].value, \"Min latency > Max latency\");\n+\tTEST_ASSERT(values[1].value < values[2].value, \"Avg latency > Max latency\");\n \n \trte_eth_dev_stop(portid);\n \ttest_put_mbuf_to_pool(mp, pbuf);\n@@ -180,22 +217,23 @@ unit_test_suite latencystats_testsuite = {\n \t\t */\n \t\tTEST_CASE_ST(NULL, NULL, test_latency_init),\n \n-\t\t/* Test Case 2: Do packet forwarding for metrics\n-\t\t * calculation and check the latency metrics values\n-\t\t * are updated\n-\t\t */\n-\t\tTEST_CASE_ST(test_latency_packet_forward, NULL,\n-\t\t\t\ttest_latency_update),\n-\t\t/* Test Case 3: To check whether latency stats names\n+\t\t/* Test Case 2: To check whether latency stats names\n \t\t * are retrieved\n \t\t */\n \t\tTEST_CASE_ST(NULL, NULL, test_latencystats_get_names),\n \n-\t\t/* Test Case 4: To check whether latency stats\n+\t\t/* Test Case 3: To check whether latency stats\n \t\t * values are retrieved\n \t\t */\n \t\tTEST_CASE_ST(NULL, NULL, test_latencystats_get),\n \n+\t\t/* Test Case 4: Do packet forwarding for metrics\n+\t\t * calculation and check the latency metrics values\n+\t\t * are updated\n+\t\t */\n+\t\tTEST_CASE_ST(test_latency_packet_forward, NULL,\n+\t\t\t\ttest_latency_update),\n+\n \t\t/* Test Case 5: To check uninit of latency test */\n \t\tTEST_CASE_ST(NULL, NULL, test_latency_uninit),\n \n", "prefixes": [ "v5", "9/9" ] }