Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139649/?format=api
{ "id": 139649, "url": "http://patchwork.dpdk.org/api/patches/139649/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/d6cd9d19a19215e0127370684cb546828699c787.1713964708.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<d6cd9d19a19215e0127370684cb546828699c787.1713964708.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/d6cd9d19a19215e0127370684cb546828699c787.1713964708.git.anatoly.burakov@intel.com", "date": "2024-04-24T13:21:38", "name": "[v1,04/22] net/ixgbe/base: rename message type macros", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "cc7d6ed912f3c182298c33a00cd3c8343f800f53", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 10, "url": "http://patchwork.dpdk.org/api/users/10/?format=api", "username": "bruce", "first_name": "Bruce", "last_name": "Richardson", "email": "bruce.richardson@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/d6cd9d19a19215e0127370684cb546828699c787.1713964708.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 31814, "url": "http://patchwork.dpdk.org/api/series/31814/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31814", "date": "2024-04-24T13:21:34", "name": "Update IXGBE base driver", "version": 1, "mbox": "http://patchwork.dpdk.org/series/31814/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/139649/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/139649/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E9DA643EAD;\n\tWed, 24 Apr 2024 15:22:45 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EF5F94349E;\n\tWed, 24 Apr 2024 15:22:23 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.9])\n by mails.dpdk.org (Postfix) with ESMTP id 802B443494\n for <dev@dpdk.org>; Wed, 24 Apr 2024 15:22:22 +0200 (CEST)", "from fmviesa006.fm.intel.com ([10.60.135.146])\n by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 24 Apr 2024 06:22:22 -0700", "from silpixa00401119.ir.intel.com ([10.55.129.167])\n by fmviesa006.fm.intel.com with ESMTP; 24 Apr 2024 06:22:19 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1713964943; x=1745500943;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=QOviK+YSqxxD3YaR9GNVJ8DXPrU9J7AOsoUHakLmOmQ=;\n b=MsxJEtHXWvUI7EtjD0e041Mmu7SJwlUiVo1wHyIqcN21xkkeAKIH6O66\n HZJCTZpuw4dUrR/2Nja4bsr33clJS9bwsXnti299v5a++Cly1twiB5Ylw\n IapminmdPGBUkAcxSI6nzBIP52UavExuoorpDNuPeXFfw995Lw+y8wG7R\n WJUOu37JUl0m9c6XlTvjHGWfj8jGc0zpLN7N5HozA3sake23ltUstW9ed\n AHxGwcbwSwX6D9MmGm56W6QTpzqvd0ZkV/6tmASUdJDRrz7Xpee7rFRBD\n 5aIw8LCxbg6Kx54rXENbNcO7AQAOSAnR5+kG5P8k1xnk08Wgc4YI110Hj w==;", "X-CSE-ConnectionGUID": [ "O9JAUE39R3Gna5qsMmn+OA==", "QTmJzoNXTheoyrott7mpYA==" ], "X-CSE-MsgGUID": [ "4S5aQWWDT3OH8DASXdLwDg==", "OO9fe5nNS+a20Yx7T8JT1Q==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,11054\"; a=\"20289244\"", "E=Sophos;i=\"6.07,226,1708416000\"; d=\"scan'208\";a=\"20289244\"", "E=Sophos;i=\"6.07,226,1708416000\"; d=\"scan'208\";a=\"24749312\"" ], "X-ExtLoop1": "1", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "Jakub Chylkowski <jakubx.chylkowski@intel.com>,\n\tvladimir.medvedkin@intel.com, bruce.richardson@intel.com,\n\tZalfresso-jundzillo@dpdk.org,\n\tMarekX <marekx.zalfresso-jundzillo@intel.com>, Michael@dpdk.org,\n\tAlice <alice.michael@intel.com>, Skajewski@dpdk.org,\n\tPiotrX <piotrx.skajewski@intel.com>, Mrozowicz@dpdk.org,\n\tSlawomirX <slawomirx.mrozowicz@intel.com>", "Subject": "[PATCH v1 04/22] net/ixgbe/base: rename message type macros", "Date": "Wed, 24 Apr 2024 14:21:38 +0100", "Message-ID": "\n <d6cd9d19a19215e0127370684cb546828699c787.1713964708.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<cover.1713964707.git.anatoly.burakov@intel.com>", "References": "<cover.1713964707.git.anatoly.burakov@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Jakub Chylkowski <jakubx.chylkowski@intel.com>\n\nThere is name similarity within IXGBE_VT_MSGTYPE_ACK and\nPFMAILBOX.ACK / VFMAILBOX.ACK which may cause confusion. Rename MSGTYPE\nmacros to SUCCESS and FAILURE as they are not specified in datasheet and\nnow will be easily distinguishable.\n\nSigned-off-by: Jakub Chylkowski <jakubx.chylkowski@intel.com>\nReviewed-by: Zalfresso-jundzillo, MarekX <marekx.zalfresso-jundzillo@intel.com>\nReviewed-by: Michael, Alice <alice.michael@intel.com>\nReviewed-by: Skajewski, PiotrX <piotrx.skajewski@intel.com>\nTested-by: Skajewski, PiotrX <piotrx.skajewski@intel.com>\nReviewed-by: Mrozowicz, SlawomirX <slawomirx.mrozowicz@intel.com>\nTested-by: Michael, Alice <alice.michael@intel.com>\n---\n drivers/net/ixgbe/base/ixgbe_mbx.h | 17 +++++++++-------\n drivers/net/ixgbe/base/ixgbe_vf.c | 32 ++++++++++++++++--------------\n drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++--\n drivers/net/ixgbe/ixgbe_pf.c | 12 +++++------\n 4 files changed, 35 insertions(+), 30 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/base/ixgbe_mbx.h b/drivers/net/ixgbe/base/ixgbe_mbx.h\nindex 1a45e49c2f..28a2d94d02 100644\n--- a/drivers/net/ixgbe/base/ixgbe_mbx.h\n+++ b/drivers/net/ixgbe/base/ixgbe_mbx.h\n@@ -38,14 +38,17 @@\n \n /* If it's a IXGBE_VF_* msg then it originates in the VF and is sent to the\n * PF. The reverse is true if it is IXGBE_PF_*.\n- * Message ACK's are the value or'd with 0xF0000000\n+ * Message results are the value or'd with 0xF0000000\n */\n-#define IXGBE_VT_MSGTYPE_ACK\t0x80000000 /* Messages below or'd with\n-\t\t\t\t\t * this are the ACK */\n-#define IXGBE_VT_MSGTYPE_NACK\t0x40000000 /* Messages below or'd with\n-\t\t\t\t\t * this are the NACK */\n-#define IXGBE_VT_MSGTYPE_CTS\t0x20000000 /* Indicates that VF is still\n-\t\t\t\t\t * clear to send requests */\n+#define IXGBE_VT_MSGTYPE_SUCCESS\t0x80000000 /* Messages or'd with this\n+\t\t\t\t\t\t * have succeeded\n+\t\t\t\t\t\t */\n+#define IXGBE_VT_MSGTYPE_FAILURE\t0x40000000 /* Messages or'd with this\n+\t\t\t\t\t\t * have failed\n+\t\t\t\t\t\t */\n+#define IXGBE_VT_MSGTYPE_CTS\t\t0x20000000 /* Indicates that VF is still\n+\t\t\t\t\t\t * clear to send requests\n+\t\t\t\t\t\t */\n #define IXGBE_VT_MSGINFO_SHIFT\t16\n /* bits 23:16 are used for extra info for certain messages */\n #define IXGBE_VT_MSGINFO_MASK\t(0xFF << IXGBE_VT_MSGINFO_SHIFT)\ndiff --git a/drivers/net/ixgbe/base/ixgbe_vf.c b/drivers/net/ixgbe/base/ixgbe_vf.c\nindex 11dbbe2a86..d390b0d5e0 100644\n--- a/drivers/net/ixgbe/base/ixgbe_vf.c\n+++ b/drivers/net/ixgbe/base/ixgbe_vf.c\n@@ -194,11 +194,11 @@ s32 ixgbe_reset_hw_vf(struct ixgbe_hw *hw)\n \tif (ret_val)\n \t\treturn ret_val;\n \n-\tif (msgbuf[0] != (IXGBE_VF_RESET | IXGBE_VT_MSGTYPE_ACK) &&\n-\t msgbuf[0] != (IXGBE_VF_RESET | IXGBE_VT_MSGTYPE_NACK))\n+\tif (msgbuf[0] != (IXGBE_VF_RESET | IXGBE_VT_MSGTYPE_SUCCESS) &&\n+\t msgbuf[0] != (IXGBE_VF_RESET | IXGBE_VT_MSGTYPE_FAILURE))\n \t\treturn IXGBE_ERR_INVALID_MAC_ADDR;\n \n-\tif (msgbuf[0] == (IXGBE_VF_RESET | IXGBE_VT_MSGTYPE_ACK))\n+\tif (msgbuf[0] == (IXGBE_VF_RESET | IXGBE_VT_MSGTYPE_SUCCESS))\n \t\tmemcpy(hw->mac.perm_addr, addr, IXGBE_ETH_LENGTH_OF_ADDRESS);\n \n \thw->mac.mc_filter_type = msgbuf[IXGBE_VF_MC_TYPE_WORD];\n@@ -327,9 +327,9 @@ s32 ixgbe_set_rar_vf(struct ixgbe_hw *hw, u32 index, u8 *addr, u32 vmdq,\n \n \tmsgbuf[0] &= ~IXGBE_VT_MSGTYPE_CTS;\n \n-\t/* if nacked the address was rejected, use \"perm_addr\" */\n+\t/* if we had failure, the address was rejected, use \"perm_addr\" */\n \tif (!ret_val &&\n-\t (msgbuf[0] == (IXGBE_VF_SET_MAC_ADDR | IXGBE_VT_MSGTYPE_NACK))) {\n+\t (msgbuf[0] == (IXGBE_VF_SET_MAC_ADDR | IXGBE_VT_MSGTYPE_FAILURE))) {\n \t\tixgbe_get_mac_addr_vf(hw, hw->mac.addr);\n \t\treturn IXGBE_ERR_MBX;\n \t}\n@@ -418,7 +418,7 @@ s32 ixgbevf_update_xcast_mode(struct ixgbe_hw *hw, int xcast_mode)\n \t\treturn err;\n \n \tmsgbuf[0] &= ~IXGBE_VT_MSGTYPE_CTS;\n-\tif (msgbuf[0] == (IXGBE_VF_UPDATE_XCAST_MODE | IXGBE_VT_MSGTYPE_NACK))\n+\tif (msgbuf[0] == (IXGBE_VF_UPDATE_XCAST_MODE | IXGBE_VT_MSGTYPE_FAILURE))\n \t\treturn IXGBE_ERR_FEATURE_NOT_SUPPORTED;\n \treturn IXGBE_SUCCESS;\n }\n@@ -446,10 +446,10 @@ s32 ixgbe_set_vfta_vf(struct ixgbe_hw *hw, u32 vlan, u32 vind,\n \tmsgbuf[0] |= vlan_on << IXGBE_VT_MSGINFO_SHIFT;\n \n \tret_val = ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf, 2);\n-\tif (!ret_val && (msgbuf[0] & IXGBE_VT_MSGTYPE_ACK))\n+\tif (!ret_val && (msgbuf[0] & IXGBE_VT_MSGTYPE_SUCCESS))\n \t\treturn IXGBE_SUCCESS;\n \n-\treturn ret_val | (msgbuf[0] & IXGBE_VT_MSGTYPE_NACK);\n+\treturn ret_val | (msgbuf[0] & IXGBE_VT_MSGTYPE_FAILURE);\n }\n \n /**\n@@ -514,7 +514,7 @@ s32 ixgbevf_set_uc_addr_vf(struct ixgbe_hw *hw, u32 index, u8 *addr)\n \tif (!ret_val) {\n \t\tmsgbuf[0] &= ~IXGBE_VT_MSGTYPE_CTS;\n \n-\t\tif (msgbuf[0] == (msgbuf_chk | IXGBE_VT_MSGTYPE_NACK))\n+\t\tif (msgbuf[0] == (msgbuf_chk | IXGBE_VT_MSGTYPE_FAILURE))\n \t\t\treturn IXGBE_ERR_OUT_OF_MEM;\n \t}\n \n@@ -617,8 +617,10 @@ s32 ixgbe_check_mac_link_vf(struct ixgbe_hw *hw, ixgbe_link_speed *speed,\n \t\tgoto out;\n \n \tif (!(in_msg & IXGBE_VT_MSGTYPE_CTS)) {\n-\t\t/* msg is not CTS and is NACK we must have lost CTS status */\n-\t\tif (in_msg & IXGBE_VT_MSGTYPE_NACK)\n+\t\t/* msg is not CTS and is FAILURE,\n+\t\t * we must have lost CTS status.\n+\t\t */\n+\t\tif (in_msg & IXGBE_VT_MSGTYPE_FAILURE)\n \t\t\tret_val = -1;\n \t\tgoto out;\n \t}\n@@ -656,7 +658,7 @@ s32 ixgbevf_rlpml_set_vf(struct ixgbe_hw *hw, u16 max_size)\n \tif (retval)\n \t\treturn retval;\n \tif ((msgbuf[0] & IXGBE_VF_SET_LPE) &&\n-\t (msgbuf[0] & IXGBE_VT_MSGTYPE_NACK))\n+\t (msgbuf[0] & IXGBE_VT_MSGTYPE_FAILURE))\n \t\treturn IXGBE_ERR_MBX;\n \n \treturn 0;\n@@ -682,7 +684,7 @@ int ixgbevf_negotiate_api_version(struct ixgbe_hw *hw, int api)\n \t\tmsg[0] &= ~IXGBE_VT_MSGTYPE_CTS;\n \n \t\t/* Store value and return 0 on success */\n-\t\tif (msg[0] == (IXGBE_VF_API_NEGOTIATE | IXGBE_VT_MSGTYPE_ACK)) {\n+\t\tif (msg[0] == (IXGBE_VF_API_NEGOTIATE | IXGBE_VT_MSGTYPE_SUCCESS)) {\n \t\t\thw->api_version = api;\n \t\t\treturn 0;\n \t\t}\n@@ -718,11 +720,11 @@ int ixgbevf_get_queues(struct ixgbe_hw *hw, unsigned int *num_tcs,\n \t\tmsg[0] &= ~IXGBE_VT_MSGTYPE_CTS;\n \n \t\t/*\n-\t\t * if we we didn't get an ACK there must have been\n+\t\t * if we didn't get a SUCCESS there must have been\n \t\t * some sort of mailbox error so we should treat it\n \t\t * as such\n \t\t */\n-\t\tif (msg[0] != (IXGBE_VF_GET_QUEUES | IXGBE_VT_MSGTYPE_ACK))\n+\t\tif (msg[0] != (IXGBE_VF_GET_QUEUES | IXGBE_VT_MSGTYPE_SUCCESS))\n \t\t\treturn IXGBE_ERR_MBX;\n \n \t\t/* record and validate values from message */\ndiff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex c61c52b296..8c60351636 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -4169,8 +4169,8 @@ ixgbevf_check_link(struct ixgbe_hw *hw, ixgbe_link_speed *speed,\n \t\tgoto out;\n \n \tif (!(in_msg & IXGBE_VT_MSGTYPE_CTS)) {\n-\t\t/* msg is not CTS and is NACK we must have lost CTS status */\n-\t\tif (in_msg & IXGBE_VT_MSGTYPE_NACK)\n+\t\t/* msg is not CTS and is FAILURE we must have lost CTS status */\n+\t\tif (in_msg & IXGBE_VT_MSGTYPE_FAILURE)\n \t\t\tmac->get_link_status = false;\n \t\tgoto out;\n \t}\ndiff --git a/drivers/net/ixgbe/ixgbe_pf.c b/drivers/net/ixgbe/ixgbe_pf.c\nindex 0a0f639e39..71104247da 100644\n--- a/drivers/net/ixgbe/ixgbe_pf.c\n+++ b/drivers/net/ixgbe/ixgbe_pf.c\n@@ -448,8 +448,8 @@ ixgbe_vf_reset(struct rte_eth_dev *dev, uint16_t vf, uint32_t *msgbuf)\n \t/* Disable multicast promiscuous at reset */\n \tixgbe_disable_vf_mc_promisc(dev, vf);\n \n-\t/* reply to reset with ack and vf mac address */\n-\tmsgbuf[0] = IXGBE_VF_RESET | IXGBE_VT_MSGTYPE_ACK;\n+\t/* reply to reset with success and vf mac address */\n+\tmsgbuf[0] = IXGBE_VF_RESET | IXGBE_VT_MSGTYPE_SUCCESS;\n \trte_memcpy(new_mac, vf_mac, RTE_ETHER_ADDR_LEN);\n \t/*\n \t * Piggyback the multicast filter type so VF can compute the\n@@ -840,7 +840,7 @@ ixgbe_rcv_msg_from_vf(struct rte_eth_dev *dev, uint16_t vf)\n \t}\n \n \t/* do nothing with the message already been processed */\n-\tif (msgbuf[0] & (IXGBE_VT_MSGTYPE_ACK | IXGBE_VT_MSGTYPE_NACK))\n+\tif (msgbuf[0] & (IXGBE_VT_MSGTYPE_SUCCESS | IXGBE_VT_MSGTYPE_FAILURE))\n \t\treturn retval;\n \n \t/* flush the ack before we write any messages back */\n@@ -919,9 +919,9 @@ ixgbe_rcv_msg_from_vf(struct rte_eth_dev *dev, uint16_t vf)\n \n \t/* response the VF according to the message process result */\n \tif (retval)\n-\t\tmsgbuf[0] |= IXGBE_VT_MSGTYPE_NACK;\n+\t\tmsgbuf[0] |= IXGBE_VT_MSGTYPE_FAILURE;\n \telse\n-\t\tmsgbuf[0] |= IXGBE_VT_MSGTYPE_ACK;\n+\t\tmsgbuf[0] |= IXGBE_VT_MSGTYPE_SUCCESS;\n \n \tmsgbuf[0] |= IXGBE_VT_MSGTYPE_CTS;\n \n@@ -933,7 +933,7 @@ ixgbe_rcv_msg_from_vf(struct rte_eth_dev *dev, uint16_t vf)\n static inline void\n ixgbe_rcv_ack_from_vf(struct rte_eth_dev *dev, uint16_t vf)\n {\n-\tuint32_t msg = IXGBE_VT_MSGTYPE_NACK;\n+\tuint32_t msg = IXGBE_VT_MSGTYPE_FAILURE;\n \tstruct ixgbe_hw *hw =\n \t\tIXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \tstruct ixgbe_vf_info *vfinfo =\n", "prefixes": [ "v1", "04/22" ] }