Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139682/?format=api
{ "id": 139682, "url": "http://patchwork.dpdk.org/api/patches/139682/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240425174617.2126159-1-ferruh.yigit@amd.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240425174617.2126159-1-ferruh.yigit@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240425174617.2126159-1-ferruh.yigit@amd.com", "date": "2024-04-25T17:46:17", "name": "[RFC] net/af_packet: make stats reset reliable", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "a5490c2297f59f0204835ecbece039d463b28c0e", "submitter": { "id": 2700, "url": "http://patchwork.dpdk.org/api/people/2700/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@amd.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240425174617.2126159-1-ferruh.yigit@amd.com/mbox/", "series": [ { "id": 31823, "url": "http://patchwork.dpdk.org/api/series/31823/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31823", "date": "2024-04-25T17:46:17", "name": "[RFC] net/af_packet: make stats reset reliable", "version": 1, "mbox": "http://patchwork.dpdk.org/series/31823/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/139682/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/139682/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9917B43F06;\n\tThu, 25 Apr 2024 19:46:35 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 64C65438F3;\n\tThu, 25 Apr 2024 19:46:35 +0200 (CEST)", "from NAM04-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam04on2082.outbound.protection.outlook.com [40.107.102.82])\n by mails.dpdk.org (Postfix) with ESMTP id C4EB1438DA\n for <dev@dpdk.org>; Thu, 25 Apr 2024 19:46:33 +0200 (CEST)", "from CH0PR04CA0045.namprd04.prod.outlook.com (2603:10b6:610:77::20)\n by CH3PR12MB8305.namprd12.prod.outlook.com (2603:10b6:610:12e::14)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.44; Thu, 25 Apr\n 2024 17:46:29 +0000", "from CH3PEPF00000011.namprd21.prod.outlook.com\n (2603:10b6:610:77:cafe::50) by CH0PR04CA0045.outlook.office365.com\n (2603:10b6:610:77::20) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.27 via Frontend\n Transport; Thu, 25 Apr 2024 17:46:29 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n CH3PEPF00000011.mail.protection.outlook.com (10.167.244.116) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.7519.0 via Frontend Transport; Thu, 25 Apr 2024 17:46:27 +0000", "from telcodpdk.amd.com (10.180.168.240) by SATLEXMB04.amd.com\n (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 25 Apr\n 2024 12:46:26 -0500" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=VFKSprRAs3TtSOed193LBScUKWK8xotZBA3CLhJCr2XRH/ZU5eu6g3DJFvz82icolJx+IiKIVLjOwNKayh9YjN32FzOI81G5TIHgfOnGc2cjIkMJK2vCz7/bo2p4hw5C+Z3NRHye3D75ZqW9QgkNYM9fkfiG/WECCGF/l5pM0FN14g7LKGvoblHtMSgSipJqFEwHseldOs97eq09oyGijp2z1n1odNqhZZtwK1TXFp7X29818xWOq2sawkgchygkhAmUF8CsR6abmJQUQ4gEFQ71WQRQ834zYiUefhv1OGoleRjDGvEQ2mHj7hMxfIrPs8NYrHVB4UhqsLUUhRkzng==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=Q+TYHv5kzrPngSwDrYcDAuJDAWJgNRvF5eIYJuFYzQ0=;\n b=RQhvZmFdv+iW7O6qO34m5RUhEAgMgLkC5ur4lGolN7nH4Fmskw/waHzl7xCMRm6SWCwfQUE2IpbVSS7VSG1b0XngDRaGltPcYXESe2Ic95gD3snKKFipk09yAhwELi9K0t5W3qaS61pL/V/xuqYERmc4WLwOe2uovvJujoJN4NnxR/s8aV5mKXQXnLG3MRVms0QCwHwlEqqXDi8YxqEKm91M2AtyHmpMt8F5OeMu2j2WJIFNvTEhqq3MpU0zuFcHOfnoUXcCIjRMx6n9stF3V3sCcyltg6oUO5PQT17pFrVKwtGTYjn/65gTwtYIO20juAIaRwk25euXu7096uXKcQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=temperror (sender ip\n is 165.204.84.17) smtp.rcpttodomain=tuxdriver.com\n smtp.mailfrom=amd.com;\n dmarc=temperror action=none header.from=amd.com; dkim=none (message not\n signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=Q+TYHv5kzrPngSwDrYcDAuJDAWJgNRvF5eIYJuFYzQ0=;\n b=37IRbcvqmzRCuHVM6Mj6+bEqp9eq8ASZAOZxTgWZWA7/SYmTu2ffYx1SXC3Y/D+NF/ZzurePXsteFVNeBcdya3lLQIL8ZJBNhqDmADbVy0ZTDzrupDWq+G3NlvmgBDvPJsD5YeZPGWq1iMa96cC3qqux8ddwAJgfx6JcW8TfSw8=", "X-MS-Exchange-Authentication-Results": "spf=temperror (sender IP is\n 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=temperror action=none header.from=amd.com;", "Received-SPF": "TempError (protection.outlook.com: error in processing during\n lookup of amd.com: DNS Timeout)", "From": "Ferruh Yigit <ferruh.yigit@amd.com>", "To": "\"John W. Linville\" <linville@tuxdriver.com>", "CC": "Thomas Monjalon <thomas@monjalon.net>, <dev@dpdk.org>, =?utf-8?q?Mattias?=\n\t=?utf-8?q?_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>,\n Stephen Hemminger <stephen@networkplumber.org>, =?utf-8?q?Morten_Br=C3=B8ru?=\n\t=?utf-8?q?p?= <mb@smartsharesystems.com>", "Subject": "[RFC] net/af_packet: make stats reset reliable", "Date": "Thu, 25 Apr 2024 18:46:17 +0100", "Message-ID": "<20240425174617.2126159-1-ferruh.yigit@amd.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"UTF-8\"", "Content-Transfer-Encoding": "8bit", "X-Originating-IP": "[10.180.168.240]", "X-ClientProxiedBy": "SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com\n (10.181.40.145)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "CH3PEPF00000011:EE_|CH3PR12MB8305:EE_", "X-MS-Office365-Filtering-Correlation-Id": "bb4bd61c-a07b-459d-d93a-08dc654fa258", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "=?utf-8?q?C6RxyGXFK2Jfc9JyQ4jJdnvgostMLvn?=\n\t=?utf-8?q?IwjMSwe2zkVV0fGd9P3kJXMlUeS99UBUb16uvscSInHN1PsnsR87ARq0ExLnYzliB?=\n\t=?utf-8?q?BWbKu3/7gVPQeu1ZTIPfNsVXEWH+Enk0bSZUAK8CPNlPfmWjl0fJLAaEjxRMnzELa?=\n\t=?utf-8?q?nkYjj4gOBJiqvji2SPd92i6drCOdu0JWDU19v8hLZlx5BGR6YrBeyqgarObhiwnOw?=\n\t=?utf-8?q?de/L9O2bTHAXSL7tM7XTbx+e1DoOne9cZ2ln4QOf097vQEwlXslv7qZrVOxBglKqk?=\n\t=?utf-8?q?OLWsevIEuyA38yfw6hwnHo3zHiM3V0uL0s10hAWiwF8Qf1p8cUYW2Z4HWwuXc4/4J?=\n\t=?utf-8?q?eUM5l04sHdbdwAVS458GlcmTbmsC6dyOJFIUO+P2LjORpLQR2ShuiHEsMAreI3qba?=\n\t=?utf-8?q?m9cMqJjZxhJX5XcWtgxl3HDAHu8sxl7fP8d7VMyB8N8iABSzEl19+wYk+svmJObC2?=\n\t=?utf-8?q?+pESr4SPX6TDrysuplWnyM1xDs2Sf67k8yj9L54d7WQzUD3f87O0MXpmqY8JZ8cEb?=\n\t=?utf-8?q?qK2V19+DM6M3z6LDp8TbIa/p5tLPDrVtHuq0iC2y+yqIgLzsQhPu0oQ2vGb4M+fgx?=\n\t=?utf-8?q?pK8M/pSmzH4VOm9Ac3zM7r4Rz1bPNkN/plJD+m4gagS9jO1Bunt6JtFEpbNLPw2kc?=\n\t=?utf-8?q?IlurSYlWQs5mVsWIuxjlDtoLaWmjV8mGr/aXXZiSO7lvOzBaD8R6hiyIXIkbMo5pS?=\n\t=?utf-8?q?Fnc95nSprAAceZZshn/wxZXEIXEZ5EzMxjc3SUf4j51O5YyoTOKhooXXInTsANrgL?=\n\t=?utf-8?q?tYsxA8WD9QUAOQFqNmxFGGWhQXttxDejTIaMp3bj9n1OEd+ByUBmDKPwHgjiq/0QX?=\n\t=?utf-8?q?Tc41AfOK7Qay9mMz3OnSR/4y9qUwmcrCaAA873qYuz2fncUZi3T/Zgu5n31+UzjNS?=\n\t=?utf-8?q?Wcv5Fi2ROi/iCDZghk4Aa8Rj5Rh4u7RcYFtWaWPzOC76gHBBBhhUIO+PbSunMe6at?=\n\t=?utf-8?q?uvQ/YKWxqrOwttf5ru9aAKXtQkOAyHOATOKbCO1XRooatF4M08X9Xml+GfRrTjGtt?=\n\t=?utf-8?q?Rim/lPuDs7gXRQ8FQjn3MaLcSIqHMconLFOpnQBvfo45wvM2AqADLELWCEYP+iacU?=\n\t=?utf-8?q?/om2nSqEb/2LlH3/52XZM98DzKmru65iBUC7IputXCSUq33jPmb0QH1TL436a0zrp?=\n\t=?utf-8?q?eb+TiueRCshlpdmsXdbEXXvX/GjUjp7Dbug4+/gc8g+GFjhfauKVLR5VBqYn6uzGs?=\n\t=?utf-8?q?E0ZINpzurTObgiawaX09jlw9TaHdFpSx0ZyETZpORxcJrT7eBPsXK9OJb2VJjeD+P?=\n\t=?utf-8?q?lww9T8sWyDn4d?=", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230031)(82310400014)(1800799015)(376005)(36860700004); DIR:OUT;\n SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "25 Apr 2024 17:46:27.9696 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n bb4bd61c-a07b-459d-d93a-08dc654fa258", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CH3PEPF00000011.namprd21.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "CH3PR12MB8305", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "For stats reset, use an offset instead of zeroing out actual stats values,\nget_stats() displays diff between stats and offset.\nThis way stats only updated in datapath and offset only updated in stats\nreset function. This makes stats reset function more reliable.\n\nAs stats only written by single thread, we can remove 'volatile' qualifier\nwhich should improve the performance in datapath.\n\nSigned-off-by: Ferruh Yigit <ferruh.yigit@amd.com>\n---\nCc: Mattias Rönnblom <mattias.ronnblom@ericsson.com>\nCc: Stephen Hemminger <stephen@networkplumber.org>\nCc: Morten Brørup <mb@smartsharesystems.com>\n\nThis update triggered by mail list discussion [1].\n\n[1]\nhttps://inbox.dpdk.org/dev/3b2cf48e-2293-4226-b6cd-5f4dd3969f99@lysator.liu.se/\n---\n drivers/net/af_packet/rte_eth_af_packet.c | 69 +++++++++++++++--------\n 1 file changed, 44 insertions(+), 25 deletions(-)", "diff": "diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c\nindex 397a32db5886..2061cdab4997 100644\n--- a/drivers/net/af_packet/rte_eth_af_packet.c\n+++ b/drivers/net/af_packet/rte_eth_af_packet.c\n@@ -51,8 +51,10 @@ struct pkt_rx_queue {\n \tuint16_t in_port;\n \tuint8_t vlan_strip;\n \n-\tvolatile unsigned long rx_pkts;\n-\tvolatile unsigned long rx_bytes;\n+\tuint64_t rx_pkts;\n+\tuint64_t rx_bytes;\n+\tuint64_t rx_pkts_offset;\n+\tuint64_t rx_bytes_offset;\n };\n \n struct pkt_tx_queue {\n@@ -64,9 +66,12 @@ struct pkt_tx_queue {\n \tunsigned int framecount;\n \tunsigned int framenum;\n \n-\tvolatile unsigned long tx_pkts;\n-\tvolatile unsigned long err_pkts;\n-\tvolatile unsigned long tx_bytes;\n+\tuint64_t tx_pkts;\n+\tuint64_t err_pkts;\n+\tuint64_t tx_bytes;\n+\tuint64_t tx_pkts_offset;\n+\tuint64_t err_pkts_offset;\n+\tuint64_t tx_bytes_offset;\n };\n \n struct pmd_internals {\n@@ -385,8 +390,18 @@ eth_dev_info(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)\n \treturn 0;\n }\n \n+\n+static uint64_t\n+stats_get_diff(uint64_t stats, uint64_t offset)\n+{\n+\tif (stats >= offset)\n+\t\treturn stats - offset;\n+\t/* unlikely wraparound case */\n+\treturn UINT64_MAX + stats - offset;\n+}\n+\n static int\n-eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *igb_stats)\n+eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n {\n \tunsigned i, imax;\n \tunsigned long rx_total = 0, tx_total = 0, tx_err_total = 0;\n@@ -396,27 +411,29 @@ eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *igb_stats)\n \timax = (internal->nb_queues < RTE_ETHDEV_QUEUE_STAT_CNTRS ?\n \t internal->nb_queues : RTE_ETHDEV_QUEUE_STAT_CNTRS);\n \tfor (i = 0; i < imax; i++) {\n-\t\tigb_stats->q_ipackets[i] = internal->rx_queue[i].rx_pkts;\n-\t\tigb_stats->q_ibytes[i] = internal->rx_queue[i].rx_bytes;\n-\t\trx_total += igb_stats->q_ipackets[i];\n-\t\trx_bytes_total += igb_stats->q_ibytes[i];\n+\t\tstruct pkt_rx_queue *rxq = &internal->rx_queue[i];\n+\t\tstats->q_ipackets[i] = stats_get_diff(rxq->rx_pkts, rxq->rx_pkts_offset);\n+\t\tstats->q_ibytes[i] = stats_get_diff(rxq->rx_bytes, rxq->rx_bytes_offset);\n+\t\trx_total += stats->q_ipackets[i];\n+\t\trx_bytes_total += stats->q_ibytes[i];\n \t}\n \n \timax = (internal->nb_queues < RTE_ETHDEV_QUEUE_STAT_CNTRS ?\n \t internal->nb_queues : RTE_ETHDEV_QUEUE_STAT_CNTRS);\n \tfor (i = 0; i < imax; i++) {\n-\t\tigb_stats->q_opackets[i] = internal->tx_queue[i].tx_pkts;\n-\t\tigb_stats->q_obytes[i] = internal->tx_queue[i].tx_bytes;\n-\t\ttx_total += igb_stats->q_opackets[i];\n-\t\ttx_err_total += internal->tx_queue[i].err_pkts;\n-\t\ttx_bytes_total += igb_stats->q_obytes[i];\n+\t\tstruct pkt_tx_queue *txq = &internal->tx_queue[i];\n+\t\tstats->q_opackets[i] = stats_get_diff(txq->tx_pkts, txq->tx_pkts_offset);\n+\t\tstats->q_obytes[i] = stats_get_diff(txq->tx_bytes, txq->tx_bytes_offset);\n+\t\ttx_total += stats->q_opackets[i];\n+\t\ttx_err_total += stats_get_diff(txq->err_pkts, txq->err_pkts_offset);\n+\t\ttx_bytes_total += stats->q_obytes[i];\n \t}\n \n-\tigb_stats->ipackets = rx_total;\n-\tigb_stats->ibytes = rx_bytes_total;\n-\tigb_stats->opackets = tx_total;\n-\tigb_stats->oerrors = tx_err_total;\n-\tigb_stats->obytes = tx_bytes_total;\n+\tstats->ipackets = rx_total;\n+\tstats->ibytes = rx_bytes_total;\n+\tstats->opackets = tx_total;\n+\tstats->oerrors = tx_err_total;\n+\tstats->obytes = tx_bytes_total;\n \treturn 0;\n }\n \n@@ -427,14 +444,16 @@ eth_stats_reset(struct rte_eth_dev *dev)\n \tstruct pmd_internals *internal = dev->data->dev_private;\n \n \tfor (i = 0; i < internal->nb_queues; i++) {\n-\t\tinternal->rx_queue[i].rx_pkts = 0;\n-\t\tinternal->rx_queue[i].rx_bytes = 0;\n+\t\tstruct pkt_rx_queue *rxq = &internal->rx_queue[i];\n+\t\trxq->rx_pkts_offset = rxq->rx_pkts;\n+\t\trxq->rx_bytes_offset = rxq->rx_bytes;\n \t}\n \n \tfor (i = 0; i < internal->nb_queues; i++) {\n-\t\tinternal->tx_queue[i].tx_pkts = 0;\n-\t\tinternal->tx_queue[i].err_pkts = 0;\n-\t\tinternal->tx_queue[i].tx_bytes = 0;\n+\t\tstruct pkt_tx_queue *txq = &internal->tx_queue[i];\n+\t\ttxq->tx_pkts_offset = txq->tx_pkts;\n+\t\ttxq->err_pkts_offset = txq->err_pkts;\n+\t\ttxq->tx_bytes_offset = txq->tx_bytes;\n \t}\n \n \treturn 0;\n", "prefixes": [ "RFC" ] }