Patch Comment Detail
get:
Show a patch comment.
patch:
Update a patch comment.
put:
Update a patch comment.
GET /api/patches/139740/comments/169798/?format=api
{ "id": 169798, "web_url": "http://patchwork.dpdk.org/comment/169798/", "msgid": "<98CBD80474FA8B44BF855DF32C47DC35E9F411@smartserver.smartshare.dk>", "list_archive_url": "https://inbox.dpdk.org/dev/98CBD80474FA8B44BF855DF32C47DC35E9F411@smartserver.smartshare.dk", "date": "2024-05-01T18:18:50", "subject": "RE: [PATCH] net/af_packet: fix statistics", "submitter": { "id": 591, "url": "http://patchwork.dpdk.org/api/people/591/?format=api", "name": "Morten Brørup", "email": "mb@smartsharesystems.com" }, "content": "> From: Stephen Hemminger [mailto:stephen@networkplumber.org]\n> Sent: Wednesday, 1 May 2024 18.45\n> \n> On Wed, 1 May 2024 17:25:59 +0100\n> Ferruh Yigit <ferruh.yigit@amd.com> wrote:\n> \n> > > - Remove the tx_error counter since it was not correct.\n> > > When transmit ring is full it is not an error and\n> > > the driver correctly returns only the number sent.\n> > >\n> >\n> > nack\n> > Transmit full is not only return case here.\n> > There are actual errors continue to process relying this error\n> calculation.\n> > Also there are error cases like interface down.\n> > Those error cases should be handled individually if we remove this.\n> > I suggest split this change to separate patch.\n> \n> I see multiple drivers have copy/pasted same code and consider\n> transmit full as an error. It is not.\n\n+1\nTransmit full is certainly not an error!\n\n> \n> There should be a new statistic at ethdev layer that does record\n> transmit full, and make it across all drivers, but that would have\n> to wait for ABI change.\n\nWhat happens to these non-transmittable packets depend on the application.\nOur application discards them and count them in a (per-port, per-queue) application level counter tx_nodescr, which eventually becomes IF-MIB::ifOutDiscards in SNMP. I think many applications behave similarly, so having an ethdev layer tx_nodescr counter might be helpful.\nOther applications could try to retransmit them; if there are still no TX descriptors, they will be counted again.\n\nIn case anyone gets funny ideas: The PMD should still not free those non-transmitted packet mbufs, because the application might want to treat them differently than the transmitted packets, e.g. for latency stats or packet capture.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7962B43F61;\n\tWed, 1 May 2024 20:18:57 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 426484027F;\n\tWed, 1 May 2024 20:18:57 +0200 (CEST)", "from dkmailrelay1.smartsharesystems.com\n (smartserver.smartsharesystems.com [77.243.40.215])\n by mails.dpdk.org (Postfix) with ESMTP id 2DB184021E\n for <dev@dpdk.org>; Wed, 1 May 2024 20:18:55 +0200 (CEST)", "from smartserver.smartsharesystems.com\n (smartserver.smartsharesys.local [192.168.4.10])\n by dkmailrelay1.smartsharesystems.com (Postfix) with ESMTP id 02E9020995;\n Wed, 1 May 2024 20:18:55 +0200 (CEST)" ], "Content-class": "urn:content-classes:message", "MIME-Version": "1.0", "Content-Type": "text/plain;\n\tcharset=\"UTF-8\"", "Content-Transfer-Encoding": "base64", "Subject": "RE: [PATCH] net/af_packet: fix statistics", "Date": "Wed, 1 May 2024 20:18:50 +0200", "X-MimeOLE": "Produced By Microsoft Exchange V6.5", "Message-ID": "<98CBD80474FA8B44BF855DF32C47DC35E9F411@smartserver.smartshare.dk>", "In-Reply-To": "<20240501094436.17ac8f00@hermes.local>", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "Thread-Topic": "[PATCH] net/af_packet: fix statistics", "Thread-Index": "Adqb5t4TsdgFLRpYQ3i9VrhkXXtfrwAClARg", "References": "<20240430154129.7347-1-stephen@networkplumber.org>\n <9025199c-585c-4779-9f4e-360845707088@amd.com>\n <20240501094436.17ac8f00@hermes.local>", "From": "=?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>", "To": "\"Stephen Hemminger\" <stephen@networkplumber.org>,\n \"Ferruh Yigit\" <ferruh.yigit@amd.com>", "Cc": "<dev@dpdk.org>, \"John W. Linville\" <linville@tuxdriver.com>, =?utf-8?q?M?=\n\t=?utf-8?q?attias_R=C3=B6nnblom?= <hofors@lysator.liu.se>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "addressed": null }