Patch Comment Detail
get:
Show a patch comment.
patch:
Update a patch comment.
put:
Update a patch comment.
GET /api/patches/139759/comments/169782/?format=api
{ "id": 169782, "web_url": "http://patchwork.dpdk.org/comment/169782/", "msgid": "<2203228.C4sosBPzcN@thomas>", "list_archive_url": "https://inbox.dpdk.org/dev/2203228.C4sosBPzcN@thomas", "date": "2024-05-01T08:19:54", "subject": "Re: [RFC] net/ice: Update base code with latest snapshot.", "submitter": { "id": 685, "url": "http://patchwork.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "content": "Hello Ian,\n\nIn general, base drivers are updated with multiple commits, one per feature.\nIt helps tracking the changes.\n\nPlease would it be possible to split?\n\nPS: look like you are not registered in the mailing list,\nthis patch was in the moderation queue.\n\n\n30/04/2024 17:40, Ian Stokes:\n> The purpose of this patch is to update shared code for the ice driver.\n> This patch not only contains the updated base code files but also the\n> required changes within the DPDK code base to enable compilation and\n> basic functionality. This is with a view to allow further regression\n> testing while a final patch series is generated that correctly splits\n> the code changes into an expected manner.\n> \n> Signed-off-by: Ian Stokes <ian.stokes@intel.com>\n> ---\n> drivers/net/ice/base/ice_acl.c | 58 +-\n> drivers/net/ice/base/ice_acl.h | 50 +-\n> drivers/net/ice/base/ice_acl_ctrl.c | 45 +-\n> drivers/net/ice/base/ice_adminq_cmd.h | 459 ++-\n> drivers/net/ice/base/ice_bitops.h | 8 +-\n> drivers/net/ice/base/ice_cgu_regs.h | 90 +\n> drivers/net/ice/base/ice_common.c | 1621 +++++---\n> drivers/net/ice/base/ice_common.h | 189 +-\n> drivers/net/ice/base/ice_controlq.c | 213 +-\n> drivers/net/ice/base/ice_controlq.h | 28 +-\n> drivers/net/ice/base/ice_dcb.c | 79 +-\n> drivers/net/ice/base/ice_dcb.h | 32 +-\n> drivers/net/ice/base/ice_ddp.c | 115 +-\n> drivers/net/ice/base/ice_ddp.h | 18 +-\n> drivers/net/ice/base/ice_devids.h | 39 +-\n> drivers/net/ice/base/ice_fdir.c | 50 +-\n> drivers/net/ice/base/ice_fdir.h | 18 +-\n> drivers/net/ice/base/ice_flex_pipe.c | 385 +-\n> drivers/net/ice/base/ice_flex_pipe.h | 32 +-\n> drivers/net/ice/base/ice_flex_type.h | 41 +-\n> drivers/net/ice/base/ice_flow.c | 337 +-\n> drivers/net/ice/base/ice_flow.h | 52 +-\n> drivers/net/ice/base/ice_fwlog.c | 5 +\n> drivers/net/ice/base/ice_fwlog.h | 4 +\n> drivers/net/ice/base/ice_hw_autogen.h | 2569 ++++++++++--\n> drivers/net/ice/base/ice_lan_tx_rx.h | 87 +-\n> drivers/net/ice/base/ice_metainit.c | 2 +-\n> drivers/net/ice/base/ice_nvm.c | 321 +-\n> drivers/net/ice/base/ice_nvm.h | 36 +-\n> drivers/net/ice/base/ice_parser.c | 57 +-\n> drivers/net/ice/base/ice_parser.h | 30 +-\n> drivers/net/ice/base/ice_parser_rt.c | 88 +-\n> drivers/net/ice/base/ice_parser_rt.h | 23 +-\n> drivers/net/ice/base/ice_phy_regs.h | 84 +\n> drivers/net/ice/base/ice_protocol_type.h | 17 +-\n> drivers/net/ice/base/ice_ptp_consts.h | 3 +-\n> drivers/net/ice/base/ice_ptp_hw.c | 4593 ++++++++++------------\n> drivers/net/ice/base/ice_ptp_hw.h | 332 +-\n> drivers/net/ice/base/ice_sbq_cmd.h | 1 -\n> drivers/net/ice/base/ice_sched.c | 556 +--\n> drivers/net/ice/base/ice_sched.h | 130 +-\n> drivers/net/ice/base/ice_switch.c | 1893 +++++----\n> drivers/net/ice/base/ice_switch.h | 241 +-\n> drivers/net/ice/base/ice_type.h | 194 +-\n> drivers/net/ice/base/ice_vf_mbx.c | 4 +\n> drivers/net/ice/base/ice_vf_mbx.h | 4 +\n> drivers/net/ice/base/ice_vlan_mode.c | 47 +-\n> drivers/net/ice/base/ice_vlan_mode.h | 2 +-\n> drivers/net/ice/base/ice_xlt_kb.c | 4 +-\n> drivers/net/ice/base/meson.build | 2 +\n> drivers/net/ice/ice_diagnose.c | 9 +-\n> drivers/net/ice/ice_ethdev.c | 55 +-\n> 52 files changed, 9105 insertions(+), 6247 deletions(-)\n> create mode 100644 drivers/net/ice/base/ice_fwlog.c\n> create mode 100644 drivers/net/ice/base/ice_fwlog.h\n> create mode 100644 drivers/net/ice/base/ice_phy_regs.h\n> create mode 100644 drivers/net/ice/base/ice_vf_mbx.c\n> create mode 100644 drivers/net/ice/base/ice_vf_mbx.h\n>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BAC9743F5C;\n\tWed, 1 May 2024 10:19:59 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3A265402A7;\n\tWed, 1 May 2024 10:19:59 +0200 (CEST)", "from fhigh2-smtp.messagingengine.com\n (fhigh2-smtp.messagingengine.com [103.168.172.153])\n by mails.dpdk.org (Postfix) with ESMTP id 825304021E\n for <dev@dpdk.org>; Wed, 1 May 2024 10:19:57 +0200 (CEST)", "from compute2.internal (compute2.nyi.internal [10.202.2.46])\n by mailfhigh.nyi.internal (Postfix) with ESMTP id C528F114010D;\n Wed, 1 May 2024 04:19:56 -0400 (EDT)", "from mailfrontend1 ([10.202.2.162])\n by compute2.internal (MEProxy); Wed, 01 May 2024 04:19:56 -0400", "by mail.messagingengine.com (Postfix) with ESMTPA; Wed,\n 1 May 2024 04:19:55 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n cc:cc:content-transfer-encoding:content-type:content-type:date\n :date:from:from:in-reply-to:in-reply-to:message-id:mime-version\n :references:reply-to:subject:subject:to:to; s=fm3; t=1714551596;\n x=1714637996; bh=LATLyeRabP6WhONV2LDxbK5yBjIGic1H/INzeE2DYeM=; b=\n i3QXEZBbzxQO47A3zUXm/wbrMZoLHHDNe7fTpvQ25IT5+M+QHiBuww4w46Xxnl//\n YFcv+1M/y557pfuXhYoFNlZ4Tjq5Wvk63A8jCFH+GlPFlE2xfRUyt24Cf29XuXxM\n An1iJUI92V6DzvW0Y045KHNhTx/upJhOeFD/6xIGCac/XzdukONUQrba4sQOQ3GA\n F3XpKXfg/taYRS9pLxgZdv+vneFCaohDRpgpbPLGgbOFt6Ly9q3pmppmXgjvBxuk\n HR2EXmWVBOWczNVQMXPT//xRBmfaH15P2/V8AQQpLelDUoWbRaKc84BXj5EatquA\n 5zzuFdHI9OT1RQ+35Pzh7w==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:cc:content-transfer-encoding\n :content-type:content-type:date:date:feedback-id:feedback-id\n :from:from:in-reply-to:in-reply-to:message-id:mime-version\n :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy\n :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1714551596; x=\n 1714637996; bh=LATLyeRabP6WhONV2LDxbK5yBjIGic1H/INzeE2DYeM=; b=g\n u8XkBbIbHYPErmIKQtmyXsJJ3C3pYlYciyB2xpZiwsRhdf4ImHc2Dq3BNMuX+MwK\n g5YPDCWoJAWGFYgOVcb+kl0qFdiJ0qQLUWSNjuyyf1Qhi3bn0frYY9hVkTU4Ij83\n L9Xo4HihrSFRKDIeErhKpYCokgYqU2DAhCOHiN8B7bJ34kvsGKLLBWJ9C7fIA4h3\n 1J6Y5VcJjYJwWIL45rucs9fORmWu7WZ3M6ngiG+g+lNEMq0HB+/BMUIsjsp/fOFW\n b4JvlZziYDitEqvGkfSk+XaatNNpHMd58I30AS2CAfG0ctxd5W1sLjqVeyVs5gsO\n gUu39nH5y3O/Zk1zQrFdw==" ], "X-ME-Sender": "<xms:LPsxZlH-3GBb52JJp2KosStHnXq14J6W7Ve3h8gBxCKUnMOKtQZUng>\n <xme:LPsxZqUqN8MqO1pnLiT-oXTdBH0s0z1aYkxSIwuR_-edFGg8vhumBiAKJ3WvDSiqW\n 8d9kx9sDQee8miU-Q>", "X-ME-Received": "\n <xmr:LPsxZnK-SQyovprugu2dkuHwvqoZjfKOvr3mTHExlqfjTl9Z_qKdTiIM-VJZtk8dUbFbFSKdWXFCSs-kxVAygSJisg>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedvledrvdduhedghedtucetufdoteggodetrfdotf\n fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen\n uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne\n cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtjeenucfhrhhomhepvfhhohhm\n rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc\n ggtffrrghtthgvrhhnpeejudevheeiveduuddtveffgfdtgeekueevjeffjeegtdeggeek\n gfdvuefgfeekjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh\n hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght", "X-ME-Proxy": "<xmx:LPsxZrHuey6bb5w6FJBjCIPORy574xrd3iFihy7ni6yLCnqcWZDgEA>\n <xmx:LPsxZrVrp-gCHcL9OZ7cMRvpEjYYm7UgpOqQ3_YP3Q6kZW6uKaJlFQ>\n <xmx:LPsxZmMW0DuLUaLpabUuAsWQqPRu2SSUFgZv4vweaJuH7oVdhSol1g>\n <xmx:LPsxZq0LmFtC47sgo9dEXKLUuUNnrpZX6v4Td9bZTSdcR-kBTOGXfw>\n <xmx:LPsxZmTFsZL44hgkiyWpz2_6782pJzIOKJ9XNa0dlzjremeo-nzKOEbG>", "Feedback-ID": "i47234305:Fastmail", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "Ian Stokes <ian.stokes@intel.com>", "Cc": "dev@dpdk.org, bruce.richardson@intel.com", "Subject": "Re: [RFC] net/ice: Update base code with latest snapshot.", "Date": "Wed, 01 May 2024 10:19:54 +0200", "Message-ID": "<2203228.C4sosBPzcN@thomas>", "In-Reply-To": "<20240430154014.1026-1-ian.stokes@intel.com>", "References": "<20240430154014.1026-1-ian.stokes@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7Bit", "Content-Type": "text/plain; charset=\"utf-8\"", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "addressed": null }