Patch Comment Detail
get:
Show a patch comment.
patch:
Update a patch comment.
put:
Update a patch comment.
GET /api/patches/139996/comments/169972/?format=api
{ "id": 169972, "web_url": "http://patchwork.dpdk.org/comment/169972/", "msgid": "<CA+sj1i85pTN8zhn5YOwcV0jRJaUSpymQX93L2s5S+Fm8x1Z_PQ@mail.gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/CA+sj1i85pTN8zhn5YOwcV0jRJaUSpymQX93L2s5S+Fm8x1Z_PQ@mail.gmail.com", "date": "2024-05-15T08:28:33", "subject": "Re: [PATCH v4] devtools: add .clang-format file", "submitter": { "id": 3080, "url": "http://patchwork.dpdk.org/api/people/3080/?format=api", "name": "Abdullah Ömer Yamaç", "email": "aomeryamac@gmail.com" }, "content": "I want to update you.\n\nOn Mon, May 13, 2024 at 4:08 PM Ferruh Yigit <ferruh.yigit@amd.com> wrote:\n\n> On 5/8/2024 10:19 PM, Abdullah Ömer Yamaç wrote:\n> > clang-format is a tool to format C/C++/Objective-C code. It can be used\n> > to reformat code to match a given coding style, or to ensure that code\n> > adheres to a specific coding style. It helps to maintain a consistent\n> > coding style across the DPDK codebase.\n> >\n> > .clang-format file overrides the default style options provided by\n> > clang-format and large set of IDEs and text editors support it.\n> >\n> > Signed-off-by: Abdullah Ömer Yamaç <aomeryamac@gmail.com>\n> >\n>\n> Hi Omer,\n>\n> I tried on ethdev.c (clang-format -i ./lib/ethdev/rte_ethdev.c), I will\n> highlight a few issues below (not all of them), I hope it is OK to\n> continue step by step, fixing these issues.\n>\n> 1. clang format failed for following options, not sure why, am I using a\n> wrong version:\n> LineEnding: LF\n> InsertNewlineAtEOF: true\n>\n> I commented them out to continue the test.\n>\n> And for 'ColumnLimit', I prefer default 80 with the flexibility to go\n> 100 when makes sense, so I will got with 'ColumnLimit: 80'; but I don't\n> want to start this discussion.\n>\n> In the .editorconfig file, 100 is stated as a max_line_length. That's why\nI prefer 100.\n\n>\n> 2. Double tab indentation vs parenthesis align\n> if (iter->bus != NULL &&\n> - /* not in middle of rte_eth_dev iteration, */\n> - iter->class_device == NULL) {\n> + /* not in middle of rte_eth_dev iteration, */\n> + iter->class_device == NULL) {\n>\n> DPDK coding guide suggests double tab, but also accepts alignment by\n> spaces. But as far as I can see most of code has double tab.\n> Majority of the diff caused because of this rule.\n>\n> Still, some discussions are going on\n\n>\n> 3. enum merged into single line\n> -enum {\n> - STAT_QMAP_TX = 0,\n> - STAT_QMAP_RX\n> -};\n> +enum { STAT_QMAP_TX = 0, STAT_QMAP_RX };\n>\n> This is ok; I will send a new patch for it.\n\n>\n> 4. split message strings\n> - RTE_ETHDEV_LOG_LINE(ERR,\n> - \"Cannot initialize iterator from NULL device description\n> string\");\n> + RTE_ETHDEV_LOG_LINE(ERR, \"Cannot initialize iterator from NULL \"\n> + \"device description string\");\n>\n>\n> 5. Empty open parenthesis\n> - RTE_ETHDEV_LOG_LINE(ERR,\n> - \"Cannot get next device from NULL iterator\");\n> + RTE_ETHDEV_LOG_LINE(\n> + ERR, \"Cannot get next device from NULL iterator\");\n>\n> I couldn't find a solution, so I am still working on it.\n\n>\n> 6. space before macro arguments\n> - RTE_ETH_FOREACH_DEV(p)\n> + RTE_ETH_FOREACH_DEV (p)\n>\n> This is ok. The fix will be in the next patch.\n\n>\n> 7. some lists get merged (this seems similar to 3.)\n> - RTE_PTYPE_L2_MASK,\n> - RTE_PTYPE_L3_MASK,\n> - RTE_PTYPE_L4_MASK,\n> - RTE_PTYPE_TUNNEL_MASK,\n> - RTE_PTYPE_INNER_L2_MASK,\n> - RTE_PTYPE_INNER_L3_MASK,\n> + RTE_PTYPE_L2_MASK, RTE_PTYPE_L3_MASK,\n> + RTE_PTYPE_L4_MASK, RTE_PTYPE_TUNNEL_MASK,\n> + RTE_PTYPE_INNER_L2_MASK, RTE_PTYPE_INNER_L3_MASK,\n>\n> I couldn't find a configuration that aligns with array initialization.\n\n>\n>\n> Thanks,\n> ferruh\n>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5FF0744034;\n\tWed, 15 May 2024 10:28:47 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id DF3574025C;\n\tWed, 15 May 2024 10:28:46 +0200 (CEST)", "from mail-oa1-f42.google.com (mail-oa1-f42.google.com\n [209.85.160.42]) by mails.dpdk.org (Postfix) with ESMTP id 903464021D\n for <dev@dpdk.org>; Wed, 15 May 2024 10:28:45 +0200 (CEST)", "by mail-oa1-f42.google.com with SMTP id\n 586e51a60fabf-23d3d092a1bso3559704fac.1\n for <dev@dpdk.org>; Wed, 15 May 2024 01:28:45 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20230601; t=1715761724; x=1716366524; darn=dpdk.org;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=TYuGcobn6vFqI9LZ8htt0QpKVg+wF5eYTzUVKavXLT4=;\n b=QZgvKp9bq4/gxUQnyRjOUQfa1wfCkfR1Mk/ln7tgM8Kg2viUYXWnODrPiTRkaGoU8Q\n Pqxt/oUSz3yZnwlFxGFFSFzHSzA3uEV+qnHa0nAHF3elcz25kaM95IHa97CoJnj4+lO1\n WsLBB7p7bEPibXOkeVFDsTuuipll6rEeFDlRhYkRRQ78hWokwRG4cTApCE0/wl8j7Cy0\n KMbtuRq3pqdnmyaRyUnTZYO2zjVrM3dLbDyVaHYDQviOpXTU4idjhjM46xUrZ7O26iqz\n b1cZkLd2EQfapxGaUAiG2jqm35V+CUF6oxa4rG+kz6B3lYqYUzFTwbNddVceqBmGOXlR\n 70AQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1715761724; x=1716366524;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=TYuGcobn6vFqI9LZ8htt0QpKVg+wF5eYTzUVKavXLT4=;\n b=CATppHxkQmq2Cnce879LQ/9+b75Ywx9ZbZTe7iU806DLVB/BmdfJUL3WsQrki1Mb8E\n 4di5SQ0X99FBFCBbA38tFmXOv+nFswXIKmS/lldnpcu1Hw5pWpV7nGaTX+rznLsYuFM2\n 9gdIcmOFBKigGrrmHPWRlxhWxSRx7gS0dvl/nW4i+M52qiEkvFfxp6gn7CKZwTPN+bxA\n aEgZFAWe7EIp6mOVTu+tCEqKqP7/8J9opM5yF/Bz9co52oQFAHtvCFh+fNsxY8P++GKb\n ShNZZcJkMX9PbBmOIWNVAo/PndrAnMDavGIEFVmk+KLM4Igb7EhOSsHr5TfARv9DtIsR\n O/zw==", "X-Gm-Message-State": "AOJu0YyTcLBiL4hTHHIda4EQGH1DLNUrSSpiTDChK+IN8O6I4LMcqO8m\n z6yfA7dyPQG5OT6h8YtxdYVXuXNnYrizABbN9QVACeZ3EUw5AuPEminqibBR4BITLNOm1gYHyU5\n r8mdhPh/nC2omETW4HeQfOfD7ugkpdooC", "X-Google-Smtp-Source": "\n AGHT+IHVnHZxQJVmVywJZ0xVFH06rUMflDsA1kNxn/XV8l2HI9xRUgPBb5/abWY/yfI9M2NNqk/Q3Tb5SKD/s9JGlc0=", "X-Received": "by 2002:a05:6870:f61f:b0:22d:fa53:5695 with SMTP id\n 586e51a60fabf-24172bcb9fcmr18386720fac.25.1715761724558; Wed, 15 May 2024\n 01:28:44 -0700 (PDT)", "MIME-Version": "1.0", "References": "\n <CA+sj1i9RvD5o7sczf_aVjjo+5P=P0UzL=8hEe9qc92VSQsqpjw@mail.gmail.com>\n <20240508211934.1143124-1-aomeryamac@gmail.com>\n <bf38f8a0-6f63-4e07-b6a7-a83de6bced9d@amd.com>", "In-Reply-To": "<bf38f8a0-6f63-4e07-b6a7-a83de6bced9d@amd.com>", "From": "=?utf-8?b?QWJkdWxsYWggw5ZtZXIgWWFtYcOn?= <aomeryamac@gmail.com>", "Date": "Wed, 15 May 2024 11:28:33 +0300", "Message-ID": "\n <CA+sj1i85pTN8zhn5YOwcV0jRJaUSpymQX93L2s5S+Fm8x1Z_PQ@mail.gmail.com>", "Subject": "Re: [PATCH v4] devtools: add .clang-format file", "To": "Ferruh Yigit <ferruh.yigit@amd.com>", "Cc": "dev@dpdk.org, stephen@networkplumber.org", "Content-Type": "multipart/alternative; boundary=\"0000000000001c97de061879e8d7\"", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "addressed": null }