Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/140007/?format=api
{ "id": 140007, "url": "http://patchwork.dpdk.org/api/patches/140007/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240509112635.1170557-2-luca.vizzarro@arm.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240509112635.1170557-2-luca.vizzarro@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240509112635.1170557-2-luca.vizzarro@arm.com", "date": "2024-05-09T11:26:31", "name": "[v2,1/5] dts: fix InteractiveShell command prompt filtering", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "099487c1407841d116bd5e9bb58a23bba9d36b60", "submitter": { "id": 3197, "url": "http://patchwork.dpdk.org/api/people/3197/?format=api", "name": "Luca Vizzarro", "email": "luca.vizzarro@arm.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240509112635.1170557-2-luca.vizzarro@arm.com/mbox/", "series": [ { "id": 31898, "url": "http://patchwork.dpdk.org/api/series/31898/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31898", "date": "2024-05-09T11:26:30", "name": "dts: testpmd show port info/stats", "version": 2, "mbox": "http://patchwork.dpdk.org/series/31898/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/140007/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/140007/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DE61C43F7C;\n\tThu, 9 May 2024 13:26:53 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4682F406B6;\n\tThu, 9 May 2024 13:26:50 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by mails.dpdk.org (Postfix) with ESMTP id C1C29402ED\n for <dev@dpdk.org>; Thu, 9 May 2024 13:26:48 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9886D12FC;\n Thu, 9 May 2024 04:27:13 -0700 (PDT)", "from localhost.localdomain (unknown [10.1.194.74])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 72D683F6A8;\n Thu, 9 May 2024 04:26:47 -0700 (PDT)" ], "From": "Luca Vizzarro <luca.vizzarro@arm.com>", "To": "dev@dpdk.org", "Cc": "=?utf-8?q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech>,\n Jeremy Spewock <jspewock@iol.unh.edu>, Luca Vizzarro <luca.vizzarro@arm.com>,\n Paul Szczepanek <paul.szczepanek@arm.com>", "Subject": "[PATCH v2 1/5] dts: fix InteractiveShell command prompt filtering", "Date": "Thu, 9 May 2024 12:26:31 +0100", "Message-Id": "<20240509112635.1170557-2-luca.vizzarro@arm.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240509112635.1170557-1-luca.vizzarro@arm.com>", "References": "<20240412111136.3470304-1-luca.vizzarro@arm.com>\n <20240509112635.1170557-1-luca.vizzarro@arm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "When sending a command using an instance of InteractiveShell the output\nshould filter out the trailing shell prompt when returning it. After\nevery command two shell prompts are summoned. One is consumed as it is\nused as a delimiter for the command output. The second one is not\nconsumed and left for the next command to be sent.\n\nGiven that the consumed prompt is merely a delimiter, this should not be\nadded to the returned output, as it may be mistakenly be interpreted as\nthe command's own output.\n\nBugzilla ID: 1411\nFixes: 88489c0501af (\"dts: add smoke tests\")\n\nSigned-off-by: Luca Vizzarro <luca.vizzarro@arm.com>\nReviewed-by: Paul Szczepanek <paul.szczepanek@arm.com>\n---\n dts/framework/remote_session/interactive_shell.py | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/dts/framework/remote_session/interactive_shell.py b/dts/framework/remote_session/interactive_shell.py\nindex 074a541279..aa5d2d9be8 100644\n--- a/dts/framework/remote_session/interactive_shell.py\n+++ b/dts/framework/remote_session/interactive_shell.py\n@@ -132,11 +132,11 @@ def send_command(self, command: str, prompt: str | None = None) -> str:\n self._stdin.flush()\n out: str = \"\"\n for line in self._stdout:\n- out += line\n if prompt in line and not line.rstrip().endswith(\n command.rstrip()\n ): # ignore line that sent command\n break\n+ out += line\n self._logger.debug(f\"Got output: {out}\")\n return out\n \n", "prefixes": [ "v2", "1/5" ] }