Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/140066/?format=api
{ "id": 140066, "url": "http://patchwork.dpdk.org/api/patches/140066/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/5362cee0c903d9769ec38f34ee71d4a061727eee.1715699832.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<5362cee0c903d9769ec38f34ee71d4a061727eee.1715699832.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/5362cee0c903d9769ec38f34ee71d4a061727eee.1715699832.git.anatoly.burakov@intel.com", "date": "2024-05-14T15:17:16", "name": "[v1,1/1] net/e1000/base: fix link power down", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f271d18040e1667de15c6ab55ff6951a4c945faa", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 10, "url": "http://patchwork.dpdk.org/api/users/10/?format=api", "username": "bruce", "first_name": "Bruce", "last_name": "Richardson", "email": "bruce.richardson@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/5362cee0c903d9769ec38f34ee71d4a061727eee.1715699832.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 31925, "url": "http://patchwork.dpdk.org/api/series/31925/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31925", "date": "2024-05-14T15:17:16", "name": "[v1,1/1] net/e1000/base: fix link power down", "version": 1, "mbox": "http://patchwork.dpdk.org/series/31925/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/140066/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/140066/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F273744031;\n\tTue, 14 May 2024 17:17:23 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 626F34029E;\n\tTue, 14 May 2024 17:17:23 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.18])\n by mails.dpdk.org (Postfix) with ESMTP id B198840156;\n Tue, 14 May 2024 17:17:21 +0200 (CEST)", "from fmviesa006.fm.intel.com ([10.60.135.146])\n by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 May 2024 08:17:19 -0700", "from silpixa00401119.ir.intel.com ([10.55.129.167])\n by fmviesa006.fm.intel.com with ESMTP; 14 May 2024 08:17:18 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1715699842; x=1747235842;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=aWDimZaVfsRnxP0EbFyD6pFXDy1c47jFH0uIMObfS3w=;\n b=aOuPnC0/kjTItGSbyEsSKxM3j6ZUrwYRX5C4wcwM6wt8kfod6VTcXU9m\n 31JH10TIDW3oHS1GqGXyllFQ1wrsLousnXu/aMR2sxo6dd5XEk1Oyl5w/\n pNqOyoZQtorTSTuv2gAJHWPJ2yjiBcghar1e2DWWhmqtprlA8OgXLYaGk\n uAYSa6fLsY7M7Ii96N6rYXvQI5sw1BFIbOYe+1mfLN3/MBRr4OqLNUN8q\n HBzkeRYmkKbxoCx3VvQCTS3NHWr+DYw3A7qfpXUHTjGj6zdLw+//NKoIp\n 79IQkv96qQJrqx46yA7DDVvIn4W7n2TTo/jk6Mb0fKk/vpPBnlWxKKDEc A==;", "X-CSE-ConnectionGUID": [ "YEDlrEv5Rq+28X025G94lg==", "1nU7JNrQQvSk9FBW2HvoCA==" ], "X-CSE-MsgGUID": [ "DW7b+KXwShq9jITqUlhuQg==", "HA5cHyAZSHWvp4TD8TCRVw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,11073\"; a=\"11508601\"", "E=Sophos;i=\"6.08,159,1712646000\"; d=\"scan'208\";a=\"11508601\"", "E=Sophos;i=\"6.08,159,1712646000\"; d=\"scan'208\";a=\"30764524\"" ], "X-ExtLoop1": "1", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org, Sasha Neftin <sasha.neftin@intel.com>,\n Jeff Kirsher <jeffrey.t.kirsher@intel.com>,\n Guinan Sun <guinanx.sun@intel.com>, Wei Zhao <wei.zhao1@intel.com>", "Cc": "stable@dpdk.org", "Subject": "[PATCH v1 1/1] net/e1000/base: fix link power down", "Date": "Tue, 14 May 2024 16:17:16 +0100", "Message-ID": "\n <5362cee0c903d9769ec38f34ee71d4a061727eee.1715699832.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.43.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Current code is a result of work to reduce duplication between various\ndevice models. However, the logic that was replaced did not exactly\nmatch the new logic, and as a result the link power down was not\nworking correctly for some NICs, and the link remained up even when\nthe interface is down.\n\nFix it to correctly power down the link under all circumstances that\nwere supported by old logic.\n\nFixes: 44dddd14059f (\"net/e1000/base: remove duplicated codes\")\nCc: guinanx.sun@intel.com\nCc: stable@dpdk.org\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n drivers/net/e1000/base/e1000_base.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/e1000/base/e1000_base.c b/drivers/net/e1000/base/e1000_base.c\nindex ab73e1e59e..3ec32e7240 100644\n--- a/drivers/net/e1000/base/e1000_base.c\n+++ b/drivers/net/e1000/base/e1000_base.c\n@@ -107,7 +107,7 @@ void e1000_power_down_phy_copper_base(struct e1000_hw *hw)\n \t\treturn;\n \n \t/* If the management interface is not enabled, then power down */\n-\tif (phy->ops.check_reset_block(hw))\n+\tif (!(e1000_enable_mng_pass_thru(hw) || phy->ops.check_reset_block(hw)))\n \t\te1000_power_down_phy_copper(hw);\n }\n \n", "prefixes": [ "v1", "1/1" ] }