Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/140238/?format=api
{ "id": 140238, "url": "http://patchwork.dpdk.org/api/patches/140238/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240522033009.143100-2-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240522033009.143100-2-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240522033009.143100-2-stephen@networkplumber.org", "date": "2024-05-22T03:27:28", "name": "[v5,01/32] cocci/rte_memcpy: add script to eliminate fixed size rte_memcpy", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "3d5b5871cc9876169012d13ccf9743f19a4d89cf", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240522033009.143100-2-stephen@networkplumber.org/mbox/", "series": [ { "id": 31958, "url": "http://patchwork.dpdk.org/api/series/31958/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31958", "date": "2024-05-22T03:27:27", "name": "replace use of rte_memcpy() with fixed size", "version": 5, "mbox": "http://patchwork.dpdk.org/series/31958/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/140238/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/140238/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AFAB644093;\n\tWed, 22 May 2024 05:30:35 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0BF91402C8;\n\tWed, 22 May 2024 05:30:30 +0200 (CEST)", "from mail-pl1-f173.google.com (mail-pl1-f173.google.com\n [209.85.214.173])\n by mails.dpdk.org (Postfix) with ESMTP id 4C13F4025C\n for <dev@dpdk.org>; Wed, 22 May 2024 05:30:27 +0200 (CEST)", "by mail-pl1-f173.google.com with SMTP id\n d9443c01a7336-1edfc57ac0cso6547275ad.3\n for <dev@dpdk.org>; Tue, 21 May 2024 20:30:27 -0700 (PDT)", "from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-1f323c70dafsm2264325ad.260.2024.05.21.20.30.25\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 21 May 2024 20:30:26 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1716348626;\n x=1716953426; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=HmSOgtgWS/Zv6CMX3f5yCgcQDSHnZlsPruUu8U5+zn4=;\n b=Z5joMTBxR2BcmOMFo6tl61teT7+/EmAoZA5hkrILcdTXB/gGLPgEhKAK9U4oq9bkmM\n 13UiklKPGhm0I46T82pjNQXxghFCCpgJclF5IhPdLRoJiAcakZWVUPeyGbY02xxHfdLB\n oBiCfoKv3A0xqmLMIuKyQQ8wBmWD07HTm2+C2UqKFnhr7q7fC1B5reGPvkqTE65DsgFl\n MLzD7b3iPRpaSWEe5X6n7XQ9vevNJH5ewlfgxKSzjYAL7PTkT5hp6tqdVrRQCipZzZGY\n TPFEt/6zJCoWjQJZsfsJoawjDfjZvR/73Gvq+LiI7f460sEPj6DMOd23nRJAXSzggyAh\n s+Wg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1716348626; x=1716953426;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=HmSOgtgWS/Zv6CMX3f5yCgcQDSHnZlsPruUu8U5+zn4=;\n b=PfbvzdjGYY4yd+Dr7DNj4x2KMFYTgvmB+vgbXuotbx/9Rvoa+8uYib57t7j2BUsFgn\n kanEz7sEpvNOzgbDPNIvFGZxj6TqqU+Mfctvq68bkbZtJaIF7PjeG3RVouE4IjQR0Lhg\n eMTXONz9rwzuLCEC60/SyOLQGOVnY1XsVaw/7ACCtZCpn5sXEv/w+fN5YS3WLi79IK0i\n yiAtRyAc/baoaN4N4kncRz2kD15jODoOplss/jcAoKMQx+uC4LinfJtVufcVcl99WVEc\n kH2mbCg72PIuTtS/VfH8MvBhc6gjkoeiLQEDN0dmb/OrKqCZGfZhzVg2f55ST2gN5byu\n qeRQ==", "X-Gm-Message-State": "AOJu0Yz28U5A2tVd7g+rXT8k9D70xJuO3SeMHC2aY15GBVvMl+V4qav3\n 0TUdz8OWc+qgBpOmmHWM0mlAZkEQx4cEqQ/M4TIwdTvA40cSK4XnH8CIb1APbeE7tDlTD4hSiC7\n 8L1A=", "X-Google-Smtp-Source": "\n AGHT+IEVI26Wg6+XrdDm55usmkD9GuWMcSDvJIkX0l3IWjmwPTRbHo8uCVNG3ajzeFX6HMrERu/xuw==", "X-Received": "by 2002:a17:902:eccc:b0:1f2:f8b7:60d1 with SMTP id\n d9443c01a7336-1f31c9a100dmr9317175ad.26.1716348626373;\n Tue, 21 May 2024 20:30:26 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[PATCH v5 01/32] cocci/rte_memcpy: add script to eliminate fixed size\n rte_memcpy", "Date": "Tue, 21 May 2024 20:27:28 -0700", "Message-ID": "<20240522033009.143100-2-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240522033009.143100-1-stephen@networkplumber.org>", "References": "<20240403163432.437275-1-stephen@networkplumber.org>\n <20240522033009.143100-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Rte_memcpy need not be used for the simple case of copying\na fix size structure because it is not faster and will hide problems\nfrom code analysis tools. Coverity, Fortify and other analyzers\nspecial case memcpy() and can find issues that rte_memcpy()\nwill hide.\n\nMany platforms use memcpy instead of rte_memcpy already.\nThe only reason rte_memcpy() was added in original DPDK was that\nthe older Gcc was doing slower on x86 than the special rte_memcpy()\nwhen handling larger size copies.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n devtools/cocci/rte_memcpy.cocci | 11 +++++++++++\n 1 file changed, 11 insertions(+)\n create mode 100644 devtools/cocci/rte_memcpy.cocci", "diff": "diff --git a/devtools/cocci/rte_memcpy.cocci b/devtools/cocci/rte_memcpy.cocci\nnew file mode 100644\nindex 0000000000..fa1038fc06\n--- /dev/null\n+++ b/devtools/cocci/rte_memcpy.cocci\n@@ -0,0 +1,11 @@\n+//\n+// rte_memcpy should not be used for simple fixed size structure\n+// because compiler's are smart enough to inline these.\n+//\n+@@\n+expression src, dst; constant size;\n+@@\n+(\n+- rte_memcpy(dst, src, size)\n++ memcpy(dst, src, size)\n+)\n", "prefixes": [ "v5", "01/32" ] }