Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 14890,
    "url": "http://patchwork.dpdk.org/api/patches/14890/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1468901869-29609-1-git-send-email-yuanhan.liu@linux.intel.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1468901869-29609-1-git-send-email-yuanhan.liu@linux.intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1468901869-29609-1-git-send-email-yuanhan.liu@linux.intel.com",
    "date": "2016-07-19T04:17:48",
    "name": "[dpdk-dev] doc: note a pitfall on reconnect feature",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "45e0e350cc7fb82cd12f1f597e15dd67cb3e85e1",
    "submitter": {
        "id": 307,
        "url": "http://patchwork.dpdk.org/api/people/307/?format=api",
        "name": "Yuanhan Liu",
        "email": "yuanhan.liu@linux.intel.com"
    },
    "delegate": null,
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1468901869-29609-1-git-send-email-yuanhan.liu@linux.intel.com/mbox/",
    "series": [],
    "comments": "http://patchwork.dpdk.org/api/patches/14890/comments/",
    "check": "pending",
    "checks": "http://patchwork.dpdk.org/api/patches/14890/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id D00AD2B86;\n\tTue, 19 Jul 2016 06:14:10 +0200 (CEST)",
            "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 9776411D4\n\tfor <dev@dpdk.org>; Tue, 19 Jul 2016 06:14:08 +0200 (CEST)",
            "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga102.fm.intel.com with ESMTP; 18 Jul 2016 21:14:05 -0700",
            "from yliu-dev.sh.intel.com ([10.239.67.162])\n\tby fmsmga001.fm.intel.com with ESMTP; 18 Jul 2016 21:14:04 -0700"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos; i=\"5.28,387,1464678000\"; d=\"scan'208\";\n\ta=\"1009497565\"",
        "From": "Yuanhan Liu <yuanhan.liu@linux.intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "Thomas Monjalon <thomas.monjalon@6wind.com>,\n\tYuanhan Liu <yuanhan.liu@linux.intel.com>",
        "Date": "Tue, 19 Jul 2016 12:17:48 +0800",
        "Message-Id": "<1468901869-29609-1-git-send-email-yuanhan.liu@linux.intel.com>",
        "X-Mailer": "git-send-email 1.9.0",
        "Subject": "[dpdk-dev] [PATCH] doc: note a pitfall on reconnect feature",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The vhost feature negotiation only happens at virtio reset stage, say\nwhen a virtio-net device is firstly initiated, or when DPDK virtio PMD\ninitiates. That means, if vhost APP restarts after the negotiation and\nreconnects, the feature negotiation process will not be triggered again,\nmeaning the info is lost. To make reconnect work, QEMU simply saves\nthe negotiated features before the restart and restores it afterwards.\n\nTherefore, the vhost supported features must be exactly the same before\nand after the restart. For example, if TSO is disabled and then enabled,\nnothing will work and issues undefined might happen.\n\nSigned-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>\n---\n\nI just put the part \"people should not do this\" into the doc, and I'm\nnot quite sure I need put the \"why\" part there or not.\n---\n doc/guides/prog_guide/vhost_lib.rst | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)",
    "diff": "diff --git a/doc/guides/prog_guide/vhost_lib.rst b/doc/guides/prog_guide/vhost_lib.rst\nindex 14d5e67..6b0c6b2 100644\n--- a/doc/guides/prog_guide/vhost_lib.rst\n+++ b/doc/guides/prog_guide/vhost_lib.rst\n@@ -189,7 +189,12 @@ vhost-user implementation has two options:\n   When the DPDK vhost-user application restarts, DPDK vhost-user will try to\n   connect to the server again. This is how the \"reconnect\" feature works.\n \n-  Note: the \"reconnect\" feature requires **QEMU v2.7** (or above).\n+  .. Note::\n+     * The \"reconnect\" feature requires **QEMU v2.7** (or above).\n+\n+     * The vhost supported features must be exactly the same before and\n+       after the restart. For example, if TSO is disabled and then enabled,\n+       nothing will work and issues undefined might happen.\n \n No matter which mode is used, once a connection is established, DPDK\n vhost-user will start receiving and processing vhost messages from QEMU.\n",
    "prefixes": [
        "dpdk-dev"
    ]
}