Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41538/?format=api
{ "id": 41538, "url": "http://patchwork.dpdk.org/api/patches/41538/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20180626091236.30429-1-olivier.matz@6wind.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180626091236.30429-1-olivier.matz@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180626091236.30429-1-olivier.matz@6wind.com", "date": "2018-06-26T09:12:35", "name": "[1/2] eal: remove deprecated function returning mbuf pool ops name", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "60ff9b0fbe643c36480b6240d84ad897001b1f89", "submitter": { "id": 8, "url": "http://patchwork.dpdk.org/api/people/8/?format=api", "name": "Olivier Matz", "email": "olivier.matz@6wind.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20180626091236.30429-1-olivier.matz@6wind.com/mbox/", "series": [ { "id": 234, "url": "http://patchwork.dpdk.org/api/series/234/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=234", "date": "2018-06-26T09:12:35", "name": "[1/2] eal: remove deprecated function returning mbuf pool ops name", "version": 1, "mbox": "http://patchwork.dpdk.org/series/234/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/41538/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/41538/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EAB521B42E;\n\tTue, 26 Jun 2018 11:13:07 +0200 (CEST)", "from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com\n\t[62.23.145.76]) by dpdk.org (Postfix) with ESMTP id EA6D61B42D\n\tfor <dev@dpdk.org>; Tue, 26 Jun 2018 11:13:06 +0200 (CEST)", "from glumotte.dev.6wind.com. (unknown [10.16.0.195])\n\tby proxy.6wind.com (Postfix) with ESMTP id DC61B19573A;\n\tTue, 26 Jun 2018 11:08:00 +0200 (CEST)" ], "From": "Olivier Matz <olivier.matz@6wind.com>", "To": "dev@dpdk.org,\n\tHemant Agrawal <hemant.agrawal@nxp.com>", "Cc": "santosh.shukla@caviumnetworks.com,\n\tJohn McNamara <john.mcnamara@intel.com>", "Date": "Tue, 26 Jun 2018 11:12:35 +0200", "Message-Id": "<20180626091236.30429-1-olivier.matz@6wind.com>", "X-Mailer": "git-send-email 2.11.0", "Subject": "[dpdk-dev] [PATCH 1/2] eal: remove deprecated function returning\n\tmbuf pool ops name", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "rte_eal_mbuf_default_mempool_ops() is replaced by\nrte_mbuf_best_mempool_ops().\n\nSigned-off-by: Olivier Matz <olivier.matz@6wind.com>\n---\n doc/guides/rel_notes/deprecation.rst | 9 ---------\n lib/librte_eal/bsdapp/eal/eal.c | 10 ----------\n lib/librte_eal/common/include/rte_eal.h | 11 -----------\n lib/librte_eal/linuxapp/eal/eal.c | 10 ----------\n lib/librte_eal/rte_eal_version.map | 2 --\n 5 files changed, 42 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst\nindex 1ce692eac..5bf680515 100644\n--- a/doc/guides/rel_notes/deprecation.rst\n+++ b/doc/guides/rel_notes/deprecation.rst\n@@ -37,15 +37,6 @@ Deprecation Notices\n - ``eal_parse_pci_DomBDF`` replaced by ``rte_pci_addr_parse``\n - ``rte_eal_compare_pci_addr`` replaced by ``rte_pci_addr_cmp``\n \n-* eal: a new set of mbuf mempool ops name APIs for user, platform and best\n- mempool names have been defined in ``rte_mbuf`` in v18.02. The uses of\n- ``rte_eal_mbuf_default_mempool_ops`` shall be replaced by\n- ``rte_mbuf_best_mempool_ops``.\n- The following function is deprecated since 18.05, and will be removed\n- in 18.08:\n-\n- - ``rte_eal_mbuf_default_mempool_ops``\n-\n * mbuf: The opaque ``mbuf->hash.sched`` field will be updated to support generic\n definition in line with the ethdev TM and MTR APIs. Currently, this field\n is defined in librte_sched in a non-generic way. The new generic format\ndiff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c\nindex dc279542d..f7cced725 100644\n--- a/lib/librte_eal/bsdapp/eal/eal.c\n+++ b/lib/librte_eal/bsdapp/eal/eal.c\n@@ -153,16 +153,6 @@ rte_eal_mbuf_user_pool_ops(void)\n \treturn internal_config.user_mbuf_pool_ops_name;\n }\n \n-/* Return mbuf pool ops name */\n-const char *\n-rte_eal_mbuf_default_mempool_ops(void)\n-{\n-\tif (internal_config.user_mbuf_pool_ops_name == NULL)\n-\t\treturn RTE_MBUF_DEFAULT_MEMPOOL_OPS;\n-\n-\treturn internal_config.user_mbuf_pool_ops_name;\n-}\n-\n /* Return a pointer to the configuration structure */\n struct rte_config *\n rte_eal_get_configuration(void)\ndiff --git a/lib/librte_eal/common/include/rte_eal.h b/lib/librte_eal/common/include/rte_eal.h\nindex 8de5d69e8..0c9c3f13b 100644\n--- a/lib/librte_eal/common/include/rte_eal.h\n+++ b/lib/librte_eal/common/include/rte_eal.h\n@@ -501,17 +501,6 @@ enum rte_iova_mode rte_eal_iova_mode(void);\n const char * __rte_experimental\n rte_eal_mbuf_user_pool_ops(void);\n \n-/**\n- * @deprecated\n- * Get default pool ops name for mbuf\n- *\n- * @return\n- * returns default pool ops name.\n- */\n-__rte_deprecated\n-const char *\n-rte_eal_mbuf_default_mempool_ops(void);\n-\n #ifdef __cplusplus\n }\n #endif\ndiff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c\nindex 8655b8691..cf2a8082b 100644\n--- a/lib/librte_eal/linuxapp/eal/eal.c\n+++ b/lib/librte_eal/linuxapp/eal/eal.c\n@@ -161,16 +161,6 @@ rte_eal_mbuf_user_pool_ops(void)\n \treturn internal_config.user_mbuf_pool_ops_name;\n }\n \n-/* Return mbuf pool ops name */\n-const char *\n-rte_eal_mbuf_default_mempool_ops(void)\n-{\n-\tif (internal_config.user_mbuf_pool_ops_name == NULL)\n-\t\treturn RTE_MBUF_DEFAULT_MEMPOOL_OPS;\n-\n-\treturn internal_config.user_mbuf_pool_ops_name;\n-}\n-\n /* Return a pointer to the configuration structure */\n struct rte_config *\n rte_eal_get_configuration(void)\ndiff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map\nindex f7dd0e7bc..3d4a9d3bb 100644\n--- a/lib/librte_eal/rte_eal_version.map\n+++ b/lib/librte_eal/rte_eal_version.map\n@@ -181,7 +181,6 @@ DPDK_17.11 {\n \trte_bus_get_iommu_class;\n \trte_eal_has_pci;\n \trte_eal_iova_mode;\n-\trte_eal_mbuf_default_mempool_ops;\n \trte_eal_using_phys_addrs;\n \trte_eal_vfio_intr_mode;\n \trte_lcore_has_role;\n@@ -259,7 +258,6 @@ EXPERIMENTAL {\n \trte_eal_cleanup;\n \trte_eal_hotplug_add;\n \trte_eal_hotplug_remove;\n-\trte_eal_mbuf_user_pool_ops;\n \trte_fbarray_attach;\n \trte_fbarray_destroy;\n \trte_fbarray_detach;\n", "prefixes": [ "1/2" ] }