Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 42097,
    "url": "http://patchwork.dpdk.org/api/patches/42097/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20180702134608.6805-1-remy.horton@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180702134608.6805-1-remy.horton@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180702134608.6805-1-remy.horton@intel.com",
    "date": "2018-07-02T13:46:08",
    "name": "[v1] lib/metrics: disallow NULL as metric name",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "279a67e0b9652dba99c7f80ec3d341121378ebf6",
    "submitter": {
        "id": 326,
        "url": "http://patchwork.dpdk.org/api/people/326/?format=api",
        "name": "Remy Horton",
        "email": "remy.horton@intel.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20180702134608.6805-1-remy.horton@intel.com/mbox/",
    "series": [
        {
            "id": 355,
            "url": "http://patchwork.dpdk.org/api/series/355/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=355",
            "date": "2018-07-02T13:46:08",
            "name": "[v1] lib/metrics: disallow NULL as metric name",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/355/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/42097/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/42097/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 005D61B528;\n\tMon,  2 Jul 2018 15:46:13 +0200 (CEST)",
            "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby dpdk.org (Postfix) with ESMTP id 794712C38\n\tfor <dev@dpdk.org>; Mon,  2 Jul 2018 15:46:12 +0200 (CEST)",
            "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t02 Jul 2018 06:46:10 -0700",
            "from rhorton-mobl1.ger.corp.intel.com (HELO FC23.ir.intel.com)\n\t([163.33.178.248])\n\tby fmsmga001.fm.intel.com with ESMTP; 02 Jul 2018 06:46:09 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.51,299,1526367600\"; d=\"scan'208\";a=\"68993409\"",
        "From": "Remy Horton <remy.horton@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "Reshma Pattan <reshma.pattan@intel.com>",
        "Date": "Mon,  2 Jul 2018 14:46:08 +0100",
        "Message-Id": "<20180702134608.6805-1-remy.horton@intel.com>",
        "X-Mailer": "git-send-email 2.9.5",
        "Subject": "[dpdk-dev] [PATCH v1] lib/metrics: disallow NULL as metric name",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "This patch adds a sanity check so that names passed into\nrte_metrics_reg_names() and the wrapper rte_metrics_reg_name()\ncannot be NULL.\n\nFixes: 349950ddb9c5 (\"metrics: add information metrics library\")\n\nSigned-off-by: Remy Horton <remy.horton@intel.com>\n---\n lib/librte_metrics/rte_metrics.c | 3 +++\n 1 file changed, 3 insertions(+)",
    "diff": "diff --git a/lib/librte_metrics/rte_metrics.c b/lib/librte_metrics/rte_metrics.c\nindex 258f058..2275244 100644\n--- a/lib/librte_metrics/rte_metrics.c\n+++ b/lib/librte_metrics/rte_metrics.c\n@@ -96,6 +96,9 @@ rte_metrics_reg_names(const char * const *names, uint16_t cnt_names)\n \t/* Some sanity checks */\n \tif (cnt_names < 1 || names == NULL)\n \t\treturn -EINVAL;\n+\tfor (idx_name = 0; idx_name < cnt_names; idx_name++)\n+\t\tif (names[idx_name] == NULL)\n+\t\t\treturn -EINVAL;\n \n \tmemzone = rte_memzone_lookup(RTE_METRICS_MEMZONE_NAME);\n \tif (memzone == NULL)\n",
    "prefixes": [
        "v1"
    ]
}