Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/43154/?format=api
{ "id": 43154, "url": "http://patchwork.dpdk.org/api/patches/43154/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/8308ba8ca44234ec58b36c422ff3bb85117ecd08.1531841506.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<8308ba8ca44234ec58b36c422ff3bb85117ecd08.1531841506.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/8308ba8ca44234ec58b36c422ff3bb85117ecd08.1531841506.git.anatoly.burakov@intel.com", "date": "2018-07-17T15:41:45", "name": "mem: fix static analysis warning", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a3854ffe4327a2792fccb54dce4cfe8b4136914d", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/8308ba8ca44234ec58b36c422ff3bb85117ecd08.1531841506.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 637, "url": "http://patchwork.dpdk.org/api/series/637/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=637", "date": "2018-07-17T15:41:45", "name": "mem: fix static analysis warning", "version": 1, "mbox": "http://patchwork.dpdk.org/series/637/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/43154/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/43154/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A125B2B92;\n\tTue, 17 Jul 2018 17:41:59 +0200 (CEST)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby dpdk.org (Postfix) with ESMTP id 80866160\n\tfor <dev@dpdk.org>; Tue, 17 Jul 2018 17:41:57 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t17 Jul 2018 08:41:46 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga008.jf.intel.com with ESMTP; 17 Jul 2018 08:41:46 -0700", "from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com\n\t[10.237.217.45])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tw6HFfjHY017761 for <dev@dpdk.org>; Tue, 17 Jul 2018 16:41:45 +0100", "from sivswdev01.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev01.ir.intel.com with ESMTP id w6HFfjxW003600\n\tfor <dev@dpdk.org>; Tue, 17 Jul 2018 16:41:45 +0100", "(from aburakov@localhost)\n\tby sivswdev01.ir.intel.com with LOCAL id w6HFfjDW003596\n\tfor dev@dpdk.org; Tue, 17 Jul 2018 16:41:45 +0100" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,366,1526367600\"; d=\"scan'208\";a=\"57569361\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Date": "Tue, 17 Jul 2018 16:41:45 +0100", "Message-Id": "<8308ba8ca44234ec58b36c422ff3bb85117ecd08.1531841506.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "Subject": "[dpdk-dev] [PATCH] mem: fix static analysis warning", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Technically, single file segments codepath will never get\ntriggered when using in-memory mode, because EAL prohibits\nmixing these two options at initialization time. However,\ncode analyzers do not know that, and some will complain\nabout either using uninitialized variables, or trying to\ndo operations on an already closed descriptor.\n\nFix this by assuring the compiler or code analyzer that\nin-memory mode code never gets triggered when using\nsingle-file segments mode.\n\nCoverity ID: 302847\nFixes: 72b49ff623c4 (\"mem: support --in-memory mode\")\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n lib/librte_eal/linuxapp/eal/eal_memalloc.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/librte_eal/linuxapp/eal/eal_memalloc.c b/lib/librte_eal/linuxapp/eal/eal_memalloc.c\nindex 79443c56a..a59f229cd 100644\n--- a/lib/librte_eal/linuxapp/eal/eal_memalloc.c\n+++ b/lib/librte_eal/linuxapp/eal/eal_memalloc.c\n@@ -481,7 +481,9 @@ alloc_seg(struct rte_memseg *ms, void *addr, int socket_id,\n \tvoid *new_addr;\n \n \talloc_sz = hi->hugepage_sz;\n-\tif (internal_config.in_memory && anonymous_hugepages_supported) {\n+\tif (!internal_config.single_file_segments &&\n+\t\t\tinternal_config.in_memory &&\n+\t\t\tanonymous_hugepages_supported) {\n \t\tint log2, flags;\n \n \t\tlog2 = rte_log2_u32(alloc_sz);\n", "prefixes": [] }