Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/43309/?format=api
{ "id": 43309, "url": "http://patchwork.dpdk.org/api/patches/43309/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/0957f38f12ba6df24f0b48f24fe8236a6ce50efc.1532434698.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<0957f38f12ba6df24f0b48f24fe8236a6ce50efc.1532434698.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/0957f38f12ba6df24f0b48f24fe8236a6ce50efc.1532434698.git.anatoly.burakov@intel.com", "date": "2018-07-24T12:21:40", "name": "Revert \"mem: allocate in reverse to reduce fragmentation\"", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3db0261443cfb58741f3fe1aac2f3d96824a6b93", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/0957f38f12ba6df24f0b48f24fe8236a6ce50efc.1532434698.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 742, "url": "http://patchwork.dpdk.org/api/series/742/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=742", "date": "2018-07-24T12:21:40", "name": "Revert \"mem: allocate in reverse to reduce fragmentation\"", "version": 1, "mbox": "http://patchwork.dpdk.org/series/742/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/43309/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/43309/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3363A2BF1;\n\tTue, 24 Jul 2018 14:21:46 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id CA6FF235\n\tfor <dev@dpdk.org>; Tue, 24 Jul 2018 14:21:44 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t24 Jul 2018 05:21:43 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga001.jf.intel.com with ESMTP; 24 Jul 2018 05:21:41 -0700", "from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com\n\t[10.237.217.45])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tw6OCLfFT010996; Tue, 24 Jul 2018 13:21:41 +0100", "from sivswdev01.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev01.ir.intel.com with ESMTP id w6OCLe0M024004;\n\tTue, 24 Jul 2018 13:21:40 +0100", "(from aburakov@localhost)\n\tby sivswdev01.ir.intel.com with LOCAL id w6OCLeIK024000;\n\tTue, 24 Jul 2018 13:21:40 +0100" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,398,1526367600\"; d=\"scan'208\";a=\"75468082\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, john.mcnamara@intel.com, zhihong.wang@intel.com,\n\tqian.q.xu@intel.com, yu.y.liu@intel.com, lei.a.yao@intel.com", "Date": "Tue, 24 Jul 2018 13:21:40 +0100", "Message-Id": "<0957f38f12ba6df24f0b48f24fe8236a6ce50efc.1532434698.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "Subject": "[dpdk-dev] [PATCH] Revert \"mem: allocate in reverse to reduce\n\tfragmentation\"", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This reverts commit 179f916e88e4a0fdd5ad4d20e226771d3d271c41.\n\nA few regressions with virtio/vhost have been discovered, due to the\nstrong dependency of virtio/vhost on the underlying memory layout.\nSpecifically, virtio/vhost share all memory pages starting from the\nbeginning of the segment, while the patch above made it so that the\nmemory is always allocated from the top of VA space, not from the\nbottom.\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n lib/librte_eal/linuxapp/eal/eal_memalloc.c | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)", "diff": "diff --git a/lib/librte_eal/linuxapp/eal/eal_memalloc.c b/lib/librte_eal/linuxapp/eal/eal_memalloc.c\nindex a59f229cd..aa95551a8 100644\n--- a/lib/librte_eal/linuxapp/eal/eal_memalloc.c\n+++ b/lib/librte_eal/linuxapp/eal/eal_memalloc.c\n@@ -731,8 +731,7 @@ alloc_seg_walk(const struct rte_memseg_list *msl, void *arg)\n \tneed = wa->n_segs;\n \n \t/* try finding space in memseg list */\n-\tcur_idx = rte_fbarray_find_prev_n_free(&cur_msl->memseg_arr,\n-\t\t\tcur_msl->memseg_arr.len - 1, need);\n+\tcur_idx = rte_fbarray_find_next_n_free(&cur_msl->memseg_arr, 0, need);\n \tif (cur_idx < 0)\n \t\treturn 0;\n \tstart_idx = cur_idx;\n", "prefixes": [] }