Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/43411/?format=api
{ "id": 43411, "url": "http://patchwork.dpdk.org/api/patches/43411/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1532627761-256100-2-git-send-email-yipeng1.wang@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1532627761-256100-2-git-send-email-yipeng1.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1532627761-256100-2-git-send-email-yipeng1.wang@intel.com", "date": "2018-07-26T17:56:01", "name": "[2/2] hash: add more accurate thread-safety comments", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "31e76fd8669140552ee99f87d2cabe51c5409d77", "submitter": { "id": 754, "url": "http://patchwork.dpdk.org/api/people/754/?format=api", "name": "Wang, Yipeng1", "email": "yipeng1.wang@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1532627761-256100-2-git-send-email-yipeng1.wang@intel.com/mbox/", "series": [ { "id": 798, "url": "http://patchwork.dpdk.org/api/series/798/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=798", "date": "2018-07-26T17:56:01", "name": null, "version": 1, "mbox": "http://patchwork.dpdk.org/series/798/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/43411/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/43411/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EF06F2B95;\n\tFri, 27 Jul 2018 02:59:54 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 29883288C\n\tfor <dev@dpdk.org>; Fri, 27 Jul 2018 02:59:52 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t26 Jul 2018 17:59:51 -0700", "from skx-yipeng.jf.intel.com ([10.54.81.175])\n\tby fmsmga002.fm.intel.com with ESMTP; 26 Jul 2018 17:59:51 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,407,1526367600\"; d=\"scan'208\";a=\"70771278\"", "From": "Yipeng Wang <yipeng1.wang@intel.com>", "To": "pablo.de.lara.guarch@intel.com, john.mcnamara@intel.com,\n\tmarko.kovacevic@intel.com", "Cc": "dev@dpdk.org,\n\tyipeng1.wang@intel.com,\n\tbruce.richardson@intel.com", "Date": "Thu, 26 Jul 2018 10:56:01 -0700", "Message-Id": "<1532627761-256100-2-git-send-email-yipeng1.wang@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1532627761-256100-1-git-send-email-yipeng1.wang@intel.com>", "References": "<1532627761-256100-1-git-send-email-yipeng1.wang@intel.com>", "Subject": "[dpdk-dev] [PATCH 2/2] hash: add more accurate thread-safety\n\tcomments", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Describing the thread-safety support more accurately for\nAPI documentation.\n\nFixes: f2e3001b53ec (\"hash: support read/write concurrency\")\n\nSigned-off-by: Yipeng Wang <yipeng1.wang@intel.com>\n---\n lib/librte_hash/rte_hash.h | 52 ++++++++++++++++++++++++++++++++++------------\n 1 file changed, 39 insertions(+), 13 deletions(-)", "diff": "diff --git a/lib/librte_hash/rte_hash.h b/lib/librte_hash/rte_hash.h\nindex 1f1a276..748d5cf 100644\n--- a/lib/librte_hash/rte_hash.h\n+++ b/lib/librte_hash/rte_hash.h\n@@ -140,7 +140,9 @@ rte_hash_count(const struct rte_hash *h);\n /**\n * Add a key-value pair to an existing hash table.\n * This operation is not multi-thread safe\n- * and should only be called from one thread.\n+ * and should only be called from one thread by default.\n+ * Thread safety can be enabled by setting flag during\n+ * table creation.\n *\n * @param h\n * Hash table to add the key to.\n@@ -160,7 +162,9 @@ rte_hash_add_key_data(const struct rte_hash *h, const void *key, void *data);\n * Add a key-value pair with a pre-computed hash value\n * to an existing hash table.\n * This operation is not multi-thread safe\n- * and should only be called from one thread.\n+ * and should only be called from one thread by default.\n+ * Thread safety can be enabled by setting flag during\n+ * table creation.\n *\n * @param h\n * Hash table to add the key to.\n@@ -181,7 +185,9 @@ rte_hash_add_key_with_hash_data(const struct rte_hash *h, const void *key,\n \n /**\n * Add a key to an existing hash table. This operation is not multi-thread safe\n- * and should only be called from one thread.\n+ * and should only be called from one thread by default.\n+ * Thread safety can be enabled by setting flag during\n+ * table creation.\n *\n * @param h\n * Hash table to add the key to.\n@@ -199,7 +205,9 @@ rte_hash_add_key(const struct rte_hash *h, const void *key);\n /**\n * Add a key to an existing hash table.\n * This operation is not multi-thread safe\n- * and should only be called from one thread.\n+ * and should only be called from one thread by default.\n+ * Thread safety can be enabled by setting flag during\n+ * table creation.\n *\n * @param h\n * Hash table to add the key to.\n@@ -219,7 +227,9 @@ rte_hash_add_key_with_hash(const struct rte_hash *h, const void *key, hash_sig_t\n /**\n * Remove a key from an existing hash table.\n * This operation is not multi-thread safe\n- * and should only be called from one thread.\n+ * and should only be called from one thread by default.\n+ * Thread safety can be enabled by setting flag during\n+ * table creation.\n *\n * @param h\n * Hash table to remove the key from.\n@@ -238,7 +248,9 @@ rte_hash_del_key(const struct rte_hash *h, const void *key);\n /**\n * Remove a key from an existing hash table.\n * This operation is not multi-thread safe\n- * and should only be called from one thread.\n+ * and should only be called from one thread by default.\n+ * Thread safety can be enabled by setting flag during\n+ * table creation.\n *\n * @param h\n * Hash table to remove the key from.\n@@ -258,7 +270,9 @@ rte_hash_del_key_with_hash(const struct rte_hash *h, const void *key, hash_sig_t\n \n /**\n * Find a key in the hash table given the position.\n- * This operation is multi-thread safe.\n+ * This operation is multi-thread safe with regarding to other lookup threads.\n+ * Read-write concurrency can be enabled by setting flag during\n+ * table creation.\n *\n * @param h\n * Hash table to get the key from.\n@@ -277,7 +291,9 @@ rte_hash_get_key_with_position(const struct rte_hash *h, const int32_t position,\n \n /**\n * Find a key-value pair in the hash table.\n- * This operation is multi-thread safe.\n+ * This operation is multi-thread safe with regarding to other lookup threads.\n+ * Read-write concurrency can be enabled by setting flag during\n+ * table creation.\n *\n * @param h\n * Hash table to look in.\n@@ -296,7 +312,9 @@ rte_hash_lookup_data(const struct rte_hash *h, const void *key, void **data);\n /**\n * Find a key-value pair with a pre-computed hash value\n * to an existing hash table.\n- * This operation is multi-thread safe.\n+ * This operation is multi-thread safe with regarding to other lookup threads.\n+ * Read-write concurrency can be enabled by setting flag during\n+ * table creation.\n *\n * @param h\n * Hash table to look in.\n@@ -317,7 +335,9 @@ rte_hash_lookup_with_hash_data(const struct rte_hash *h, const void *key,\n \n /**\n * Find a key in the hash table.\n- * This operation is multi-thread safe.\n+ * This operation is multi-thread safe with regarding to other lookup threads.\n+ * Read-write concurrency can be enabled by setting flag during\n+ * table creation.\n *\n * @param h\n * Hash table to look in.\n@@ -335,7 +355,9 @@ rte_hash_lookup(const struct rte_hash *h, const void *key);\n \n /**\n * Find a key in the hash table.\n- * This operation is multi-thread safe.\n+ * This operation is multi-thread safe with regarding to other lookup threads.\n+ * Read-write concurrency can be enabled by setting flag during\n+ * table creation.\n *\n * @param h\n * Hash table to look in.\n@@ -370,7 +392,9 @@ rte_hash_hash(const struct rte_hash *h, const void *key);\n \n /**\n * Find multiple keys in the hash table.\n- * This operation is multi-thread safe.\n+ * This operation is multi-thread safe with regarding to other lookup threads.\n+ * Read-write concurrency can be enabled by setting flag during\n+ * table creation.\n *\n * @param h\n * Hash table to look in.\n@@ -391,7 +415,9 @@ rte_hash_lookup_bulk_data(const struct rte_hash *h, const void **keys,\n \n /**\n * Find multiple keys in the hash table.\n- * This operation is multi-thread safe.\n+ * This operation is multi-thread safe with regarding to other lookup threads.\n+ * Read-write concurrency can be enabled by setting flag during\n+ * table creation.\n *\n * @param h\n * Hash table to look in.\n", "prefixes": [ "2/2" ] }