Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/43416/?format=api
{ "id": 43416, "url": "http://patchwork.dpdk.org/api/patches/43416/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/7679658279b52ae069260b62696398a97648eb6a.1532679585.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<7679658279b52ae069260b62696398a97648eb6a.1532679585.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/7679658279b52ae069260b62696398a97648eb6a.1532679585.git.anatoly.burakov@intel.com", "date": "2018-07-27T08:24:35", "name": "eal/bsd: silence not supported error in interrupts", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3d8f86e1fc75f35556ae6ab5a94a4093d24ef663", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/7679658279b52ae069260b62696398a97648eb6a.1532679585.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 802, "url": "http://patchwork.dpdk.org/api/series/802/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=802", "date": "2018-07-27T08:24:35", "name": "eal/bsd: silence not supported error in interrupts", "version": 1, "mbox": "http://patchwork.dpdk.org/series/802/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/43416/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/43416/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5CA99326C;\n\tFri, 27 Jul 2018 10:25:00 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby dpdk.org (Postfix) with ESMTP id D7575324B\n\tfor <dev@dpdk.org>; Fri, 27 Jul 2018 10:24:57 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t27 Jul 2018 01:24:56 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga001.jf.intel.com with ESMTP; 27 Jul 2018 01:24:36 -0700", "from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com\n\t[10.237.217.45])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tw6R8OZm7009868; Fri, 27 Jul 2018 09:24:35 +0100", "from sivswdev01.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev01.ir.intel.com with ESMTP id w6R8OZCV024161;\n\tFri, 27 Jul 2018 09:24:35 +0100", "(from aburakov@localhost)\n\tby sivswdev01.ir.intel.com with LOCAL id w6R8OZwh024149;\n\tFri, 27 Jul 2018 09:24:35 +0100" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,408,1526367600\"; d=\"scan'208\";a=\"76406417\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>, thomas@monjalon.net,\n\tchangqingx.wu@intel.com", "Date": "Fri, 27 Jul 2018 09:24:35 +0100", "Message-Id": "<7679658279b52ae069260b62696398a97648eb6a.1532679585.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "Subject": "[dpdk-dev] [PATCH] eal/bsd: silence not supported error in\n\tinterrupts", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently, nic_uio driver does not support interrupts, so any\nattempts to install an interrupt handler will fail with a\nnot supported error, which will cause an error message that is\nconfusing to the user.\n\nSilence this error by moving it to debug log level, and reword\nthe message to avoid containing the word \"Error\", to avoid\ntriggering DTS test failures [1].\n\n[1] https://git.dpdk.org/tools/dts/tree/tests/\nTestSuite_scatter.py?#n110\n\nFixes: 23150bd8d8a8 (\"eal/bsd: add interrupt thread\")\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n lib/librte_eal/bsdapp/eal/eal_interrupts.c | 14 ++++++++++++--\n 1 file changed, 12 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/librte_eal/bsdapp/eal/eal_interrupts.c b/lib/librte_eal/bsdapp/eal/eal_interrupts.c\nindex 29356f320..2feee2d52 100644\n--- a/lib/librte_eal/bsdapp/eal/eal_interrupts.c\n+++ b/lib/librte_eal/bsdapp/eal/eal_interrupts.c\n@@ -156,8 +156,18 @@ rte_intr_callback_register(const struct rte_intr_handle *intr_handle,\n \t\t * add the intr file descriptor into wait list.\n \t\t */\n \t\tif (kevent(kq, &ke, 1, NULL, 0, NULL) < 0) {\n-\t\t\tRTE_LOG(ERR, EAL, \"Error adding fd %d kevent, %s\\n\",\n-\t\t\t\tsrc->intr_handle.fd, strerror(errno));\n+\t\t\t/* currently, nic_uio does not support interrupts, so\n+\t\t\t * this error will always be triggered and output to the\n+\t\t\t * user. so, don't output it unless debug log level set.\n+\t\t\t */\n+\t\t\tif (errno == ENODEV)\n+\t\t\t\tRTE_LOG(DEBUG, EAL, \"Interrupt handle %d not supported\\n\",\n+\t\t\t\t\tsrc->intr_handle.fd);\n+\t\t\telse\n+\t\t\t\tRTE_LOG(ERR, EAL, \"Error adding fd %d \"\n+\t\t\t\t\t\t\"kevent, %s\\n\",\n+\t\t\t\t\t\tsrc->intr_handle.fd,\n+\t\t\t\t\t\tstrerror(errno));\n \t\t\tret = -errno;\n \t\t\tgoto fail;\n \t\t}\n", "prefixes": [] }