Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/43513/?format=api
{ "id": 43513, "url": "http://patchwork.dpdk.org/api/patches/43513/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20180802010557.16648-2-yskoh@mellanox.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180802010557.16648-2-yskoh@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180802010557.16648-2-yskoh@mellanox.com", "date": "2018-08-02T01:05:57", "name": "[2/2] net/mlx5: preserve allmulti flag for flow isolation mode", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9d944eb908c87e70716c8b0d2632a08172a1365e", "submitter": { "id": 636, "url": "http://patchwork.dpdk.org/api/people/636/?format=api", "name": "Yongseok Koh", "email": "yskoh@mellanox.com" }, "delegate": { "id": 6624, "url": "http://patchwork.dpdk.org/api/users/6624/?format=api", "username": "shahafs", "first_name": "Shahaf", "last_name": "Shuler", "email": "shahafs@mellanox.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20180802010557.16648-2-yskoh@mellanox.com/mbox/", "series": [ { "id": 867, "url": "http://patchwork.dpdk.org/api/series/867/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=867", "date": "2018-08-02T01:05:57", "name": null, "version": 1, "mbox": "http://patchwork.dpdk.org/series/867/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/43513/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/43513/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 659E21B3EE;\n\tThu, 2 Aug 2018 03:06:19 +0200 (CEST)", "from EUR03-DB5-obe.outbound.protection.outlook.com\n\t(mail-eopbgr40063.outbound.protection.outlook.com [40.107.4.63])\n\tby dpdk.org (Postfix) with ESMTP id 079EB1B3A2;\n\tThu, 2 Aug 2018 03:06:16 +0200 (CEST)", "from mellanox.com (209.116.155.178) by\n\tAM5PR0501MB2034.eurprd05.prod.outlook.com (2603:10a6:203:1a::20) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.995.19;\n\tThu, 2 Aug 2018 01:06:14 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n\ts=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=eu/y6pqlSjaKASwerg3oCOzFfN1AKLEfloXbtPlBrlk=;\n\tb=Uz13paWhMkmVs9rAJgZ8/EgsTY3czW19WwEyqlX4MVUqV8GqcsWkRD8aLI25NrZmDn1+nTsLdVCg8pth00AxcmjLamOOt5uuMs4fLvVuvQE/uqKrA1+Uv5rHXOBO3Lvp6b8DQhGGGTmW2CLtqC/7jYPgm4L8xmkK5s5rw6IymvY=", "Authentication-Results": "spf=none (sender IP is )\n\tsmtp.mailfrom=yskoh@mellanox.com; ", "From": "Yongseok Koh <yskoh@mellanox.com>", "To": "shahafs@mellanox.com", "Cc": "dev@dpdk.org,\n\tYongseok Koh <yskoh@mellanox.com>,\n\tstable@dpdk.org", "Date": "Wed, 1 Aug 2018 18:05:57 -0700", "Message-Id": "<20180802010557.16648-2-yskoh@mellanox.com>", "X-Mailer": "git-send-email 2.11.0", "In-Reply-To": "<20180802010557.16648-1-yskoh@mellanox.com>", "References": "<20180802010557.16648-1-yskoh@mellanox.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[209.116.155.178]", "X-ClientProxiedBy": "MWHPR15CA0054.namprd15.prod.outlook.com\n\t(2603:10b6:301:4c::16) To AM5PR0501MB2034.eurprd05.prod.outlook.com\n\t(2603:10a6:203:1a::20)", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "bfa7f225-3e27-48ad-7842-08d5f8142544", "X-MS-Office365-Filtering-HT": "Tenant", "X-Microsoft-Antispam": "BCL:0; PCL:0;\n\tRULEID:(7020095)(4652040)(8989117)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020);\n\tSRVR:AM5PR0501MB2034; ", "X-Microsoft-Exchange-Diagnostics": [ "1; AM5PR0501MB2034;\n\t3:M9LrebsKQPg+Cs6317zqFc39e5i4qU45sp/IzTWqhS1jguwrg2q1Ak81xM/9DgFjHQ9r3nkxjeEAv3RPQgJmTf04awD0UTEEMN9DnC6JO0nBdWNNeDcAN+SE+1Zjoaymz2zgnjbKbphnW8Wwdf8L3G4VdtP6+M02Sd6EmgAAGAm7PrFTzFNDu5fr2lhxtGqDZkr3h91ps/ztTASYQoki8LtIwU9a6t3JYZrqQMt35Pch8yhA/hDw/OaeJgcQ63E7;\n\t25:hY6Fi9mKb6ymJ96wCKIpBt/kOLjU0BexuESa2eJKZ0VmL0VwsvjNpyNbuXJHbMsbHNmrphuei3IG3hQw2xO0/FdSVavnFb9SbQI/CjyUrOvlSeRFWTU/pTBzfZCD53HZEs0j0KuCpOzoj9vR+16+TygSjm9e+D2O8/jqbibBlW0YE30Dp3fdJXOSxil6ECFCiHlL1UTjvdP0aieuNRYXDu1h1jNABZznJVGTE975kxZpOOkCNp+v36r6GRyBROrC/1qcnUHcq6mDPuRqkJUfw1uhNt7JKM6sglFzBiiPfg/fwMXpT2sXbutuWFVsZ/haEe24GCfJf05yFrLWgbqsBQ==;\n\t31:5gaLhEQa6HXJP3CBMWslKlvE6LfvkIRGK8IINjYacT26aBhHA6FERGD9/75Q4DIJrE1rjxeMS0iKcLVTSIB0uWQw3uSz2G80I3Jv3Prx0KGF6DCGnAIfed+SVfU5Gsbu8nNXt38eqrCLtHpZzg1CUz8qhN6LYaUQsQR7Dz3razF0XsdGYbYy6/oDJ1iPRQVG79RFYmDoYnSjyTnLUVpDzTv8Xh+kOJ/+Bh22YGvFZ48=", "1; AM5PR0501MB2034;\n\t20:2ZKd9ussJYhMzq+wMzDn4vduCgl0j3qQegF1pw5F9nbnZl/YjyO4z7lSnf4rmeYZH/a0iF07DawObODy+VQdKcTPmg94YsuikIlaNpkFx9FKYZ3/H/QhYDxqMAsP8S52l42TwLmZrPPofaw8MRUCHGsuZwfLIE3mdVNDdIxBkg2Ibd1FH0qv6nDR4IBfBYPS8d0/GUEhuX01tWw0TMnw0i7d9meSO8tOX8c7TXYaPKMcZfnjjI57tD7A55F9pxRSIqxZE1PAd3ZDS/PodajuVyAYt9dTsH/4Ir/UoSD/opYnPBt7qMjdwdIjMfFtgYBi/HY0HCjghDB2CfeakfuD/wfEztfKZM7VQtXArq0syxSdFjfuZkE90CacLbe6nuER9pSd44EmiQimc1SbpokqqtZeEhl+pZuj+qWMnubc/HOpjp+SzDpMawvY+dCuBHXqk4Z6Th8prHfM9mN3B2DSLuBrp3FL5g1LcH2gHWlEmAv+xgMQ1c7d+vz2V8W1KAiQ;\n\t4:ETSp39iUNDZ0LA3SxUpyhrZzrd+eFnMlA6mqkmxmAdGTZom8yKu6TGAQtDpjk3E+JkUtPfIE7pdI17vb+QaTmuyon74Z1mGRWTwpEAOpxT3JqqTbhd1Qaf50DM9+yEwSTDjE0UxNnDrCwvDpunXe5XLAhzqSchk/9amBF/IX4UGuvYFkohRO3eqQigUhmrGBTKlE1OjaywOunG+6ckVwFXuGkUReZAOmpRoM+8OpsCaFBzx0Ntukwu/nOwpL9P9+El0juBOmz3xT5ZoATBRJWQ==", "=?us-ascii?Q?1; AM5PR0501MB2034;\n\t23:1F9jRjC63IN9CvunSoOXv4w2DEj38p4YLpobXR+?=\n\tS4Mx67YtAIAyqo+TIDDAm92AGeSFExoSK2RPtjVNS4gTxcM57svfp3mHGe4l28940uxngtYdO4MexTuPEfffA9BehPN4KfdS93MtEX7VPa+nuwudlxap+xu7Nk2s19oJLDEEyy+ljPHu1P+Z1jF+FE7RofXGNsOCGGI9BqF4ShDc+TvSXLRzPGO5qZfhBHvMAwbctn+9pg6Ju1Qc2Kz/IYLfrbsqMJXEAXRr4t3mpkPs1eKDktdBjuO3Ta6XhSm6QVwn8spDgIPFWwXMllND6bwmqaXDiSwKhb2043jOUSvX+emcwqJMu6dORHshjIreSQwnAwbN49J4PAEblGE9BsUHY38Vjf+BXyJa9Elh5iIPAX6U1HBf47XfXO6M/A4c9paSQ9D3XPUFllniEBJ2O/WmhQ2c98LqJ+8yMqrNKdiLt6CV4nAxFEbG6XMbq3RUDqmpWb/aOTy3hApzwXM1ovvlSgFSKK/OQ1NV+YixwZhI/cSn50yFsXhwe9jFhiWlIjcDYmxVk/dajLpzfSL9TiIhT3U3vf6gaWeyeTv4Y4IGomAQZR+xGFICwYiN+jt4EnYCr9g+FlWeHfxYjSEDpU4VRSc2xy2gMmLn+wBw/KyreBysSEelI5WZe45nNEtiWCqs4HaqEH+EcM7fUf4fr6fQF4lrRvalQedAvUnPQ47QX+uMZ3SxpGK+2mbu3VHJ9EA6zlUO5hWQJHDzYR2nHNx/424l+zyA/k44KOKmm2PluBQjy4AFREaO18y1pM4KR4MhPwSVKJP57t/K4kcaNO2Rx3bHnsKUUfcorzvJZYR1p6o/rbV/6lbS/bIHiCpNlZnePGVx9H8spS+/fVgP4or/rfsagtb+5WdoUyaluqDnQzuZhSm2CMONQa5QrHFxzA2U5FQht9x7NVvvJDxbBTlWJItCE/rvRYGjllerxtd81JECD9cZ1bRgdHOVvfnftKUFdjfC60EWewEIAQxusGg+MnAcArykoVYzSfq0ZHeZerbY+cllF2UVFerEZ2ayjOmmMrllSBoABLC/4S8Ih1h8SP8AiY9hAp+DE88GPJGAIFS6MA3KKZNl0jpr5UcVAZo66nTgaUP9R84adQu4HilJBsXck0/fFpjdL8qPmbwGos3zQ05ZxVx7YB5SnnbJc/g3cT4CDN1pRsPzShjuJJWdPZb76ua1tLHnESSAV+lBLHCllHEOw0gi2UJWNsc+9f4eIgxrt9EBecQUO/nMyTdRPrxtP8ZcQBcdrVjo1j00egPuMrTFhg1GUV/EUaoNHOIA=", "1; AM5PR0501MB2034;\n\t6:UqYFvsvwT59DXfaW/TI9I5zdFVqIpebvkduirNcgQ1ZWCbUUanBBWrGHS1XLybeFcFTaQgg0ggAHsp/1qEYtAjj6RIITTA5vMR9SfyM66UqDczsJAiEI/+Oz9IuYJaNzXZVLfLNJ8jfN8EcslM52Ix/hoqtk5wp4iyALzq6oMdOIs0Ht0rStmsHtn0eOFRCQL6PDVqyHv/yGd8Y5onWZfkJ8yKW214HfVR9fQ9MIyOu+QTVRgIHwBbjueuUAmyKe8VijM6iNM/XlaIHJzAfLdIFMXnHr/NAdcfYHAgjLesyPrnvf4Zarvi3pOxjmEnMC4EbkQS9l46AiDnfhVdW9zqrvrAcssS97pzUeD4rvfoCVaAErJERfYJ7/mZgf74ZarwcFrRyQFcGoq4vBktrxWiU3UptsVl92jmDmh9K5w5d0WMSojp3JlbCIujdozhKrPCPRqmgXrY0qsmyV8peZYQ==;\n\t5:X4PmkbZTdF2Eh7mIQtx7nIv7h+dKl3EPwGma5S8mzRVH/Y7mrQzP9c4UlHrx/F4/JT534kEvyxejFDorBOGzMts+VoOT1eNWps9cqS7vNb5Ip0yl1Z8rdwloGjZ7RAE1kSFrFA0SSMD5RT06CHRd8PAw0Ykoj+G3G7zmcQzqMhk=;\n\t7:tGua5uKs3RShCrwVESK1HO6kMFT0fNSKmMIELvWJb8DUSHGj/mIqnROyZPA+EqNGwDiBieMmGasz1gKBfheDScGL8iodVzsNYy3Mzuig29uj/RdBHoTpyF3+q9bA1CNBmjNXFJdo4cdR/RYIpWrLRDUkouvtF5SFEcFxugNhbr4utr15ySGx5MMjT3s+gSiP/AaWlXartejdlgEqGYn+CkqNK8+MZKr8RmX7qgs+S5VgaPvN+UtG+2xUUFDgMsMP" ], "X-MS-TrafficTypeDiagnostic": "AM5PR0501MB2034:", "X-Microsoft-Antispam-PRVS": "<AM5PR0501MB2034D436756F69499063AD54C32C0@AM5PR0501MB2034.eurprd05.prod.outlook.com>", "X-Exchange-Antispam-Report-Test": "UriScan:;", "X-MS-Exchange-SenderADCheck": "1", "X-Exchange-Antispam-Report-CFA-Test": "BCL:0; PCL:0;\n\tRULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(3231311)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(20161123564045)(6072148)(201708071742011)(7699016);\n\tSRVR:AM5PR0501MB2034; BCL:0; PCL:0; RULEID:; SRVR:AM5PR0501MB2034; ", "X-Forefront-PRVS": "07521929C1", "X-Forefront-Antispam-Report": "SFV:NSPM;\n\tSFS:(10009020)(396003)(136003)(376002)(346002)(39860400002)(366004)(189003)(199004)(11346002)(26005)(2616005)(6116002)(105586002)(25786009)(2351001)(486006)(956004)(8676002)(34206002)(446003)(4326008)(3846002)(386003)(86362001)(476003)(1076002)(55016002)(36756003)(106356001)(81156014)(50226002)(21086003)(81166006)(53936002)(47776003)(69596002)(97736004)(5660300001)(316002)(52116002)(37006003)(6666003)(48376002)(2361001)(6636002)(7736002)(66066001)(16526019)(50466002)(68736007)(450100002)(76176011)(2906002)(14444005)(8936002)(305945005)(7696005)(51416003)(16586007)(478600001);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0501MB2034; H:mellanox.com; FPR:;\n\tSPF:None; \n\tLANG:en; PTR:InfoNoRecords; MX:1; A:1; ", "Received-SPF": "None (protection.outlook.com: mellanox.com does not designate\n\tpermitted sender hosts)", "X-Microsoft-Antispam-Message-Info": "PMDMO9RjsEPe4w14XEtb1t5bC7EflvkCjK1Ar6ShYetk511c8k4hmM8VoARXcN0KmIRQYM8CK958A9h8gjvKQOuPVDpKtQRkFPPLyXA430em6312YwjpqDMqJqYFkyPf4tOOhEWeHKqWVPimg9FtiUQBmi170AhAqwD2f+FYhLQFAT4rD/UJq3SsNAkW0RaiPExoPsF+5Xl294JVT4Q1IUdCeRxyXs/sd5JaNchyhtMMCeA0Grm6aJ+xcSiLkJFerOal24CCogB3avR5nlPpbADYJhETUx0zUJDb8R6JRKY5FSKnanatOqtpm97iFU+kjkeUMhF11RDWBiNqEXMw/dnNRgFqbpF667qmJ9Kmd3Y=", "SpamDiagnosticOutput": "1:99", "SpamDiagnosticMetadata": "NSPM", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "02 Aug 2018 01:06:14.0601\n\t(UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "bfa7f225-3e27-48ad-7842-08d5f8142544", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "a652971c-7d2e-4d9b-a6a4-d149256f461b", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM5PR0501MB2034", "Subject": "[dpdk-dev] [PATCH 2/2] net/mlx5: preserve allmulti flag for flow\n\tisolation mode", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "mlx5_dev_ops_isolate doesn't have APIs for enabling/disabling allmulti\nmode as it can't be enabled in flow isolation mode. If the function\npointers are null, librte APIs such as\nrte_eth_allmulticast_enable/disable() fail to set the flag\n(dev->data->all_multicast). Also, there's need to preserve allmulti mode\nsetting when toggling flow isolation mode. Allmulti mode, if enabled,\nshould be disabled when switching to flow isolation mode and vice versa.\n\nFixes: 0887aa7f27f3 (\"net/mlx5: add new operations for isolated mode\")\nCc: stable@dpdk.org\n\nSigned-off-by: Yongseok Koh <yskoh@mellanox.com>\n---\n drivers/net/mlx5/mlx5.c | 2 ++\n drivers/net/mlx5/mlx5_flow.c | 6 ++++++\n drivers/net/mlx5/mlx5_rxmode.c | 8 ++++++--\n 3 files changed, 14 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c\nindex 83b82f11ab..ec63bc6e22 100644\n--- a/drivers/net/mlx5/mlx5.c\n+++ b/drivers/net/mlx5/mlx5.c\n@@ -401,6 +401,8 @@ const struct eth_dev_ops mlx5_dev_ops_isolate = {\n \t.dev_close = mlx5_dev_close,\n \t.promiscuous_enable = mlx5_promiscuous_enable,\n \t.promiscuous_disable = mlx5_promiscuous_disable,\n+\t.allmulticast_enable = mlx5_allmulticast_enable,\n+\t.allmulticast_disable = mlx5_allmulticast_disable,\n \t.link_update = mlx5_link_update,\n \t.stats_get = mlx5_stats_get,\n \t.stats_reset = mlx5_stats_reset,\ndiff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c\nindex 268d1f056c..fcaa7ddfc3 100644\n--- a/drivers/net/mlx5/mlx5_flow.c\n+++ b/drivers/net/mlx5/mlx5_flow.c\n@@ -3345,11 +3345,17 @@ mlx5_flow_isolate(struct rte_eth_dev *dev,\n \t\t\tmlx5_promiscuous_disable(dev);\n \t\t\tdev->data->promiscuous = 1;\n \t\t}\n+\t\tif (dev->data->all_multicast) {\n+\t\t\tmlx5_allmulticast_disable(dev);\n+\t\t\tdev->data->all_multicast = 1;\n+\t\t}\n \t} else {\n \t\tdev->dev_ops = &mlx5_dev_ops;\n \t\t/* Take back disabled features if needed. */\n \t\tif (dev->data->promiscuous)\n \t\t\tmlx5_promiscuous_enable(dev);\n+\t\tif (dev->data->all_multicast)\n+\t\t\tmlx5_allmulticast_enable(dev);\n \t}\n \treturn 0;\n }\ndiff --git a/drivers/net/mlx5/mlx5_rxmode.c b/drivers/net/mlx5/mlx5_rxmode.c\nindex 0ed4c1a174..5b73f3eb8b 100644\n--- a/drivers/net/mlx5/mlx5_rxmode.c\n+++ b/drivers/net/mlx5/mlx5_rxmode.c\n@@ -76,10 +76,13 @@ mlx5_promiscuous_disable(struct rte_eth_dev *dev)\n void\n mlx5_allmulticast_enable(struct rte_eth_dev *dev)\n {\n+\tstruct priv *priv = dev->data->dev_private;\n \tint ret;\n \n \tdev->data->all_multicast = 1;\n-\tif (((struct priv *)dev->data->dev_private)->config.vf)\n+\tif (priv->isolated)\n+\t\treturn;\n+\tif (priv->config.vf)\n \t\tmlx5_nl_allmulti(dev, 1);\n \tret = mlx5_traffic_restart(dev);\n \tif (ret)\n@@ -96,10 +99,11 @@ mlx5_allmulticast_enable(struct rte_eth_dev *dev)\n void\n mlx5_allmulticast_disable(struct rte_eth_dev *dev)\n {\n+\tstruct priv *priv = dev->data->dev_private;\n \tint ret;\n \n \tdev->data->all_multicast = 0;\n-\tif (((struct priv *)dev->data->dev_private)->config.vf)\n+\tif (priv->config.vf)\n \t\tmlx5_nl_allmulti(dev, 0);\n \tret = mlx5_traffic_restart(dev);\n \tif (ret)\n", "prefixes": [ "2/2" ] }