Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/45974/?format=api
{ "id": 45974, "url": "http://patchwork.dpdk.org/api/patches/45974/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20181003173612.67101-1-kevin.laatz@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181003173612.67101-1-kevin.laatz@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20181003173612.67101-1-kevin.laatz@intel.com", "date": "2018-10-03T17:36:02", "name": "[v2,00/10] introduce telemetry library", "commit_ref": null, "pull_url": null, "state": null, "archived": false, "hash": null, "submitter": { "id": 921, "url": "http://patchwork.dpdk.org/api/people/921/?format=api", "name": "Kevin Laatz", "email": "kevin.laatz@intel.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20181003173612.67101-1-kevin.laatz@intel.com/mbox/", "series": [], "comments": "http://patchwork.dpdk.org/api/patches/45974/comments/", "check": "pending", "checks": "http://patchwork.dpdk.org/api/patches/45974/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2FC481B13D;\n\tWed, 3 Oct 2018 19:36:22 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id A82564C96\n\tfor <dev@dpdk.org>; Wed, 3 Oct 2018 19:36:18 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t03 Oct 2018 10:36:16 -0700", "from silpixa00397517.ir.intel.com (HELO\n\tsilpixa00397517.ger.corp.intel.com) ([10.237.222.54])\n\tby orsmga001.jf.intel.com with ESMTP; 03 Oct 2018 10:36:07 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,336,1534834800\"; d=\"scan'208\";a=\"96182407\"", "From": "Kevin Laatz <kevin.laatz@intel.com>", "To": "dev@dpdk.org", "Cc": "harry.van.haaren@intel.com, stephen@networkplumber.org,\n\tgaetan.rivet@6wind.com, shreyansh.jain@nxp.com, thomas@monjalon.net, \n\tKevin Laatz <kevin.laatz@intel.com>", "Date": "Wed, 3 Oct 2018 18:36:02 +0100", "Message-Id": "<20181003173612.67101-1-kevin.laatz@intel.com>", "X-Mailer": "git-send-email 2.9.5", "In-Reply-To": "<1535026093-101872-1-git-send-email-ciara.power@intel.com>", "References": "<1535026093-101872-1-git-send-email-ciara.power@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 00/10] introduce telemetry library", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patchset introduces a Telemetry library for DPDK Service Assurance.\nThis library provides an easy way to query DPDK Ethdev metrics.\n\nThe telemetry library provides a method for a service assurance component\nto retrieve metrics from a DPDK packet forwarding application.\nCommunicating from the service assurance component to DPDK is done using a\nUNIX domain socket, passing a JSON formatted string. A reply is sent (again\na JSON formatted string) of the current DPDK metrics.\n\nThe telemetry component makes use of the existing rte_metrics library to\nquery values. The values to be transmitted via the telemetry infrastructure\nmust be present in the Metrics library. Currently the ethdev values are\npushed to the metrics library, and the queried from there there is an open\nquestion on how applications would like this to occur. Currently only\nethdev to metrics functionality is implemented, however other subsystems\nlike crypto, eventdev, keepalive etc can use similar mechanisms.\n\nExposing DPDK Telemetry via a socket interface enables service assurance\nagents like collectd to consume data from DPDK. This is vital for\nmonitoring, fault-detection, and error reporting. A collectd plugin has\nbeen created to interact with the DPDK Telemetry component, showing how it\ncan be used in practice. The collectd plugin will be upstreamed to collectd\nat a later stage. A small python script is provided in\n./usertools/telemetry_client.py to quick-start using DPDK Telemetry.\n\nNote: We are aware that the --telemetry flag is not working for meson\nbuilds, we are working on it for a future patch. Despite opterr being set\nto 0, --telemetry said to be 'unrecognized' as a startup print. This is a\ncosmetic issue and will also be addressed.\n\n---\nv2:\n - Reworked telemetry as part of EAL instead of using vdev (Gaetan)\n - Refactored rte_telemetry_command (Gaetan)\n - Added MAINTAINERS file entry (Stephen)\n - Updated docs to reflect vdev to eal rework\n - Removed collectd patch from patchset (Thomas)\n - General code clean up from v1 feedback\n\nCiara Power, Brian Archbold and Kevin Laatz (10):\n telemetry: initial telemetry infrastructure\n telemetry: add initial connection socket\n telemetry: add client feature and sockets\n telemetry: add parser for client socket messages\n telemetry: update metrics before sending stats\n telemetry: format json response when sending stats\n telemetry: add tests for telemetry api\n telemetry: add ability to disable selftest\n doc: add telemetry documentation\n usertools: add client python script for telemetry\n\n MAINTAINERS | 5 +\n config/common_base | 5 +\n doc/guides/howto/index.rst | 1 +\n doc/guides/howto/telemetry.rst | 85 +\n lib/Makefile | 2 +\n lib/librte_eal/common/include/rte_eal.h | 19 +\n lib/librte_eal/linuxapp/eal/eal.c | 37 +-\n lib/librte_eal/rte_eal_version.map | 7 +\n lib/librte_telemetry/Makefile | 30 +\n lib/librte_telemetry/meson.build | 9 +\n lib/librte_telemetry/rte_telemetry.c | 1786 +++++++++++++++++++++\n lib/librte_telemetry/rte_telemetry.h | 48 +\n lib/librte_telemetry/rte_telemetry_internal.h | 81 +\n lib/librte_telemetry/rte_telemetry_parser.c | 586 +++++++\n lib/librte_telemetry/rte_telemetry_parser.h | 13 +\n lib/librte_telemetry/rte_telemetry_parser_test.c | 534 ++++++\n lib/librte_telemetry/rte_telemetry_parser_test.h | 39 +\n lib/librte_telemetry/rte_telemetry_socket_tests.h | 36 +\n lib/librte_telemetry/rte_telemetry_version.map | 7 +\n lib/meson.build | 2 +-\n mk/rte.app.mk | 1 +\n usertools/dpdk-telemetry-client.py | 116 ++\n 22 files changed, 3447 insertions(+), 2 deletions(-)\n create mode 100644 doc/guides/howto/telemetry.rst\n create mode 100644 lib/librte_telemetry/Makefile\n create mode 100644 lib/librte_telemetry/meson.build\n create mode 100644 lib/librte_telemetry/rte_telemetry.c\n create mode 100644 lib/librte_telemetry/rte_telemetry.h\n create mode 100644 lib/librte_telemetry/rte_telemetry_internal.h\n create mode 100644 lib/librte_telemetry/rte_telemetry_parser.c\n create mode 100644 lib/librte_telemetry/rte_telemetry_parser.h\n create mode 100644 lib/librte_telemetry/rte_telemetry_parser_test.c\n create mode 100644 lib/librte_telemetry/rte_telemetry_parser_test.h\n create mode 100644 lib/librte_telemetry/rte_telemetry_socket_tests.h\n create mode 100644 lib/librte_telemetry/rte_telemetry_version.map\n create mode 100644 usertools/dpdk-telemetry-client.py", "diff": null, "prefixes": [ "v2", "00/10" ] }