Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/47898/?format=api
{ "id": 47898, "url": "http://patchwork.dpdk.org/api/patches/47898/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/e6f96c0a1a26b2c73e19ef6f9be55a12f87f190e.1541513401.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<e6f96c0a1a26b2c73e19ef6f9be55a12f87f190e.1541513401.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/e6f96c0a1a26b2c73e19ef6f9be55a12f87f190e.1541513401.git.anatoly.burakov@intel.com", "date": "2018-11-06T14:13:29", "name": "mem: fix use after free in legacy mem init", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6507aed2d3b970225ad8adf4d455ea284b0bd350", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/e6f96c0a1a26b2c73e19ef6f9be55a12f87f190e.1541513401.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 2298, "url": "http://patchwork.dpdk.org/api/series/2298/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=2298", "date": "2018-11-06T14:13:29", "name": "mem: fix use after free in legacy mem init", "version": 1, "mbox": "http://patchwork.dpdk.org/series/2298/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/47898/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/47898/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 551A22082;\n\tTue, 6 Nov 2018 15:13:33 +0100 (CET)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 3358F14EC\n\tfor <dev@dpdk.org>; Tue, 6 Nov 2018 15:13:32 +0100 (CET)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t06 Nov 2018 06:13:31 -0800", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby fmsmga001.fm.intel.com with ESMTP; 06 Nov 2018 06:13:30 -0800", "from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com\n\t[10.237.217.45])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\twA6EDTY0025728; Tue, 6 Nov 2018 14:13:29 GMT", "from sivswdev01.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev01.ir.intel.com with ESMTP id wA6EDTKL019156;\n\tTue, 6 Nov 2018 14:13:29 GMT", "(from aburakov@localhost)\n\tby sivswdev01.ir.intel.com with LOCAL id wA6EDT93019151;\n\tTue, 6 Nov 2018 14:13:29 GMT" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,472,1534834800\"; d=\"scan'208\";a=\"105713286\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "alejandro.lucero@netronome.com", "Date": "Tue, 6 Nov 2018 14:13:29 +0000", "Message-Id": "<e6f96c0a1a26b2c73e19ef6f9be55a12f87f190e.1541513401.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "Subject": "[dpdk-dev] [PATCH] mem: fix use after free in legacy mem init", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Adding an additional failure path in DMA mask check has exposed an\nissue where `hugepage` pointer may point to memory that has already\nbeen unmapped, but pointer value is still not NULL, so failure\nhandler will attempt to unmap it second time if DMA mask check\nfails. Fix it by setting `hugepage` pointer to NULL once it is no\nlonger needed.\n\nCoverity ID: 325730\n\nFixes: 165c89b84538 (\"mem: use DMA mask check for legacy memory\")\nCc: alejandro.lucero@netronome.com\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n lib/librte_eal/linuxapp/eal/eal_memory.c | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c\nindex c1b5e0791..48b23ce19 100644\n--- a/lib/librte_eal/linuxapp/eal/eal_memory.c\n+++ b/lib/librte_eal/linuxapp/eal/eal_memory.c\n@@ -1617,6 +1617,7 @@ eal_legacy_hugepage_init(void)\n \ttmp_hp = NULL;\n \n \tmunmap(hugepage, nr_hugefiles * sizeof(struct hugepage_file));\n+\thugepage = NULL;\n \n \t/* we're not going to allocate more pages, so release VA space for\n \t * unused memseg lists\n", "prefixes": [] }