Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/48150/?format=api
{ "id": 48150, "url": "http://patchwork.dpdk.org/api/patches/48150/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1542326031-5263-9-git-send-email-konstantin.ananyev@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1542326031-5263-9-git-send-email-konstantin.ananyev@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1542326031-5263-9-git-send-email-konstantin.ananyev@intel.com", "date": "2018-11-15T23:53:50", "name": "[8/9] ipsec: helper functions to group completed crypto-ops", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e00d675b18c1e778024013811256acb7524e3411", "submitter": { "id": 33, "url": "http://patchwork.dpdk.org/api/people/33/?format=api", "name": "Ananyev, Konstantin", "email": "konstantin.ananyev@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1542326031-5263-9-git-send-email-konstantin.ananyev@intel.com/mbox/", "series": [ { "id": 2458, "url": "http://patchwork.dpdk.org/api/series/2458/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=2458", "date": "2018-11-15T23:53:50", "name": null, "version": 1, "mbox": "http://patchwork.dpdk.org/series/2458/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/48150/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/48150/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 624855A6A;\n\tFri, 16 Nov 2018 00:54:20 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 4D6004CAD\n\tfor <dev@dpdk.org>; Fri, 16 Nov 2018 00:54:11 +0100 (CET)", "from orsmga007.jf.intel.com ([10.7.209.58])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t15 Nov 2018 15:54:11 -0800", "from sivswdev08.ir.intel.com (HELO localhost.localdomain)\n\t([10.237.217.47])\n\tby orsmga007.jf.intel.com with ESMTP; 15 Nov 2018 15:54:09 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.56,238,1539673200\"; d=\"scan'208\";a=\"89697393\"", "From": "Konstantin Ananyev <konstantin.ananyev@intel.com>", "To": "dev@dpdk.org", "Cc": "Konstantin Ananyev <konstantin.ananyev@intel.com>", "Date": "Thu, 15 Nov 2018 23:53:50 +0000", "Message-Id": "<1542326031-5263-9-git-send-email-konstantin.ananyev@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "In-Reply-To": "<1535129598-27301-1-git-send-email-konstantin.ananyev@intel.com>", "References": "<1535129598-27301-1-git-send-email-konstantin.ananyev@intel.com>", "Subject": "[dpdk-dev] [PATCH 8/9] ipsec: helper functions to group completed\n\tcrypto-ops", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Introduce helper functions to process completed crypto-ops\nand group related packets by sessions they belong to.\n\nSigned-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>\n---\n lib/librte_ipsec/Makefile | 1 +\n lib/librte_ipsec/meson.build | 2 +-\n lib/librte_ipsec/rte_ipsec.h | 2 +\n lib/librte_ipsec/rte_ipsec_group.h | 151 +++++++++++++++++++++++++\n lib/librte_ipsec/rte_ipsec_version.map | 2 +\n 5 files changed, 157 insertions(+), 1 deletion(-)\n create mode 100644 lib/librte_ipsec/rte_ipsec_group.h", "diff": "diff --git a/lib/librte_ipsec/Makefile b/lib/librte_ipsec/Makefile\nindex 79f187fae..98c52f388 100644\n--- a/lib/librte_ipsec/Makefile\n+++ b/lib/librte_ipsec/Makefile\n@@ -21,6 +21,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_IPSEC) += ses.c\n \n # install header files\n SYMLINK-$(CONFIG_RTE_LIBRTE_IPSEC)-include += rte_ipsec.h\n+SYMLINK-$(CONFIG_RTE_LIBRTE_IPSEC)-include += rte_ipsec_group.h\n SYMLINK-$(CONFIG_RTE_LIBRTE_IPSEC)-include += rte_ipsec_sa.h\n \n include $(RTE_SDK)/mk/rte.lib.mk\ndiff --git a/lib/librte_ipsec/meson.build b/lib/librte_ipsec/meson.build\nindex 6e8c6fabe..d2427b809 100644\n--- a/lib/librte_ipsec/meson.build\n+++ b/lib/librte_ipsec/meson.build\n@@ -5,6 +5,6 @@ allow_experimental_apis = true\n \n sources=files('sa.c', 'ses.c')\n \n-install_headers = files('rte_ipsec.h', 'rte_ipsec_sa.h')\n+install_headers = files('rte_ipsec.h', 'rte_ipsec_group.h', 'rte_ipsec_sa.h')\n \n deps += ['mbuf', 'net', 'cryptodev', 'security']\ndiff --git a/lib/librte_ipsec/rte_ipsec.h b/lib/librte_ipsec/rte_ipsec.h\nindex 429d4bf38..0df7ea907 100644\n--- a/lib/librte_ipsec/rte_ipsec.h\n+++ b/lib/librte_ipsec/rte_ipsec.h\n@@ -147,6 +147,8 @@ rte_ipsec_pkt_process(const struct rte_ipsec_session *ss, struct rte_mbuf *mb[],\n \treturn ss->pkt_func.process(ss, mb, num);\n }\n \n+#include <rte_ipsec_group.h>\n+\n #ifdef __cplusplus\n }\n #endif\ndiff --git a/lib/librte_ipsec/rte_ipsec_group.h b/lib/librte_ipsec/rte_ipsec_group.h\nnew file mode 100644\nindex 000000000..d264d7e78\n--- /dev/null\n+++ b/lib/librte_ipsec/rte_ipsec_group.h\n@@ -0,0 +1,151 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(c) 2018 Intel Corporation\n+ */\n+\n+#ifndef _RTE_IPSEC_GROUP_H_\n+#define _RTE_IPSEC_GROUP_H_\n+\n+/**\n+ * @file rte_ipsec_group.h\n+ * @b EXPERIMENTAL: this API may change without prior notice\n+ *\n+ * RTE IPsec support.\n+ * It is not recomended to include this file direclty,\n+ * include <rte_ipsec.h> instead.\n+ * Contains helper functions to process completed crypto-ops\n+ * and group related packets by sessions they belong to.\n+ */\n+\n+\n+#ifdef __cplusplus\n+extern \"C\" {\n+#endif\n+\n+/**\n+ * Used to group mbufs by some id.\n+ * See below for particular usage.\n+ */\n+struct rte_ipsec_group {\n+\tunion {\n+\t\tuint64_t val;\n+\t\tvoid *ptr;\n+\t} id; /**< grouped by value */\n+\tstruct rte_mbuf **m; /**< start of the group */\n+\tuint32_t cnt; /**< number of entries in the group */\n+\tint32_t rc; /**< status code associated with the group */\n+};\n+\n+/**\n+ * Take crypto-op as an input and extract pointer to related ipsec session.\n+ * @param cop\n+ * The address of an input *rte_crypto_op* structure.\n+ * @return\n+ * The pointer to the related *rte_ipsec_session* structure.\n+ */\n+static inline __rte_experimental struct rte_ipsec_session *\n+rte_ipsec_ses_from_crypto(const struct rte_crypto_op *cop)\n+{\n+\tconst struct rte_security_session *ss;\n+\tconst struct rte_cryptodev_sym_session *cs;\n+\n+\tif (cop->sess_type == RTE_CRYPTO_OP_SECURITY_SESSION) {\n+\t\tss = cop->sym[0].sec_session;\n+\t\treturn (void *)(uintptr_t)ss->opaque_data;\n+\t} else if (cop->sess_type == RTE_CRYPTO_OP_WITH_SESSION) {\n+\t\tcs = cop->sym[0].session;\n+\t\treturn (void *)(uintptr_t)cs->opaque_data;\n+\t}\n+\treturn NULL;\n+}\n+\n+/**\n+ * Take as input completed crypto ops, extract related mbufs\n+ * and group them by rte_ipsec_session they belong to.\n+ * For mbuf which crypto-op wasn't completed successfully\n+ * PKT_RX_SEC_OFFLOAD_FAILED will be raised in ol_flags.\n+ * Note that mbufs with undetermined SA (session-less) are not freed\n+ * by the function, but are placed beyond mbufs for the last valid group.\n+ * It is a user responsibility to handle them further.\n+ * @param cop\n+ * The address of an array of *num* pointers to the input *rte_crypto_op*\n+ * structures.\n+ * @param mb\n+ * The address of an array of *num* pointers to output *rte_mbuf* structures.\n+ * @param grp\n+ * The address of an array of *num* to output *rte_ipsec_group* structures.\n+ * @param num\n+ * The maximum number of crypto-ops to process.\n+ * @return\n+ * Number of filled elements in *grp* array.\n+ */\n+static inline uint16_t __rte_experimental\n+rte_ipsec_pkt_crypto_group(const struct rte_crypto_op *cop[],\n+\tstruct rte_mbuf *mb[], struct rte_ipsec_group grp[], uint16_t num)\n+{\n+\tuint32_t i, j, k, n;\n+\tvoid *ns, *ps;\n+\tstruct rte_mbuf *m, *dr[num];\n+\n+\tj = 0;\n+\tk = 0;\n+\tn = 0;\n+\tps = NULL;\n+\n+\tfor (i = 0; i != num; i++) {\n+\n+\t\tm = cop[i]->sym[0].m_src;\n+\t\tns = cop[i]->sym[0].session;\n+\n+\t\tm->ol_flags |= PKT_RX_SEC_OFFLOAD;\n+\t\tif (cop[i]->status != RTE_CRYPTO_OP_STATUS_SUCCESS)\n+\t\t\tm->ol_flags |= PKT_RX_SEC_OFFLOAD_FAILED;\n+\n+\t\t/* no valid session found */\n+\t\tif (ns == NULL) {\n+\t\t\tdr[k++] = m;\n+\t\t\tcontinue;\n+\t\t}\n+\n+\t\t/* different SA */\n+\t\tif (ps != ns) {\n+\n+\t\t\t/*\n+\t\t\t * we already have an open group - finilise it,\n+\t\t\t * then open a new one.\n+\t\t\t */\n+\t\t\tif (ps != NULL) {\n+\t\t\t\tgrp[n].id.ptr =\n+\t\t\t\t\trte_ipsec_ses_from_crypto(cop[i - 1]);\n+\t\t\t\tgrp[n].cnt = mb + j - grp[n].m;\n+\t\t\t\tn++;\n+\t\t\t}\n+\n+\t\t\t/* start new group */\n+\t\t\tgrp[n].m = mb + j;\n+\t\t\tps = ns;\n+\t\t}\n+\n+\t\tmb[j++] = m;\n+\t}\n+\n+\t/* finalise last group */\n+\tif (ps != NULL) {\n+\t\tgrp[n].id.ptr = rte_ipsec_ses_from_crypto(cop[i - 1]);\n+\t\tgrp[n].cnt = mb + j - grp[n].m;\n+\t\tn++;\n+\t}\n+\n+\t/* copy mbufs with unknown session beyond recognised ones */\n+\tif (k != 0 && k != num) {\n+\t\tfor (i = 0; i != k; i++)\n+\t\t\tmb[j + i] = dr[i];\n+\t}\n+\n+\treturn n;\n+}\n+\n+#ifdef __cplusplus\n+}\n+#endif\n+\n+#endif /* _RTE_IPSEC_GROUP_H_ */\ndiff --git a/lib/librte_ipsec/rte_ipsec_version.map b/lib/librte_ipsec/rte_ipsec_version.map\nindex d1c52d7ca..0f91fb134 100644\n--- a/lib/librte_ipsec/rte_ipsec_version.map\n+++ b/lib/librte_ipsec/rte_ipsec_version.map\n@@ -1,6 +1,7 @@\n EXPERIMENTAL {\n \tglobal:\n \n+\trte_ipsec_pkt_crypto_group;\n \trte_ipsec_pkt_crypto_prepare;\n \trte_ipsec_session_prepare;\n \trte_ipsec_pkt_process;\n@@ -8,6 +9,7 @@ EXPERIMENTAL {\n \trte_ipsec_sa_init;\n \trte_ipsec_sa_size;\n \trte_ipsec_sa_type;\n+\trte_ipsec_ses_from_crypto;\n \n \tlocal: *;\n };\n", "prefixes": [ "8/9" ] }